Re: [PATCH] libgompd: Add OMPD support and global ICV functions

2022-05-18 Thread Mohamed Atef via Gcc-patches
Hi Jakub, Sorry for the rush of emails, I removed the Copyright part, I will use DCO. Note: I filled out the form. On Wed, May 18, 2022 at 2:55 PM Mohamed Atef wrote: > > > On Wed, May 18, 2022 at 2:43 PM Jakub Jelinek wrote: > >> On Wed, May 18, 2022 at 02:10:29PM +0200, Mohamed Atef wrote:

Re: [PATCH] libgompd: Add OMPD support and global ICV functions

2022-05-18 Thread Mohamed Atef via Gcc-patches
On Wed, May 18, 2022 at 2:43 PM Jakub Jelinek wrote: > On Wed, May 18, 2022 at 02:10:29PM +0200, Mohamed Atef wrote: > > > As I said earlier, as this is just partial implementation of the > > > OMPD, I think it would be better to commit it to a git branch but > > > already in the upstream reposit

Re: [PATCH] libgompd: Add OMPD support and global ICV functions

2022-05-18 Thread Jakub Jelinek via Gcc-patches
On Wed, May 18, 2022 at 02:10:29PM +0200, Mohamed Atef wrote: > > As I said earlier, as this is just partial implementation of the > > OMPD, I think it would be better to commit it to a git branch but > > already in the upstream repository, say devel/omp/ompd branch. > > > > Do you have a FSF Copyr

Re: [PATCH] libgompd: Add OMPD support and global ICV functions

2022-05-18 Thread Mohamed Atef via Gcc-patches
Hi Jakub, This is the final patch. I fixed things that you mentioned. I added two more small functions at ompd-helper.c. One more thing, the functions in ompd-helper.c are very similar. I can try to make them generic to a single function but, I think it's better to get the value of every ICV by i

Re: [PATCH] libgompd: Add OMPD support and global ICV functions

2022-05-18 Thread Mohamed Atef via Gcc-patches
On Wed, May 18, 2022 at 9:35 AM Jakub Jelinek wrote: > On Mon, May 16, 2022 at 07:35:17PM +0200, Mohamed Atef via Gcc-patches > wrote: > > libgomp/ChangeLog > > > > 2022-05-15 Mohamed Atef > > > > *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. > > *config/hpux/plugin-suffix.h (SONAM

Re: [PATCH] libgompd: Add OMPD support and global ICV functions

2022-05-18 Thread Jakub Jelinek via Gcc-patches
On Mon, May 16, 2022 at 07:35:17PM +0200, Mohamed Atef via Gcc-patches wrote: > libgomp/ChangeLog > > 2022-05-15 Mohamed Atef > > *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. > *config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. > *config/posix/plugin-suffix.h (SONAME_SUFFIX

[PATCH] libgompd: Add OMPD support and global ICV functions

2022-05-16 Thread Mohamed Atef via Gcc-patches
libgomp/ChangeLog 2022-05-15 Mohamed Atef *config/darwin/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. *config/hpux/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. *config/posix/plugin-suffix.h (SONAME_SUFFIX): Remove ()s. *configure: Regenerate. *Makefile.am (toolexeclib_LTLIBRARIES): Add libgompd.