Re: [PATCH] fortran/65429 -- don't dereference a null pointer

2015-04-22 Thread Steve Kargl
On Tue, Apr 07, 2015 at 12:59:20PM -0700, Steve Kargl wrote: > On Tue, Mar 31, 2015 at 10:17:14AM -0700, Jerry DeLisle wrote: > > On 03/29/2015 09:25 AM, Steve Kargl wrote: > > > On Sat, Mar 28, 2015 at 01:01:57AM +0100, Dominique Dhumieres wrote: > > >> > > >> AFAICT your test succeeds without you

Re: [PATCH] fortran/65429 -- don't dereference a null pointer

2015-04-07 Thread Steve Kargl
On Tue, Mar 31, 2015 at 10:17:14AM -0700, Jerry DeLisle wrote: > On 03/29/2015 09:25 AM, Steve Kargl wrote: > > On Sat, Mar 28, 2015 at 01:01:57AM +0100, Dominique Dhumieres wrote: > >> > >> AFAICT your test succeeds without your patch and does not test that the ICE > >> reported by FX is gone (ind

Re: [PATCH] fortran/65429 -- don't dereference a null pointer

2015-03-31 Thread Jerry DeLisle
On 03/29/2015 09:25 AM, Steve Kargl wrote: On Sat, Mar 28, 2015 at 01:01:57AM +0100, Dominique Dhumieres wrote: AFAICT your test succeeds without your patch and does not test that the ICE reported by FX is gone (indeed it is with your patch). New patch and testcase. The ChangeLog entries ar

Re: [PATCH] fortran/65429 -- don't dereference a null pointer

2015-03-29 Thread Steve Kargl
On Sat, Mar 28, 2015 at 01:01:57AM +0100, Dominique Dhumieres wrote: > > AFAICT your test succeeds without your patch and does not test that the ICE > reported by FX is gone (indeed it is with your patch). > New patch and testcase. The ChangeLog entries are in the original email. Built and te

Re: [PATCH] fortran/65429 -- don't dereference a null pointer

2015-03-28 Thread Dominique d'Humières
> Le 28 mars 2015 à 15:50, Steve Kargl a > écrit : > > Can one do anything useful with a zero-sized array > of strings where the length of a non-existent > element of the array is nonzero? The only answer I can give is that the users’ imagination is unbounded! Dominique > -- > Steve

Re: [PATCH] fortran/65429 -- don't dereference a null pointer

2015-03-28 Thread Steve Kargl
>> 28 mars 2015, 01:33, Steve Kargl : >> >> On Sat, Mar 28, 2015 at 01:01:57AM +0100, Dominique Dhumieres wrote: >>> >>> AFAICT your test succeeds without your patch and does not test that the ICE >>> reported by FX is gone (indeed it is with your patch). >>> >> >> Yeah, I thought about that, b

Re: [PATCH] fortran/65429 -- don't dereference a null pointer

2015-03-28 Thread Dominique d'Humières
See also my comment 2 in pr65429. Cheers, Dominique > Le 28 mars 2015 à 01:33, Steve Kargl a > écrit : > > On Sat, Mar 28, 2015 at 01:01:57AM +0100, Dominique Dhumieres wrote: >> >> AFAICT your test succeeds without your patch and does not test that the ICE >> reported by FX is gone (indeed

Re: [PATCH] fortran/65429 -- don't dereference a null pointer

2015-03-27 Thread Steve Kargl
On Sat, Mar 28, 2015 at 01:01:57AM +0100, Dominique Dhumieres wrote: > > AFAICT your test succeeds without your patch and does not test that the ICE > reported by FX is gone (indeed it is with your patch). > Yeah, I thought about that, but did not pursue it, yet. It is a zero-size string issue b

Re: [PATCH] fortran/65429 -- don't dereference a null pointer

2015-03-27 Thread Dominique Dhumieres
Steve, AFAICT your test succeeds without your patch and does not test that the ICE reported by FX is gone (indeed it is with your patch). TIA Dominique

Re: [PATCH] fortran/65429 -- don't dereference a null pointer

2015-03-27 Thread Tobias Burnus
Steve Kargl wrote: The following patch avoids the dereferencing of a null pointer, which led to an ICE. The patch here is a slight variation on the patch submitted by drikosev at otenet dot gr. The testcase is a slight variation on the code submitted by FX. Built and regression tested on x86_6

[PATCH] fortran/65429 -- don't dereference a null pointer

2015-03-27 Thread Steve Kargl
The following patch avoids the dereferencing of a null pointer, which led to an ICE. The patch here is a slight variation on the patch submitted by drikosev at otenet dot gr. The testcase is a slight variation on the code submitted by FX. Built and regression tested on x86_64-*-freebsd. OK to c