Rainer Orth writes:
> Hi Martin,
>
>> On 11/26/18 10:52 AM, Rainer Orth wrote:
>>> Hi Martin,
>>>
I have now committed this patch as r266418.
>>>
>>> this patch has created a bunch of XPASSes everywhere:
>>>
>>> +XPASS: gcc.dg/tree-ssa/builtin-fprintf-warn-1.c pr87756 (test for
>>> warnings,
Hi Martin,
> On 11/26/18 10:52 AM, Rainer Orth wrote:
>> Hi Martin,
>>
>>> I have now committed this patch as r266418.
>>
>> this patch has created a bunch of XPASSes everywhere:
>>
>> +XPASS: gcc.dg/tree-ssa/builtin-fprintf-warn-1.c pr87756 (test for
>> warnings, line 119)
>> +XPASS: gcc.dg/tree-
On 11/26/18 10:52 AM, Rainer Orth wrote:
Hi Martin,
I have now committed this patch as r266418.
this patch has created a bunch of XPASSes everywhere:
+XPASS: gcc.dg/tree-ssa/builtin-fprintf-warn-1.c pr87756 (test for warnings,
line 119)
+XPASS: gcc.dg/tree-ssa/builtin-fprintf-warn-1.c pr877
On 11/26/18 1:55 PM, Martin Sebor wrote:
> In the committed patch I forgot that the CONSTRUCTOR to STRING_CST
> transformation introduced this summer only takes place for arrays
> of char and not also those of wide characters. That resulted in
> sprintf incorrectly getting STRING_CSTs for individu
In the committed patch I forgot that the CONSTRUCTOR to STRING_CST
transformation introduced this summer only takes place for arrays
of char and not also those of wide characters. That resulted in
sprintf incorrectly getting STRING_CSTs for individual elements
of constant wide character arrays li
On 11/26/18 10:27 AM, Joseph Myers wrote:
On Fri, 23 Nov 2018, Martin Sebor wrote:
I have now committed this patch as r266418.
This commit introduced spurious warnings that break the glibc testsuite
build.
bug-ungetwc2.c:62:17: error: '%ls' directive argument is not a nul-terminated
string
Hi Martin,
> I have now committed this patch as r266418.
this patch has created a bunch of XPASSes everywhere:
+XPASS: gcc.dg/tree-ssa/builtin-fprintf-warn-1.c pr87756 (test for warnings,
line 119)
+XPASS: gcc.dg/tree-ssa/builtin-fprintf-warn-1.c pr87756 (test for warnings,
line 120)
+XPASS: g
On Fri, 23 Nov 2018, Martin Sebor wrote:
> I have now committed this patch as r266418.
This commit introduced spurious warnings that break the glibc testsuite
build.
bug-ungetwc2.c:62:17: error: '%ls' directive argument is not a nul-terminated
string [-Werror=format-overflow=]
62 | fprint
On Fri, Nov 23, 2018 at 11:46:18AM -0700, Martin Sebor wrote:
> I have now committed this patch as r266418.
Two of the tests fail everywhere.
Fixed thusly, committed as obvious:
2018-11-23 Jakub Jelinek
PR tree-optimization/87756
* gcc.dg/builtin-memchr-2.c: Scan the gimple d
I have now committed this patch as r266418.
Martin
On 11/6/18 5:05 PM, Martin Sebor wrote:
Jeff, I'd like to go ahead and commit the patch as is. I believe
the use of the default argument is appropriate and in line with
GCC practice. Please let me know if you have strong objections.
If I don'
Jeff, I'd like to go ahead and commit the patch as is. I believe
the use of the default argument is appropriate and in line with
GCC practice. Please let me know if you have strong objections.
If I don't hear any I will proceed later this week
Thanks
Martin
On 10/30/2018 10:38 AM, Martin Sebor
On 10/30/2018 09:54 AM, Jeff Law wrote:
On 10/30/18 9:44 AM, Martin Sebor wrote:
On 10/30/2018 09:27 AM, Jeff Law wrote:
On 10/29/18 5:51 PM, Martin Sebor wrote:
The missing nul detection fails when the argument of the %s or
similar sprintf directive is the address of a non-nul character
const
On 10/30/18 9:44 AM, Martin Sebor wrote:
> On 10/30/2018 09:27 AM, Jeff Law wrote:
>> On 10/29/18 5:51 PM, Martin Sebor wrote:
>>> The missing nul detection fails when the argument of the %s or
>>> similar sprintf directive is the address of a non-nul character
>>> constant such as in:
>>>
>>> co
On 10/30/2018 09:27 AM, Jeff Law wrote:
On 10/29/18 5:51 PM, Martin Sebor wrote:
The missing nul detection fails when the argument of the %s or
similar sprintf directive is the address of a non-nul character
constant such as in:
const char c = 'a';
int f (void)
{
return snprintf (0, 0
On 10/29/18 5:51 PM, Martin Sebor wrote:
> The missing nul detection fails when the argument of the %s or
> similar sprintf directive is the address of a non-nul character
> constant such as in:
>
> const char c = 'a';
> int f (void)
> {
> return snprintf (0, 0, "%s", &c);
> }
>
> Thi
The missing nul detection fails when the argument of the %s or
similar sprintf directive is the address of a non-nul character
constant such as in:
const char c = 'a';
int f (void)
{
return snprintf (0, 0, "%s", &c);
}
This is because the string_constant function only succeeds for
ar
16 matches
Mail list logo
