Re: [COMMITTED] Fix pr88850 test

2019-02-21 Thread Wilco Dijkstra
Hi Christophe, >> > But my question was more: why skip the test if one forces >> > -mfloat-abi=softfp while you have this very same option in the >> > dg-additional-options ? >> > Isn't it a typo that -mfloat-abi=soft in the "exclude" should use floatfp? >> >> I don't know, I just copied the magic

Re: [COMMITTED] Fix pr88850 test

2019-02-20 Thread Christophe Lyon
On Wed, 20 Feb 2019 at 15:17, Wilco Dijkstra wrote: > > Hi Christophe, > > > Option overrides are appended/prepended depending on dejagnu version :-( > > Why stop there? Dejagnu could increase the fun of testing by randomizing > option ordering. > > > But my question was more: why skip the test if

Re: [COMMITTED] Fix pr88850 test

2019-02-20 Thread Wilco Dijkstra
Hi Christophe, > Option overrides are appended/prepended depending on dejagnu version :-( Why stop there? Dejagnu could increase the fun of testing by randomizing option ordering. > But my question was more: why skip the test if one forces > -mfloat-abi=softfp while you have this very same optio

Re: [COMMITTED] Fix pr88850 test

2019-02-20 Thread Christophe Lyon
On Wed, 20 Feb 2019 at 13:35, Wilco Dijkstra wrote: > > Hi Christophe, > > > +/* { dg-skip-if "do not override -mfloat-abi" { *-*-* } { "-mfloat-abi=*" > } {"-mfloat-abi=soft" } } */ > > Does this mean the test would be skipped if one forces > > -mfloat-abi=softfp and not if one uses -mfloat-abi

Re: [COMMITTED] Fix pr88850 test

2019-02-20 Thread Wilco Dijkstra
Hi Christophe, > +/* { dg-skip-if "do not override -mfloat-abi" { *-*-* } { "-mfloat-abi=*" } > {"-mfloat-abi=soft" } } */ > Does this mean the test would be skipped if one forces > -mfloat-abi=softfp and not if one uses -mfloat-abi=soft ? Yes it seems it is. No idea why the testsuite is so br

Re: [COMMITTED] Fix pr88850 test

2019-02-20 Thread Christophe Lyon
Hi Wilco, On Tue, 19 Feb 2019 at 19:44, Wilco Dijkstra wrote: > > Fix pr88850.c testcase which was failing in hardfp environments. > > Committed as obvious. > > ChangeLog: > 2019-02-19 Wilco Dijkstra > > * gcc.target/arm/pr88850.c: Block -mfloat-abi override. > > -- > diff --git a/gcc/

[COMMITTED] Fix pr88850 test

2019-02-19 Thread Wilco Dijkstra
Fix pr88850.c testcase which was failing in hardfp environments. Committed as obvious. ChangeLog: 2019-02-19 Wilco Dijkstra * gcc.target/arm/pr88850.c: Block -mfloat-abi override. -- diff --git a/gcc/testsuite/gcc.target/arm/pr88850.c b/gcc/testsuite/gcc.target/arm/pr88850.c index