On Wed, 20 Feb 2019 at 15:17, Wilco Dijkstra <wilco.dijks...@arm.com> wrote:
>
> Hi Christophe,
>
> > Option overrides are appended/prepended depending on dejagnu version :-(
>
> Why stop there? Dejagnu could increase the fun of testing by randomizing
> option ordering.
>
> > But my question was more: why skip the test if one forces
> > -mfloat-abi=softfp while you have this very same option in the
> > dg-additional-options ?
> > Isn't it a typo that -mfloat-abi=soft in the "exclude" should use floatfp?
>
> I don't know, I just copied the magic hack from other tests. Do you know
Not quite, I think.
All the other tests in gcc.target/arm that use dg-skip-if with
-mfloat-abi have the
"exclude" parameter matching the option in dg-options (when there is an explicit
"exclude" and dg-options is used).
So I suggest:
--- a/gcc/testsuite/gcc.target/arm/pr88850.c
+++ b/gcc/testsuite/gcc.target/arm/pr88850.c
@@ -1,6 +1,6 @@
/* PR target/88850 */
/* { dg-do compile } */
-/* { dg-skip-if "do not override -mfloat-abi" { *-*-* } {
"-mfloat-abi=*" } {"-mfloat-abi=soft" } } */
+/* { dg-skip-if "do not override -mfloat-abi" { *-*-* } {
"-mfloat-abi=*" } {"-mfloat-abi=softfp" } } */
/* { dg-options "-O2 -march=armv7-a -mfloat-abi=softfp -mfpu=neon
-fdump-rtl-final" } */
/* { dg-require-effective-target arm_neon_ok } */
Christophe
> of a better way of writing this?
>
> Wilco
