On Wed, 20 Feb 2019 at 13:35, Wilco Dijkstra <wilco.dijks...@arm.com> wrote: > > Hi Christophe, > > > +/* { dg-skip-if "do not override -mfloat-abi" { *-*-* } { "-mfloat-abi=*" > } {"-mfloat-abi=soft" } } */ > > Does this mean the test would be skipped if one forces > > -mfloat-abi=softfp and not if one uses -mfloat-abi=soft ? > > Yes it seems it is. No idea why the testsuite is so broken, obviously option > overrides should > be added before the test-specific options are appended. Due to this bug there > are hundreds > of these skip-if required in the Arm testsuite alone.
Option overrides are appended/prepended depending on dejagnu version :-( But my question was more: why skip the test if one forces -mfloat-abi=softfp while you have this very same option in the dg-additional-options ? Isn't it a typo that -mfloat-abi=soft in the "exclude" should use floatfp? Christophe > > Cheers, > Wilco