[PATCH] i386: Use scalar operand in SF/DF/SI/DI vec_dup patterns

2018-10-26 Thread H.J. Lu
Use scalar operand in SF/DF/SI/DI vec_dup patterns which enables combiner to generate (set (reg:V8SF 84) (vec_duplicate:V8SF (mem/c:SF (symbol_ref:DI ("y") const_vector_duplicate_operand is added for constant vector broadcast. We split (set (reg:V16SF 86) (const_vector:V16SF

Re: [PATCH] S/390: Add loc patterns for QImode and HImode

2018-10-26 Thread Andreas Krebbel
On 10/26/18 5:33 PM, Robin Dapp wrote: > Hi, > > this is v2 of the patch with less quirky pattern syntax and two tests. > > Regards > Robin > > -- > > gcc/ChangeLog: > > 2018-10-26 Robin Dapp > > * config/s390/s390.md: QImode and HImode for load on condition. > > gcc/testsuite/Chan

Re: [PATCH] S/390: Allow immediates in loc expander

2018-10-26 Thread Andreas Krebbel
On 10/26/18 5:31 PM, Robin Dapp wrote: > Hi, > > this is v2 of the patch. The Z13 check has been moved from the > predicate to the expander. In addition, it changes a test case to > always run with -march=zEC12 because from z13 on the load immediate on > condition will prevent loop hoisting that

[PATCH v3 3/3] or1k: gcc: initial support for openrisc

2018-10-26 Thread Stafford Horne
-mm-dd Stafford Horne Richard Henderson Joel Sherrill gcc/ChangeLog: * common/config/or1k/or1k-common.c: New file. * config/or1k/*: New. * config.gcc (or1k*-*-*): New. * configure.ac (or1k*-*-*): New test for openrisc tls.

[PATCH v3 2/3] or1k: testsuite: initial support for openrisc

2018-10-26 Thread Stafford Horne
-mm-dd Stafford Horne Richard Henderson gcc/testsuite/ChangeLog: * gcc.c-torture/execute/20101011-1.c: Adjust for OpenRISC. * gcc.dg/20020312-2.c: Likewise. * gcc.dg/attr-alloc_size-11.c: Likewise. * gcc.dg/builtin-apply2.c: Likewise. *

[PATCH v3 0/3] OpenRISC port

2018-10-26 Thread Stafford Horne
Hello, Changes Since v2: - Add RTEMS patches from Joel Sherrill - Disable t-softfp-excl as suggsted by Joseph Myers - Add new architecture flags needed to run on real FPGA's found in testing * -mror - enable l.ror (rotate right) * -mshftimm - enable shift/rorate by immediate instructions

[PATCH v3 1/3] or1k: libgcc: initial support for openrisc

2018-10-26 Thread Stafford Horne
-mm-dd Stafford Horne Richard Henderson libgcc/ChangeLog: * config.host: Add OpenRISC support. * config/or1k/*: New. --- libgcc/config.host| 13 ++ libgcc/config/or1k/crti.S | 33 + libgcc/config/or1k/crtn.S | 1 + libg

Re: RFC: Allow moved-from strings to be non-empty

2018-10-26 Thread Ville Voutilainen
On Sat, 27 Oct 2018 at 01:27, Joe Buck wrote: > > The reason move constructors were introduced was to speed up code in cases > where an object > Is copied and the copy is no longer needed. It is unfortunate that there may > now be code out > there that relies on accidental properties of library

RE: RFC: Allow moved-from strings to be non-empty

2018-10-26 Thread Joe Buck
The reason move constructors were introduced was to speed up code in cases where an object Is copied and the copy is no longer needed. It is unfortunate that there may now be code out there that relies on accidental properties of library implementations. It would be best if the Implementation

Re: [PATCH, ARM] PR85434: Prevent spilling of stack protector guard's address on ARM

2018-10-26 Thread Thomas Preudhomme
Hi, Please find updated patch to fix PR85434: spilling of stack protector guard's address on ARM. Quite a few changes have been made to the ARM part since last round of review so I think it makes more sense to review it anew. Ran bootstrap + regression testsuite + glibc build + glibc regression te

Re: [PATCH] powerpc: Fix typos in the manual

2018-10-26 Thread Segher Boessenkool
On Fri, Oct 26, 2018 at 02:40:46PM -0300, Tulio Magno Quites Machado Filho wrote: > [gcc] > 2018-10-26 Tulio Magno Quites Machado Filho > > * doc/extend.texi (PowerPC builtins): Fix __builtin_unpack_ibm128 > return type and other typos. Thanks! I've committed this to trunk for yo

Re: [PATCH v2, rs6000 4/4] Add compatible implementations of x86 SSSE3 intrinsics

2018-10-26 Thread Paul Clarke
On 10/26/2018 02:02 PM, Bill Schmidt wrote: > On 10/25/18 2:08 PM, Paul Clarke wrote: >> diff --git a/trunk/gcc/testsuite/gcc.target/powerpc/ssse3-check.h >> b/trunk/gcc/testsuite/gcc.target/powerpc/ssse3-check.h >> new file mode 10644 >> --- /dev/null(revision 0) >> +++ b/trunk/gcc/tests

[PATCH, committed] Backport PR87473 fix to GCC 7

2018-10-26 Thread Bill Schmidt
Committed the backport as follows (some slight changes between versions were required): [gcc] 2018-10-26 Bill Schmidt Backport from mainline 2018-10-19 Bill Schmidt PR tree-optimization/87473 * gimple-ssa-strength-reduction.c (record_phi_increments): For

Re: GCC 6 branch is now closed

2018-10-26 Thread Eric Gallager
On 10/26/18, Jakub Jelinek wrote: > After the GCC 6.5 release the GCC 6 branch is now closed. Please > refrain from committing to it from now on. > > Thanks > Jakub > So, since it's the last branch with java in it, can we go and finally remove the last vestiges of java from the gcc website

Re: [PATCH, rs6000] Intrinsic compatibility tests should not pass just because DEBUG is set

2018-10-26 Thread Segher Boessenkool
Hi Bill, On Thu, Oct 25, 2018 at 02:58:59PM -0500, Bill Schmidt wrote: > A number of the test cases for the intrinsic compatibility headers are set up > to dump more information when a test case fails and the DEBUG macro has been > set. Unfortunately, many of them also then pass the test case sin

Re: [PATCH v2, rs6000 4/4] Add compatible implementations of x86 SSSE3 intrinsics

2018-10-26 Thread Bill Schmidt
On 10/25/18 2:08 PM, Paul Clarke wrote: > This is part 2/2 for contributing PPC64LE support for X86 SSE3 > instrisics. This patch includes testsuite/gcc.target tests for the > intrinsics defined in pmmintrin.h, copied from gcc.target/i386. > > Bootstrapped and tested on Linux POWER8 LE, POWER8 BE (

[PATCH, committed] Backport PR87473 fix to GCC 8

2018-10-26 Thread Bill Schmidt
Committed the backport as follows: [gcc] 2018-10-26 Bill Schmidt Backport from mainline 2018-10-19 Bill Schmidt PR tree-optimization/87473 * gimple-ssa-strength-reduction.c (record_phi_increments_1): For phi arguments identical to the base expressio

Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Ian Lance Taylor
On Fri, Oct 26, 2018 at 9:13 AM, Rainer Orth wrote: > Hi Than, > >> OK, thanks again. Another fix sent: >> >> https://go-review.googlesource.com/c/gofrontend/+/145021 > > great, thanks again. While the two previous patches were enough to get > decent Solaris 11 results, on Solaris 10 all libgo t

Re: [PATCH v2, rs6000 3/4] Add compatible implementations of x86 SSSE3 intrinsics

2018-10-26 Thread Paul Clarke
On 10/26/2018 01:00 PM, Segher Boessenkool wrote: > On Thu, Oct 25, 2018 at 02:07:54PM -0500, Paul Clarke wrote: >> This is a follow-on to earlier commits for adding compatibility >> implementations of x86 intrinsics for PPC64LE. This is the first of >> two patches for SSSE3. This patch adds the

Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Bernhard Reutner-Fischer
On 26 October 2018 18:13:32 CEST, Rainer Orth wrote: >Hi Than, > >> OK, thanks again. Another fix sent: >> >> https://go-review.googlesource.com/c/gofrontend/+/145021 > >great, thanks again. While the two previous patches were enough to get >decent Solaris 11 results, on Solaris 10 all libgo te

Re: [C++ Patch] PR 84644 ("internal compiler error: in warn_misplaced_attr_for_class_type, at cp/decl.c:4718")

2018-10-26 Thread Paolo Carlini
Hi, On 26/10/18 17:18, Jason Merrill wrote: On Fri, Oct 26, 2018 at 4:52 AM Paolo Carlini wrote: On 24/10/18 22:41, Jason Merrill wrote: On 10/15/18 12:45 PM, Paolo Carlini wrote: && ((TREE_CODE (declspecs->type) != TYPENAME_TYPE + && TREE_CODE (declspecs->type) != DECLTYPE_TY

Re: [PATCH v2, rs6000 4/4] Add compatible implementations of x86 SSSE3 intrinsics

2018-10-26 Thread Segher Boessenkool
On Thu, Oct 25, 2018 at 02:08:03PM -0500, Paul Clarke wrote: > This is part 2/2 for contributing PPC64LE support for X86 SSE3 > instrisics. This patch includes testsuite/gcc.target tests for the > intrinsics defined in pmmintrin.h, copied from gcc.target/i386. > > Bootstrapped and tested on Linux

Re: [PATCH v2, rs6000 3/4] Add compatible implementations of x86 SSSE3 intrinsics

2018-10-26 Thread Segher Boessenkool
On Thu, Oct 25, 2018 at 02:07:54PM -0500, Paul Clarke wrote: > This is a follow-on to earlier commits for adding compatibility > implementations of x86 intrinsics for PPC64LE. This is the first of > two patches for SSSE3. This patch adds the 32 x86 intrinsics from > ("SSSE3"). (Patch 2/2 adds t

Re: [PATCH] combine: Do not combine moves from hard registers

2018-10-26 Thread Segher Boessenkool
On Fri, Oct 26, 2018 at 04:39:06PM +, Steve Ellcey wrote: > What is the status of this patch?  I see PR 87708, which is for the > regression to ira-shrinkwrap-prep-[12].c but what about all the > other regressions?  I see 27 of them on my aarch64 build and when > I looked at one of them (gcc.ta

[PATCH] powerpc: Fix typos in the manual

2018-10-26 Thread Tulio Magno Quites Machado Filho
[gcc] 2018-10-26 Tulio Magno Quites Machado Filho * doc/extend.texi (PowerPC builtins): Fix __builtin_unpack_ibm128 return type and other typos. --- gcc/doc/extend.texi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/doc/extend.texi b/gcc/doc/exten

Re: [PATCH v2, rs6000 1/4] Fixes for x86 intrinsics on POWER 32bit

2018-10-26 Thread Segher Boessenkool
On Fri, Oct 26, 2018 at 08:06:28AM -0500, Paul Clarke wrote: > On 10/25/2018 05:17 PM, Segher Boessenkool wrote: > > On Thu, Oct 25, 2018 at 02:07:33PM -0500, Paul Clarke wrote: > >> Various clean-ups for 32bit support. > >> > >> Implement various corrections in the compatibility implementations of

Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Ian Lance Taylor
On Fri, Oct 26, 2018 at 7:44 AM, Than McIntosh wrote: > OK, thanks again. Another fix sent: > > https://go-review.googlesource.com/c/gofrontend/+/145021 Thanks. Sorry for missing that in code review. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE ===

[gomp5] Use gomp_aligned_alloc for workshare allocation

2018-10-26 Thread Jakub Jelinek
Hi! The gomp_work_share struct is designed to have first half mostly readonly, set once, and the second half meant for writes, with the middle being 64-byte aligned. The following patch uses (as an optimization) the new gomp_aligned_alloc if it is not the fallback implementation. Tested on x86_6

Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Ian Lance Taylor
On Fri, Oct 26, 2018 at 5:04 AM, Than McIntosh wrote: > > Thanks for reporting this. > > Sent https://go-review.googlesource.com/c/gofrontend/+/145017 with a > tentative fix. Thanks, committed to mainline. Ian Index: gcc/go/gofrontend/MERGE ===

Re: Fix failure with the odr-1.C test

2018-10-26 Thread Bernhard Reutner-Fischer
On 26 October 2018 09:46:52 CEST, Jan Hubicka wrote: >Hi, >@@ -1138,7 +1139,7 @@ warn_types_mismatch (tree t1, tree t2, l > if (TREE_CODE (n1) == TYPE_DECL) > n1 = DECL_NAME (n1); > if (TREE_CODE (n2) == TYPE_DECL) >- n1 = DECL_NAME (n2); >+ n2 = DECL_NAME (n2); > /* M

Re: [PATCH] combine: Do not combine moves from hard registers

2018-10-26 Thread Steve Ellcey
What is the status of this patch?  I see PR 87708, which is for the regression to ira-shrinkwrap-prep-[12].c but what about all the other regressions?  I see 27 of them on my aarch64 build and when I looked at one of them (gcc.target/aarch64/cvtf_1.c) the code looks worse than before, generating an

Re: [PATCH][rs6000] improve gpr inline expansion of str[n]cmp

2018-10-26 Thread Segher Boessenkool
Hi Aaron, On Thu, Oct 25, 2018 at 09:11:56AM -0500, Aaron Sawdey wrote: > This patch changes the sequence that gcc generates for inline expansion of > strcmp/strncmp using scalar (gpr) instructions. The new sequence is one > instruction shorter and uses cmpb/cmpb/orc./bne which I also have been >

Re: Cleanup handling of variants in ipa-devirt

2018-10-26 Thread Jan Hubicka
> On 26 October 2018 09:18:39 CEST, Jan Hubicka wrote: > > @@ -1094,10 +1133,15 @@ warn_types_mismatch (tree t1, tree t2, l > gcc_assert (TYPE_NAME (t1) && TYPE_NAME (t2) >&& TREE_CODE (TYPE_NAME (t1)) == TYPE_DECL >&& TREE_CODE (TYPE_NAME (t2)) == TYPE_DECL); > +

Re: Cleanup handling of variants in ipa-devirt

2018-10-26 Thread Bernhard Reutner-Fischer
On 26 October 2018 09:18:39 CEST, Jan Hubicka wrote: @@ -1094,10 +1133,15 @@ warn_types_mismatch (tree t1, tree t2, l gcc_assert (TYPE_NAME (t1) && TYPE_NAME (t2) && TREE_CODE (TYPE_NAME (t1)) == TYPE_DECL && TREE_CODE (TYPE_NAME (t2)) == TYPE_DECL); + tree n1 =

Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Rainer Orth
Hi Than, > OK, thanks again. Another fix sent: > > https://go-review.googlesource.com/c/gofrontend/+/145021 great, thanks again. While the two previous patches were enough to get decent Solaris 11 results, on Solaris 10 all libgo tests still FAIL like this: _testmain.go:9:25: error: reference

Re: [ARM/FDPIC v3 04/21] [ARM] FDPIC: Add support for FDPIC for arm architecture

2018-10-26 Thread Richard Earnshaw (lists)
On 26/10/2018 16:25, Christophe Lyon wrote: > On Tue, 23 Oct 2018 at 16:07, Richard Earnshaw (lists) > wrote: >> >> On 19/10/2018 14:40, Christophe Lyon wrote: >>> On 12/10/2018 12:45, Richard Earnshaw (lists) wrote: On 11/10/18 14:34, Christophe Lyon wrote: > The FDPIC register is hard-c

Re: [PATCH] S/390: Add loc patterns for QImode and HImode

2018-10-26 Thread Robin Dapp
Hi, this is v2 of the patch with less quirky pattern syntax and two tests. Regards Robin -- gcc/ChangeLog: 2018-10-26 Robin Dapp * config/s390/s390.md: QImode and HImode for load on condition. gcc/testsuite/ChangeLog: 2018-10-26 Robin Dapp * gcc.target/s390/ifcvt-one

Re: [PATCH] S/390: Allow immediates in loc expander

2018-10-26 Thread Robin Dapp
Hi, this is v2 of the patch. The Z13 check has been moved from the predicate to the expander. In addition, it changes a test case to always run with -march=zEC12 because from z13 on the load immediate on condition will prevent loop hoisting that the test requires. Regards Robin -- gcc/Change

Re: [ARM/FDPIC v3 04/21] [ARM] FDPIC: Add support for FDPIC for arm architecture

2018-10-26 Thread Christophe Lyon
On Tue, 23 Oct 2018 at 16:07, Richard Earnshaw (lists) wrote: > > On 19/10/2018 14:40, Christophe Lyon wrote: > > On 12/10/2018 12:45, Richard Earnshaw (lists) wrote: > >> On 11/10/18 14:34, Christophe Lyon wrote: > >>> The FDPIC register is hard-coded to r9, as defined in the ABI. > >>> > >>> We

Re: [C++ Patch] PR 84644 ("internal compiler error: in warn_misplaced_attr_for_class_type, at cp/decl.c:4718")

2018-10-26 Thread Jason Merrill
On Fri, Oct 26, 2018 at 4:52 AM Paolo Carlini wrote: > On 24/10/18 22:41, Jason Merrill wrote: > > On 10/15/18 12:45 PM, Paolo Carlini wrote: > >> && ((TREE_CODE (declspecs->type) != TYPENAME_TYPE > >> + && TREE_CODE (declspecs->type) != DECLTYPE_TYPE > >> && MAYBE_CLASS_TYP

Re: [PATCH] Add option to control warnings added through attribure "warning"

2018-10-26 Thread Jeff Law
On 10/26/18 9:11 AM, Martin Sebor wrote: > On 10/26/2018 05:01 AM, Nikolai Merinov wrote: >> Hi, >> >> What next steps should I perform in order to get this changes merged >> to GCC? > > Keep pinging it once a week until a maintainer approves it. > I'm not empowered to do that. Nikolai -- your pat

Re: [PATCH] Add option to control warnings added through attribure "warning"

2018-10-26 Thread Martin Sebor
On 10/26/2018 05:01 AM, Nikolai Merinov wrote: Hi, What next steps should I perform in order to get this changes merged to GCC? Keep pinging it once a week until a maintainer approves it. I'm not empowered to do that. Martin Regards, Nikolai - Original Message - From: "Nikolai Mer

Re: [ARM/FDPIC v3 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

2018-10-26 Thread Christophe Lyon
On Tue, 23 Oct 2018 at 17:14, Segher Boessenkool wrote: > > On Tue, Oct 23, 2018 at 02:58:21PM +0100, Richard Earnshaw (lists) wrote: > > On 15/10/2018 11:10, Christophe Lyon wrote: > > > Do you mean to also make -mfdpic non-existent/rejected when GCC is not > > > configured > > > for arm-uclinuxf

Re: [PATCH 0/7] libsanitizer: merge from trunk

2018-10-26 Thread Jakub Jelinek
On Fri, Oct 26, 2018 at 09:48:54AM -0500, Bill Seurer wrote: > On 10/26/18 03:57, Jakub Jelinek wrote: > > On Thu, Oct 25, 2018 at 12:49:42PM +0200, Jakub Jelinek wrote: > > > On Thu, Oct 25, 2018 at 12:15:46PM +0200, marxin wrote: > > > > I've just finished my first merge from libsanitizer mainlin

Re: [PATCH 0/7] libsanitizer: merge from trunk

2018-10-26 Thread Bill Seurer
On 10/26/18 03:57, Jakub Jelinek wrote: On Thu, Oct 25, 2018 at 12:49:42PM +0200, Jakub Jelinek wrote: On Thu, Oct 25, 2018 at 12:15:46PM +0200, marxin wrote: I've just finished my first merge from libsanitizer mainline. Overall it looks fine, apparently ABI hasn't changed and so that SONAME bu

Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Than McIntosh via gcc-patches
OK, thanks again. Another fix sent: https://go-review.googlesource.com/c/gofrontend/+/145021 Cheers, Than On Fri, Oct 26, 2018 at 10:20 AM Rainer Orth wrote: > > Hi Than, > > > Thanks for reporting this. > > > > Sent https://go-review.googlesource.com/c/gofrontend/+/145017 with a > > tentative

Re: gOlogy: skip dbranch at -Og

2018-10-26 Thread Jeff Law
On 10/25/18 11:12 PM, Alexandre Oliva wrote: > Delayed slot filling moves insns without any regard to variable > location notes, causing the location information in them to become > incorrect. > > Fixing that appears to be quite difficult, but filling delay slots is > hardly an essential optimizat

Re: [PATCH v4] Avoid unnecessarily numbering cloned symbols.

2018-10-26 Thread Jan Hubicka
> From aea94273e7a477a03d1ee10a5d9043d6d13b8e8d Mon Sep 17 00:00:00 2001 > From: Michael Ploujnikov > Date: Thu, 25 Oct 2018 13:16:36 -0400 > Subject: [PATCH] Avoid unnecessarily numbering cloned symbols. > > gcc/ChangeLog: > > 2018-10-26 Michael Ploujnikov > > * cgraph.h (clone_functi

Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Rainer Orth
Hi Than, > Thanks for reporting this. > > Sent https://go-review.googlesource.com/c/gofrontend/+/145017 with a > tentative fix. fine, thanks. While actually running the libgo testsuite, another issue came up: all tests FAIL like this: /vol/gcc/src/hg/trunk/local/libgo/testsuite/gotest[516]: loc

Re: Turn complete to incomplete types in free_lang_data

2018-10-26 Thread Jan Hubicka
> > OK if it survives more testing on firefox and lto bootstrap? > > It looks like a hack to do free_lang_data_in_type from free_lang_data_in_decl > walk - I remember you wanted to unify find_* and free_*? If not doing that I did try it :) There is a catch - free lang data calls langhooks to pro

Re: Add a loop versioning pass

2018-10-26 Thread Richard Biener
On Thu, Oct 25, 2018 at 3:52 PM Richard Biener wrote: > > On Wed, Oct 24, 2018 at 3:05 PM Richard Sandiford > wrote: > > > > This patch adds a pass that versions loops with variable index strides > > for the case in which the stride is 1. E.g.: > > > > for (int i = 0; i < n; ++i) > > x

Re: [PATCH v2, rs6000 1/4] Fixes for x86 intrinsics on POWER 32bit

2018-10-26 Thread Paul Clarke
On 10/25/2018 05:17 PM, Segher Boessenkool wrote: > On Thu, Oct 25, 2018 at 02:07:33PM -0500, Paul Clarke wrote: >> Various clean-ups for 32bit support. >> >> Implement various corrections in the compatibility implementations of the >> x86 vector intrinsics found after enabling 32bit mode for the a

Re: [PATCH v4] Avoid unnecessarily numbering cloned symbols.

2018-10-26 Thread Michael Ploujnikov
Hi Martin, Thanks for the review. On 2018-10-26 03:51 AM, Martin Liška wrote: > On 10/26/18 12:59 AM, Michael Ploujnikov wrote: >> I've taken the advice from a discussion on IRC and re-wrote the patch >> with more uniform function names and using overloading. >> >> I think this function accomplis

GCC 6 branch is now closed

2018-10-26 Thread Jakub Jelinek
After the GCC 6.5 release the GCC 6 branch is now closed. Please refrain from committing to it from now on. Thanks Jakub

Re: [PATCH, rs6000] Fix _mm_extract_pi16 for big-endian

2018-10-26 Thread Paul Clarke
On 10/25/2018 05:08 PM, Jakub Jelinek wrote: > On Thu, Oct 25, 2018 at 05:07:03PM -0500, Segher Boessenkool wrote: >> On Thu, Oct 25, 2018 at 01:41:15PM -0500, Paul Clarke wrote: >>> For compatibility implementation of x86 vector intrinsic, _mm_extract_pi16, >>> adjust shift value for big-endian mo

Re: Turn complete to incomplete types in free_lang_data

2018-10-26 Thread Richard Biener
On Fri, Oct 26, 2018 at 1:29 PM Jan Hubicka wrote: > > Hi, > this is minimal variant of the patch turning complete to incomplete pointers > in > fields. We can do more - in particular it would be very function to do same > for functions types and decls (because they often end up being streamed t

Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Than McIntosh via gcc-patches
Thanks for reporting this. Sent https://go-review.googlesource.com/c/gofrontend/+/145017 with a tentative fix. Than On Fri, Oct 26, 2018 at 7:55 AM Rainer Orth wrote: > > Hi Ian, > > > This patch by Than McIntosh improves the mangling of package paths in > > the Go frontend. > > > > The curren

Improve relocation

2018-10-26 Thread Marc Glisse
Hello, here are some tweaks so that I can usefully mark deque as trivially relocatable. It includes more noexcept(auto) madness. For __relocate_a_1, I should also test if copying, ++ and != are noexcept, but I wanted to ask first because there might be restrictions on what iterators are allowe

Re: Go patch committed: Improve name mangling for package paths

2018-10-26 Thread Rainer Orth
Hi Ian, > This patch by Than McIntosh improves the mangling of package paths in > the Go frontend. > > The current implementation of Gogo::pkgpath_for_symbol was written in > a way that allowed two distinct package paths to map to the same > symbol, which could cause collisions at link- time or co

Turn complete to incomplete types in free_lang_data

2018-10-26 Thread Jan Hubicka
Hi, this is minimal variant of the patch turning complete to incomplete pointers in fields. We can do more - in particular it would be very function to do same for functions types and decls (because they often end up being streamed to symtab) and we should also turn pointers to arrays and enums to

Re: Free more of type decls

2018-10-26 Thread Richard Biener
On Fri, 26 Oct 2018, Jan Hubicka wrote: > > On Fri, Oct 26, 2018 at 9:12 AM Jan Hubicka wrote: > > > > > > Hi, > > > this patch frees TYPE_DECL and alignment from TYPE_DECL and also preserves > > > only those TYPE_DECL pointers that are actually used to build ODR type > > > tree. > > > > > > It

Re: [PATCH] Add option to control warnings added through attribure "warning"

2018-10-26 Thread Nikolai Merinov
Hi, What next steps should I perform in order to get this changes merged to GCC? Regards, Nikolai - Original Message - From: "Nikolai Merinov" To: "Martin Sebor" , gcc-patches@gcc.gnu.org Sent: Monday, October 15, 2018 3:21:15 PM Subject: Re: [PATCH] Add option to control warnings added

[PATCH] Fix compile-time issue with last SLP vectorizer patch

2018-10-26 Thread Richard Biener
While I fixed up all correctness places I totally forgot about compile-time when not adding visited hash_set<>s to all SLP tree walks. This rectifies things and fixes 538.imagick_r build time (currently reducing a testcase which I will add once finished). Bootstrapped on x86_64-unknown-linux-g

Re: RFC: Allow moved-from strings to be non-empty

2018-10-26 Thread Marc Glisse
On Fri, 26 Oct 2018, Ville Voutilainen wrote: On Fri, 26 Oct 2018 at 12:55, Jonathan Wakely wrote: Why not? There are already several, and it helps find bugs. Maybe you could convince libc++ to change as well if you want to keep the behavior the same? What bugs? Assuming the string is empt

Fix up gcc_release script

2018-10-26 Thread Jakub Jelinek
Hi! I got a failure when trying to do 6.5 release, because "^GCC 6.5" didn't match in the expected portion of NEWS, there was only GCC 6.5 This patch accepts whitespace before it and makes the checks consistent, also it doesn't print just the first argument on error/inform, but all of them (nee

maintainer-scripts closing of 6.x

2018-10-26 Thread Jakub Jelinek
Hi! I've committed this change to close the 6.x branch. 2018-10-26 Jakub Jelinek * update_version_svn (IGNORE_BRANCHES): Add gcc-6-branch. * crontab: Remove gcc-6-branch entry. --- maintainer-scripts/update_version_svn.jj2017-10-10 15:08:45.837996075 +0200 +++ maintainer

Re: [PATCH][GCC][mingw-w64][Ada] Fix Ada native bootstrap (PR81878).

2018-10-26 Thread Eric Botcazou
> Due to the changes in PR81878 builds of GCC8 and trunk are impossible > with Ada enabled[1][2]. > > The reason the patch breaks the bootstrap is due to how gnatlink receives > it's arguments. Thanks for working on this! > Bootstrapped on x86_64-pc-linux-gnu and mingw-w64-x86_64. > > Ok for tr

Re: RFC: Allow moved-from strings to be non-empty

2018-10-26 Thread Ville Voutilainen
On Fri, 26 Oct 2018 at 12:55, Jonathan Wakely wrote: > >> Why not? There are already several, and it helps find bugs. Maybe you > >> could convince libc++ to change as well if you want to keep the behavior > >> the same? > > > >What bugs? > > Assuming the string is empty after a move and appending

Re: RFC: Allow moved-from strings to be non-empty

2018-10-26 Thread Jonathan Wakely
On 26/10/18 08:25 +0200, Marc Glisse wrote: On Fri, 26 Oct 2018, Jonathan Wakely wrote: For the libc++ string zeroing the length of a small string happens to be faster. Ah, yes, of course. Is it? In debug mode, I'd be tempted to leave the string as "moved" (size 5, short string so there is

Re: RFC: Allow moved-from strings to be non-empty

2018-10-26 Thread Jonathan Wakely
On 26/10/18 12:16 +0300, Ville Voutilainen wrote: On Fri, 26 Oct 2018 at 01:42, Marc Glisse wrote: On Fri, 26 Oct 2018, Ville Voutilainen wrote: > I would rather not introduce a behavioral difference between us and > libc++. Why not? There are already several, and it helps find bugs. Maybe y

Ping^3 Re: [PATCH v3 0/6] [MIPS] Reorganize the loongson march and extensions instructions set

2018-10-26 Thread Paul Hua
Ping ? On Tue, Oct 23, 2018 at 9:16 AM Paul Hua wrote: > > Ping ? > > On Fri, Oct 19, 2018 at 2:19 PM Paul Hua wrote: > > > > Ping? > > > > I'd like check in those patches before stage3. > > > > Thanks, > > > > On Tue, Oct 16, 2018 at 10:49 AM Paul Hua wrote: > > > > > > Hi: > > > > > > The ori

Re: Free more of type decls

2018-10-26 Thread Jan Hubicka
> On Fri, Oct 26, 2018 at 9:12 AM Jan Hubicka wrote: > > > > Hi, > > this patch frees TYPE_DECL and alignment from TYPE_DECL and also preserves > > only those TYPE_DECL pointers that are actually used to build ODR type tree. > > > > It reduces number of TYPE_DECLs streamed from WPA to ltrans to ab

Re: RFC: Allow moved-from strings to be non-empty

2018-10-26 Thread Ville Voutilainen
On Fri, 26 Oct 2018 at 01:42, Marc Glisse wrote: > > On Fri, 26 Oct 2018, Ville Voutilainen wrote: > > > I would rather not introduce a behavioral difference between us and > > libc++. > > Why not? There are already several, and it helps find bugs. Maybe you > could convince libc++ to change as we

Re: [PATCH 0/7] libsanitizer: merge from trunk

2018-10-26 Thread Jakub Jelinek
On Thu, Oct 25, 2018 at 12:49:42PM +0200, Jakub Jelinek wrote: > On Thu, Oct 25, 2018 at 12:15:46PM +0200, marxin wrote: > > I've just finished my first merge from libsanitizer mainline. Overall it > > looks fine, apparently ABI hasn't changed and so that SONAME bump is not > > needed. > > Given t

Re: Is the D frontend good to go? (was Re: [PATCH 02/14] Add D frontend (GDC) implementation.)

2018-10-26 Thread Richard Biener
On Thu, Oct 25, 2018 at 4:13 PM Iain Buclaw wrote: > > On Thu, 25 Oct 2018 at 15:06, David Malcolm wrote: > > > > On Tue, 2018-10-23 at 19:21 +0200, Iain Buclaw wrote: > > > On Tue, 23 Oct 2018 at 15:48, Richard Sandiford > > > wrote: > > > > > > > > Iain Buclaw writes: > > > > > I'm just going

Re: [PATCH] Relax hash function to match equals function behavior (PR testsuite/86158).

2018-10-26 Thread Richard Biener
On Fri, Oct 26, 2018 at 9:20 AM Martin Liška wrote: > > Hi. > > The patch aligns ipa_vr_ggc_hash_traits::hash function what actual > ipa_vr_ggc_hash_traits::equals > operator does. Currently, the hash function is pointer based, which the real > equal operator > does internally operand_equal_p, w

Re: Free more of type decls

2018-10-26 Thread Richard Biener
On Fri, Oct 26, 2018 at 9:12 AM Jan Hubicka wrote: > > Hi, > this patch frees TYPE_DECL and alignment from TYPE_DECL and also preserves > only those TYPE_DECL pointers that are actually used to build ODR type tree. > > It reduces number of TYPE_DECLs streamed from WPA to ltrans to about 20% > and

Re: [C++ Patch] PR 84644 ("internal compiler error: in warn_misplaced_attr_for_class_type, at cp/decl.c:4718")

2018-10-26 Thread Paolo Carlini
Hi, On 24/10/18 22:41, Jason Merrill wrote: On 10/15/18 12:45 PM, Paolo Carlini wrote:     && ((TREE_CODE (declspecs->type) != TYPENAME_TYPE +   && TREE_CODE (declspecs->type) != DECLTYPE_TYPE && MAYBE_CLASS_TYPE_P (declspecs->type)) I would think that the MAYBE_CLASS_TYPE_P

Re: [RFC][PR87528][PR86677] Disable builtin popcount detection when back-end does not define it

2018-10-26 Thread Richard Biener
On Fri, Oct 26, 2018 at 4:55 AM Jeff Law wrote: > > On 10/25/18 4:33 PM, Kugan Vivekanandarajah wrote: > > Hi, > > > > PR87528 showed a case where libgcc generated popcount is causing > > regression for Skylake. > > We also have PR86677 where kernel build is failing because the kernel > > does not

Re: [PATCH][GCC][mingw-w64][Ada] Fix Ada native bootstrap (PR81878).

2018-10-26 Thread Arnaud Charlet
> Bootstrapped on x86_64-pc-linux-gnu and mingw-w64-x86_64. > > Ok for trunk? OK, thanks.

Re: V4 [PATCH] x86: Add pmovzx/pmovsx patterns with memory operands

2018-10-26 Thread H.J. Lu
On 10/26/18, Uros Bizjak wrote: > On Fri, Oct 26, 2018 at 9:37 AM Uros Bizjak wrote: >> >> On Fri, Oct 26, 2018 at 9:35 AM Uros Bizjak wrote: >> > >> > On Fri, Oct 26, 2018 at 9:19 AM H.J. Lu wrote: >> > > >> > > On 10/25/18, Uros Bizjak wrote: >> > > > On Fri, Oct 26, 2018 at 8:07 AM H.J. Lu

[AArch64] Add Saphira pipeline description.

2018-10-26 Thread Sameera Deshpande
Hi! Please find attached the patch to add a pipeline description for the Qualcomm Saphira core. It is tested with a bootstrap and make check, with no regressions. Ok for trunk? gcc/ Changelog: 2018-10-26 Sameera Deshpande * config/aarch64/aarch64-cores.def (saphira): Use saphira pipeline. *

Re: [PATCH v4] Avoid unnecessarily numbering cloned symbols.

2018-10-26 Thread Martin Liška
On 10/26/18 12:59 AM, Michael Ploujnikov wrote: > I've taken the advice from a discussion on IRC and re-wrote the patch > with more uniform function names and using overloading. > > I think this function accomplished the following goals: > - remove clone numbering where it's not needed: >fina

Fix failure with the odr-1.C test

2018-10-26 Thread Jan Hubicka
Hi, this patch fixes issues with the odr test I made yesterday. One problem is that I got the template wrong which made dg to crash and I did not notice it fails. Other problem is that it still trips an sanity check in ipa-devirt. This is fixed now. It is bit surprising that one can make C++ non

[PATCH] apply_subst_iterator: Handle define_split/define_insn_and_split

2018-10-26 Thread H.J. Lu
On 10/25/18, Uros Bizjak wrote: > On Fri, Oct 26, 2018 at 8:48 AM H.J. Lu wrote: >> >> On 10/25/18, Uros Bizjak wrote: >> > On Fri, Oct 26, 2018 at 8:07 AM H.J. Lu wrote: >> >> >> >> * read-rtl.c (apply_subst_iterator): Handle >> >> define_insn_and_split. >> >> --- >> >> gcc/read-rtl.c

Re: V4 [PATCH] x86: Add pmovzx/pmovsx patterns with memory operands

2018-10-26 Thread Uros Bizjak
On Fri, Oct 26, 2018 at 9:37 AM Uros Bizjak wrote: > > On Fri, Oct 26, 2018 at 9:35 AM Uros Bizjak wrote: > > > > On Fri, Oct 26, 2018 at 9:19 AM H.J. Lu wrote: > > > > > > On 10/25/18, Uros Bizjak wrote: > > > > On Fri, Oct 26, 2018 at 8:07 AM H.J. Lu wrote: > > > >> > > > >> Many x86 pmovzx/

Re: V4 [PATCH] x86: Add pmovzx/pmovsx patterns with memory operands

2018-10-26 Thread Uros Bizjak
On Fri, Oct 26, 2018 at 9:35 AM Uros Bizjak wrote: > > On Fri, Oct 26, 2018 at 9:19 AM H.J. Lu wrote: > > > > On 10/25/18, Uros Bizjak wrote: > > > On Fri, Oct 26, 2018 at 8:07 AM H.J. Lu wrote: > > >> > > >> Many x86 pmovzx/pmovsx instructions with memory operands are modeled in > > >> a wrong

Re: [PATCH] Change vectorizer SLP tree to be a graph

2018-10-26 Thread Richard Biener
On Wed, 24 Oct 2018, Richard Biener wrote: > > This does the last step (I've already changed costing, analysis and > code generation to process nodes as if it were) in making the SLP > tree a graph. This means adjusting SLP analysis to lookup already > identified SLP nodes for a set of scalar st

Re: V4 [PATCH] x86: Add pmovzx/pmovsx patterns with memory operands

2018-10-26 Thread Uros Bizjak
On Fri, Oct 26, 2018 at 9:19 AM H.J. Lu wrote: > > On 10/25/18, Uros Bizjak wrote: > > On Fri, Oct 26, 2018 at 8:07 AM H.J. Lu wrote: > >> > >> Many x86 pmovzx/pmovsx instructions with memory operands are modeled in > >> a wrong way. For example: > >> > >> (define_insn "sse4_1_v8qiv8hi2" > >>

[PATCH] Relax hash function to match equals function behavior (PR testsuite/86158).

2018-10-26 Thread Martin Liška
Hi. The patch aligns ipa_vr_ggc_hash_traits::hash function what actual ipa_vr_ggc_hash_traits::equals operator does. Currently, the hash function is pointer based, which the real equal operator does internally operand_equal_p, which works fine for equal constants (with different addresses). It

[PATCH] Fix testsuite issue throwing off TCL

2018-10-26 Thread Richard Biener
Committed. Richard. 2018-10-26 Richard Biener PR testsuite/87754 * g++.dg/lto/odr-1_0.C: Fix pattern. Index: gcc/testsuite/g++.dg/lto/odr-1_0.C === --- gcc/testsuite/g++.dg/lto/odr-1_0.C (revision 265516) +++

V4 [PATCH] x86: Add pmovzx/pmovsx patterns with memory operands

2018-10-26 Thread H.J. Lu
On 10/25/18, Uros Bizjak wrote: > On Fri, Oct 26, 2018 at 8:07 AM H.J. Lu wrote: >> >> Many x86 pmovzx/pmovsx instructions with memory operands are modeled in >> a wrong way. For example: >> >> (define_insn "sse4_1_v8qiv8hi2" >> [(set (match_operand:V8HI 0 "register_operand" "=Yr,*x,v") >>

Cleanup handling of variants in ipa-devirt

2018-10-26 Thread Jan Hubicka
Hi, with this patch ipa-devirt no longer needs TYPE_DECLs on type variants. The basic idea is that anything working with ODR types should work on main variants only. For ODR type checking we then have type_variants_equivalent_p which double check that we have same qualifiers, alignment and attribu

Re: [PATCH] Make __PRETTY_FUNCTION__-like functions mergeable string csts (PR c++/64266).

2018-10-26 Thread Martin Liška
On 10/24/18 7:24 PM, Jason Merrill wrote: > On Tue, Oct 23, 2018 at 4:59 AM Martin Liška wrote: >> However, I still see some minor ICEs, it's probably related to >> decay_conversion in cp_fname_init: >> >> 1) ./xg++ -B. >> /home/marxin/Programming/gcc/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-__f

Free more of type decls

2018-10-26 Thread Jan Hubicka
Hi, this patch frees TYPE_DECL and alignment from TYPE_DECL and also preserves only those TYPE_DECL pointers that are actually used to build ODR type tree. It reduces number of TYPE_DECLs streamed from WPA to ltrans to about 20% and is important for the patch turning types to incomplete types. Wi