On 10/25/2018 05:08 PM, Jakub Jelinek wrote: > On Thu, Oct 25, 2018 at 05:07:03PM -0500, Segher Boessenkool wrote: >> On Thu, Oct 25, 2018 at 01:41:15PM -0500, Paul Clarke wrote: >>> For compatibility implementation of x86 vector intrinsic, _mm_extract_pi16, >>> adjust shift value for big-endian mode. >>> >>> Bootstrapped and tested on Linux POWER8 LE, POWER8 BE (64 & 32), and POWER7. >> >> Does it fix existing testcases?
No. I found it with my own testing. I have a "to-do" to enhance the testing in this area, not only for endian issues, but I think corner/edge cases are not well tested. >> Okay for trunk in either case. Thanks! Also fine to backport to 8. Thanks! >>> 2018-10-25 Paul A. Clarke <p...@us.ibm.com> >>> >>> * config/rs6000/xmmintrin.h: Fix _mm_extract_pi16 for big-endian. > > The ChangeLog entry is incorrect, should be: > * config/rs6000/xmmintrin.h (_mm_extract_pi16): Fix for big-endian. > or so. Will fix before committing. Thanks! PC
