Re: libgo patch committed: Update to 1.11 release

2018-09-24 Thread Andreas Schwab
This breaks aarch64/-mabi=ilp32. ../../../../libgo/go/internal/poll/splice_linux.go:165:45: error: reference to undefined identifier 'syscall.SYS_FCNTL' 165 | if _, _, errno := syscall.Syscall(syscall.SYS_FCNTL, uintptr(fds[0]), syscall.F_GETPIPE_SZ, 0); errno != 0 { |

Re: GCC 8 backports

2018-09-24 Thread Martin Liška
Hi. One more tested patch. Martin >From 62538e940432b55cf38e96e1a2cd72ed1f5f569f Mon Sep 17 00:00:00 2001 From: marxin Date: Mon, 24 Sep 2018 11:22:38 + Subject: [PATCH] Backport r264528 gcc/ChangeLog: 2018-09-24 Martin Liska PR sanitizer/85774 * asan.c: Make asan_handled_variables e

Re: [patch, fortran, committed] Another fallout from the INTENT(OUT) patch

2018-09-24 Thread Janus Weil
Am Mo., 24. Sep. 2018 um 19:16 Uhr schrieb Thomas Koenig : > > Hello world, > > another obvious and simple one-line fix for fallout from the INTENT(OUT) > clobber patch. Committed as r264539, after regression-testing. > > It seems our testsuite is not testing as many combinations in the > language

Re: [PATCH] Fix EQ_ATTR_ALT size calculation (PR bootstrap/87417)

2018-09-24 Thread Richard Sandiford
Ilya Leoshkevich writes: > Bootstrap and regtest running on s390x-redhat-linux. > > "r264537: Change EQ_ATTR_ALT to support up to 64 alternatives" changed > the format of EQ_ATTR_ALT from ii to ww. This broke the bootstrap on > 32-bit systems, because the formula for rtx_code_size assumed that on

Re: [PATCH v4 01/10] Initial TI PRU GCC port

2018-09-24 Thread Dimitar Dimitrov
On Monday, 9/24/2018 11:38:23 EEST Richard Sandiford wrote: > Dimitar Dimitrov writes: > > On Thursday, 9/13/2018 13:02:21 EEST Richard Sandiford wrote: > >> Dimitar Dimitrov writes: > >> > +/* Callback for walk_gimple_seq that checks TP tree for TI ABI > >> > compliance. */ +static tree > >> >

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-24 Thread Jeff Law
On 9/24/18 12:18 PM, Bernd Edlinger wrote: > On 09/24/18 19:48, Jeff Law wrote: >> On 9/16/18 1:58 PM, Bernd Edlinger wrote: >>> Hi, >>> >>> this is a cleanup of the recently added strlen/strcpy/stpcpy >>> no nul warning code. >>> >>> Most importantly it moves the SSA_NAME handling from >>> untermi

[PATCH] RISC-V: Fix problems with ilp32e ABI support.

2018-09-24 Thread Jim Wilson
Using -march=rv32i -mabi=ilp32e causes the high registers to be accidentally used in the calling convention. This is a problem with ABI related macros checking the architecture for RVE support instead of the ABI for ilp32e support, which is easy to fix. This was tested with cross riscv32-elf buil

Merge from trunk to gccgo branch

2018-09-24 Thread Ian Lance Taylor
I merged trunk revision 264547 to the gccgo branch. Ian

[Committed] Fix -mcpu=thunderx and -mcpu=thunderx2t99

2018-09-24 Thread Andrew Pinski
Hi, When Naveen committed the following patch: 2017-06-29 Naveen H.S * config/aarch64/aarch64.c (aarch_macro_fusion_pair_p): Push the check for CC usage into AARCH64_FUSE_CMP_BRANCH. * config/i386/i386.c (ix86_macro_fusion_pair_p): Push the check for CC usage f

Re: [PATCH 08/14] Add D2 Testsuite files.

2018-09-24 Thread Iain Buclaw
On 24 September 2018 at 20:28, Mike Stump wrote: > On Sep 21, 2018, at 2:38 PM, Iain Buclaw wrote: >> >> On 21 September 2018 at 22:54, Mike Stump wrote: >>> On Sep 17, 2018, at 5:36 PM, Iain Buclaw wrote: This patch adds part of the D2 testsuite, which includes D source code fil

[libstdc++,doc] doc/xml/manual/codecvt.xml: Move link to "UTF-8 and Unicode FAQ" to https

2018-09-24 Thread Gerald Pfeifer
Committed. Gerald 2018-09-25 Gerald Pfeifer * doc/xml/manual/codecvt.xml: Move link to "UTF-8 and Unicode FAQ" to https. Index: doc/xml/manual/codecvt.xml === --- doc/xml/manual/codecvt.xml (revision 264546) +++

[wwwdocs] Tweak hierarchy of headings in gcc-5/porting_to.html

2018-09-24 Thread Gerald Pfeifer
While working on the porting_to.html guides for later versions, I noticed that the Links heading was at the wrong level ( instead of ). Fixed thusly; committed. Gerald Index: gcc-5/porting_to.html === RCS file: /cvs/gcc/wwwdocs/htdo

[wwwdocs] Fix a link to intel.com on readings.html

2018-09-24 Thread Gerald Pfeifer
Committed. Gerald Index: readings.html === RCS file: /cvs/gcc/wwwdocs/htdocs/readings.html,v retrieving revision 1.301 diff -u -r1.301 readings.html --- readings.html 23 Sep 2018 15:21:34 - 1.301 +++ readings.html

[PATCH] Fix EQ_ATTR_ALT size calculation (PR bootstrap/87417)

2018-09-24 Thread Ilya Leoshkevich
Bootstrap and regtest running on s390x-redhat-linux. "r264537: Change EQ_ATTR_ALT to support up to 64 alternatives" changed the format of EQ_ATTR_ALT from ii to ww. This broke the bootstrap on 32-bit systems, because the formula for rtx_code_size assumed that only certain codes contain HOST_WIDE_

libgo patch committed: Update to 1.11 release

2018-09-24 Thread Ian Lance Taylor
I've committed a patch to update libgo to the 1.11 release. As usual for these updates, the patch is too large to attach to this e-mail message. I've attached some of the more relevant directories. This update required some minor patches to the gotools directory and the Go testsuite, also includ

Re: [PR 87339, testsuite] Fix failure of gcc.dg/warn-abs-1.c on some targets

2018-09-24 Thread Christophe Lyon
On Mon, 24 Sep 2018 at 20:46, Martin Jambor wrote: > > Hi, > > the test added to check whether _Float128 types are handled correctly by > the new warning about suspicious calls to abs-like functions fails on > many platforms. The patch below circumvents the problem by running on > i686/x86_64 onl

Re: [PATCH] Do array index calculations in gfc_array_index_type

2018-09-24 Thread Janne Blomqvist
On Mon, Sep 24, 2018 at 7:48 PM Kyrill Tkachov wrote: > Hi all, > > On 24/09/18 14:54, Andreas Schwab wrote: > > On Sep 22 2018, Janne Blomqvist wrote: > > > > > +! { dg-final { scan-tree-dump-times "_gfortran_caf_lock > \\(four.token, .*\\(1 - four.dim\\\[0\\\].lbound\\), > \\(integer\\(kind=4\

Re: [PATCH, libgfortran] Remove recursion check

2018-09-24 Thread Janne Blomqvist
On Mon, Sep 24, 2018 at 7:48 PM Thomas Koenig wrote: > Hi Janne, > > > libgfortran has a recursion check in the error handling paths. This > > works by checking the value of a static variable, and if it matches, > > aborting immediately instead of continuing error processing. > > Unfortunately,

Re: [PR 87339, testsuite] Fix failure of gcc.dg/warn-abs-1.c on some targets

2018-09-24 Thread Mike Stump
On Sep 24, 2018, at 11:45 AM, Martin Jambor wrote: > > the test added to check whether _Float128 types are handled correctly by > the new warning about suspicious calls to abs-like functions fails on > many platforms. The patch below circumvents the problem by running on > i686/x86_64 only. I u

Re: [PATCH] PR86957

2018-09-24 Thread Indu Bhagat
Done. Attached is updated patch. Patch is tested on x86_64 Thanks On 09/24/2018 09:37 AM, Martin Sebor wrote: I would suggest to use the term "remove" or "delete" instead of the informal "wipe out" when referring to removing files or their contents. Martin diff --git a/gcc/common.opt b/gc

Re: C++ PATCH: trivial cleanup

2018-09-24 Thread Jason Merrill
OK. On Fri, Sep 21, 2018 at 3:51 PM, Marek Polacek wrote: > Use the proper type for "complain". > > I guess it's obvious, but anyway, bootstrapped/regtested on x86_64-linux, ok > for trunk? > > 2018-09-21 Marek Polacek > > * cp-tree.h (build_noexcept_spec, add_exception_specifier): Adj

[PR 87339, testsuite] Fix failure of gcc.dg/warn-abs-1.c on some targets

2018-09-24 Thread Martin Jambor
Hi, the test added to check whether _Float128 types are handled correctly by the new warning about suspicious calls to abs-like functions fails on many platforms. The patch below circumvents the problem by running on i686/x86_64 only. I understand that the proper solution would be to come up wit

[PR 87347] Prevent segfaults if TYPE_ARG_TYPES is NULL

2018-09-24 Thread Martin Jambor
Hi, the warning for suspicious calls of abs-like functions segfaults if a user declared their own parameter-less-ish variant of abs like in the testcase below. Fixed by looking whether there is any TYPE_ARG_TYPES before trying to compare the actual argument with it. Bootstrapped and tested on x8

Re: [PATCH 08/14] Add D2 Testsuite files.

2018-09-24 Thread Mike Stump
On Sep 21, 2018, at 2:38 PM, Iain Buclaw wrote: > > On 21 September 2018 at 22:54, Mike Stump wrote: >> On Sep 17, 2018, at 5:36 PM, Iain Buclaw wrote: >>> >>> This patch adds part of the D2 testsuite, which includes D source code >>> files that are considered compilable; files that are consid

Re: [PATCH] Remove Pascal-related entries in code and comments.

2018-09-24 Thread Jeff Law
On 9/24/18 5:17 AM, Martin Liška wrote: > On 9/21/18 6:47 PM, Joseph Myers wrote: >> On Fri, 21 Sep 2018, Martin Liška wrote: >> >>> Hi. >>> >>> This is removal of some Pascal-related comments. >> There are two different kinds of comments being removed here. There are >> comments relating to GNU

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-24 Thread Bernd Edlinger
On 09/24/18 19:48, Jeff Law wrote: > On 9/16/18 1:58 PM, Bernd Edlinger wrote: >> Hi, >> >> this is a cleanup of the recently added strlen/strcpy/stpcpy >> no nul warning code. >> >> Most importantly it moves the SSA_NAME handling from >> unterminated_array to string_constant, thereby fixing >> ano

Re: [PATCH][DOC] Document all param values and remove defaults (PR middle-end/86078).

2018-09-24 Thread Jeff Law
On 9/24/18 4:18 AM, Martin Liška wrote: > Hi. > > As mentioned in the PR we miss defaults for quite some param option. > I agreed with Richi that easiest way how to fix that would be to remove > that from documentation and use rather --help=param. It's done in the patch. > > Apart from that I rem

Re: [PATCH] Cleanup strcpy/stpcpy no nul warning code

2018-09-24 Thread Jeff Law
On 9/16/18 1:58 PM, Bernd Edlinger wrote: > Hi, > > this is a cleanup of the recently added strlen/strcpy/stpcpy > no nul warning code. > > Most importantly it moves the SSA_NAME handling from > unterminated_array to string_constant, thereby fixing > another round of xfails in the strlen and stpc

Re: [PATCH v4 01/10] Initial TI PRU GCC port

2018-09-24 Thread Jeff Law
On 9/24/18 4:38 AM, Richard Sandiford wrote: > Dimitar Dimitrov writes: >> On Thursday, 9/13/2018 13:02:21 EEST Richard Sandiford wrote: >>> Dimitar Dimitrov writes: +(define_insn "sub_impl_>>> _zext_op2>" + [(set (match_operand:EQD 0 "register_operand" "=r,r,r") + (minus:EQD >>>

Re: [PATCH 02/25] Propagate address spaces to builtins.

2018-09-24 Thread Andreas Schwab
On Sep 24 2018, Andrew Stubbs wrote: > What should I have done? Make sure you have the ILP32 patches for glibc and kernel. You can get them from the arm/ilp32 branch on sourceware.org and the staging/ilp32-4.17 branch of

Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread H.J. Lu
On Mon, Sep 24, 2018 at 10:23 AM, H.J. Lu wrote: > On Mon, Sep 24, 2018 at 9:55 AM, Jan Hubicka wrote: >>> On Mon, Sep 24, 2018 at 9:50 AM, Jan Hubicka wrote: >>> >> On Mon, Sep 24, 2018 at 9:19 AM, Jan Hubicka wrote: >>> >> >> >> PING. >>> >> >> > >>> >> >> > Hi, Jan Uros, >>> >> >> > >>> >> >

Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread H.J. Lu
On Mon, Sep 24, 2018 at 9:55 AM, Jan Hubicka wrote: >> On Mon, Sep 24, 2018 at 9:50 AM, Jan Hubicka wrote: >> >> On Mon, Sep 24, 2018 at 9:19 AM, Jan Hubicka wrote: >> >> >> >> PING. >> >> >> > >> >> >> > Hi, Jan Uros, >> >> >> > >> >> >> > Can you review this patch? >> >> >> >> >> >> I don't kn

[patch, fortran, committed] Another fallout from the INTENT(OUT) patch

2018-09-24 Thread Thomas Koenig
Hello world, another obvious and simple one-line fix for fallout from the INTENT(OUT) clobber patch. Committed as r264539, after regression-testing. It seems our testsuite is not testing as many combinations in the language as I thought :-) Regards Thomas 2018-09-24 Thomas Koenig

ping [PATCH 0/4] [MSP430] Add methods to extract MCU data from file

2018-09-24 Thread Jozef Lawrynowicz
ping for these patches [PATCH 1/4] [MSP430] Consolidate hard-coded MCU data https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01673.html [PATCH 2/4] [MSP430] Update hard-coded MCU data https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01674.html [PATCH 3/4] [MSP430] Search for MCU data file on include

Re: [PATCH] v2: C++: suggestions for misspelled private members (PR c++/84993)

2018-09-24 Thread Martin Sebor
On 09/21/2018 04:09 PM, David Malcolm wrote: This is v2 of the patch; I managed to bit-rot my own patch due to my fix for r264335, which tightened up the "is this meaningful" threshold on edit distances when finding spelling correction candidates. The only change in this version is to rename var

Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread Jan Hubicka
> On Mon, Sep 24, 2018 at 9:50 AM, Jan Hubicka wrote: > >> On Mon, Sep 24, 2018 at 9:19 AM, Jan Hubicka wrote: > >> >> >> PING. > >> >> > > >> >> > Hi, Jan Uros, > >> >> > > >> >> > Can you review this patch? > >> >> > >> >> I don't know CET stuff, so I'm not able to review functionality of CET

Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread H.J. Lu
On Mon, Sep 24, 2018 at 9:50 AM, Jan Hubicka wrote: >> On Mon, Sep 24, 2018 at 9:19 AM, Jan Hubicka wrote: >> >> >> PING. >> >> > >> >> > Hi, Jan Uros, >> >> > >> >> > Can you review this patch? >> >> >> >> I don't know CET stuff, so I'm not able to review functionality of CET >> >> patches. >>

Re: [PATCH 02/25] Propagate address spaces to builtins.

2018-09-24 Thread Andrew Stubbs
On 22/09/18 19:51, Andreas Schwab wrote: That breaks aarch64 ILP32. I'm struggling to reproduce this because apparently I don't know how to build aarch64 ILP32. Presumably, in order to be building libgomp this must be an aarch64-linux-gnu toolchain, but when I set --with-abi=ilp32 I can't

Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread Jan Hubicka
> On Mon, Sep 24, 2018 at 9:19 AM, Jan Hubicka wrote: > >> >> PING. > >> > > >> > Hi, Jan Uros, > >> > > >> > Can you review this patch? > >> > >> I don't know CET stuff, so I'm not able to review functionality of CET > >> patches. > > > > My (very partial) understanding is that ENDBR is used to

Re: [PATCH] Do array index calculations in gfc_array_index_type

2018-09-24 Thread Kyrill Tkachov
Hi all, On 24/09/18 14:54, Andreas Schwab wrote: On Sep 22 2018, Janne Blomqvist wrote: > +! { dg-final { scan-tree-dump-times "_gfortran_caf_lock \\(four.token, .*\\(1 - four.dim\\\[0\\\].lbound\\), \\(integer\\(kind=4\\)\\) \\(7 - four.dim\\\[1\\\].lbound\\), &acquired.\[0-9\]+, &ii, 0B, 0

Re: [PATCH, libgfortran] Remove recursion check

2018-09-24 Thread Thomas Koenig
Hi Janne, libgfortran has a recursion check in the error handling paths. This works by checking the value of a static variable, and if it matches, aborting immediately instead of continuing error processing. Unfortunately, in a multi-threaded program, if two threads report an error at the same

Re: [PATCH] Change EQ_ATTR_ALT to support up to 64 alternatives

2018-09-24 Thread Rainer Orth
Hi Ilya, >> Am 24.09.2018 um 13:29 schrieb Richard Sandiford : >> >> Ilya Leoshkevich writes: >>> On S/390 there is a need to support more than 32 instruction >>> alternatives per define_insn. Currently this is not explicitly >>> prohibited or unsupported: MAX_RECOG_ALTERNATIVES is equal 35, an

Re: [PATCH] PR86957

2018-09-24 Thread Martin Sebor
On 09/21/2018 05:27 PM, Indu Bhagat wrote: Attached is the refreshed patch for trunk. After commit 264462 (Remove arc profile histogram in non-LTO mode.), the API of get_coverage_counts was changed a bit. So the main difference between the current version of my patch from the previous one is tha

Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread H.J. Lu
On Mon, Sep 24, 2018 at 9:19 AM, Jan Hubicka wrote: >> >> PING. >> > >> > Hi, Jan Uros, >> > >> > Can you review this patch? >> >> I don't know CET stuff, so I'm not able to review functionality of CET >> patches. > > My (very partial) understanding is that ENDBR is used to mark places where one

Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread Jan Hubicka
> >> PING. > > > > Hi, Jan Uros, > > > > Can you review this patch? > > I don't know CET stuff, so I'm not able to review functionality of CET > patches. My (very partial) understanding is that ENDBR is used to mark places where one can jump/call. So we need to always arrange it first. Normally

Re: PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread Uros Bizjak
On Mon, Sep 24, 2018 at 4:34 PM, H.J. Lu wrote: > On Mon, Apr 2, 2018 at 5:08 AM, H.J. Lu wrote: >> On Mon, Mar 26, 2018 at 4:09 AM, H.J. Lu wrote: >>> On Fri, Jan 26, 2018 at 6:23 AM, H.J. Lu wrote: On Sun, Jan 7, 2018 at 7:11 PM, H.J. Lu wrote: > On Tue, Oct 24, 2017 at 10:58 AM, H.

Re: [C++ Patch] PR 85070 ("[8/9 Regression] ICE on C++ code: in lazily_declare_fn, at cp/method.c:2409")

2018-09-24 Thread Nathan Sidwell
On 9/24/18 3:48 AM, Paolo Carlini wrote: Hi, as explained in the audit trail, the gcc_assert added by Nathan triggers during error-recovery too, when add_method correctly returns false because it failed to add the method. Thus it seems that we should simply loosen a bit the assertion. Tested

Re: [PATCH] Change EQ_ATTR_ALT to support up to 64 alternatives

2018-09-24 Thread Ilya Leoshkevich
> Am 24.09.2018 um 13:29 schrieb Richard Sandiford : > > Ilya Leoshkevich writes: >> On S/390 there is a need to support more than 32 instruction >> alternatives per define_insn. Currently this is not explicitly >> prohibited or unsupported: MAX_RECOG_ALTERNATIVES is equal 35, and, >> futhermore

[patch,openacc] update fortran nested parallelism error messages

2018-09-24 Thread Cesar Philippidis
Bernhard noticed a typo in one of the OpenACC parallelism error messages. The error should have reported that gang loops cannot be nested inside vector loops, not worker loops. I'll commit the attached patch to trunk as obvious. I bootstrapped and regtested it against x86_64 Linux with nvptx offlo

Re: [openacc] Teach gfortran to lower OpenACC routine dims

2018-09-24 Thread Cesar Philippidis
On 09/20/2018 09:10 AM, Bernhard Reutner-Fischer wrote: > On Thu, 20 Sep 2018 07:41:08 -0700 > Cesar Philippidis wrote: > >> On 09/19/2018 03:27 PM, Bernhard Reutner-Fischer wrote: >>> On Wed, 5 Sep 2018 12:52:03 -0700 >>> Cesar Philippidis wrote: > diff --git a/gcc/fortran/trans-decl.c b/

Re: [PATCH 2/4] Remove unused functions and fields.

2018-09-24 Thread Jeff Law
On 9/22/18 1:08 PM, marxin wrote: > > gcc/ChangeLog: > > 2018-09-24 Martin Liska > > * alias.c (set_dest_equal_p): Remove unused function. > * config/i386/i386.c (def_builtin_pure2): Likewise. > * diagnostic-show-locus.c (class layout): Remove > unused field. > (

Re: [PATCH 1/4] Add filter-rtags-warnings.py script.

2018-09-24 Thread Jeff Law
On 9/23/18 1:16 AM, marxin wrote: > > contrib/ChangeLog: > > 2018-09-24 Martin Liska > > * filter-rtags-warnings.py: New file. > --- > contrib/filter-rtags-warnings.py | 71 > 1 file changed, 71 insertions(+) > create mode 100755 contrib/filter-rtags-w

Re: [PATCH 4/4] Fix scaling of a sreal number.

2018-09-24 Thread Jeff Law
On 9/23/18 1:08 AM, marxin wrote: > > The patch is addressing following LLVM warning: > gcc/ipa-fnsummary.c:2745:54:Value Conversion Issue: implicit conversion from > 'double' to 'int64_t' (aka 'long') changes value from 0.99 to 0: > -Wliteral-conversion > > Taking look at GIMPLE IR we end up w

Re: [PATCH 3/4] Fix small coding style issues (PR fortran/87394).

2018-09-24 Thread Jeff Law
On 9/22/18 1:17 PM, marxin wrote: > > gcc/ChangeLog: > > 2018-09-24 Martin Liska > > PR fortran/87394 > * dbgcnt.c (dbg_cnt_process_single_pair): Return false > instead of NULL. > * dumpfile.c (dump_enable_all): Remove extra parenthesis. > * gcov-tool.c: Declare

PING^6: [PATCH] i386: Insert ENDBR before the profiling counter call

2018-09-24 Thread H.J. Lu
On Mon, Apr 2, 2018 at 5:08 AM, H.J. Lu wrote: > On Mon, Mar 26, 2018 at 4:09 AM, H.J. Lu wrote: >> On Fri, Jan 26, 2018 at 6:23 AM, H.J. Lu wrote: >>> On Sun, Jan 7, 2018 at 7:11 PM, H.J. Lu wrote: On Tue, Oct 24, 2017 at 10:58 AM, H.J. Lu wrote: > On Tue, Oct 24, 2017 at 10:40 AM, A

Re: [PATCH] Do array index calculations in gfc_array_index_type

2018-09-24 Thread Andreas Schwab
On Sep 22 2018, Janne Blomqvist wrote: > +! { dg-final { scan-tree-dump-times "_gfortran_caf_lock \\(four.token, > .*\\(1 - four.dim\\\[0\\\].lbound\\), \\(integer\\(kind=4\\)\\) \\(7 - > four.dim\\\[1\\\].lbound\\), &acquired.\[0-9\]+, &ii, 0B, > 0\\);|_gfortran_caf_lock \\(four.token, 1 - fo

[PATCH 1/2] Check pie_enabled target in PIC tests

2018-09-24 Thread H.J. Lu
We need to check pie_enabled target in PIC tests to support GCC where PIE is enabled by default when configured with --enable-default-pie. PR testsuite/70150 * gcc.dg/20020312-2.c (dg-additional-options): Set to "-no-pie" for pie_enabled target. * gcc.dg/uninit-19.c

[PATCH 2/2] Check non-pic/ia32 in stackprotectexplicit2.C

2018-09-24 Thread H.J. Lu
For ia32, __stack_chk_fail isn't called in PIC. We need to check non-pic or non-ia32 before scanning for __stack_chk_fail. PR testsuite/70150 * g++.dg/stackprotectexplicit2.C: Scanning for __stack_chk_fail only for non-pic or non-ia32 . --- gcc/testsuite/g++.dg/stackprote

Re: [rs6000] Do not generate sibling call to nested function

2018-09-24 Thread Kyrill Tkachov
Hi Eric, On 18/09/18 15:56, Segher Boessenkool wrote: Hi! On Mon, Sep 17, 2018 at 11:11:53AM +0200, Eric Botcazou wrote: > more precisely, to a nested function that requires a static chain. The reason > is that the sibling call epilogue may clobber the static chain register r11. > > Tested on

Re: [PATCH v3] S/390: Fix conditional returns on z196+

2018-09-24 Thread Ulrich Weigand
Ilya Leoshkevich wrote: > gcc/ChangeLog: > > 2018-09-19 Ilya Leoshkevich > > PR target/80080 > * config/s390/s390.c (s390_emit_epilogue): Do not use PARALLEL > RETURN+USE when returning via %r14. > > gcc/testsuite/ChangeLog: > > 2018-09-19 Ilya Leoshkevich > > PR

[PATCH v3] S/390: Fix conditional returns on z196+

2018-09-24 Thread Ilya Leoshkevich
S/390 epilogue ends with (parallel [(return) (use %r14)]) instead of the more usual (return) or (simple_return). This sequence is not recognized by the conditional return logic in try_optimize_cfg (). This was introduced for processors older than z196, where it is sometimes profitable to use call

Re: [PATCH] Change EQ_ATTR_ALT to support up to 64 alternatives

2018-09-24 Thread Richard Sandiford
Ilya Leoshkevich writes: > On S/390 there is a need to support more than 32 instruction > alternatives per define_insn. Currently this is not explicitly > prohibited or unsupported: MAX_RECOG_ALTERNATIVES is equal 35, and, > futhermore, the related code uses uint64_t for bitmaps in most places. >

Re: [PATCH] Remove Pascal-related entries in code and comments.

2018-09-24 Thread Martin Liška
On 9/21/18 6:47 PM, Joseph Myers wrote: > On Fri, 21 Sep 2018, Martin Liška wrote: > >> Hi. >> >> This is removal of some Pascal-related comments. > > There are two different kinds of comments being removed here. There are > comments relating to GNU Pascal, which has long been a dead project, s

[libstdc++,doc] update a link in doc/xml/manual/policy_data_structures_biblio.xml

2018-09-24 Thread Gerald Pfeifer
Both the protocol (https) and the local part of the URL changed; updates thusly and committed. Gerald 2018-09-24 Gerald Pfeifer * doc/xml/manual/policy_data_structures_biblio.xml: Update link to "Priority Queues and the STL". Index: doc/xml/manual/policy_data_structures_bibl

Re: OpenCoarrays integration with gfortran

2018-09-24 Thread Alastair McKinstry
On 23/09/2018 10:46, Toon Moene wrote: On 09/22/2018 01:23 AM, Jerry DeLisle wrote: I just installed opencoarrays on my system at home (Debian Testing): root@moene:~# apt-get install libcoarrays-openmpi-dev ... Setting up libcaf-openmpi-3:amd64 (2.2.0-3) ... Setting up libcoarrays-openmpi-dev

[C++ Patch] PR 85070 ("[8/9 Regression] ICE on C++ code: in lazily_declare_fn, at cp/method.c:2409")

2018-09-24 Thread Paolo Carlini
Hi, as explained in the audit trail, the gcc_assert added by Nathan triggers during error-recovery too, when add_method correctly returns false because it failed to add the method. Thus it seems that we should simply loosen a bit the assertion. Tested x86_64-linux. Thanks, Paolo. //

Re: [PATCH v4 01/10] Initial TI PRU GCC port

2018-09-24 Thread Richard Sandiford
Dimitar Dimitrov writes: > On Thursday, 9/13/2018 13:02:21 EEST Richard Sandiford wrote: >> Dimitar Dimitrov writes: >> > +(define_insn >> > "sub_impl_> > _zext_op2>" + [(set (match_operand:EQD 0 "register_operand" "=r,r,r") >> > + (minus:EQD >> > + (zero_extend:EQD >> > +(match_operand:E

[Ada] Fix PR ada/87396

2018-09-24 Thread Eric Botcazou
Enumeration types are unsigned in Ada so use 'unsigned char' instead of 'char' for mapping Attribute_Id. Tested x86-64/Linux, applied on the mainline. 2018-09-24 Eric Botcazou PR ada/87396 * fe.h (Get_Attribute_Definition_Clause): Use 'unsigned char' instead of 'char

[PATCH][DOC] Document all param values and remove defaults (PR middle-end/86078).

2018-09-24 Thread Martin Liška
Hi. As mentioned in the PR we miss defaults for quite some param option. I agreed with Richi that easiest way how to fix that would be to remove that from documentation and use rather --help=param. It's done in the patch. Apart from that I remove few unused params and added all not yet documented

Re: [PR87054] fix unaligned access

2018-09-24 Thread Richard Biener
On Mon, 24 Sep 2018, Alexandre Oliva wrote: > On Sep 18, 2018, Richard Biener wrote: > > >> +# ifdef __SSE__ > >> +# define T __int128 > > Rainer reported this didn't work on 32-bit x86 with SSE enabled. > Here's a patch that fixes it. Ok to install? Tested on x86_64, > including such combin

[PATCH][GCC][ARM] New helper functions to check atomicity requirements

2018-09-24 Thread Matthew Malcomson
A few places in the arm and aarch64 backends check whether an atomic operation needs acquire or release semantics. This is generally done with a check like (is_mm_relaxed (model) || is_mm_consume (model) || is_mm_release (model)) In this patch we introduce two helper functions to make things

Re: [PR87054] fix unaligned access

2018-09-24 Thread Alexandre Oliva
On Sep 18, 2018, Richard Biener wrote: >> +# ifdef __SSE__ >> +# define T __int128 Rainer reported this didn't work on 32-bit x86 with SSE enabled. Here's a patch that fixes it. Ok to install? Tested on x86_64, including such combinations as -m32, -m32/-msse, and -m32/-mno-sse. [PR87054] ad

Re: [ARM] Fix ICE during thunk generation with -mlong-calls

2018-09-24 Thread Eric Botcazou
> Ah! But that still doesn't explain why you want to skip these passes > when building thunks. They simply don't work because there is no CFG for thunks; I can add a blurb about that. > So is the barrier correct, or isn't it? There's really no two ways > about this. I don't like arbitrary cha

[PATCH, libgfortran] Remove recursion check

2018-09-24 Thread Janne Blomqvist
libgfortran has a recursion check in the error handling paths. This works by checking the value of a static variable, and if it matches, aborting immediately instead of continuing error processing. Unfortunately, in a multi-threaded program, if two threads report an error at the same time, this ca

[RFC PATCH, i386]: Rewrite nearbyint expanders

2018-09-24 Thread Uros Bizjak
Hello! Attached patch rewrites nearbyint expanders. The problem with the current approach is, that setting mask flag of precision interrupt on x87 only prevents interrupt generation, but the insn still sets interrupt flag. fclex clears the flag, but it also clears other flags (e.g. invalid flag, s

Re: [patch, fortran, committed] Another fallout from clobbering INTENT(OUT) variables

2018-09-24 Thread Janus Weil
Hi Thomas, I'm seeing some more fallout from your intent(out) patch: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87401 Cheers, Janus Am So., 23. Sep. 2018 um 22:23 Uhr schrieb Thomas König : > > Hello world, > > committed as obvious after regression-testing. Instead of spending > a lot of wor

Re: [PATCH] Unpoison variable partition properly (PR sanitizer/85774).

2018-09-24 Thread Jakub Jelinek
On Mon, Sep 24, 2018 at 09:39:30AM +0200, Martin Liška wrote: > Hi. > > As always Jakub provided my very nice hint how to fix the issue. > It's about adding representative of a stack partitioning into > asan_handled_variables when another variable of the partition > lies in asan_handled_variables.

[PATCH] Unpoison variable partition properly (PR sanitizer/85774).

2018-09-24 Thread Martin Liška
Hi. As always Jakub provided my very nice hint how to fix the issue. It's about adding representative of a stack partitioning into asan_handled_variables when another variable of the partition lies in asan_handled_variables. Patch survives testing on ppc64le-linux-gnu. Ready for trunk? gcc/Chang

[PATCH 1/4] Add filter-rtags-warnings.py script.

2018-09-24 Thread marxin
contrib/ChangeLog: 2018-09-24 Martin Liska * filter-rtags-warnings.py: New file. --- contrib/filter-rtags-warnings.py | 71 1 file changed, 71 insertions(+) create mode 100755 contrib/filter-rtags-warnings.py diff --git a/contrib/filter-rtags-warnin

[PATCH 3/4] Fix small coding style issues (PR fortran/87394).

2018-09-24 Thread marxin
gcc/ChangeLog: 2018-09-24 Martin Liska PR fortran/87394 * dbgcnt.c (dbg_cnt_process_single_pair): Return false instead of NULL. * dumpfile.c (dump_enable_all): Remove extra parenthesis. * gcov-tool.c: Declare the function with ATTRIBUTE_NORETURN.

[PATCH 4/4] Fix scaling of a sreal number.

2018-09-24 Thread marxin
The patch is addressing following LLVM warning: gcc/ipa-fnsummary.c:2745:54:Value Conversion Issue: implicit conversion from 'double' to 'int64_t' (aka 'long') changes value from 0.99 to 0: -Wliteral-conversion Taking look at GIMPLE IR we end up with: : D.107433 ={v} {CLOBBER}; sreal::s

[PATCH 2/4] Remove unused functions and fields.

2018-09-24 Thread marxin
gcc/ChangeLog: 2018-09-24 Martin Liska * alias.c (set_dest_equal_p): Remove unused function. * config/i386/i386.c (def_builtin_pure2): Likewise. * diagnostic-show-locus.c (class layout): Remove unused field. (layout::layout): Likewise here. * du

[PATCH 0/4] Clean-up warnings spotted by Rtags

2018-09-24 Thread marxin
Hello. For quite some time I've been using Rtags for code completion and other related stuff. Recently I noticed they provide diagnostics for an entire project. Doing so, one can get quite some extra warning reported by Clang and I consider some of them useful. So that I would like to install m