> On Mon, Sep 24, 2018 at 9:50 AM, Jan Hubicka <hubi...@ucw.cz> wrote: > >> On Mon, Sep 24, 2018 at 9:19 AM, Jan Hubicka <hubi...@ucw.cz> wrote: > >> >> >> PING. > >> >> > > >> >> > Hi, Jan Uros, > >> >> > > >> >> > Can you review this patch? > >> >> > >> >> I don't know CET stuff, so I'm not able to review functionality of CET > >> >> patches. > >> > > >> > My (very partial) understanding is that ENDBR is used to mark places > >> > where one > >> > can jump/call. So we need to always arrange it first. Normally this is > >> > done > >> > simply by inserting it very first in the instruction stream, but in cases > >> > where profiling code is inserted this breaks because profiling code is > >> > output as string rather than real instructions because it needs the code > >> > label > >> > to be referred from mloc_count section. > >> > > >> > It is ugly, I wonder how much work would be tu turn profiler insertion > >> > to also > >> > use RTL representation? > >> > > >> > >> We will investigate it. > > Thanks, do we need to backport this fix into release braches? > > (I think current patch is more suitable for backporting) > > Yes, we need to backport it to GCC 8 branch.
OK, then I guess the patch is fine for mainline and for branch after a week (I am not sure how much of practical CET testing we have though). Please however investigate the cleanup for the profiler code. It is not first time it hit us and it would be nice to have less code output to function bodies that is not visible to RTL passes. Honza > > -- > H.J.
