Re: [PATCH, GCC] Fix PR67781: wrong code generation for partial load on big endian targets

2016-01-20 Thread Thomas Preud'homme
On Friday, January 08, 2016 10:05:25 AM Richard Biener wrote: > On Tue, 5 Jan 2016, Thomas Preud'homme wrote: > > Hi, > > > > bswap optimization pass generate wrong code on big endian targets when the > > result of a bit operation it analyzed is a partial load of the range of > > memory accessed b

Re: [PATCH 1/5] s390: Use proper read-only data section for literals.

2016-01-20 Thread Marcin Kościelnicki
On 20/01/16 14:11, Andreas Krebbel wrote: On 01/02/2016 08:16 PM, Marcin Kościelnicki wrote: Previously, .rodata was hardcoded. For C++ vague linkage functions, this resulted in needlessly duplicated literals. With the new split stack support, this resulted in link errors, due to .rodata conta

Re: [PATCH] Fix up reduction-1{1,2} testcases (PR middle-end/68221)

2016-01-20 Thread Thomas Schwinge
Hi! Ping. On Mon, 11 Jan 2016 11:40:58 +0100, I wrote: > Ping. > > On Wed, 23 Dec 2015 12:03:48 +0100, I wrote: > > Ping. > > > > On Thu, 26 Nov 2015 14:31:56 +0100, I wrote: > > > On Mon, 23 Nov 2015 12:13:07 +0100 (CET), Richard Biener > > > wrote: > > > > On Fri, 20 Nov 2015, Jakub Jelinek

Re: gomp_target_fini

2016-01-20 Thread Thomas Schwinge
Hi! Ping. On Mon, 11 Jan 2016 11:39:46 +0100, I wrote: > Ping. > > On Wed, 23 Dec 2015 12:05:32 +0100, I wrote: > > Ping. > > > > On Wed, 16 Dec 2015 13:30:21 +0100, I wrote: > > > On Mon, 14 Dec 2015 19:47:36 +0300, Ilya Verbin wrote: > > > > On Fri, Dec 11, 2015 at 18:27:13 +0100, Jakub Jeli

[PATCH] fix #69405 - [6 Regression] ICE in c_tree_printer on an invalid __atomic_fetch_add

2016-01-20 Thread Martin Sebor
The attached patch avoids printing a diagnostic referencing the type of an incompatible argument to the __atomic_xxx built-ins when the argument is in error. Doing otherwise causes an ICE as pointed out in the bug, for both of which I am to blame. Martin gcc/testsuite/ChangeLog: 2016-01-20 Mart

Re: [gomp4] fix c++ reference mappings in openacc

2016-01-20 Thread Cesar Philippidis
On 01/20/2016 07:46 PM, Cesar Philippidis wrote: > I've applied this patch to gomp-4_0-branch which fixes of problems > involving reference type variables in openacc data clauses. The first > problem was, the c++ front end was incorrectly handling reference types > in general in openacc. Instead of

[gomp4] fix c++ reference mappings in openacc

2016-01-20 Thread Cesar Philippidis
I've applied this patch to gomp-4_0-branch which fixes of problems involving reference type variables in openacc data clauses. The first problem was, the c++ front end was incorrectly handling reference types in general in openacc. Instead of mapping the variable, it would map the pointer to the va

Re: Fixes for PR66178

2016-01-20 Thread Jeff Law
On 01/20/2016 07:25 AM, Bernd Schmidt wrote: PR66178 has some testcases where we construct expressions involving additions and subtractions of label addresses, and we crash when trying to expand these. There are two different issues here, shown by various testcases in the PR: * expand_expr_rea

Re: [SMS] Schedule normalization after scheduling branch

2016-01-20 Thread Jeff Law
On 01/18/2016 02:38 PM, Roman Zhuykov wrote: Hello, 4 years ago when I create some SMS patches nobody cares about SMS failures on ia64. Now ia64 is even more dead but at least one of bugs appears on powerpc - PR69252. Proposed patch is here: https://gcc.gnu.org/ml/gcc-patches/2011-12/txt00266.t

Re: [PATCH] Revert an __int20ish get_ref_base_and_extent change (PR c++/69355)

2016-01-20 Thread Jeff Law
On 01/20/2016 05:03 PM, Jakub Jelinek wrote: Hi! Among the __int20 changes was one that made get_ref_base_and_extent behave differently from similar get_inner_reference, e.g. for XFmode long double or structures containing just a single long double member, get_ref_base_and_extent now returns on

Re: [PATCH] #52291 - clarify sync_fetch_and_OP for pointers

2016-01-20 Thread Jeff Law
On 01/20/2016 05:11 PM, Martin Sebor wrote: The bug points out that while the __sync_fetch_and_OP intrinsics are documented to have semantics equivalent to the "x OP= y" compound assignment expressions, when used with pointer operands they actually behave as if they operated on integers. I.e., t

Re: [PATCH v2] PR48344: Fix unrecognizable insn error when gcc

2016-01-20 Thread Jeff Law
On 01/20/2016 04:51 PM, Bernd Schmidt wrote: On 01/20/2016 10:49 PM, Kelvin Nilsen wrote: * toplev.c (do_compile): remove invocation of process_options () from within do_compile () (toplev::main): insert invocation of process_options () before invocation of handle_

TR29124 C++ Special Maths - Make pull functions into global namespace.

2016-01-20 Thread Ed Smith-Rowland
Now that libstdc++ installs a proper math.h we can piggyback on that to put in the last bit of TR29124. This patch adds the math special functions to c_compatibility/math.h in the global namespace. I remove the XFAILs from the compile_2.cc tests. This converts 21 XFAILs into 21 PASSes. Teste

Re: [doc, dwarf] Update bit-rotten DWARF option documentation

2016-01-20 Thread Sandra Loosemore
On 01/20/2016 06:52 AM, Jason Merrill wrote: On 01/19/2016 11:31 PM, Sandra Loosemore wrote: -@option{-gdwarf-2} does not accept a concatenated debug level, because -GCC used to support an option @option{-gdwarf} that meant to generate -debug information in version 1 of the DWARF format (which i

Re: [PATCH], PowerPC IEEE 128-bit fp, #11-rev4 (enable libgcc conversions)

2016-01-20 Thread Michael Meissner
This is revision 4 of the IEEE 128-bit floating point libgcc support. Since revision 3, I have removed the gcc changes that broke AIX. I rewrote the IBM extended double pack/unpack support to not use the builtin functions, but instead uses a union. The libgcc code that I wrote tickles a bug in t

[PATCH] #52291 - clarify sync_fetch_and_OP for pointers

2016-01-20 Thread Martin Sebor
The bug points out that while the __sync_fetch_and_OP intrinsics are documented to have semantics equivalent to the "x OP= y" compound assignment expressions, when used with pointer operands they actually behave as if they operated on integers. I.e., they are not scaled by the size of the pointed

[PATCH] Revert an __int20ish get_ref_base_and_extent change (PR c++/69355)

2016-01-20 Thread Jakub Jelinek
Hi! Among the __int20 changes was one that made get_ref_base_and_extent behave differently from similar get_inner_reference, e.g. for XFmode long double or structures containing just a single long double member, get_ref_base_and_extent now returns on x86 80 instead of 96 or 128 which the type span

[committed] Fix a warning in omp-low.c

2016-01-20 Thread Jakub Jelinek
Hi! richi reported a warning in omp-low.c with some configure options (forgot which), this patch ensures we don't warn. Bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk. 2016-01-21 Jakub Jelinek * omp-low.c (expand_omp_target): Avoid -Wmaybe-uninitialized

Re: [PATCH v2] PR48344: Fix unrecognizable insn error when gcc

2016-01-20 Thread Bernd Schmidt
On 01/20/2016 10:49 PM, Kelvin Nilsen wrote: * toplev.c (do_compile): remove invocation of process_options () from within do_compile () (toplev::main): insert invocation of process_options () before invocation of handle_common_deferred_options (). The ChangeLog se

Re: [SMS] Schedule normalization after scheduling branch

2016-01-20 Thread Jeff Law
On 01/20/2016 02:30 PM, Martin Sebor wrote: 2016-01-20 Martin Sebor PR target/69252 * gcc.target/powerpc/pr69252.c: New test. This is OK once the fix for the scheduler goes in. It could be improved by moving it into gcc.dg since I don't see anything in it that is PPC specifi

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-01-20 Thread Evandro Menezes
On 01/06/16 14:44, Evandro Menezes wrote: Hi, Wilco. On 01/06/2016 06:04 AM, Wilco Dijkstra wrote: Here's what I had in mind when I inquired about distinguishing FCMP from FCCMP. As you can see in the patch, Exynos is the only target that cares about it, but I wonder if ThunderX or Xgene woul

Re: [PATCH] c++/58109 - alignas() fails to compile with constant expression

2016-01-20 Thread Martin Sebor
Right. The problem is this code in is_late_template_attribute: /* If the first attribute argument is an identifier, only consider second and following arguments. Attributes like mode, format, cleanup and several target specific attributes aren't late just becau

[PATCH v2] PR48344: Fix unrecognizable insn error when gcc

2016-01-20 Thread Kelvin Nilsen
This patch has bootstrapped and tested on powerpc64le-unknown-linux-gnu with no regressions. Is this ok for the trunk? See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48344 for the original problem report. The error resulted because gcc's processing of command-line options within gcc init

Re: [SMS] Schedule normalization after scheduling branch

2016-01-20 Thread Martin Sebor
On 01/18/2016 02:38 PM, Roman Zhuykov wrote: Hello, 4 years ago when I create some SMS patches nobody cares about SMS failures on ia64. Now ia64 is even more dead but at least one of bugs appears on powerpc - PR69252. Proposed patch is here: https://gcc.gnu.org/ml/gcc-patches/2011-12/txt00266.t

[PATCH, rs6000] Add Power9 asm entries

2016-01-20 Thread Pat Haugen
The following adds a couple missed Power9 assembler option entries. Bootstrapped on ppc64. Ok for trunk? -Pat 2016-01-20 Pat Haugen * config/rs6000/aix71.h (ASM_CPU_SPEC): Add entry for Power9. * config/rs6000/driver-rs6000.c (struct asm_names): Likewise. Index: config/rs60

Re: [PATCH] ARM PR68620 (ICE with FP16 on armeb)

2016-01-20 Thread Christophe Lyon
On 19 January 2016 at 15:51, Alan Lawrence wrote: > On 19/01/16 11:15, Christophe Lyon wrote: > For neon_vdupn, I chose to implement neon_vdup_nv4hf and neon_vdup_nv8hf instead of updating the VX iterator because I thought it was not desirable to impact neon_vrev32. >>> >>> >>> Well

Re: [PATCH, rs6000] Add support for __builtin_cpu_is() and __builtin_cpu_supports()

2016-01-20 Thread Peter Bergner
On Wed, 2016-01-20 at 15:15 -0500, David Edelsohn wrote: > On Thu, Jan 14, 2016 at 10:50 PM, Peter Bergner wrote: > > gcc/ > > * config/rs6000/ppc-auxv.h: New file. > > * config/rs6000/rs6000-builtin.def (cpu_init): Add new builtin. > > (cpu_is): Likewise. > > (cpu_

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

2016-01-20 Thread Gerald Pfeifer
On Wed, 20 Jan 2016, Manuel López-Ibáñez wrote: >> And I can commit working my way backwards through all the other >> changes.html pages over the coming couple of days. > wwwdocs/htdocs$ find . -name '*.html' | xargs grep --color -e " style *=" > > shows a bit more inline CSS than changes.html, un

Re: [PATCH, AArch64] Fix for PR67896 (C++ FE cannot distinguish __Poly{8,16,64,128}_t types)

2016-01-20 Thread Roger Ferrer Ibáñez
Hi James, > This patch looks technically correct to me, though there is a small > style issue to correct (in-line below), and your ChangeLogs don't fit > our usual style. thank you very much for the useful comments. I'm attaching a new version of the patch with the style issues (hopefully) ironed

Re: [PATCH, rs6000] Add support for __builtin_cpu_is() and __builtin_cpu_supports()

2016-01-20 Thread David Edelsohn
On Thu, Jan 14, 2016 at 10:50 PM, Peter Bergner wrote: > This patch adds support for __builtin_cpu_init(), __builtin_cpu_is() and > __builtin_cpu_supports() builtins for PowerPC. We use the same API as the > x86* builtins of the same name. These builtins uses the new GLIBC 2.23 > feature where w

[PATCH] PR target/68609 vector swsqrt

2016-01-20 Thread David Edelsohn
This patch finishes PR target/68609 to use reciprocal estimate for vector sqrt. PR target/68609 * config/rs6000/rs6000.c (rs6000_emit_swsqrt): Add vector domain check. * config/rs6000/vector.md (sqrt2): Call rs6000_emit_swsqrt for V4SFmode. Thanks, David Index: rs6000.c =

Re: RFA: MIPS: Fix race condition causing PR 69129

2016-01-20 Thread Matthias Klose
On 19.01.2016 14:52, Nick Clifton wrote: Hi Catherine, Hi Eric, Hi Matthew, GCC PR 69129 reports a problem with the MIPS backend: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69129 I traced the problem down to a race condition in mips_compute_frame_info. This calls mips_global_pointe

[wwwdocs] Colorize gcc-4.9/changes.html again

2016-01-20 Thread Gerald Pfeifer
Use global CSS classes instead of local styles (which browsers now often block based on the server settings of gcc.gnu.org). Committed. Gerald Index: gcc-4.9/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.9/changes.html,v

[trans-mem] PR 68964 fallout -- bootstrap 69343+69339

2016-01-20 Thread Richard Henderson
These two bootstrap PRs, caused by old binutils on s390x and embedded powerpc that doesn't support altivec, could have been worked around with yet more configure checks. But after discussion on IRC, we decided that to revert the arm+ppc+s390 changes entirely and keep the libitm ABI the same. Inst

Re: [hsa merge 07/10] IPA-HSA pass

2016-01-20 Thread Ilya Verbin
On Fri, Jan 15, 2016 at 21:05:47 +0300, Ilya Verbin wrote: > On Fri, Jan 15, 2016 at 17:45:22 +0100, Jakub Jelinek wrote: > > On Fri, Jan 15, 2016 at 07:38:14PM +0300, Ilya Verbin wrote: > > > On Fri, Jan 15, 2016 at 17:09:54 +0100, Jakub Jelinek wrote: > > > > On Fri, Jan 15, 2016 at 05:02:34PM +0

[wwwdocs] Make colors work again on gcc-5/changes.html

2016-01-20 Thread Gerald Pfeifer
Per our discussion around gcc-6/changes.html, this uses the new global styles (and adds another one). Committed. Gerald Introduce a new CSS class boldlime. Use this, and similar ones throughout gcc-5/changes.html. Index: gcc.css =

[PATCH][cilkplus] fix c++ implicit conversions with cilk_spawn (PR/69024, PR/68997)

2016-01-20 Thread Ryan Burn
This patch follows on from https://gcc.gnu.org/ml/gcc-patches/2015-12/msg02142.html As discussed, it creates a separate function cilk_cp_detect_spawn_and_unwrap in gcc/cp to handle processing cilk_spawn expressions for c++ and adds support for implicit constructor and type conversions. Bootstrapp

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

2016-01-20 Thread Manuel López-Ibáñez
On 20 January 2016 at 17:38, Gerald Pfeifer wrote: > On Wed, 20 Jan 2016, Jakub Jelinek wrote: >>> Content-Security-Policy: default-src 'self' http: https: >>> >>> So either we get the configuration of the web server changed, or >>> indeed we need to touch all those existing pages. >> At least t

[gomp-nvptx 13/13] libgomp plugin: handle multiple teams

2016-01-20 Thread Alexander Monakov
This complements multiple teams support on the libgomp plugin side. * plugin/plugin-nvptx.c (struct targ_fn_descriptor): Add new fields. (struct ptx_device): Ditto. Set them... (nvptx_open_device): ...here. (GOMP_OFFLOAD_load_image): Set new targ_fn_descriptor fiel

[gomp-nvptx 12/13] libgomp: handle multiple teams on NVPTX

2016-01-20 Thread Alexander Monakov
* config/nvptx/icv-device.c (omp_get_num_teams): Update. (omp_get_team_num): Ditto. * config/nvptx/target.c (GOMP_teams): Update. * config/nvptx/team.c (nvptx_thrs): Place in shared memory. * icv.c (gomp_num_teams_var): Define. * libgomp.h (gomp_num_t

Re: [patch] libstdc++/14608 Add C++-conforming wrappers for stdlib.h and math.h

2016-01-20 Thread Jonathan Wakely
On 20/01/16 17:17 +0100, Dominik Vogt wrote: On Tue, Jan 19, 2016 at 09:43:59PM +, Jonathan Wakely wrote: On 08/01/16 19:18 +, Jonathan Wakely wrote: >This resolves the longstanding issue that #include uses the C >library header, which on most targets doesn't declare the additional >ove

[gomp-nvptx 11/13] pick GOMP_target_ext changes from the hsa branch

2016-01-20 Thread Alexander Monakov
This adds necessary plumbing to spawn multiple teams. To be reverted on this branch prior to merge. --- gcc/builtin-types.def| 7 +- gcc/fortran/types.def| 5 +- gcc/omp-builtins.def | 2 +- gcc/omp-low.c

[gomp-nvptx 08/13] libgomp: add nvptx lock.c

2016-01-20 Thread Alexander Monakov
This patch implements lock.c on NVPTX by moving a bunch of generic implementations (in terms of gomp_mutex_t) from config/linux/lock.c to lock.c and reusing them on NVPTX. * config/linux/lock.c (gomp_init_lock_30): Move to generic lock.c. (gomp_destroy_lock_30): Ditto. (gom

Re: [RFC] [nvptx] Try to cope with cuLaunchKernel returning CUDA_ERROR_LAUNCH_OUT_OF_RESOURCES

2016-01-20 Thread Alexander Monakov
On Tue, 19 Jan 2016, Alexander Monakov wrote: > > You mean you already have implemented something along the lines I > > proposed? > > Yes, I was implementing OpenMP teams, and it made sense to add warps per block > limiting at the same time (i.e. query CU_FUNC_ATTRIBUTE_... and limit if > default

Re: [wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit (v2)

2016-01-20 Thread Gerald Pfeifer
On Wed, 20 Jan 2016, Jakub Jelinek wrote: >> Content-Security-Policy: default-src 'self' http: https: >> >> So either we get the configuration of the web server changed, or >> indeed we need to touch all those existing pages. > At least the warning/error/note styles are something that multiple p

[gomp-nvptx 02/13] omp-low: extend SIMD lowering for SIMT execution

2016-01-20 Thread Alexander Monakov
This patch extends SIMD-via-SIMT lowering in omp-low.c to handle all loops, lowering reduction/lastprivate/ordered appropriately (but it still chickens out on collapsed loops, handling them as if safelen=1). New SIMT lowering snippets use new internal functions that are folded for non-SIMT targets

[gomp-nvptx 07/13] libgomp plugin: set __nvptx_clocktick

2016-01-20 Thread Alexander Monakov
This is the libgomp plugin side of omp_clock_wtime support on NVPTX. Query GPU frequency and copy the value into the device image. At the moment CUDA driver sets GPU to a fixed frequency when a CUDA context is created (the default is to use the highest non-boost frequency, but it can be altered w

[gomp-nvptx 06/13] libgomp: add nvptx time.c

2016-01-20 Thread Alexander Monakov
This patch implements time.c on NVPTX with the %clock64 register. The PTX documentation describes %globaltimer as explicitely off-limits for us. * config/nvptx/time.c: New. --- libgomp/ChangeLog.gomp-nvptx | 4 libgomp/config/nvptx/time.c | 49 +

[gomp-nvptx 09/13] libgomp: use generic fortran.c on nvptx

2016-01-20 Thread Alexander Monakov
This patch removes the nvptx fortran.c stub that provides only _gfortran_abort. It is possible to link libgfortran on NVPTX with -foffload=-lgfortran. * config/nvptx/fortran.c: Delete. --- libgomp/ChangeLog.gomp-nvptx | 4 libgomp/config/nvptx/fortran.c | 40 -

[gomp-nvptx 00/13] SIMD, teams, Fortran

2016-01-20 Thread Alexander Monakov
Hello, I'm pushing this patch series to the gomp-nvptx branch. It adds the following: - backend and omp-low.c changes for SIMT-style SIMD region handling - libgomp changes for running the fortran testsuite - libgomp changes for spawning multiple OpenMP teams I'll perform a trunk merge and

[gomp-nvptx 01/13] nvptx backend: new patterns for OpenMP SIMD-via-SIMT

2016-01-20 Thread Alexander Monakov
This patch adds a few insn patterns used for OpenMP SIMD reduction/lastprivate/ordered lowering for SIMT execution. OpenMP lowering produces GOMP_SIMT_... internal functions when lowering SIMD constructs that can be offloaded to a SIMT device. After lto stream-in, those internal functions are tri

[gomp-nvptx 05/13] libgomp: remove sections.c, splay-tree.c

2016-01-20 Thread Alexander Monakov
This patch removes two zero-size stubs, there's no need for these overrides. * config/nvptx/section.c: Delete. * config/nvptx/splay-tree.c: Delete. --- libgomp/ChangeLog.gomp-nvptx | 5 + libgomp/config/nvptx/sections.c | 0 libgomp/config/nvptx/splay-tree.c | 0 3 file

[gomp-nvptx 10/13] libgomp testsuite: add -foffload=-lgfortran

2016-01-20 Thread Alexander Monakov
Link libgfortran for offloaded code as well. * testsuite/libgomp.fortran/fortran.exp (lang_link_flags): Pass -foffload=-lgfortran in addition to -lgfortran. * testsuite/libgomp.oacc-fortran/fortran.exp (lang_link_flags): Ditto. --- libgomp/ChangeLog.gomp-nvptx

[gomp-nvptx 03/13] nvptx backend: silence warning

2016-01-20 Thread Alexander Monakov
* config/nvptx/nvptx.c (nvptx_declare_function_name): Fix warning. --- gcc/ChangeLog.gomp-nvptx | 4 gcc/config/nvptx/nvptx.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gcc/config/nvptx/nvptx.c b/gcc/config/nvptx/nvptx.c index 45aebdd..f63f840 100644 --- a/g

[gomp-nvptx 04/13] nvptx backend: add support for placing variables in shared memory

2016-01-20 Thread Alexander Monakov
This patch allows to use __attribute__((shared)) to place non-automatic variables in shared memory. * config/nvptx/nvptx.c (nvptx_encode_section_info): Handle "shared" attribute. (nvptx_handle_shared_attribute): New. Use it... (nvptx_attribute_table): ... here (new

Re: [PATCH] c++/59759 - ICE in unify, using std::enable_if on classes

2016-01-20 Thread Martin Sebor
On 01/20/2016 06:39 AM, Jason Merrill wrote: On 01/19/2016 01:09 PM, Martin Sebor wrote: Attached is the patch to avoid the ICE that Kai posted below with the test case Marek asked for in his response. I didn't see any further followup on the list. Thanks, but the code is actually well-formed

Re: [patch] libstdc++/14608 Add C++-conforming wrappers for stdlib.h and math.h

2016-01-20 Thread Dominik Vogt
On Tue, Jan 19, 2016 at 09:43:59PM +, Jonathan Wakely wrote: > On 08/01/16 19:18 +, Jonathan Wakely wrote: > >This resolves the longstanding issue that #include uses the C > >library header, which on most targets doesn't declare the additional > >overloads required by C++11 26.8 [c.math],

Re: [PATCH] Fix ICE with asm "m" (stmt-expr) operand (PR middle-end/67653)

2016-01-20 Thread Andreas Schwab
Richard Biener writes: > On Wed, 20 Jan 2016, Andreas Schwab wrote: > >> Jakub Jelinek writes: >> >> > +"memory input %d is not directly addressable", >> >> What does that mean? > > Is "input %d is not addressable" better? If that's the same what the standard calls "ad

Re: reject decl with incomplete struct/union type in check_global_declaration()

2016-01-20 Thread Marek Polacek
On Wed, Jan 20, 2016 at 06:52:48PM +0530, Prathamesh Kulkarni wrote: > Thanks for the review, I have done the suggested changes in this > version of the patch. > Ok for trunk ? Given that Joseph already approved substance of the patch, this is ok (but you might want to correct a typo below), thank

Re: [PATCH] [ARC] Add basic support for double load and store instructions

2016-01-20 Thread Joern Wolfgang Rennecke
On 19/01/16 17:46, Claudiu Zissulescu wrote: > Hi, > > I've prepared a new patch based on the received review (attached). I also added a mod on invoke.texi regarding mll64 documentation. This mod was missing in the first patch. > > I have tested it with dg.exp for arc700, archs and archs+ll64.

[Patch AArch64] GCC 6 regression in vector performance. - Fix vector initialization to happen with lane load instructions.

2016-01-20 Thread James Greenhalgh
Hi, In a number of cases where we try to create vectors we end up spilling to the stack and then filling. This is one example distilled from a couple of micro-benchmrks where the issue shows up. The reason for the extra cost in this case is the unnecessary use of the stack. The patch attempts to

[PATCH] Fix PR69378

2016-01-20 Thread Richard Biener
I am currently testing the following patch to fix PR69378 (another fallout of the PR69117 fix). Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2016-01-20 Richard Biener PR tree-optimization/69378 * tree-ssa-sccvn.c (dominated_by_p_w_unex): New function.

Re: [hsa merge 02/10] Modifications to libgomp proper

2016-01-20 Thread Jakub Jelinek
On Wed, Jan 20, 2016 at 05:47:59PM +0300, Ilya Verbin wrote: > OK for trunk? > > libgomp/ > * task.c (gomp_create_target_task): Set firstprivate_copies to NULL. > > diff --git a/libgomp/task.c b/libgomp/task.c > index 0f45c44..38d4e9b 100644 > --- a/libgomp/task.c > +++ b/libgomp/task.c > @

RE: [PATCH] MIPS: Prevent the p5600-bonding.c test from being run for the n32 and 64 ABIs

2016-01-20 Thread Andrew Bennett
Ping. Andrew > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On > Behalf Of Andrew Bennett > Sent: 02 September 2015 14:55 > To: Matthew Fortune; gcc-patches@gcc.gnu.org > Cc: Moore, Catherine (catherine_mo...@mentor.com) > Subject: RE: [P

Re: [hsa merge 02/10] Modifications to libgomp proper

2016-01-20 Thread Ilya Verbin
On Wed, Jan 13, 2016 at 18:39:27 +0100, Martin Jambor wrote: > * task.c (GOMP_PLUGIN_target_task_completion): Free > firstprivate_copies. Also this change caused 3 fails on intelmicemul: FAIL: libgomp.c/target-32.c execution test FAIL: libgomp.c/target-33.c execution test FAIL: libgom

Re: [PATCH] xfail one ppc testcase (PR tree-optimization/66612)

2016-01-20 Thread David Edelsohn
On Wed, Jan 20, 2016 at 9:28 AM, Jakub Jelinek wrote: > Hi! > > As per discussion in the PR, I'd like to xfail this test for GCC6 and > change it to 7.0 milestone, because it is too late/too risky to change > this for gcc 6 now. > > Bootstrapped/regtested on powerpc64{,le}-linux, ok for trunk? > >

Re: [PATCH] New version of libmpx with new memmove wrapper

2016-01-20 Thread Ilya Enkovich
2016-01-20 16:20 GMT+03:00 Matthias Klose : > On 11.12.2015 15:34, Ilya Enkovich wrote: >> >> I fixed it, bootstrapped, regtested and applied to trunk. Here is >> committed version. > > > this left libmpx/libtool-version, which now is unused and outdated. Ok to > remove? OK if bootstrap passes.

[PATCH] xfail one ppc testcase (PR tree-optimization/66612)

2016-01-20 Thread Jakub Jelinek
Hi! As per discussion in the PR, I'd like to xfail this test for GCC6 and change it to 7.0 milestone, because it is too late/too risky to change this for gcc 6 now. Bootstrapped/regtested on powerpc64{,le}-linux, ok for trunk? 2016-01-20 Jakub Jelinek PR tree-optimization/66612

Fixes for PR66178

2016-01-20 Thread Bernd Schmidt
PR66178 has some testcases where we construct expressions involving additions and subtractions of label addresses, and we crash when trying to expand these. There are two different issues here, shown by various testcases in the PR: * expand_expr_real_2 can drop EXPAND_INITIALIZER and then go

Re: [PATCH] Fix ICE with asm "m" (stmt-expr) operand (PR middle-end/67653)

2016-01-20 Thread Jakub Jelinek
On Wed, Jan 20, 2016 at 03:14:04PM +0100, Andreas Schwab wrote: > Jakub Jelinek writes: > > > + "memory input %d is not directly addressable", > > What does that mean? That is preexisting diagnostic wording, just for the cases that can be handled by preloading the var i

Re: [PATCH] Fix ICE with asm "m" (stmt-expr) operand (PR middle-end/67653)

2016-01-20 Thread Richard Biener
On Wed, 20 Jan 2016, Andreas Schwab wrote: > Jakub Jelinek writes: > > > + "memory input %d is not directly addressable", > > What does that mean? Is "input %d is not addressable" better? Otherwise the patch looks ok. Richard.

Re: Patch RFA: Add option -fcollectible-pointers, use it in ivopts

2016-01-20 Thread Richard Biener
On Wed, Jan 20, 2016 at 3:02 PM, Ian Lance Taylor wrote: > On Wed, Jan 20, 2016 at 3:13 AM, Richard Biener > wrote: >> On Wed, Jan 20, 2016 at 6:48 AM, Ian Lance Taylor wrote: >>> As discussed at https://gcc.gnu.org/ml/gcc/2016-01/msg00023.html , the >>> Go frontend needs some way to prevent ivo

Re: [PATCH] Fix ICE with asm "m" (stmt-expr) operand (PR middle-end/67653)

2016-01-20 Thread Andreas Schwab
Jakub Jelinek writes: > + "memory input %d is not directly addressable", What does that mean? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH] Fix ICE with asm "m" (stmt-expr) operand (PR middle-end/67653)

2016-01-20 Thread Jakub Jelinek
On Wed, Jan 20, 2016 at 02:59:14PM +0100, Marek Polacek wrote: > > + warning_at (EXPR_HAS_LOCATION (TREE_VALUE (link)) > > + ? EXPR_HAS_LOCATION (TREE_VALUE (link)) > > + : input_location, 0, > > This looks wrong, I think you meant EXPR_H

Re: Patch RFA: Add option -fcollectible-pointers, use it in ivopts

2016-01-20 Thread Ian Lance Taylor
On Wed, Jan 20, 2016 at 3:13 AM, Richard Biener wrote: > On Wed, Jan 20, 2016 at 6:48 AM, Ian Lance Taylor wrote: >> As discussed at https://gcc.gnu.org/ml/gcc/2016-01/msg00023.html , the >> Go frontend needs some way to prevent ivopts from temporarily removing >> all pointers into a memory block

Re: [PATCH 2/5] s390: Fix missing .size directives.

2016-01-20 Thread Dominik Vogt
On Wed, Jan 20, 2016 at 02:16:23PM +0100, Andreas Krebbel wrote: > On 01/02/2016 08:16 PM, Marcin Kościelnicki wrote: > > s390_asm_declare_function_size (FILE *asm_out_file, > > - const char *fnname ATTRIBUTE_UNUSED, tree decl) > > + const char *

Re: [PATCH] Fix ICE with asm "m" (stmt-expr) operand (PR middle-end/67653)

2016-01-20 Thread Marek Polacek
On Wed, Jan 20, 2016 at 02:51:52PM +0100, Jakub Jelinek wrote: > On Wed, Jan 20, 2016 at 10:41:47AM +0100, Richard Biener wrote: > > > We already do diagnose tons of other cases for inline asm at > > > gimplification time. I can replace the error with a warning followed by > > > copying it to addr

Re: [doc, dwarf] Update bit-rotten DWARF option documentation

2016-01-20 Thread Jason Merrill
On 01/19/2016 11:31 PM, Sandra Loosemore wrote: -@option{-gdwarf-2} does not accept a concatenated debug level, because -GCC used to support an option @option{-gdwarf} that meant to generate -debug information in version 1 of the DWARF format (which is very -different from version 2), and it woul

Re: [PATCH] Fix ICE with asm "m" (stmt-expr) operand (PR middle-end/67653)

2016-01-20 Thread Jakub Jelinek
On Wed, Jan 20, 2016 at 10:41:47AM +0100, Richard Biener wrote: > > We already do diagnose tons of other cases for inline asm at > > gimplification time. I can replace the error with a warning followed by > > copying it to addressable memory, that seems to be what the older gccs were > > doing dur

Re: [PATCH] c++/59759 - ICE in unify, using std::enable_if on classes

2016-01-20 Thread Jason Merrill
On 01/19/2016 01:09 PM, Martin Sebor wrote: Attached is the patch to avoid the ICE that Kai posted below with the test case Marek asked for in his response. I didn't see any further followup on the list. Thanks, but the code is actually well-formed; I've now fixed the bug properly. Jason

Re: [hsa merge 02/10] Modifications to libgomp proper

2016-01-20 Thread Ilya Verbin
On Wed, Jan 13, 2016 at 18:39:27 +0100, Martin Jambor wrote: > diff --git a/liboffloadmic/plugin/libgomp-plugin-intelmic.cpp > b/liboffloadmic/plugin/libgomp-plugin-intelmic.cpp > index 68f7b2c..58ef595 100644 > --- a/liboffloadmic/plugin/libgomp-plugin-intelmic.cpp > +++ b/liboffloadmic/plugin/li

Re: reject decl with incomplete struct/union type in check_global_declaration()

2016-01-20 Thread Prathamesh Kulkarni
On 19 January 2016 at 16:49, Marek Polacek wrote: > Sorry for speaking up late, but I think we could do better with formatting > in this patch: > > On Sat, Jan 16, 2016 at 03:45:22PM +0530, Prathamesh Kulkarni wrote: >> diff --git a/gcc/c/c-decl.c b/gcc/c/c-decl.c >> index 915376d..d36fc67 100644

Re: [PATCH] New version of libmpx with new memmove wrapper

2016-01-20 Thread Matthias Klose
On 11.12.2015 15:34, Ilya Enkovich wrote: I fixed it, bootstrapped, regtested and applied to trunk. Here is committed version. this left libmpx/libtool-version, which now is unused and outdated. Ok to remove? Matthias

Re: [PATCH] OpenACC use_device clause ICE fix

2016-01-20 Thread Bernd Schmidt
On 01/05/2016 02:15 PM, Chung-Lin Tang wrote: * omp-low.c (scan_sharing_clauses): Call add_local_decl() for use_device/use_device_ptr variables. It looks vaguely plausible, but if everything is part of the host function, why make a copy of the decl at all? I.e. what happens if

Re: [PATCH 2/5] s390: Fix missing .size directives.

2016-01-20 Thread Andreas Krebbel
On 01/02/2016 08:16 PM, Marcin Kościelnicki wrote: > It seems at some point the .size hook was hijacked to emit some > machine-specific directives, and the actual .size directive was > forgotten. This caused problems for split-stack support, since > linker couldn't scan the function body for non-s

Re: [PATCH 1/5] s390: Use proper read-only data section for literals.

2016-01-20 Thread Andreas Krebbel
On 01/02/2016 08:16 PM, Marcin Kościelnicki wrote: > Previously, .rodata was hardcoded. For C++ vague linkage functions, > this resulted in needlessly duplicated literals. With the new split > stack support, this resulted in link errors, due to .rodata containing > relocations to the discarded te

Re: [PATCH][GCC][ARM] testcase memset-inline-10.c uses -mfloat-abi=hard but does not check whether target supports it

2016-01-20 Thread Christophe Lyon
On 19 January 2016 at 12:51, Ramana Radhakrishnan wrote: > On Thu, Nov 12, 2015 at 3:16 PM, Andre Vieira > wrote: >> On 12/11/15 15:08, Andre Vieira wrote: >>> >>> Hi, >>> >>>This patch changes the memset-inline-10.c testcase to make sure that >>> it is only compiled for ARM targets that supp

[patch] libstdc++/69386 Ensure C++ language linkage in cmath and cstdlib

2016-01-20 Thread Jonathan Wakely
On 19/01/16 21:43 +, Jonathan Wakely wrote: On 08/01/16 19:18 +, Jonathan Wakely wrote: This resolves the longstanding issue that #include uses the C library header, which on most targets doesn't declare the additional overloads required by C++11 26.8 [c.math], and similarly for . With

Re: [PATCH, PR tree-optimization/69328] Fix vectorization of boolean vector comparision in COND_EXPR

2016-01-20 Thread Richard Biener
On Tue, Jan 19, 2016 at 11:46 AM, Ilya Enkovich wrote: > Hi, > > Currently vectorizer incorrectly handles a case when COND_EXPR > has boolean vector comparison. Firstly masked COND_EXPR is > determined incorrectly. Also we don't check vector types of > compared values are compatible. This patch

Re: [PATCH PR68542]

2016-01-20 Thread Richard Biener
On Mon, Jan 18, 2016 at 3:50 PM, Yuri Rumyantsev wrote: > Richard, > > Here is the second part of patch which really preforms mask stores and > all statements related to it to new basic block guarded by test on > zero mask. Hew test is also added. > > Is it OK for trunk? + /* Pick up all masked

[gomp4, committed] Remove reduction clauses in kernels region earlier

2016-01-20 Thread Tom de Vries
Hi, I've committed this patch to gomp-4_0-branch, moving the removal of the reduction clauses in the kernels region earlier, before localize_reductions. Thanks, - Tom Remove reduction clauses in kernels region earlier 2016-01-20 Tom de Vries * gimplify.c (gimplify_omp_for): Remove reduct

[wwwdocs] Add GCC 6 porting_to template

2016-01-20 Thread Marek Polacek
I suspect we'll be adding some real material there soon. Applied. Index: porting_to.html === RCS file: porting_to.html diff -N porting_to.html --- /dev/null 1 Jan 1970 00:00:00 - +++ porting_to.html 20 Jan 2016 11:53:29 -00

Re: [wwwdocs] Update changes.html for LTO and IPA

2016-01-20 Thread Jan Hubicka
> >+ is not performed. GCC 7 will support incremental IL linking. > > "IL" again what does this mean to users? Thanks for corrections, I will apply them and post updated patch. Here I wanted to explain that gcc -r should now give a correct code (while with earlier GCC releases it will

Re: [patch] Restore cross-language inlining into Ada

2016-01-20 Thread Richard Biener
On Wed, Jan 20, 2016 at 9:32 AM, Eric Botcazou wrote: > Hi, > > this patch from Jan: > https://gcc.gnu.org/ml/gcc-patches/2015-03/msg01388.html > totally disabled cross-language inlining into Ada without notice, by adding a > check that always fails when the language of the callee is not Ada...

Re: [C/C++ PATCH] Don't emit invalid VEC_COND_EXPR for vector comparisons (PR c/68062)

2016-01-20 Thread Marek Polacek
On Wed, Jan 13, 2016 at 11:11:52PM +, Joseph Myers wrote: > The C front-end changes are OK. Jason, is the C++ part of this patch here (which is identical to the change in the C FE) ok? Also, not sure about backporting this, maybe just

Re: [PATCH] Fix c/68513 for GCC5 (match.pd and SAVE_EXPRs)

2016-01-20 Thread Marek Polacek
On Wed, Jan 20, 2016 at 12:01:50PM +0100, Richard Biener wrote: > On Tue, Jan 19, 2016 at 8:48 PM, Marek Polacek wrote: > > Recently on IRC we've concluded that for GCC 5 the simplest solution > > will be to just disable the problematic pattern on GENERIC. So done > > in the following. (The prob

Re: Patch RFA: Add option -fcollectible-pointers, use it in ivopts

2016-01-20 Thread Richard Biener
On Wed, Jan 20, 2016 at 6:48 AM, Ian Lance Taylor wrote: > As discussed at https://gcc.gnu.org/ml/gcc/2016-01/msg00023.html , the > Go frontend needs some way to prevent ivopts from temporarily removing > all pointers into a memory block. This patch adds a new option > -fcollectible-pointers whic

Re: [PATCH] Fix c/68513 for GCC5 (match.pd and SAVE_EXPRs)

2016-01-20 Thread Richard Biener
On Tue, Jan 19, 2016 at 8:48 PM, Marek Polacek wrote: > Recently on IRC we've concluded that for GCC 5 the simplest solution > will be to just disable the problematic pattern on GENERIC. So done > in the following. (The problem was that the match.pd pattern created > SAVE_EXPRs which then leaked

Re: [committed] Add oacc_kernels_p argument to pass_parallelize_loops

2016-01-20 Thread Tom de Vries
On 20/01/16 09:54, Thomas Schwinge wrote: Hi! On Mon, 18 Jan 2016 14:07:11 +0100, Tom de Vries wrote: Add oacc_kernels_p argument to pass_parallelize_loops --- a/gcc/tree-parloops.c +++ b/gcc/tree-parloops.c @@ -2315,6 +2367,9 @@ gen_parallel_loop (struct loop *loop, | /* Ensure that

Re: [PATCH] Require non-x32 target for compile-time MPX tests

2016-01-20 Thread Ilya Enkovich
2016-01-20 8:29 GMT+03:00 H.J. Lu : > Compile-time MPX tests don't need the MPX run-time library. They > should pass for non-x32 target. > > OK for trunk and backport to GCC 5 branch? This patch is OK. Thanks, Ilya > > H.J. > --- > Compile-time MPX tests don't need the MPX run-time library. Th

  1   2   >