On Wed, Jan 20, 2016 at 02:16:23PM +0100, Andreas Krebbel wrote:
> On 01/02/2016 08:16 PM, Marcin Kościelnicki wrote:
> > s390_asm_declare_function_size (FILE *asm_out_file,
> > - const char *fnname ATTRIBUTE_UNUSED, tree decl)
> > + const char *fnname, tree decl)
> > {
> > + if (!flag_inhibit_size_directive)
> > + ASM_OUTPUT_MEASURED_SIZE (asm_out_file, fnname);
> > if (DECL_FUNCTION_SPECIFIC_TARGET (decl) == NULL)
> > return;
> > fprintf (asm_out_file, "\t.machine pop\n");
>
> It would be good to use the original ASM_DECLARE_FUNCTION_SIZE macro from
> config/elfos.h here. This
> probably would require to change its name in s390.h first and then use it from
> s390_asm_declare_function_size. Not really beautiful but at least changes to
> the original macro
> would not require adjusting our backend.
Maybe it's better not to invent yet another solution to deal with
this and just do it like proposed in the patch. So if the default
implementation is ever changed, the same search pattern will find
all identical copies of the code.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
IBM Germany
