ipa-cp heuristics fixes

2015-12-09 Thread Jan Hubicka
Martin, while looking into the ipa-cp dumps for bzip and Firefox I noticed few issues. First of all, ipcp_cloning_candidate_p calls optimize_function_for_speed_p (DECL_STRUCT_FUNCTION (node->decl)) which can not be used at WPA time, becuase we have no DECL_STRUCT_FUNCTION around. I replaced it by

check initializer to be zero in .bss-like sections

2015-12-09 Thread Jan Beulich
Just like gas, which has recently learned to reject such initializers, gcc shouldn't accept such either. --- The only question really is whether the new test case should be limited to certain targets - I haven't been able to figure out possible valid qualifiers to use here. gcc/ 2015-12-10 Jan Be

Re: [PATCHES, PING*2] Enhance standard DWARF for Ada

2015-12-09 Thread Pierre-Marie de Rodat
Ping for the patches submitted in and for the 2/8 update submitted in . Thank you in advance! -- Pierre-Marie de Rodat

Re: [committed] Tighten runtime initialization check in __canonicalize_funcptr_for_compare on hppa-linux

2015-12-09 Thread John David Anglin
On 2015-12-01, at 7:15 PM, John David Anglin wrote: > The attached change fixes a startup issue of emacs24 on Debian hppa-linux. > The emacs24 build does some tricky > stuff to preinitialize values, so that standard static initialization check > is skipped. However, the global offset table has

[committed] Fix PR target/68729

2015-12-09 Thread John David Anglin
The attached fixes an ICE building gridengine. The problem is we are asked to do an HImode reload for a floating pointing register. However, we can only do 32 and 64-bit loads and stores to/from floating point registers. The problem is resolved by not checking that the mode requested is consis

Re: [0/7] Type promotion pass and elimination of zext/sext

2015-12-09 Thread Kugan
Hi Riachard, Thanks for the reviews. I think since we have some unresolved issues here, it is best to aim for the next stage1. I however would like any feedback so that I can continue to improve this. https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01063.html is also related to https://gcc.gnu.org

Re: [PATCH] Better error messages for merge-conflict markers (v3)

2015-12-09 Thread Martin Sebor
@@ -471,6 +471,20 @@ c_parser_peek_2nd_token (c_parser *parser) return &parser->tokens[1]; } +/* Return a pointer to the Nth token from PARSER, reading it + in if necessary. The N-1th token is already read in. */ + +static c_token * +c_parser_peek_nth_token (c_parser *parser, unsigned i

Re: [RFA] Transparent alias suport part 10: Fix base+offset alias analysis oracle WRT aliases

2015-12-09 Thread Jan Hubicka
> > > + bool in_symtab1 = decl_in_symtab_p (base1); > > > + bool in_symtab2 = decl_in_symtab_p (base2); > > > + > > > + /* Declarations of non-automatic variables may have aliases. All other > > > + decls are unique. */ > > > + if (in_symtab1 != in_symtab2 || !in_symtab1) > > > +retur

[RFA] [PATCH] [PR tree-optimization/68619] Avoid direct cfg cleanups in tree-ssa-dom.c [4/3] v2

2015-12-09 Thread Jeff Law
Finally the mechanical changes necessary due to the API change in the walker. Jeff commit 02cea5bd751566459ba5da5c4ca3a567f72c9c16 Author: Jeff Law Date: Wed Dec 9 15:52:17 2015 -0700 * compare-elim.c (find_comparison_dom_walker::before_dom_children): Change return type to an

[RFA] [PATCH] [PR tree-optimization/68619] Avoid direct cfg cleanups in tree-ssa-dom.c [3/3] v2

2015-12-09 Thread Jeff Law
Testcases for the DOM changes. commit abf324bb826e59302aa8baa22763206536725974 Author: Jeff Law Date: Mon Dec 7 22:43:53 2015 -0700 PR tree-optimization/68619 * gcc.dg/tree-ssa/pr68619-1.c: New test. * gcc.dg/tree-ssa/pr68619-2.c: New test. * gcc.dg/tree-ssa/pr

[RFA] [PATCH] [PR tree-optimization/68619] Avoid direct cfg cleanups in tree-ssa-dom.c [2/3] v2

2015-12-09 Thread Jeff Law
Changes for DOM to use the new capability in the dom walker. Jeff commit 88806f8996419d50d00f33f5d9924a1638316e3b Author: Jeff Law Date: Mon Dec 7 22:43:06 2015 -0700 PR tree-optimization/68619 * tree-ssa-dom.c (dom_opt_dom_walker::before_dom_children): Propgate return

[RFA] [PATCH] [PR tree-optimization/68619] Avoid direct cfg cleanups in tree-ssa-dom.c [1/3] v2

2015-12-09 Thread Jeff Law
This is the refactoring part of the patch -- essentially bits move from tree-ssa-sccvn into domwalk so that other domwalk clients can benefit from the ability to detect unreachable blocks and propagate unreachable edge properties. This also fixes up tree-ssa-sccvn to use the new bits from domw

[RFA] [PATCH] [PR tree-optimization/68619] Avoid direct cfg cleanups in tree-ssa-dom.c [0/3] v2

2015-12-09 Thread Jeff Law
Richi and I have been discussing revamping slightly how DOM handles conditionals which it detects are always true or always false. During gcc6 stage1 I added code to allow DOM to clean them up immediately, primarily to avoid the waste of having the threader handle those cases. It was also believ

[PATCH] update -Wall and -Wextra documentation

2015-12-09 Thread Martin Sebor
A number of warning options are missing from the list shown under -Wall (for example, -Winit-self, -Wlogical-not-parentheses, and -Wplacement-new). The patch adds the missing ones and adjusts some of the existing ones to maintain an alphabetical order. It also makes a couple of minor clarificati

Fix lto.c ICE

2015-12-09 Thread Jan Hubicka
Hi, this patch fixes ICE in lto.c caused by the (ab)use of TREE_CHAIN by lto_symtab_prevail_decl. We check twice that TREE_CHAIN does not point to a decl - once before merging and once after. It is sufficient to do it once. I also noticed that LTO_NO_PREVAIL use gcc_assert and replaced it by gcc

[PATCH] Fix up noce_try_abs again (PR rtl-optimization/68670)

2015-12-09 Thread Jakub Jelinek
Hi! Not sure what I've been thinking when writing the previous noce_try_abs fix. I thought that the optimization can be applied for all the conditions, and whether it can be applied depends on if it is cond ? ~x : x or cond ? x : ~x. But that is not the case, the optimization can be only applied

[PATCH] Fix up fold_ctor_reference and fully_constant_vn_reference_p (PR tree-optimization/68785)

2015-12-09 Thread Jakub Jelinek
Hi! On a testcase like below which would trigger UB at runtime we trigger UB in the compiler, by reading uninitialized bytes. The VCE folding for which native_{encode,interpret}_expr has been originally written passes the length from the first one to the second one, so that the latter can return

Re: [Fortran, Patch] Memory sync after coarray image control statements and assignment

2015-12-09 Thread Tobias Burnus
Alessandro Fanfarillo wrote: Done. Thanks. Committed as r231476. Do we need to do anything about GCC 5 or is this only a GCC 6 issue? I have permission for contributing but I don't have write permission on the repository. That can be changed: Simply fill out the form and list me (burnus (at

Re: [PATCH] rtlanal: Fix bits/bytes confusion in set_noop_p (PR68814)

2015-12-09 Thread Segher Boessenkool
On Wed, Dec 09, 2015 at 10:13:34PM +0100, Eric Botcazou wrote: > > The meaning of ZERO_EXTRACT depends on BITS_BIG_ENDIAN, not on > > BYTES_BIG_ENDIAN. > > That's correct. > > --- a/gcc/rtlanal.c > > +++ b/gcc/rtlanal.c > > @@ -1534,7 +1534,7 @@ set_noop_p (const_rtx set) > > > >if (GET_CODE

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

2015-12-09 Thread Markus Trippelsdorf
On 2015.12.09 at 10:53 -0800, H.J. Lu wrote: > > Empty C++ class is a corner case which isn't covered in psABI nor C++ ABI. > There is no mention of "empty record" in GCC documentation. But there are > plenty of "empty class" in gcc/cp. This change affects all targets. C++ ABI > should specify

Re: [PATCH] rtlanal: Fix bits/bytes confusion in set_noop_p (PR68814)

2015-12-09 Thread Eric Botcazou
> The meaning of ZERO_EXTRACT depends on BITS_BIG_ENDIAN, not on > BYTES_BIG_ENDIAN. That's correct. > Testing in progress on powerpc64le-linux; if it passes, is this > okay for trunk? > > > Segher > > > 2015-12-09 Segher Boessenkool > > PR rtl-optimization/68814 > * rtlanal.c

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

2015-12-09 Thread H.J. Lu
On Wed, Dec 9, 2015 at 10:53 AM, H.J. Lu wrote: > On Wed, Dec 9, 2015 at 6:05 AM, Richard Biener > wrote: >> On Tue, Dec 8, 2015 at 5:22 PM, H.J. Lu wrote: >>> On Mon, Nov 23, 2015 at 12:53 PM, H.J. Lu wrote: On Mon, Nov 23, 2015 at 1:57 AM, Richard Biener wrote: > On Sat, Nov 21

[PATCH v4] Fix shrink-wrapping bug (PR67778, PR68634)

2015-12-09 Thread Segher Boessenkool
After shrink-wrapping has found the "tightest fit" for where to place the prologue, it tries move it earlier (so that frame saves are run earlier) -- but without copying any more basic blocks. Unfortunately a candidate block we select can be inside a loop, and we will still allow it (because the l

[PATCH] rtlanal: Fix bits/bytes confusion in set_noop_p (PR68814)

2015-12-09 Thread Segher Boessenkool
The meaning of ZERO_EXTRACT depends on BITS_BIG_ENDIAN, not on BYTES_BIG_ENDIAN. This caused PR68814. Testing in progress on powerpc64le-linux; if it passes, is this okay for trunk? Segher 2015-12-09 Segher Boessenkool PR rtl-optimization/68814 * rtlanal.c (set_noop_p): Us

Re: [PATCH] Better error recovery for merge-conflict markers (v4)

2015-12-09 Thread Jeff Law
On 12/09/2015 10:44 AM, Bernd Schmidt wrote: Just thinking out loud - I guess it would be too much to hope for to share lexers between frontends so that we need only one copy of this? Probably :( Someone slap sense into me, I just thought of deriving C and C++ parsers from a common base class

Transparent alias suport part 11 (vtable rewritting fix)

2015-12-09 Thread Jan Hubicka
Hi, this patch fixes a thinko in vtable rewritting where instead of checking references we was checking list of nodes referring to vtable. The loop looks for the entries in vtable that can be replaced by local aliases, so this bug probably disabled most of the transformations. It reproduced as an

Re: Transparent alias suport part 9 (ipa-reference fixes)

2015-12-09 Thread Jan Hubicka
Hi, unfortunately I managed to mess up while handling this patch and accidentally commit earlier version of it yesterday (without Changelog). This introduced one testsuite regression in leaf attribute testing. I commited the following which should fix the fallout. My apologize for that. The pat

Fix thinko in lto-symtab prevailing decl merging

2015-12-09 Thread Jan Hubicka
Hi, this patch fixes a thinko I introduced into lto_symtab_merge_decls_2 yesterday: a decl can not be prevailed by itself. Bootstrapped/regtested x86_64-linux, comitted. PR lto/68811 * g++.dg/lto/pr68811_0.C: New testcase. * g++.dg/lto/pr68811_1.C: New testcase. *

Re: [patch] remove WCHAR_TYPE definition for FreeBSD PowerPC64

2015-12-09 Thread Andreas Tobler
On 06.12.15 23:54, Andreas Tobler wrote: Hi, I'm going to commit this patch to trunk, 5.4 and 4.9 branch if there are no objections. The redefinition of WCHAR_TYPE for PowerPC64 is wrong since its beginning. My fault. We use the definition from freebsd.h. Committed to trunk. But I left the

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

2015-12-09 Thread H.J. Lu
On Wed, Dec 9, 2015 at 6:05 AM, Richard Biener wrote: > On Tue, Dec 8, 2015 at 5:22 PM, H.J. Lu wrote: >> On Mon, Nov 23, 2015 at 12:53 PM, H.J. Lu wrote: >>> On Mon, Nov 23, 2015 at 1:57 AM, Richard Biener >>> wrote: On Sat, Nov 21, 2015 at 12:46 AM, H.J. Lu wrote: > On Fri, Nov 20,

[gomp-nvptx] git branch created

2015-12-09 Thread Alexander Monakov
Hello, I have created a git-only branch "gomp-nvptx" for development of OpenMP offloading on NVPTX. Changelogs on the branch have the corresponding suffix, and I'll use it to tag emails with patches for the branch. The branch currently has 41 patch on top of yesterday's trunk. Some of those hav

Re: [AArch64] Emit square root using the Newton series

2015-12-09 Thread Evandro Menezes
On 12/09/2015 11:16 AM, Kyrill Tkachov wrote: On 09/12/15 17:02, Kyrill Tkachov wrote: On 09/12/15 16:59, Evandro Menezes wrote: On 12/09/2015 10:52 AM, Kyrill Tkachov wrote: Hi Evandro, On 08/12/15 21:35, Evandro Menezes wrote: Emit square root using the Newton series 2015-12-03 Evan

Re: [PATCH][ARC] Refurbish emitting DWARF2 for epilogue.

2015-12-09 Thread Joern Wolfgang Rennecke
On 09/12/15 15:34, Claudiu Zissulescu wrote: Well, it seems to me that we prefer to disable optimizations when talking about debug related information (see PR target/60598 git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@208749 138bc75d-0d04-0410-961f-82ee72b054a4 commit). Actually, unwind in

Re: PATCH to shorten_compare -Wtype-limits handling

2015-12-09 Thread Manuel López-Ibáñez
On 20 November 2015 at 22:28, Jeff Law wrote: >>> That was the overall plan and he posted a patch for that. But that patch >>> didn't do the due diligence to verify that once the shortening code was >>> made >>> "pure" that we didn't regress on the quality of the code we generated. >> >> >> I tho

[Patch] Fix for MIPS PR target/65604

2015-12-09 Thread Steve Ellcey
This is a MIPS patch to make mips_output_division obey the -fno-delayed-branch flag. Right now, with mips1 and -mcheck-zero-division, the division instruction is put into the bne delay slot even when -fno-delayed-branch is specified. This change uses a similar strategy to MIPS16 where we do the d

[PATCH 1/3] [graphite] dump param name when timing out

2015-12-09 Thread Sebastian Pop
--- gcc/graphite-optimize-isl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/graphite-optimize-isl.c b/gcc/graphite-optimize-isl.c index 8727e39..f90fcfd 100644 --- a/gcc/graphite-optimize-isl.c +++ b/gcc/graphite-optimize-isl.c @@ -426,7 +426,7 @@ optimize_isl (scop_p s

[PATCH 2/3] [graphite] add array access function in the right order

2015-12-09 Thread Sebastian Pop
we used to add the access functions in the wrong order, Fortran style, leading to unprofitable interchanges. --- gcc/graphite-sese-to-poly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/graphite-sese-to-poly.c b/gcc/graphite-sese-to-poly.c index 887c212..480c552 100644

[PATCH 3/3] [graphite] specify more isl codegen options

2015-12-09 Thread Sebastian Pop
--- gcc/graphite-optimize-isl.c | 8 1 file changed, 8 insertions(+) diff --git a/gcc/graphite-optimize-isl.c b/gcc/graphite-optimize-isl.c index f90fcfd..50f2b3c 100644 --- a/gcc/graphite-optimize-isl.c +++ b/gcc/graphite-optimize-isl.c @@ -50,6 +50,7 @@ along with GCC; see the file COP

Re: [PATCH] enable loop fusion on isl-15

2015-12-09 Thread Richard Biener
On December 9, 2015 6:45:42 PM GMT+01:00, Sebastian Pop wrote: >Richard Biener wrote: >> On Fri, Dec 4, 2015 at 8:59 PM, Sebastian Paul Pop > wrote: >> > I would highly recommend updating the required version of ISL to >isl-0.15: >> > that would simplify the existing code, removing a lot of code

Re: [Patch, Fortran] PR68815 - replace '%s' quotes by %< ... %>

2015-12-09 Thread Steve Kargl
On Wed, Dec 09, 2015 at 04:53:37PM +0100, Tobias Burnus wrote: > > Build and regtested on x86-64-gnu-linux. > OK for the trunk? > OK. -- Steve

Re: [PATCH] enable loop fusion on isl-15

2015-12-09 Thread Sebastian Pop
Richard Biener wrote: > On Fri, Dec 4, 2015 at 8:59 PM, Sebastian Paul Pop wrote: > > I would highly recommend updating the required version of ISL to isl-0.15: > > that would simplify the existing code, removing a lot of code under "#ifdef > > old ISL", > > and allow us to fully transition to sch

Re: [PATCH] Better error recovery for merge-conflict markers (v4)

2015-12-09 Thread Bernd Schmidt
On 12/09/2015 05:58 PM, David Malcolm wrote: On Wed, 2015-11-04 at 14:56 +0100, Bernd Schmidt wrote: This seems like fairly low impact but also low cost, so I'm fine with it in principle. I wonder whether the length of the marker is the same across all versions of patch (and VC tools)? It's h

[gomp4, committed] backport: "Fix oacc kernels default mapping for scalars"

2015-12-09 Thread Tom de Vries
Hi, I've backported the patch "Fix oacc kernels default mapping for scalars" from trunk to gomp-4_0-branch. Committed to gomp-4_0-branch. Thanks, - Tom backport: "Fix oacc kernels default mapping for scalars" 2015-12-02 Tom de Vries backport from trunk: * gimplify.c (enum gimplify_omp_

Re: [PATCH] Add levels to -Wmisleading-indentation; add level 1 to -Wall

2015-12-09 Thread Bernd Schmidt
On 12/09/2015 05:49 PM, David Malcolm wrote: +void +fn_40_implicit_level_1 (int arg) +{ +if (flagA) + foo (0); + + foo (1); + The distinction I want to make here is between badly indented code vs misleadingly indented code. Yes, the code is badly indented, but to my eyes the code is suffici

Re: [PATCH, ARM] PR68674 Fix LTO support for neon builtins and error catching

2015-12-09 Thread Kyrill Tkachov
Hi Christian, On 08/12/15 12:53, Christian Bruel wrote: Hi, The order of the NEON builtins construction has led to complications since the attribute target support. This was not a problem when driven from the command line, but was causing various issues when the builtins was mixed between fpu

[gomp4, committed] Handle ptr iterator in acc loop

2015-12-09 Thread Tom de Vries
Hi, this patch ensures that the &b[0][0][0] initializer of the acc loop in the testcase is properly compiled. Committed to gomp-4_0-branch. Thanks, - Tom Handle ptr iterator in acc loop 2015-12-09 Tom de Vries * omp-low.c (expand_omp_for_generic): Gimplify seq_loop loop start and limit

Re: Splitting up gcc/omp-low.c?

2015-12-09 Thread Bernd Schmidt
On 12/09/2015 05:24 PM, Thomas Schwinge wrote: In addition to that, how about we split up gcc/omp-low.c into several files? Would it make sense (I have not yet looked in detail) to do so along the borders of the several passes defined therein? Or, can you tell already that there would be too m

Re: [PATCH] Add levels to -Wmisleading-indentation; add level 1 to -Wall

2015-12-09 Thread Pedro Alves
On 12/09/2015 04:49 PM, David Malcolm wrote: > This is about managing the signal:noise ratio for something in -Wall. > > The distinction I want to make here is between badly indented code vs > misleadingly indented code. Yes, the code is badly indented, but to my > eyes the code is sufficiently

Re: [AArch64] Emit square root using the Newton series

2015-12-09 Thread Kyrill Tkachov
On 09/12/15 17:02, Kyrill Tkachov wrote: On 09/12/15 16:59, Evandro Menezes wrote: On 12/09/2015 10:52 AM, Kyrill Tkachov wrote: Hi Evandro, On 08/12/15 21:35, Evandro Menezes wrote: Emit square root using the Newton series 2015-12-03 Evandro Menezes gcc/ * config/aarc

[PATCH v2] Do not sanitize left shifts for -fwrapv (PR68418)

2015-12-09 Thread Paolo Bonzini
Left shifts into the sign bit is a kind of overflow, and the standard chooses to treat left shifts of negative values the same way. However, the -fwrapv option modifies the language to one where integers are defined as two's complement---which also defines entirely the behavior of shifts. Disable

Re: [AArch64] Emit square root using the Newton series

2015-12-09 Thread Kyrill Tkachov
On 09/12/15 16:59, Evandro Menezes wrote: On 12/09/2015 10:52 AM, Kyrill Tkachov wrote: Hi Evandro, On 08/12/15 21:35, Evandro Menezes wrote: Emit square root using the Newton series 2015-12-03 Evandro Menezes gcc/ * config/aarch64/aarch64-protos.h (aarch64_emit_swsqrt)

Re: [AArch64] Emit square root using the Newton series

2015-12-09 Thread Evandro Menezes
On 12/09/2015 10:52 AM, Kyrill Tkachov wrote: Hi Evandro, On 08/12/15 21:35, Evandro Menezes wrote: Emit square root using the Newton series 2015-12-03 Evandro Menezes gcc/ * config/aarch64/aarch64-protos.h (aarch64_emit_swsqrt): Declare new function.

Re: -fstrict-aliasing fixes 5/6: make type system independent of flag_strict_aliasing

2015-12-09 Thread Jan Hubicka
> On Wed, 9 Dec 2015, Arnaud Charlet wrote: > > > > Hi > > > this patch implements the trik for punting if we get too many nested > > > pointers. > > > This fixes the ada tstcases. Curiously enough I would like to replace > > > safe_push > > > by quick_push but doing so I get weird error about fre

Re: [RFA] Transparent alias suport part 10: Fix base+offset alias analysis oracle WRT aliases

2015-12-09 Thread Jan Hubicka
> > + bool in_symtab1 = decl_in_symtab_p (base1); > > + bool in_symtab2 = decl_in_symtab_p (base2); > > + > > + /* Declarations of non-automatic variables may have aliases. All other > > + decls are unique. */ > > + if (in_symtab1 != in_symtab2 || !in_symtab1) > > +return 0; > > + re

Re: [AArch64] Emit square root using the Newton series

2015-12-09 Thread Kyrill Tkachov
Hi Evandro, On 08/12/15 21:35, Evandro Menezes wrote: Emit square root using the Newton series 2015-12-03 Evandro Menezes gcc/ * config/aarch64/aarch64-protos.h (aarch64_emit_swsqrt): Declare new function. * config/aarch64/aarch64-simd.md (sqrt2)

Re: [PATCH] Add levels to -Wmisleading-indentation; add level 1 to -Wall

2015-12-09 Thread David Malcolm
On Wed, 2015-12-09 at 16:40 +0100, Bernd Schmidt wrote: > On 12/09/2015 04:38 PM, David Malcolm wrote: > > +/* The following function contains examples of bad indentation that's > > + arguably not misleading, due to a blank line between the guarded and the > > + non-guarded code. Some of the b

[PATCH] Better error recovery for merge-conflict markers (v4)

2015-12-09 Thread David Malcolm
On Wed, 2015-11-04 at 14:56 +0100, Bernd Schmidt wrote: > On 10/30/2015 04:16 PM, David Malcolm wrote: > > The idea is to more gracefully handle merger conflict markers > > in the source code being compiled. Specifically, in the C and > > C++ frontends, if we're about to emit an error, see if the

Re: [gomp4] Fix Fortran deviceptr

2015-12-09 Thread James Norris
Cesar, On 12/08/2015 11:10 AM, Cesar Philippidis wrote: On 12/08/2015 08:22 AM, James Norris wrote: 2. It appears that deviceptr code in GOACC_parallel_keyed is mostly identical to GOACC_data_start. Can you put that duplicate code into a function? That would be easier to maintai

RE: [AArch64] Emit square root using the Newton series

2015-12-09 Thread Evandro Menezes
Hi, Marcus. I've run Geekbench, SPEC CPU2000 and synthetic benchmarks. I can share these results iterating an array with values between 1 and 100 and taking their square root: Million Operations/sJuno A53 @850MHz A57 @1100MHz X^½ DP

Re: [PATCH] Make basic asm implicitly clobber memory, pr24414

2015-12-09 Thread Bernd Edlinger
Hi, On 09.12.2015 16:48 Bernd Schmidt wrote: > On 12/09/2015 04:09 PM, Bernd Edlinger wrote: > >> So would you agree on the general direction of the patch, >> if I drop the hunk in sched-deps.c ? > > I'm not sure there was any consensus in that other thread, but I think > assuming that basic asms

Splitting up gcc/omp-low.c? (was: [hsa 5/10] OpenMP lowering/expansion changes (gridification))

2015-12-09 Thread Thomas Schwinge
Hi! I've been meaning to suggest this for some time already: On Wed, 9 Dec 2015 14:19:30 +0100, Jakub Jelinek wrote: > As for omp-low.c changes, the file is already large enough that it would be > nice if it is easy to find out what routines are for gridification purposes > only, use some specia

Re: [PATCH, testsuite] Fix sse4_1-round* inline asm statements

2015-12-09 Thread Uros Bizjak
On Wed, Dec 9, 2015 at 8:18 AM, Uros Bizjak wrote: > Saying that, I see we don't need to define ASM_SUFFIX anymore. I'll > prepare the patch that removes these #defines. 2015-12-09 Uros Bizjak * gcc.target/i386/sse4_1-roundps-1.c: Remove ASM_SUFFIX define. * gcc.target/i386/sse4_1-ro

Re: [Fortran, Patch] Memory sync after coarray image control statements and assignment

2015-12-09 Thread Alessandro Fanfarillo
Done. I have permission for contributing but I don't have write permission on the repository. 2015-12-09 8:23 GMT+01:00 Tobias Burnus : > Alessandro Fanfarillo wrote: >> >> in attachment the new patch. I also checked the behavior with >> move_alloc: it synchronizes right after the deregistration

[Patch, Fortran] PR68815 - replace '%s' quotes by %< ... %>

2015-12-09 Thread Tobias Burnus
This patch replaces some of the '%s' quotes of diagnostic strings by the nicer quotes. First, it replaces some leftovers of '%s' -> %qs in directly used error strings. It then also converts some (well: resolve.c only) '%s' to %%<%s%%>, which are using with sprintf(), but which are still passed

Re: [PATCH] Make basic asm implicitly clobber memory, pr24414

2015-12-09 Thread Bernd Schmidt
On 12/09/2015 04:09 PM, Bernd Edlinger wrote: So would you agree on the general direction of the patch, if I drop the hunk in sched-deps.c ? I'm not sure there was any consensus in that other thread, but I think assuming that basic asms clobber memory and CC, can be justified. That certainly

[committed] Avoid undefined behavior in test.

2015-12-09 Thread Alexander Monakov
I have committed the following testsuite patch as obvious. The test calls a variadic function that extracts pointers with va_arg, but the terminating NULL is passed as an int, not a pointer. This wouldn't trip on 32-bit architectures, and even on 64-bit the test simply iterates until it gets a NU

Re: [PATCH] Add testcase for c++/68348

2015-12-09 Thread Marek Polacek
On Wed, Dec 09, 2015 at 03:39:50PM +, Kyrill Tkachov wrote: > On 09/12/15 15:38, Marek Polacek wrote: > >This adds a testcase for the already fixed PR68348. > > > >Tested on x86_64-linux, ok for trunk? > > > >2015-12-09 Marek Polacek > > > > PR c++/68348 > > * g++.dg/cpp0x/pr68348.C:

Re: [PATCH] Add testcase for c++/68348

2015-12-09 Thread Kyrill Tkachov
On 09/12/15 15:38, Marek Polacek wrote: This adds a testcase for the already fixed PR68348. Tested on x86_64-linux, ok for trunk? 2015-12-09 Marek Polacek PR c++/68348 * g++.dg/cpp0x/pr68348.C: New test. diff --git gcc/testsuite/g++.dg/cpp0x/pr68348.C gcc/testsuite/g++.dg/

Re: [PATCH] Add levels to -Wmisleading-indentation; add level 1 to -Wall

2015-12-09 Thread Bernd Schmidt
On 12/09/2015 04:38 PM, David Malcolm wrote: +/* The following function contains examples of bad indentation that's + arguably not misleading, due to a blank line between the guarded and the + non-guarded code. Some of the blank lines deliberately contain + redundant whitespace, to verify

[PATCH] Add testcase for c++/68348

2015-12-09 Thread Marek Polacek
This adds a testcase for the already fixed PR68348. Tested on x86_64-linux, ok for trunk? 2015-12-09 Marek Polacek PR c++/68348 * g++.dg/cpp0x/pr68348.C: New test. diff --git gcc/testsuite/g++.dg/cpp0x/pr68348.C gcc/testsuite/g++.dg/cpp0x/pr68348.C index e69de29..9033bba 100

RE: [PATCH][ARC] Refurbish emitting DWARF2 for epilogue.

2015-12-09 Thread Claudiu Zissulescu
> The main point of having rtl epilogues is to allow such optimizations. > Traditionally, we have said that at -O1, it is OK to curb optimizations for > the > sake of having programs that are saner to debug, while -O2 and above should > just optimize, and the debug info generation is just thrown i

[PATCH] Add levels to -Wmisleading-indentation; add level 1 to -Wall

2015-12-09 Thread David Malcolm
On Mon, 2015-11-02 at 16:41 -0700, Jeff Law wrote: > On 11/02/2015 12:35 PM, David Malcolm wrote: > > > > >> diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c > >> index fff4862..2559a36 100644 > >> --- a/gdb/ada-lang.c > >> +++ b/gdb/ada-lang.c > >> @@ -11359,9 +11359,11 @@ ada_evaluate_subexp (struct

Re: [PATCH] Make basic asm implicitly clobber memory, pr24414

2015-12-09 Thread Bernd Edlinger
Hi, On 09.12.2015 12:06 Bernd Schmidt wrote: > On 12/09/2015 03:18 AM, Bernd Edlinger wrote: >> Furthermore there is a documented use for asm(""): The empty >> assembler string is used to make a function >> volatile, thus calls can not be optimized away. But I think it is >> not necessary to ma

Re: [PATCH 5/7][Testsuite] Support ARMv8.1 ARM tests.

2015-12-09 Thread Christophe Lyon
On 7 December 2015 at 17:10, Matthew Wahab wrote: > On 27/11/15 17:11, Matthew Wahab wrote: >> >> On 27/11/15 13:44, Christophe Lyon wrote: On 26/11/15 16:02, Matthew Wahab wrote: >> >> > This patch adds ARMv8.1 support to GCC Dejagnu, to allow ARM > tests to specify targest and

RE: [Patch,rtl Optimization]: Better register pressure estimate for Loop Invariant Code Motion.

2015-12-09 Thread Ajit Kumar Agarwal
-Original Message- From: Bernd Schmidt [mailto:bschm...@redhat.com] Sent: Wednesday, December 09, 2015 7:34 PM To: Ajit Kumar Agarwal; Richard Biener Cc: Jeff Law; GCC Patches; Vinod Kathail; Shail Aditya Gupta; Vidhumouli Hunsigida; Nagaraju Mekala Subject: Re: [Patch,rtl Optimization]

Re: [Fortran, Patch] Memory sync after coarray image control statements and assignment

2015-12-09 Thread Matthew Wahab
On 08/12/15 09:25, Tobias Burnus wrote: On Mon, Dec 07, 2015 at 02:09:22PM +, Matthew Wahab wrote: I wonder whether using __asm__ __volatile__ ("":::"memory"); would be sufficient as it has a way lower overhead than __sync_synchronize(). I don't know anything about Fortran or coarrays and

Re: [PATCH] Fix phiopt ICE in Factor conversion in COND_EXPR (PR tree-optimization/66949)

2015-12-09 Thread Richard Biener
On Wed, Dec 9, 2015 at 3:22 PM, Marek Polacek wrote: > On Wed, Dec 09, 2015 at 11:41:44AM +0100, Richard Biener wrote: >> But I don't see why we have the asserts at all - they seem to be originated >> from >> development. IMHO factor_out_conditonal_conversion should simply return >> the new PHI

Re: [Patch,rtl Optimization]: Better register pressure estimate for Loop Invariant Code Motion.

2015-12-09 Thread David Malcolm
On Wed, 2015-12-09 at 11:35 +0100, Richard Biener wrote: > On Tue, Dec 8, 2015 at 11:24 PM, Ajit Kumar Agarwal > wrote: > > Based on the comments on RFC patch this patch incorporates all the comments > > from Jeff. Thanks Jeff for the valuable feedback. > > > > This patch enables the better regis

RE: [PATCH] [ARC] Add support for atomic memory built-in.

2015-12-09 Thread Claudiu Zissulescu
I will add this text before "*memory_barrier" pattern: ;; For ARCHS, we use a hardware data memory barrier that waits for ;; completion of current data memory operations before initiating ;; similar data memory operations. Once done, I will commit it. Thanks, Claudiu > > Tested with dg.exp (wh

Re: [C++ Patch] PR 60218

2015-12-09 Thread Jason Merrill
OK

Re: [PATCH] Fix phiopt ICE in Factor conversion in COND_EXPR (PR tree-optimization/66949)

2015-12-09 Thread Marek Polacek
On Wed, Dec 09, 2015 at 11:41:44AM +0100, Richard Biener wrote: > But I don't see why we have the asserts at all - they seem to be originated > from > development. IMHO factor_out_conditonal_conversion should simply return > the new PHI it generates instead of relying on > signle_non_signelton_ph

[PATCH, c++] Add testcase from PR68348 to the testsuite

2015-12-09 Thread Uros Bizjak
This patch adds the test for the fixed PR. 2015-12-09 Uros Bizjak PR c++/68348 PR c++/68464 * g++.dg/pr68348.C: New test. Tested on x86_64-linux-gnu. OK for mainline? Uros. Index: g++.dg/pr68348.C === --- g++.dg/pr6

Re: [Patch,rtl Optimization]: Better register pressure estimate for Loop Invariant Code Motion.

2015-12-09 Thread Bernd Schmidt
On 12/09/2015 12:22 PM, Ajit Kumar Agarwal wrote: This is because the available_regs = 6 and the regs_needed = 1 and new_regs = 0 and the regs_used = 10. As the reg_used that are based on the Liveness given above is greater than the available_regs, then > it's candidate of spill and the estima

Re: [AArch64] Emit square root using the Newton series

2015-12-09 Thread Marcus Shawcroft
On 8 December 2015 at 21:35, Evandro Menezes wrote: >Emit square root using the Newton series > >2015-12-03 Evandro Menezes > >gcc/ > * config/aarch64/aarch64-protos.h (aarch64_emit_swsqrt): >Declare new > function. > * config/aarch64/aarch64-

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

2015-12-09 Thread Richard Biener
On Tue, Dec 8, 2015 at 5:22 PM, H.J. Lu wrote: > On Mon, Nov 23, 2015 at 12:53 PM, H.J. Lu wrote: >> On Mon, Nov 23, 2015 at 1:57 AM, Richard Biener >> wrote: >>> On Sat, Nov 21, 2015 at 12:46 AM, H.J. Lu wrote: On Fri, Nov 20, 2015 at 2:17 PM, Jason Merrill wrote: > On 11/20/2015 01:

[PATCH] Do not compute dependences in if-conversion

2015-12-09 Thread Richard Biener
This removes the dubious dependence computation in if-conversion just for the sake of testing if that might fail (given the vectorizer itself doesn't fail that easily). It's a quadratic operation after all which we should avoid at all cost. Bootstrap and regtest running on x86_64-unknown-linux-g

Re: [hsa 6/10] Pass manager changes

2015-12-09 Thread Richard Biener
On Wed, Dec 9, 2015 at 2:20 PM, Jakub Jelinek wrote: > On Mon, Dec 07, 2015 at 12:24:05PM +0100, Martin Jambor wrote: >> the pass manager changes required for HSA have already been committed >> to trunk so all that remains are these additions to the pass pipeline. >> >> Thanks, >> >> Martin >> >>

[PATCH] Fix PR68806

2015-12-09 Thread Richard Biener
This fixes vectorization re-start without SLP when SLP analysis removed an SLP instance - I was relying on the reduction chains still being in the SLP instances. The following properly detects this case and also handles SLP reductions properly (they can be vectorized non-SLP as well). Bootstrap

Re: [PATCH] Do not sanitize left shifts for -fwrapv (PR68418)

2015-12-09 Thread Paolo Bonzini
On 04/12/2015 23:48, Jeff Law wrote: >> >> Why would pointer types be shifted at all (at the ubsan level, >> which is basically the AST)? > BTW, if you argument is that we can never get into this code with a > shift of a pointer object, I'd like to see some kind of analysis to back > up that asse

Re: [hsa 6/10] Pass manager changes

2015-12-09 Thread Jakub Jelinek
On Mon, Dec 07, 2015 at 12:24:05PM +0100, Martin Jambor wrote: > the pass manager changes required for HSA have already been committed > to trunk so all that remains are these additions to the pass pipeline. > > Thanks, > > Martin > > > 2015-12-04 Martin Jambor > Martin Liska >

Re: [hsa 5/10] OpenMP lowering/expansion changes (gridification)

2015-12-09 Thread Jakub Jelinek
On Mon, Dec 07, 2015 at 12:22:43PM +0100, Martin Jambor wrote: > it creates a copy of the entire target body and expands it slightly > differently for concurrent execution on a GPU. Note that both teams > and distribute constructs are mandatory. Moreover, currently the > distribute has to be in a

Re: [PATCH] Fix memory leaks in tree-vect-data-refs.c

2015-12-09 Thread Richard Biener
On Wed, Dec 9, 2015 at 12:14 PM, Martin Liška wrote: > Hi. > > This is simple follow-up of the previous patch that fixes last remaining > leak in vectorizer. > > Patch can regbootstrap on x64_64-linux-gnu. > > Ready for trunk? Ok. Richard. > Martin

Re: [Patch AArch64] Reinstate CANNOT_CHANGE_MODE_CLASS to fix pr67609

2015-12-09 Thread Marcus Shawcroft
On 27 November 2015 at 13:01, James Greenhalgh wrote: > 2015-11-27 James Greenhalgh > > * config/aarch64/aarch64-protos.h > (aarch64_cannot_change_mode_class): Bring back. > * config/aarch64/aarch64.c > (aarch64_cannot_change_mode_class): Likewise. > * c

Re: [PATCH] GCC-5 backport of PR lto/65948

2015-12-09 Thread Bernd Schmidt
On 12/09/2015 12:50 PM, Martin Liška wrote: I would like to backport forgotten patch to GCC-5 branch. Bootstrap and regression tests have been running, ready after it finishes? Ok. Bernd

Re: [PATCH] Fix PR68583

2015-12-09 Thread Richard Biener
On Wed, 9 Dec 2015, Richard Biener wrote: > > Well, not really in the end - the actual testcase would need code > hoisting to make the refs equal enough for ifcvt. Making the testcase > simpler doesn't seem to capture the issue so for now without one > (I'll keep trying). > > Bootstrapped and t

[PATCH] Fix PR68583 some more

2015-12-09 Thread Richard Biener
This time with a simplified testcase - the remaining issue with the original one is if-conversion looking at DR_REF and nothing hoisting the address compute of a[i+1] in both arms making it see they are the same (yeah, SCEV to the rescue, but not in this patch). This patch re-organizes things so

Re: [hsa 4/10] Merge of HSA branch

2015-12-09 Thread Jakub Jelinek
On Mon, Dec 07, 2015 at 12:21:22PM +0100, Martin Jambor wrote: > Subject: Make copy_gimple_seq_and_replace_locals copy seqs in omp clauses > > Hi, > > this is https://gcc.gnu.org/ml/gcc-patches/2015-12/msg00477.html with > the early return requested by Jakub. Please refer to that previous > emai

Re: [hsa 3/10] HSA libgomp plugin

2015-12-09 Thread Jakub Jelinek
On Mon, Dec 07, 2015 at 12:20:49PM +0100, Martin Jambor wrote: > +#include > +#include > +#include > +#include > +#include "libgomp-plugin.h" > +#include "gomp-constants.h" > +#include "hsa.h" > +#include "hsa_ext_finalize.h" If these 2 headers are coming from outside of gcc, better use <> for

Re: [hsa 2/10] Modifications to libgomp proper

2015-12-09 Thread Jakub Jelinek
On Mon, Dec 07, 2015 at 12:19:57PM +0100, Martin Jambor wrote: > +/* Flag set when the subsequent element in the device-specific argument > + values. */ > +#define GOMP_TARGET_ARG_SUBSEQUENT_PARAM (1 << 7) > + > +/* Bitmask to apply to a target argument to find out the value identifier. >

[PATCH] GCC-5 backport of PR lto/65948

2015-12-09 Thread Martin Liška
Hi. I would like to backport forgotten patch to GCC-5 branch. Bootstrap and regression tests have been running, ready after it finishes? Thanks, Martin >From 626df2a92db87f7c0668c7f2902f314ed6a9bc4c Mon Sep 17 00:00:00 2001 From: marxin Date: Wed, 9 Dec 2015 12:49:22 +0100 Subject: [PATCH] Backp

  1   2   >