On 12/09/2015 04:38 PM, David Malcolm wrote:
+/* The following function contains examples of bad indentation that's
+ arguably not misleading, due to a blank line between the guarded and the
+ non-guarded code. Some of the blank lines deliberately contain
+ redundant whitespace, to verify that this is handled.
+ Based on examples seen in gcc/fortran/io.c, gcc/function.c, and
+ gcc/regrename.c.
+
+ At -Wmisleading-indentation (implying level 1) we shouldn't emit
+ warnings for this function. Compare with
+ fn_40_level_1 in Wmisleading-indentation-level-1.c and
+ fn_40_level_2 in Wmisleading-indentation-level-2.c. */
+
+void
+fn_40_implicit_level_1 (int arg)
+{
+if (flagA)
+ foo (0);
+
+ foo (1);
+
I personally see no use for the blank line heuristic, in fact I think it
is misguided. To my eyes a warning is clearly warranted for the examples
in this testcase. Do we actually have any users calling for this heuristic?
Bernd