Re: [PATCH][PR67666] Handle single restrict pointer in struct in create_variable_info_for_1

2015-09-28 Thread Tom de Vries
On 22/09/15 09:49, Richard Biener wrote: On Tue, 22 Sep 2015, Tom de Vries wrote: Hi, Consider this test-case: struct ps { int *__restrict__ p; }; void f (struct ps &__restrict__ ps1) { *(ps1.p) = 1; } Atm, the restrict on p has no effect. Now, say we add a field to the struct: stru

Re: [Patch, testsuite] Skip addr_equal-1 if target keeps null pointer checks

2015-09-28 Thread Senthil Kumar Selvaraj
On Mon, Sep 28, 2015 at 01:38:18PM -0600, Jeff Law wrote: > On 09/28/2015 02:15 AM, Senthil Kumar Selvaraj wrote: > >Hi, > > > > The below patch skips gcc.dg/addr_equal-1.c if the target keeps null > > pointer checks. > > > > The test fails for such targets (avr, in my case) because the addre

RE: [Patch,optimization]: Optimized changes in the estimate register pressure cost.

2015-09-28 Thread Ajit Kumar Agarwal
-Original Message- From: Aaron Sawdey [mailto:acsaw...@linux.vnet.ibm.com] Sent: Monday, September 28, 2015 11:55 PM To: Ajit Kumar Agarwal Cc: GCC Patches; Vinod Kathail; Shail Aditya Gupta; Vidhumouli Hunsigida; Nagaraju Mekala Subject: Re: [Patch,optimization]: Optimized changes in t

[patch, committed] Dump function attributes

2015-09-28 Thread Tom de Vries
[ was: Re: [RFC] Dump function attributes ] On 28/09/15 17:17, Bernd Schmidt wrote: On 09/28/2015 04:32 PM, Tom de Vries wrote: patch below prints the function attributes in the dump file. foo () [ noclone , noinline ] { ... Good idea? If so, do we want one attribute per line? Only for r

[patch committed SH] Fix PR target/67716

2015-09-28 Thread Kaz Kojima
I've committed the attached patch to fix PR target/67716. It implements targetm.override_options_after_change for SH. Tested on sh4-unknown-linux-gnu. Regards, kaz -- 2015-09-29 Kaz Kojima PR target/67716 * config/sh/sh.c (sh_override_options_after_change): New.

Re: [Patch,optimization]: Optimized changes in the estimate register pressure cost.

2015-09-28 Thread Bin.Cheng
On Tue, Sep 29, 2015 at 2:25 AM, Aaron Sawdey wrote: > On Sat, 2015-09-26 at 04:51 +, Ajit Kumar Agarwal wrote: >> I have made the following changes in the estimate_reg_pressure_cost function >> used >> by the loop invariant and IVOPTS. >> >> Earlier the estimate_reg_pressure cost uses the co

Re: [PATCH][AArch64] Add separate insn sched class for vector LDP & STP

2015-09-28 Thread Andrew Pinski
On Mon, Sep 28, 2015 at 4:52 PM, Evandro Menezes wrote: > In some micro-architectures the insns to load or store pairs of vector > registers are implemented rather differently from those affecting lanes in > vector registers. Then, it's important that such insns be described > likewise differentl

Re: [PATCH] fix PR67700

2015-09-28 Thread H.J. Lu
On Mon, Sep 28, 2015 at 3:48 PM, Sebastian Paul Pop wrote: > I fixed this in a follow-up patch. > Now I got https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67754 FAIL: gcc.dg/graphite/interchange-10.c execution test FAIL: gcc.dg/graphite/interchange-11.c execution test FAIL: gcc.dg/graphite/interc

[PATCH][AArch64] Add separate insn sched class for vector LDP & STP

2015-09-28 Thread Evandro Menezes
In some micro-architectures the insns to load or store pairs of vector registers are implemented rather differently from those affecting lanes in vector registers. Then, it's important that such insns be described likewise differently in the scheduling model. This patch adds the insn types ne

Re: [PATCH] Fix gcc.dg/asm-4.c

2015-09-28 Thread Mike Stump
On Sep 28, 2015, at 2:43 PM, Segher Boessenkool wrote: > Double-quoted words in Tcl have substitutions performed on them, including > backslash substitutions. That isn't terribly nice for regular expressions, > so use braced words instead. > > Tested on powerpc64-linux. Okay for mainline? Ok.

RE: [PATCH] fix PR67700

2015-09-28 Thread Sebastian Paul Pop
I fixed this in a follow-up patch. Sebastian -Original Message- From: H.J. Lu [mailto:hjl.to...@gmail.com] Sent: Monday, September 28, 2015 2:39 PM To: Tobias Grosser Cc: Sebastian Pop; GCC Patches; Sebastian Pop; aditya...@samsung.com; Richard Biener Subject: Re: [PATCH] fix PR67700 O

RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI

2015-09-28 Thread Moore, Catherine
> -Original Message- > From: Steve Ellcey [mailto:sell...@imgtec.com] > Sent: Friday, September 11, 2015 2:06 PM > To: Matthew Fortune > Cc: GCC Patches; Moore, Catherine > Subject: RE: [PATCH, MIPS] Frame header optimization for MIPS O32 ABI > > On Fri, 2015-09-04 at 01:40 -0700, Matthe

Update soft-fp from glibc

2015-09-28 Thread Joseph Myers
This patch updates the soft-fp code in libgcc from glibc. There are no changes here of significance to the use of soft-fp in GCC (and so no testsuite additions); it's simply an update to bring in the latest soft-fp version (which will also hopefully go into Linux 4.4 to replace the 15-year-old cop

[PATCH] Fix gcc.dg/asm-4.c

2015-09-28 Thread Segher Boessenkool
Double-quoted words in Tcl have substitutions performed on them, including backslash substitutions. That isn't terribly nice for regular expressions, so use braced words instead. Tested on powerpc64-linux. Okay for mainline? Segher 2015-09-28 Segher Boessenkool gcc/testsuite/ * g

Re: [Patch, fortran] PR40054 and PR63921 - Implement pointer function assignment - redux

2015-09-28 Thread Paul Richard Thomas
Committed as revision 228222. Thanks for all the help. I'll update the fortran documentation tomorrow. Cheers Paul On 28 September 2015 at 20:22, Paul Richard Thomas wrote: > Dear Mikael, > > snip... > >>> * io.c (next_char_not_space): Change tab warning to warning now >>> to pre

Re: [PATCH] Convert SPARC to LRA

2015-09-28 Thread Segher Boessenkool
On Mon, Sep 28, 2015 at 03:23:37PM -0400, Vladimir Makarov wrote: > There are more ports using reload than LRA now. Even some major ports > (e.g. ppc64) did not switch to LRA. There still are some failures in the testsuite (ICEs even) so we're not there yet. > I usually say target maintainers,

Re: [PATCH] hurd: align -p and -pg behavior on Linux

2015-09-28 Thread Samuel Thibault
Ping? Samuel Thibault, le Sat 19 Sep 2015 14:00:23 +0200, a écrit : > On Linux, -p and -pg do not make gcc link against libc_p.a, only > -profile does (as documented in r11246), and thus people expect -p > and -pg to work without libc_p.a installed (it is actually even not > available any more in

Re: [PATCH] fix PR67700

2015-09-28 Thread H.J. Lu
On Sat, Sep 26, 2015 at 3:34 AM, Tobias Grosser wrote: > On 09/25/2015 10:39 PM, Sebastian Pop wrote: >> >> The patch makes the detection of scop parameters in >> parameter_index_in_region a >> bit more conservative by discarding scalar variables defined in function >> of data >> references define

Re: Openacc launch API

2015-09-28 Thread Nathan Sidwell
On 09/24/15 04:40, Jakub Jelinek wrote: Iff GCC 5 compiled offloaded OpenACC/PTX code will always do host fallback anyway because of the incompatible PTX version, then why don't you just do goacc_save_and_set_bind (acc_device_host); fn (hostaddrs); goacc_restore_bind (); Committed the

Re: [Patch, testsuite] Skip addr_equal-1 if target keeps null pointer checks

2015-09-28 Thread Jeff Law
On 09/28/2015 02:15 AM, Senthil Kumar Selvaraj wrote: Hi, The below patch skips gcc.dg/addr_equal-1.c if the target keeps null pointer checks. The test fails for such targets (avr, in my case) because the address comparison in the below code does not resolve to a constant, causing

Re: [PATCH] Fix undefined behaviour in arc port

2015-09-28 Thread Jeff Law
On 09/28/2015 11:12 AM, Jeff Law wrote: On 09/26/2015 03:05 AM, Andreas Schwab wrote: Jeff Law writes: @@ -9320,7 +9320,9 @@ arc_legitimize_reload_address (rtx *p, machine_mode mode, int opnum, if ((scale-1) & offset) scale = 1; shift = scale >> 1; - offset_base = (

Re: [PATCH] Convert SPARC to LRA

2015-09-28 Thread Vladimir Makarov
On 09/27/2015 09:29 PM, Jeff Law wrote: On 09/27/2015 01:57 PM, Hans-Peter Nilsson wrote: On Wed, 9 Sep 2015, Mike Stump wrote: On Sep 8, 2015, at 9:41 PM, David Miller wrote: +#define TARGET_LRA_P hook_bool_void_true Are we at the point there this should be the default, and old ports shou

Re: New power of 2 hash policy

2015-09-28 Thread François Dumont
On 25/09/2015 15:28, Jonathan Wakely wrote: > @@ -501,6 +503,129 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION >> mutable std::size_t_M_next_resize; >> }; >> >> + /// Range hashing function considering that second args is a power >> of 2. > > Does this mean "assuming" not "considering"? I assume

Re: [Patch, testsuite] Skip addr_equal-1 if target keeps null pointer checks

2015-09-28 Thread Mike Stump
On Sep 28, 2015, at 1:15 AM, Senthil Kumar Selvaraj wrote: > The below patch skips gcc.dg/addr_equal-1.c if the target keeps null > pointer checks. > > The test fails for such targets (avr, in my case) because the address > comparison in the below code does not resolve to a constant, causing

[patch] libstdc++/67726 LWG 2135: terminate() in condition_variable::wait()

2015-09-28 Thread Jonathan Wakely
This was a change between C++11 and C++14. Tested powerpc64le-linux, committed to trunk. commit 023e16117005d8ca7dbb0e2e61059b59d7cc0e40 Author: Jonathan Wakely Date: Mon Sep 28 17:47:35 2015 +0100 LWG 2135: terminate() in condition_variable::wait() * include/std/condition_var

Re: [PATCH] Convert SPARC to LRA

2015-09-28 Thread David Miller
From: Oleg Endo Date: Mon, 28 Sep 2015 21:26:14 +0900 > LRA on SH seems to work without GCC test suite failures. However, I'd > expect that there still hidden bugs not covered by the test suite. SH's > R0 spill failures are greatly reduced with LRA, although some hacks had > to be added to the

Re: [Patch,optimization]: Optimized changes in the estimate register pressure cost.

2015-09-28 Thread Aaron Sawdey
On Sat, 2015-09-26 at 04:51 +, Ajit Kumar Agarwal wrote: > I have made the following changes in the estimate_reg_pressure_cost function > used > by the loop invariant and IVOPTS. > > Earlier the estimate_reg_pressure cost uses the cost of n_new variables that > are generated by the Loop In

Re: [Patch, fortran] PR40054 and PR63921 - Implement pointer function assignment - redux

2015-09-28 Thread Paul Richard Thomas
Dear Mikael, snip... >> * io.c (next_char_not_space): Change tab warning to warning now >> to prevent locus being lost. > > This has disappeared? duuh! Thanks snip > I think that for better error reporting (avoid unclassifiable statement), > the gfc_notification_std can

Re: [PATCH] Convert SPARC to LRA

2015-09-28 Thread Mike Stump
On Sep 27, 2015, at 6:29 PM, Jeff Law wrote: > I don't think we're there yet either -- many ports still require some > guidance from Vlad to get working with LRA. > > It *may* be time to decree that any new ports must use the LRA path rather > than reload. I'm still on the fence with that. So

Re: [PATCH GCC]Improve rtl loop inv cost by checking if the inv can be propagated to address uses

2015-09-28 Thread Jeff Law
On 09/28/2015 05:28 AM, Bernd Schmidt wrote: On 09/28/2015 11:43 AM, Bin Cheng wrote: Bootstrap and test on x86_64 and x86_32. Will test it on aarch64. So any comments? Thanks, bin 2015-09-28 Bin Cheng * loop-invariant.c (struct def): New field cant_fwprop_to_addr_uses. (inv_cant

Re: [PATCH] Fix undefined behaviour in arc port

2015-09-28 Thread Jeff Law
On 09/26/2015 03:05 AM, Andreas Schwab wrote: Jeff Law writes: @@ -9320,7 +9320,9 @@ arc_legitimize_reload_address (rtx *p, machine_mode mode, int opnum, if ((scale-1) & offset) scale = 1; shift = scale >> 1; - offset_base = (offset + (256 << shift)) & (-512 << sh

Re: [PATCH] Fix undefined behaviour in arc port

2015-09-28 Thread Jeff Law
On 09/26/2015 03:06 AM, Andreas Schwab wrote: Jeff Law writes: @@ -195,7 +195,7 @@ "@internal Unconditional two-address add / sub constant" (and (match_code "const_int") - (match_test "ival == -1 << 31 + (match_test "ival == HOST_WIDE_INT (HOST_WIDE_INT_M1U << 31) Sy

[gomp4] error on acc loops not associated with offloaded acc regions

2015-09-28 Thread Cesar Philippidis
I've applied this patch to gomp-4_0-branch which teaches omplower how to error when it detects acc loops which aren't nested inside an acc parallel or kernels region or located within a function marked as an acc routine. A couple of test cases needed to be updated. The error message is kind of lon

[doc, committed] clean up Asm Labels documentation

2015-09-28 Thread Sandra Loosemore
I've committed the attached patch on behalf of David Wohlferd, who doesn't have SVN write access. Jeff Law already approved the technical content off-list, and I'm not sure the final version of the patch was ever posted here previously. -Sandra 2015-09-28 David Wohlferd * doc/ex

RE: [Graphite] Redesign Graphite scop detection

2015-09-28 Thread Sebastian Paul Pop
Hi Tobi, we do not cache SCEV information as it depends on the region boundaries, so I think we are safe when we extend scops. On handling non-affine regions/loops, you are right, we would need to first teach scop detection about how to handle them, and then teach it to the SESE-to-poly pass as w

Re: [PATCH][RTL-ifcvt] PR rtl-optimization/67465: Handle pairs of complex+simple blocks and empty blocks more gracefully

2015-09-28 Thread H.J. Lu
On Mon, Sep 28, 2015 at 1:26 AM, Kyrill Tkachov wrote: > > On 25/09/15 21:03, Jeff Law wrote: >> >> On 09/25/2015 05:06 AM, Kyrill Tkachov wrote: >>> >>> Hi Rainer, >>> >>> On 25/09/15 11:57, Rainer Orth wrote: Hi Kyrill, > Bootstrapped and tested on aarch64 and x86_64. > Ra

Re: [AArch64] Improve TLS Descriptor pattern to release RTL loop IV opt

2015-09-28 Thread Jiong Wang
Jiong Wang writes: > Andrew Pinski writes: > >> On Tue, Jul 28, 2015 at 6:12 AM, Jiong Wang wrote: >>> >>> The instruction sequences for preparing argument for TLS descriptor >>> runtime resolver and the later function call to resolver can actually be >>> hoisted out of the loop. >>> >>> Current

Re: [PATCH][committed] Fix PR67652: wrong sizeof calculation in liboffloadmic

2015-09-28 Thread Ilya Verbin
On Mon, Sep 28, 2015 at 18:15:14 +0200, Jakub Jelinek wrote: > On Mon, Sep 28, 2015 at 07:10:13PM +0300, Ilya Verbin wrote: > > Committed to trunk as obvious. > > > > PR other/67652 > > * runtime/offload_engine.cpp (Engine::init_process): Fix sizeof. > > > > diff --git a/liboffloadmic/run

Re: [PATCH][committed] Fix PR67652: wrong sizeof calculation in liboffloadmic

2015-09-28 Thread Andrew Pinski
On Mon, Sep 28, 2015 at 9:15 AM, Jakub Jelinek wrote: > On Mon, Sep 28, 2015 at 07:10:13PM +0300, Ilya Verbin wrote: >> Committed to trunk as obvious. >> >> PR other/67652 >> * runtime/offload_engine.cpp (Engine::init_process): Fix sizeof. >> >> diff --git a/liboffloadmic/runtime/offlo

Re: [PATCH][committed] Fix PR67652: wrong sizeof calculation in liboffloadmic

2015-09-28 Thread Jakub Jelinek
On Mon, Sep 28, 2015 at 07:10:13PM +0300, Ilya Verbin wrote: > Committed to trunk as obvious. > > PR other/67652 > * runtime/offload_engine.cpp (Engine::init_process): Fix sizeof. > > diff --git a/liboffloadmic/runtime/offload_engine.cpp > b/liboffloadmic/runtime/offload_engine.cpp >

[PATCH][committed] Fix PR67652: wrong sizeof calculation in liboffloadmic

2015-09-28 Thread Ilya Verbin
Committed to trunk as obvious. PR other/67652 * runtime/offload_engine.cpp (Engine::init_process): Fix sizeof. diff --git a/liboffloadmic/runtime/offload_engine.cpp b/liboffloadmic/runtime/offload_engine.cpp index 16b440d..00b673a 100644 --- a/liboffloadmic/runtime/offload_engine

[gomp4] remove goacc locking

2015-09-28 Thread Nathan Sidwell
I've committed this to remove the now no longer needed lock and unlock builtins and related infrastructure. nathan 2015-09-28 Nathan Sidwell * target.def (GOACC_LOCK): Delete hook. * doc/tm.texi.in (TARGET_GOACC_LOCK): Delete. * doc/tm.texi: Rebuilt. * targhooks.h (default_goacc_lock): D

[gomp4] Remove erroneous test and unreachable situation.

2015-09-28 Thread James Norris
Hi, The attached patch removes an erroneous attribute test and an unreachable situation. Both showed up when dealing with the routine directive and the name option where the name was the identical to the name of the function / subroutine. Committed after regtest on x86_64 and powerpc64le. Thank

[gomp4, WIP] Implement -foffload-alias

2015-09-28 Thread Tom de Vries
Hi, this work-in-progress patch implements a new option -foffload-alias=. The option -foffload-alias=none instructs the compiler to assume that objects references and pointer dereferences in an offload region do not alias. The option -foffload-alias=pointer instructs the compiler to assume

Re: [AArch64] Improve TLS Descriptor pattern to release RTL loop IV opt

2015-09-28 Thread Marcus Shawcroft
On 28 July 2015 at 14:12, Jiong Wang wrote: > > The instruction sequences for preparing argument for TLS descriptor > runtime resolver and the later function call to resolver can actually be > hoisted out of the loop. > > Currently we can't because we have exposed the hard register X0 as > destina

Re: [RFC] Dump function attributes

2015-09-28 Thread Bernd Schmidt
On 09/28/2015 04:32 PM, Tom de Vries wrote: patch below prints the function attributes in the dump file. foo () [ noclone , noinline ] { ... Good idea? If so, do we want one attribute per line? Only for really long ones I'd think. Patch is ok for now. Bernd

Re: [PATCH] Update RTEMS multilib for SPARC

2015-09-28 Thread Daniel Hellstrom
On 09/28/2015 03:49 PM, Sebastian Huber wrote: On 28/09/15 15:39, Daniel Hellstrom wrote: On 09/28/2015 03:37 PM, Sebastian Huber wrote: On 28/09/15 15:20, Daniel Hellstrom wrote: Which multilibs do we have after this change? .; soft;@msoft-float v8;@mcpu=v8 leon3;@mcpu=leon3 leon3v7;@mc

Re: [PATCH] Remove restriction for remote testing

2015-09-28 Thread Bernd Schmidt
On 09/28/2015 02:35 PM, James Norris wrote: The attached patch fixes a problem when doing remote testing. Specifically, testing of the atomic tests found in gcc/atomic. The code in atomic_init precludes the setting of the variable 'link_flags' when doing remote testing. The conditional test can b

[PATCH] liboffloadmic emulation mode: make it asynchronous

2015-09-28 Thread Ilya Verbin
Hi! Currently the COI emulator is single-threaded, i.e. it is able to run only one target function at a time, e.g. the following testcase: #pragma omp parallel sections num_threads(2) { #pragma omp section #pragma omp target while (1) putchar ('.'); #pragma

Re: [AArch64] Improve TLS Descriptor pattern to release RTL loop IV opt

2015-09-28 Thread Jiong Wang
Andrew Pinski writes: > On Tue, Jul 28, 2015 at 6:12 AM, Jiong Wang wrote: >> >> The instruction sequences for preparing argument for TLS descriptor >> runtime resolver and the later function call to resolver can actually be >> hoisted out of the loop. >> >> Currently we can't because we have ex

[PATCH] AIX SECTION_EXCLUDE

2015-09-28 Thread David Edelsohn
The appended patch allows GCC to emit LTO information to a reasonable location in XCOFF objects. Thanks, David * config/rs6000/rs6000.c (rs6000_xcoff_asm_named_section): Place SECTION_EXCLUDE in XO mapping class. Index: rs6000.c ===

[RFC] Dump function attributes

2015-09-28 Thread Tom de Vries
Hi, patch below prints the function attributes in the dump file. Say we mark a function foo with attributes noinline and noclone like this: ... int __attribute__((noinline, noclone)) foo (void) ... Then using this patch, we find in the dump file: ... ;; Function foo (foo, funcdef_no=10, decl_ui

Re: [patch] Enable lightweight checks with _GLIBCXX_ASSERTIONS.

2015-09-28 Thread Florian Weimer
On 09/27/2015 12:24 PM, Jonathan Wakely wrote: > Doh, sorry, I meant this instead i.e. the non-recursive mutex. > +# if _GLIBCXX_ASSERTIONS && defined(PTHREAD_ERRORCHECK_MUTEX_INITIALIZER_NP) > +// Use an error-checking mutex type when assertions are enabled. > +__native_type _M_mutex = P

[SH][committed] Improve treg_set_expr matching

2015-09-28 Thread Oleg Endo
Hi, This patch has been hanging around in my queue for a while. Basically, it uses reverse_condition to get better matching for treg_set_expr. Tested on sh-elf with make -k check RUNTESTFLAGS="--target_board=sh-sim \{-m2/-ml,-m2/-mb,-m2a/-mb,-m4/-ml,-m4/-mb,-m4a/-ml,-m4a/-mb}" and no new failures

Re: [PATCH] Update RTEMS multilib for SPARC

2015-09-28 Thread Sebastian Huber
On 28/09/15 15:39, Daniel Hellstrom wrote: On 09/28/2015 03:37 PM, Sebastian Huber wrote: On 28/09/15 15:20, Daniel Hellstrom wrote: Which multilibs do we have after this change? .; soft;@msoft-float v8;@mcpu=v8 leon3;@mcpu=leon3 leon3v7;@mcpu=leon3v7 leon;@mcpu=leon leon/ut699;@mcpu=leon

Re: [SH][committed] Fix PR 67391

2015-09-28 Thread Oleg Endo
On Sun, 2015-09-27 at 21:03 +0900, Oleg Endo wrote: > On Wed, 2015-09-23 at 21:04 +0900, Oleg Endo wrote: > > Hi, > > > > The attached patch fixes PR 67391. Some additional reg overlapping were > > added to the addsi3 patterns while making LRA on SH work, but not all of > > them seem to be good.

Re: [PATCH] Update RTEMS multilib for SPARC

2015-09-28 Thread Daniel Hellstrom
On 09/28/2015 03:37 PM, Sebastian Huber wrote: On 28/09/15 15:20, Daniel Hellstrom wrote: Which multilibs do we have after this change? .; soft;@msoft-float v8;@mcpu=v8 leon3;@mcpu=leon3 leon3v7;@mcpu=leon3v7 leon;@mcpu=leon leon/ut699;@mcpu=leon@mfix-ut699 leon/at697f;@mcpu=leon@mfix-at697f

Re: [PATCH] Update RTEMS multilib for SPARC

2015-09-28 Thread Sebastian Huber
On 28/09/15 15:20, Daniel Hellstrom wrote: Which multilibs do we have after this change? .; soft;@msoft-float v8;@mcpu=v8 leon3;@mcpu=leon3 leon3v7;@mcpu=leon3v7 leon;@mcpu=leon leon/ut699;@mcpu=leon@mfix-ut699 leon/at697f;@mcpu=leon@mfix-at697f soft/v8;@msoft-float@mcpu=v8 soft/leon3;@msoft-

Re: [PATCH] Update RTEMS multilib for SPARC

2015-09-28 Thread Daniel Hellstrom
On 09/28/2015 02:36 PM, Sebastian Huber wrote: On 28/09/15 14:33, Sebastian Huber wrote: On 28/09/15 14:13, Daniel Hellstrom wrote: Now that muser-mode is default the multilib definitions does not require to specify that switch any more. Add UT699 to multilib after recent patches. Add AT697F

[gomp4] lockless reductions

2015-09-28 Thread Nathan Sidwell
I've committed this patch, which implements a lockless update scheme. This fixes the deadlock (hypothesized to come from resource starvation) observed with worker-level locks in shared memory. It also will make it easier to replace the lockless updating of a particular variable with an atomic

Re: [PATCH] Update RTEMS multilib for SPARC

2015-09-28 Thread Sebastian Huber
On 28/09/15 14:33, Sebastian Huber wrote: On 28/09/15 14:13, Daniel Hellstrom wrote: Now that muser-mode is default the multilib definitions does not require to specify that switch any more. Add UT699 to multilib after recent patches. Add AT697F multilib since there are many LEON2 users runn

[PATCH] Remove restriction for remote testing

2015-09-28 Thread James Norris
Hi, The attached patch fixes a problem when doing remote testing. Specifically, testing of the atomic tests found in gcc/atomic. The code in atomic_init precludes the setting of the variable 'link_flags' when doing remote testing. The conditional test can be safely removed as get_multilibs will r

Re: New post-LTO OpenACC pass

2015-09-28 Thread Nathan Sidwell
On 09/25/15 09:19, Bernd Schmidt wrote: On 09/25/2015 03:03 PM, Bernd Schmidt wrote: 182 else if (acc_device_type (acc_dev->type) == acc_device_host) (gdb) p acc_dev->type $1 = OFFLOAD_TARGET_TYPE_HOST (gdb) next 184 fn (hostaddrs); It's not running the offloaded version, so the t

Re: [PATCH] Update RTEMS multilib for SPARC

2015-09-28 Thread Sebastian Huber
On 28/09/15 14:13, Daniel Hellstrom wrote: Now that muser-mode is default the multilib definitions does not require to specify that switch any more. Add UT699 to multilib after recent patches. Add AT697F multilib since there are many LEON2 users running RTEMS. To gcc/ChangeLog: gcc/ * c

Re: [PATCH] Convert SPARC to LRA

2015-09-28 Thread Oleg Endo
On Sun, 2015-09-27 at 19:29 -0600, Jeff Law wrote: > On 09/27/2015 01:57 PM, Hans-Peter Nilsson wrote: > > On Wed, 9 Sep 2015, Mike Stump wrote: > > > >> On Sep 8, 2015, at 9:41 PM, David Miller wrote: > >>> +#define TARGET_LRA_P hook_bool_void_true > >> > >> Are we at the point there this should

[PATCH] Update RTEMS multilib for SPARC

2015-09-28 Thread Daniel Hellstrom
Now that muser-mode is default the multilib definitions does not require to specify that switch any more. Add UT699 to multilib after recent patches. Add AT697F multilib since there are many LEON2 users running RTEMS. To gcc/ChangeLog: gcc/ * config/sparc/t-rtems: Remove -muser-mode, add

Re: [PATCH 1/4] Add mkoffload for Intel MIC

2015-09-28 Thread Bernd Schmidt
On 09/28/2015 02:00 PM, Jakub Jelinek wrote: On Mon, Sep 28, 2015 at 01:27:32PM +0200, Bernd Schmidt wrote: I've removed obstack_ptr_grow for arrays with known sizes after this review: https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02210.html That's unfortunate, I think that made the code less

Re: [PATCH 1/4] Add mkoffload for Intel MIC

2015-09-28 Thread Jakub Jelinek
On Mon, Sep 28, 2015 at 01:27:32PM +0200, Bernd Schmidt wrote: > >I've removed obstack_ptr_grow for arrays with known sizes after this review: > >https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02210.html > > That's unfortunate, I think that made the code less future-proof. IMO we > should revert to

Re: [PATCH] Add new hooks ASM_OUTPUT_START_FUNCTION_HEADER ...

2015-09-28 Thread Bernd Schmidt
On 09/28/2015 11:44 AM, Dominik Vogt wrote: On Fri, Sep 25, 2015 at 03:33:56PM +0200, Bernd Schmidt wrote: On 09/24/2015 03:48 PM, Dominik Vogt wrote: Hm, I wonder whether wrapping all these section switches in assemble_start/end_function in ".machine" pseudoops (that's what we need the hooks f

Re: [PATCH GCC]Improve rtl loop inv cost by checking if the inv can be propagated to address uses

2015-09-28 Thread Bernd Schmidt
On 09/28/2015 11:43 AM, Bin Cheng wrote: Bootstrap and test on x86_64 and x86_32. Will test it on aarch64. So any comments? Thanks, bin 2015-09-28 Bin Cheng * loop-invariant.c (struct def): New field cant_fwprop_to_addr_uses. (inv_cant_fwprop_to_addr_use): New function.

Re: [PATCH 1/4] Add mkoffload for Intel MIC

2015-09-28 Thread Bernd Schmidt
On 09/28/2015 01:25 PM, Ilya Verbin wrote: On Mon, Sep 28, 2015 at 12:09:19 +0200, Bernd Schmidt wrote: On 09/28/2015 12:03 PM, Bernd Schmidt wrote: On 09/28/2015 10:26 AM, Thomas Schwinge wrote: - objcopy_argv[8] = NULL; + objcopy_argv[objcopy_argc++] = NULL; + gcc_checking_assert (objcopy

Re: [PATCH 1/4] Add mkoffload for Intel MIC

2015-09-28 Thread Ilya Verbin
On Mon, Sep 28, 2015 at 12:09:19 +0200, Bernd Schmidt wrote: > On 09/28/2015 12:03 PM, Bernd Schmidt wrote: > >On 09/28/2015 10:26 AM, Thomas Schwinge wrote: > >>- objcopy_argv[8] = NULL; > >>+ objcopy_argv[objcopy_argc++] = NULL; > >>+ gcc_checking_assert (objcopy_argc <= OBJCOPY_ARGC_MAX); > >

Re: lto wrapper verboseness

2015-09-28 Thread Bernd Schmidt
We need to pass on the verbose flag. I once came up with the following patch (depends on "Refactor intelmic-mkoffload.c argv building", ); OK for trunk? /* Run objcopy. */ @@ -457,6 +465,8 @@

Re: Use gcc/coretypes.h:enum offload_abi in mkoffloads

2015-09-28 Thread Bernd Schmidt
Hi Thomas, Your patch submissions are sometimes very verbose which makes them hard to follow. commit de4d7cbcf979edc095a48dff5b38d12846bdab6f Author: Thomas Schwinge Date: Tue Aug 4 13:12:36 2015 +0200 Cut unnecessary information such as this. git headers are uninteresting. Use gc

Re: [PATCH 1/4] Add mkoffload for Intel MIC

2015-09-28 Thread Bernd Schmidt
On 09/28/2015 12:03 PM, Bernd Schmidt wrote: On 09/28/2015 10:26 AM, Thomas Schwinge wrote: - objcopy_argv[8] = NULL; + objcopy_argv[objcopy_argc++] = NULL; + gcc_checking_assert (objcopy_argc <= OBJCOPY_ARGC_MAX); On its own this is not an improvement - you're trading a compile time error

Re: [PATCH 1/4] Add mkoffload for Intel MIC

2015-09-28 Thread Bernd Schmidt
On 09/28/2015 10:26 AM, Thomas Schwinge wrote: - objcopy_argv[8] = NULL; + objcopy_argv[objcopy_argc++] = NULL; + gcc_checking_assert (objcopy_argc <= OBJCOPY_ARGC_MAX); On its own this is not an improvement - you're trading a compile time error for a runtime error. So, what is the other ch

Re: [PATCH] Add new hooks ASM_OUTPUT_START_FUNCTION_HEADER ...

2015-09-28 Thread Dominik Vogt
On Fri, Sep 25, 2015 at 03:33:56PM +0200, Bernd Schmidt wrote: > On 09/24/2015 03:48 PM, Dominik Vogt wrote: > >Hm, I wonder whether wrapping all these section switches in > >assemble_start/end_function in ".machine" pseudoops (that's what > >we need the hooks for; similar to .arch for ix86) has an

[PATCH GCC]Improve rtl loop inv cost by checking if the inv can be propagated to address uses

2015-09-28 Thread Bin Cheng
Hi, For below rtl dump before loop invariant pass: LOOP: 1482: r1838:DI=0xa880 1483: r1837:DI=sfp:DI+r1838:DI REG_DEAD r1838:DI REG_EQUAL sfp:DI-0x5780 1484: r1839:V4SI=r910:V4SI>>const_vector 1485: r1840:V4SI=r1067:V4SI+r910:V4SI REG_DEAD r910:V4SI 1486: r1841:V

Re: Ping^2 Re: Pass -foffload targets from driver to libgomp at link time

2015-09-28 Thread Thomas Schwinge
Hi! On Fri, 11 Sep 2015 17:43:49 +0200, Jakub Jelinek wrote: > So, do I understand well that you'll call GOMP_set_offload_targets from > construct[ors] of all shared libraries (and the binary) that contain offloaded > code? If yes, that is surely going to fail the assertions in there. Indeed.

libgomp: Guard all devices/num_devices/num_devices_openmp access by register_lock (was: libgomp: Guard all offload_images/num_offload_images access by register_lock)

2015-09-28 Thread Thomas Schwinge
Hi! On Fri, 25 Sep 2015 19:49:50 +0300, Ilya Verbin wrote: > On Fri, Sep 25, 2015 at 18:21:27 +0200, Thomas Schwinge wrote: > > On Thu, 26 Mar 2015 23:41:30 +0300, Ilya Verbin wrote: > > > On Thu, Mar 26, 2015 at 13:09:19 +0100, Jakub Jelinek wrote: > > > > the current code is majorly broken. A

Re: lto wrapper verboseness

2015-09-28 Thread Thomas Schwinge
Hi! On Thu, 30 Jul 2015 10:09:05 +0200, Richard Biener wrote: > On Thu, Jul 30, 2015 at 1:05 AM, Nathan Sidwell wrote: > > Jakub, > > this patch augments the lto wrapper to print out the arguments to spawned > > commands when verbose. I found this useful in debugging recent development. > > >

Re: [PATCH 1/4] Add mkoffload for Intel MIC

2015-09-28 Thread Thomas Schwinge
Hi! On Wed, 22 Oct 2014 22:57:01 +0400, Ilya Verbin wrote: > On 22 Oct 09:57, Jakub Jelinek wrote: > > On Wed, Oct 22, 2014 at 02:30:44AM +0400, Ilya Verbin wrote: > > > + obstack_init (&argv_obstack); > > > + obstack_ptr_grow (&argv_obstack, "objcopy"); > > > + obstack_ptr_grow (&argv_obstack

Re: [PATCH][RTL-ifcvt] PR rtl-optimization/67465: Handle pairs of complex+simple blocks and empty blocks more gracefully

2015-09-28 Thread Kyrill Tkachov
On 25/09/15 21:03, Jeff Law wrote: On 09/25/2015 05:06 AM, Kyrill Tkachov wrote: Hi Rainer, On 25/09/15 11:57, Rainer Orth wrote: Hi Kyrill, Bootstrapped and tested on aarch64 and x86_64. Rainer, could you please try this patch in combination with the one I sent earlier at: https://gcc.gnu.

[Committed] Add gcc.dg/vect/pr62171.c

2015-09-28 Thread Tom de Vries
Hi, this patch adds testcase gcc.dg/vect/pr62171.c. The testcase passes thanks to the fix for PR67673. Committed to trunk. Thanks, - Tom Add gcc.dg/vect/pr62171.c 2015-09-28 Tom de Vries * gcc.dg/vect/pr62171.c: New test. --- gcc/testsuite/gcc.dg/vect/pr62171.c | 27

Re: [Graphite] Redesign Graphite scop detection

2015-09-28 Thread Tobias Grosser
On 09/28/2015 03:30 AM, Aditya Kumar wrote: From: hiraditya Redesign Graphite scop detection for faster compiler time and detecting more SCoPs. Existing algorithm for SCoP detection in graphite was based on dominator tree where a tree (CFG) traversal was required for analyzing an SESE. The tr

[Patch, testsuite] Skip addr_equal-1 if target keeps null pointer checks

2015-09-28 Thread Senthil Kumar Selvaraj
Hi, The below patch skips gcc.dg/addr_equal-1.c if the target keeps null pointer checks. The test fails for such targets (avr, in my case) because the address comparison in the below code does not resolve to a constant, causing builtin_constant_p to return false and fail the test. /*

Re: Use gcc/coretypes.h:enum offload_abi in mkoffloads

2015-09-28 Thread Thomas Schwinge
Hi! On Tue, 4 Aug 2015 13:20:12 +0200, I wrote: > On Thu, 8 Jan 2015 07:02:19 -0800, "H.J. Lu" wrote: > > On Thu, Jan 8, 2015 at 6:59 AM, Thomas Schwinge > > wrote: > > > On Mon, 22 Dec 2014 12:28:20 +0100, Jakub Jelinek > > > wrote: > > >> On Mon, Dec 22, 2014 at 12:25:32PM +0100, Thomas Sch