On Mon, Sep 28, 2015 at 07:10:13PM +0300, Ilya Verbin wrote:
> Committed to trunk as obvious.
>
> PR other/67652
> * runtime/offload_engine.cpp (Engine::init_process): Fix sizeof.
>
> diff --git a/liboffloadmic/runtime/offload_engine.cpp
> b/liboffloadmic/runtime/offload_engine.cpp
> index 16b440d..00b673a 100644
> --- a/liboffloadmic/runtime/offload_engine.cpp
> +++ b/liboffloadmic/runtime/offload_engine.cpp
> @@ -173,7 +173,7 @@ void Engine::init_process(void)
> // use putenv instead of setenv as Windows has no setenv.
> // Note: putenv requires its argument can't be freed or modified.
> // So no free after call to putenv or elsewhere.
> - char * env_var = (char*) malloc(sizeof("COI_DMA_CHANNEL_COUNT=2"
> + 1));
> + char * env_var = (char*)
> malloc(sizeof("COI_DMA_CHANNEL_COUNT=2"));
> sprintf(env_var, "COI_DMA_CHANNEL_COUNT=2");
> putenv(env_var);
Missing error handling if malloc returns NULL?
Jakub
