Re: [PATCH] Fix up -march=native handling under KVM (PR target/61570)

2014-06-23 Thread Uros Bizjak
On Mon, Jun 23, 2014 at 6:29 PM, H.J. Lu wrote: > --- gcc/config/i386/driver-i386.c.jj2014-05-14 14:45:54.0 > +0200 > +++ gcc/config/i386/driver-i386.c 2014-06-20 18:59:57.805006358 > +0200 > @@ -745,6 +745,11 @@ const char *host_detect_local_cpu (int

Re: [PATCH, PR61554] ICE during CCP

2014-06-23 Thread Chung-Lin Tang
On 2014/6/23 04:45 PM, Richard Biener wrote: > On Mon, Jun 23, 2014 at 7:32 AM, Chung-Lin Tang > wrote: >> Hi Richard, >> >> In this change: >> https://gcc.gnu.org/ml/gcc-patches/2014-06/msg01278.html >> >> where substitute_and_fold() was changed to use a dom walker, the calls >> to purge dead EH

Re: Fortran OpenMP UDR fixes, nested handling fixes etc.

2014-06-23 Thread Tobias Burnus
Jakub Jelinek wrote: So, either we need something like the following patch (incremental), or another possibility for the problem is not do the value.function.name related change in module.c in the UDR patch, and instead fix up the UDR combiner/initializer expressions when they are loaded from mod

[RFC] Making fold-const sane WRT symbol visibilities

2014-06-23 Thread Jan Hubicka
Hello, fold-const contains quite few confused statements that deal with WEAK visibility and aliases: static int simple_operand_p (const_tree exp) { /* Strip any conversions that don't change the machine mode. */ STRIP_NOPS (exp); return (CONSTANT_CLASS_P (exp) || TREE_CODE (exp)

Re: [PATCH] Fix for invalid sanitization of trailing byte in __builtin_strlen

2014-06-23 Thread Maxim Ostapenko
On 06/23/2014 10:11 PM, Jeff Law wrote: On 06/23/14 10:55, Maxim Ostapenko wrote: Hi, when I applied this patch (r211846), I made a little mistake in output test patterns. This patch fixes this. Tested on x86_64-unknown-linux-gnu. Ok to commit? OK. jeff Thanks, done in r211927. -Maxim

Re: [patch] change specific int128 -> generic intN

2014-06-23 Thread DJ Delorie
> The changes to dwarf2asm.c, cppbuiltin.c, optabs.c, defaults.h, expr.c, > expmed.c, tree-dfa.c, simplify-rtx.c, lto-object.c, loop-iv.c, varasm.c, > the msp430 back end and some of the stor-layout.c changes don't look like > they should depend on the rest of the patch. I think it would help

Re: [patch] change specific int128 -> generic intN

2014-06-23 Thread DJ Delorie
> Since the test on __STRICT_ANSI__ is removed for all other uses, it would > seem consistent to me to remove this one as well. Besides, you are already > testing __GLIBCXX_USE_INT_N_0, which as far as I understand is protected > by !flag_iso (with the exception of size_t). Yup, I'll clean tha

Re: [PATCH] gcc: fix segfault from calling free on non-malloc'd area

2014-06-23 Thread Paul Gortmaker
[Re: [PATCH] gcc: fix segfault from calling free on non-malloc'd area] On 23/06/2014 (Mon 14:32) Jeff Law wrote: > On 06/23/14 14:09, Tobias Burnus wrote: > >This patch broke bootstrapping for me on x86-64-gnu-linux: > > > >/usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../x86_64-suse-linux/bin/ld

Re: [PATCH 5/5] add libcc1

2014-06-23 Thread Trevor Saunders
On Mon, Jun 23, 2014 at 01:09:41PM -0600, Jeff Law wrote: > On 06/20/14 09:33, Tom Tromey wrote: > >>"Trevor" == Trevor Saunders writes: > > > >Trevor> I'm curious, what is the reason you choose not to write this in > >C++11 or > >Trevor> later? Its distributed with gcc, so the only case whe

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

2014-06-23 Thread Cong Hou
It has been 8 months since this patch is posted. I have addressed all comments to this patch. The SAD pattern is very useful for some multimedia algorithms like ffmpeg. This patch will greatly improve the performance of such algorithms. Could you please have a look again and check if it is OK for

RE: [PATCH,MIPS] MIPS64r6 support

2014-06-23 Thread Steve Ellcey
On Mon, 2014-06-23 at 03:31 -0700, Matthew Fortune wrote: > > > Recommendations on how to rework the mips.exp logic to cope with this > > > would be appreciated. > > > > Could you give an example of the kind of thing you mean? > > You have actually covered the cases I was concerned about below.

[patch] fix namespaces for std::experimental types

2014-06-23 Thread Jonathan Wakely
The current Fundamentals TS says any, optional and string_view should be in an inline namespace called fundamentals_v1. Tested x86_64-linux, committed to trunk. commit 3b316b60d21ea224c56bb23a8e1afb06e2277cf8 Author: Jonathan Wakely Date: Mon Jun 23 21:34:29 2014 +0100 * include/experim

[Committed] New testcase for conditional move with conditional compares

2014-06-23 Thread Andrew Pinski
Hi, When looking at the current conditional compare patch, I find that we don't have a testcase to test that we don't ICE for the case where we have conditional compares and conditional moves where the moves are of floating point types. This patch adds that testcase to the C torture compile test

Re: [PATCH] gcc: fix segfault from calling free on non-malloc'd area

2014-06-23 Thread Jakub Jelinek
On Mon, Jun 23, 2014 at 02:32:37PM -0600, Jeff Law wrote: > On 06/23/14 14:09, Tobias Burnus wrote: > >This patch broke bootstrapping for me on x86-64-gnu-linux: > > > >/usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../x86_64-suse-linux/bin/ld: > >i386 architecture of input file `/usr/lib/crti.o' is

Re: Instructions vs Expressions in the backend (was Re: RFA: Rework FOR_BB_INSNS iterators)

2014-06-23 Thread Oleg Endo
On Mon, 2014-06-23 at 14:54 -0400, David Malcolm wrote: > FWIW I'm actually working on such a change, or, at least, to make > instructions be a subclass of rtx_def; presumably this should make it > easier to make it an entirely separate type, if that's desirable. > > Executive summary is that it'

Re: [PATCH] gcc: fix segfault from calling free on non-malloc'd area

2014-06-23 Thread Jeff Law
On 06/23/14 14:09, Tobias Burnus wrote: This patch broke bootstrapping for me on x86-64-gnu-linux: /usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../x86_64-suse-linux/bin/ld: i386 architecture of input file `/usr/lib/crti.o' is incompatible with i386:x86-64 output If I revert the patch, it wo

Re: [patch] libstdc++/61532 fix make_signed failures

2014-06-23 Thread Jonathan Wakely
On 23/06/14 19:18 +0100, Jonathan Wakely wrote: This fixes some more fallout from my make_signed changes and improves the make_unsigned tests which were already fixed last month. Tested x86_64-linux and powerpc64-linux, committed to trunk. I'll be making the same changes on the 4.9 branch shortl

Re: calloc = malloc + memset

2014-06-23 Thread Andrew Pinski
On Mon, Jun 23, 2014 at 1:21 PM, Andi Kleen wrote: > On Mon, Jun 23, 2014 at 10:14:25PM +0200, Marc Glisse wrote: >> On Mon, 23 Jun 2014, Andi Kleen wrote: >> >> >I would prefer to not do it. >> >> For the sake of micro benchmarks? > > Yes benchmarks are important. But micro-benchmarks are not i

Move DECL_VINDEX and DECL_SAVED_TREE into function_decl

2014-06-23 Thread Jan Hubicka
Hi, this patch makes DECL_VINDEX and DECL_SAVED_TREE to be FUNCTION_DECL only. This needs to resolve overloading in C++ FE. For namespaces I added new fields in lang specific annotation and for TEMPLATE_DECL I moved the overload to UNIT_SIZE that is currently unused. My incremental plan is to 1)

Re: calloc = malloc + memset

2014-06-23 Thread Andi Kleen
On Mon, Jun 23, 2014 at 10:14:25PM +0200, Marc Glisse wrote: > On Mon, 23 Jun 2014, Andi Kleen wrote: > > >I would prefer to not do it. > > For the sake of micro benchmarks? Yes benchmarks are important. -Andi

Re: [fortran, patch] IEEE intrinsic modules (ping)

2014-06-23 Thread Steve Kargl
On Mon, Jun 23, 2014 at 12:23:39PM -0700, Steve Kargl wrote: > I meant to look this over this weekend. Unfortnately, baseball > and soccer (both daughter and USA vs Portugal) got in the way. > First issue, > > cd gcc4x > patch < ieee_withregenerated_2.diff > ... > -- > |I

Re: calloc = malloc + memset

2014-06-23 Thread Marc Glisse
On Mon, 23 Jun 2014, Andi Kleen wrote: I would prefer to not do it. For the sake of micro benchmarks? I'm not sure it has a lot of benefit. It has a non-zero benefit. If you want to keep it please make sure there is an easy way to turn it off. Any of these flags works: -fdisable-tree-s

Re: [PATCH] gcc: fix segfault from calling free on non-malloc'd area

2014-06-23 Thread Tobias Burnus
This patch broke bootstrapping for me on x86-64-gnu-linux: /usr/lib64/gcc/x86_64-suse-linux/4.8/../../../../x86_64-suse-linux/bin/ld: i386 architecture of input file `/usr/lib/crti.o' is incompatible with i386:x86-64 output If I revert the patch, it works for me. Tobias Paul Gortmaker wrote

RE: [PATCH] Fix forwporp pattern (T)(P + A) - (T)P -> (T)A

2014-06-23 Thread Bernd Edlinger
Hi, On Mon, 23 Jun 2014 16:22:13, Eric Botcazou wrote: > >> I noticed that several testcases in the GMP-4.3.2 test suite are failing now >> which did not happen with GCC 4.9.0. I debugged the first one, >> mpz/convert, and found the file mpn/generic/get_str.c was miscompiled. >> >> mpn/get_str.c.1

Re: calloc = malloc + memset

2014-06-23 Thread Andi Kleen
On Mon, Jun 23, 2014 at 09:00:02PM +0200, Marc Glisse wrote: > On Mon, 23 Jun 2014, Andi Kleen wrote: > > >FWIW i believe the transformation will break a large variety of micro > >benchmarks. > > > >calloc internally knows that memory fresh from the OS is zeroed. > >But the memory may not be faul

Re: [fortran, patch] IEEE intrinsic modules (ping)

2014-06-23 Thread Steve Kargl
I meant to look this over this weekend. Unfortnately, baseball and soccer (both daughter and USA vs Portugal) got in the way. First issue, cd gcc4x patch < ieee_withregenerated_2.diff ... -- |Index: configure.host |=

Re: [PATCH] gcc: fix segfault from calling free on non-malloc'd area

2014-06-23 Thread Jeff Law
On 06/23/14 08:42, Paul Gortmaker wrote: We see the following on a 32bit gcc installed on 64 bit host: Reading symbols from ./i586-pokymllib32-linux-gcc...done. (gdb) run Starting program: x86-pokymllib32-linux/lib32-gcc/4.9.0-r0/image/usr/bin/i586-pokymllib32-linux-gcc Program rec

Re: [doc] Remove duplicate -Wmaybe-uninitialized

2014-06-23 Thread Jeff Law
On 06/22/14 11:30, Marc Glisse wrote: Hello, a trivial patch to remove a duplicated option, you can see the second one 4 lines below in the patch. (the mixed use of single or double spaces in this list is strange) This was included in the bootstrap of another patch. 2014-06-23 Marc Glisse

Re: [PATCH 5/5] add libcc1

2014-06-23 Thread Jeff Law
On 06/20/14 09:33, Tom Tromey wrote: "Trevor" == Trevor Saunders writes: Trevor> I'm curious, what is the reason you choose not to write this in C++11 or Trevor> later? Its distributed with gcc, so the only case where you aren't Trevor> building with the in tree compiler and libraries is when

Re: [PATCH] Fix 61565 -- cmpelim vs non-call exceptions

2014-06-23 Thread Richard Henderson
On 06/23/2014 08:55 AM, Ramana Radhakrishnan wrote: > Agreed, this is why cmpelim looks interesting for Thumb1. (We may need another > hook or something to disable it in configurations we don't need it in, but you > know ... ) Yeah. Feel free to change targetm.flags_regnum from a variable to a fu

Instructions vs Expressions in the backend (was Re: RFA: Rework FOR_BB_INSNS iterators)

2014-06-23 Thread David Malcolm
On Mon, 2014-06-09 at 20:32 +0100, Richard Sandiford wrote: > Steven Bosscher writes: > > On Sat, Jun 7, 2014 at 7:54 PM, Richard Sandiford wrote: > >> The two parts of the loop condition are really handling two different > >> kinds of block: ones like entry and exit that are completely empty > >>

Re: calloc = malloc + memset

2014-06-23 Thread Marc Glisse
On Mon, 23 Jun 2014, Andi Kleen wrote: FWIW i believe the transformation will break a large variety of micro benchmarks. calloc internally knows that memory fresh from the OS is zeroed. But the memory may not be faulted in yet. memset always faults in the memory. So if you have some test lik

Re: [PATCH] Only transform rotate to rotatert and v.v. if target has both

2014-06-23 Thread Jeff Law
On 06/22/14 14:58, Segher Boessenkool wrote: Many targets do not have both rotate and rotatert. Of the 47 targets in the tree, 17 have both, 9 have only rotate, 2 have only rotatert, and 19 have neither (this is based on "grep -wil" so it can be slightly off). rs6000 has only rotate, and mips h

Re: calloc = malloc + memset

2014-06-23 Thread Andrew Pinski
On Mon, Jun 23, 2014 at 11:17 AM, Andi Kleen wrote: > Marc Glisse writes: > >> Hello, >> >> this is a stage 1 patch, and I'll ping it then, but if you have >> comments now... > > FWIW i believe the transformation will break a large variety of micro > benchmarks. > > calloc internally knows that

Re: [PATCH] Fix for invalid sanitization of trailing byte in __builtin_strlen

2014-06-23 Thread Jeff Law
On 06/23/14 10:55, Maxim Ostapenko wrote: Hi, when I applied this patch (r211846), I made a little mistake in output test patterns. This patch fixes this. Tested on x86_64-unknown-linux-gnu. Ok to commit? OK. jeff

[Patch, Fortran] Fix a coarray ICE on invalid code

2014-06-23 Thread Tobias Burnus
First, the following coarray patches are still awaiting review: * https://gcc.gnu.org/ml/gcc-patches/2014-06/msg01662.html * https://gcc.gnu.org/ml/fortran/2014-06/msg00183.html The attached patch fixes an ICE on invalid code with polymorphic coarrays. Build and regtested on x86-64-gnu-linux. OK

Re: [PATCH] Don't segv on __atomic_store (PR c/61553)

2014-06-23 Thread Marek Polacek
On Mon, Jun 23, 2014 at 04:39:55PM +0200, Marek Polacek wrote: > --- gcc/testsuite/c-c++-common/pr61553.c > +++ gcc/testsuite/c-c++-common/pr61553.c > @@ -0,0 +1,8 @@ > +/* PR c/61553 */ > +/* { dg-do compile } */ > + > +void > +foo (char *s) > +{ > + __atomic_store (s, (void *) 0, __ATOMIC_SEQ_CS

Re: calloc = malloc + memset

2014-06-23 Thread Andi Kleen
Marc Glisse writes: > Hello, > > this is a stage 1 patch, and I'll ping it then, but if you have > comments now... FWIW i believe the transformation will break a large variety of micro benchmarks. calloc internally knows that memory fresh from the OS is zeroed. But the memory may not be faulte

[patch] libstdc++/61532 fix make_signed failures

2014-06-23 Thread Jonathan Wakely
This fixes some more fallout from my make_signed changes and improves the make_unsigned tests which were already fixed last month. Tested x86_64-linux and powerpc64-linux, committed to trunk. I'll be making the same changes on the 4.9 branch shortly. commit 43db1e59326da5af1f75a86e37e51f015989b7

Re: [PATCH][libsanitizer] Cherry-pick r211008 [Was: Re: libsanitizer merge from upstream r208536]

2014-06-23 Thread Jakub Jelinek
On Mon, Jun 23, 2014 at 07:23:09PM +0200, Paolo Carlini wrote: > / > 2014-06-23 Paolo Carlini > > * sanitizer_common/sanitizer_common_interceptors.inc: > Cherry pick upstream r211008. Sure, thanks. > Index: sanitizer_common/sanitizer_common_interceptors.inc >

RE: [PATCH] Fix forwporp pattern (T)(P + A) - (T)P -> (T)A

2014-06-23 Thread Bernd Edlinger
Hi, On Mon, 23 Jun 2014 19:12:47, Richard Biener wrote: > > On Mon, Jun 23, 2014 at 4:28 PM, Bernd Edlinger > wrote: >> Hi, >> >> On Mon, 23 Jun 2014 10:40:53, Richard Biener wrote: >>> >>> On Sun, Jun 22, 2014 at 9:14 AM, Bernd Edlinger >>> wrote: Hi, I noticed that several testc

Re: [Patch] Not very subtle fix for pr61510

2014-06-23 Thread Jan Hubicka
> On Mon, 23 Jun 2014, James Greenhalgh wrote: > > > > > Hi, > > > > pr61510 is a case where cgraphunit.c::analyze_functions can end up > > dereferencing a NULL pointer. This is, to me, the obvious way to avoid > > dereferencing NULL. > > > > However, I'm not very confident that this isn't just

Re: Another AIX Bootstrap failure

2014-06-23 Thread Jan Hubicka
> The tests gcc.dg/globalalias-2.c and gcc.dg/localalias-2.c fail on darwin with > > /opt/gcc/work/gcc/testsuite/gcc.dg/globalalias-2.c:20:2: warning: alias > definitions not supported in Mach-O; ignored > > I think they should be protected by > > /* { dg-require-alias "" } */ I see, the anoyi

[PATCH][libsanitizer] Cherry-pick r211008 [Was: Re: libsanitizer merge from upstream r208536]

2014-06-23 Thread Paolo Carlini
Hi, On 06/16/2014 10:42 AM, Konstantin Serebryany wrote: On Wed, Jun 11, 2014 at 2:28 PM, Paolo Carlini wrote: Hi, On 05/22/2014 09:02 PM, Jakub Jelinek wrote: In file included from ../../../../trunk/libsanitizer/asan/asan_interceptors.cc:147:0: ../../../../trunk/libsanitizer/sanitizer_comm

RE: [PATCH] Fix forwporp pattern (T)(P + A) - (T)P -> (T)A

2014-06-23 Thread Bernd Edlinger
Hi, On Mon, 23 Jun 2014 10:27:59, Jeff Law wrote: > > On 06/22/14 01:14, Bernd Edlinger wrote: >> Hi, >> >> I noticed that several testcases in the GMP-4.3.2 test suite are failing now >> which >> did not happen with GCC 4.9.0. I debugged the first one, mpz/convert, and >> found >> the file mpn/

Re: [PATCH] DWARFv5 Emit DW_TAG_atomic_type.

2014-06-23 Thread Mark Wielaard
On Mon, 2014-06-23 at 10:31 -0600, Tom Tromey wrote: > > "Mark" == Mark Wielaard writes: > > Mark> The following is just a prototype to try out a new qualifier type tag > Mark> proposed for DWARFv5. There is not even a draft yet of DWARFv5, so this > Mark> is just based on a proposal that mig

Re: [PATCH] Fix forwporp pattern (T)(P + A) - (T)P -> (T)A

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 4:28 PM, Bernd Edlinger wrote: > Hi, > > On Mon, 23 Jun 2014 10:40:53, Richard Biener wrote: >> >> On Sun, Jun 22, 2014 at 9:14 AM, Bernd Edlinger >> wrote: >>> Hi, >>> >>> I noticed that several testcases in the GMP-4.3.2 test suite are failing >>> now which >>> did not

[Patch, Fortran, committed] Fixed one issue with -fcoarray=lib

2014-06-23 Thread Tobias Burnus
The issue fixed by the attached test case was that an automatic array wasn't properly initialized with -fcoarray=lib. As the code is for explicit-size arrays, it isn't reachable for allocatable coarrays. On the other hand, for coarrays with SAVE attribute, already the condition before should be

Re: [PATCH 2/N] allow storing values directly in hash tables

2014-06-23 Thread Richard Biener
On Fri, Jun 20, 2014 at 12:52 PM, wrote: > From: Trevor Saunders > > Hi, > > this patch allows you to define the type the hash table stores as elements > instead of the type elements point at by having your hash descriptor define > the > type store_values_directly. It turns out trying to imple

Re: [PATCH 3/3] add hash_map class

2014-06-23 Thread Richard Biener
On Fri, Jun 20, 2014 at 12:52 PM, wrote: > From: Trevor Saunders > > Hi, > > This patch adds a hash_map class so we can consolidate the boiler plate around > using hash_table as a map, it also allows us to get rid of pointer_map which I > do in this patch by converting its users to hash_map. > >

Re: [PATCH] Fix for invalid sanitization of trailing byte in __builtin_strlen

2014-06-23 Thread Maxim Ostapenko
Hi, when I applied this patch (r211846), I made a little mistake in output test patterns. This patch fixes this. Tested on x86_64-unknown-linux-gnu. Ok to commit? -Maxim gcc/testsuite/ChangeLog: 2014-06-23 Max Ostapenko * c-c++-common/asan/strlen-overflow-1.c: Change match patterns. d

Re: [PATCH] Don't segv on __atomic_store (PR c/61553)

2014-06-23 Thread Joseph S. Myers
On Mon, 23 Jun 2014, Marek Polacek wrote: > We ICEd on the following testcase since the void type has a NULL > TYPE_SIZE_UNIT. I took Andrew's patch from gcc@ ML and added > a testcase. > > Regtested/bootstrapped on x86_64-linux, ok for trunk? > > 2014-06-23 Marek Polacek > Andrew

Re: [PATCH][RFC] Gate loop passes group on number-of-loops > 1, add no-loops group

2014-06-23 Thread Richard Biener
On Wed, 18 Jun 2014, Jeff Law wrote: > On 06/18/14 04:42, Richard Biener wrote: > > > > The following aims at reducing the number of pointless passes we run > > on functions containing no loops. Those are at least two copyprop > > and one dce pass (two dce passes when vectorization is enabled, >

Re: Another AIX Bootstrap failure

2014-06-23 Thread Dominique Dhumieres
The tests gcc.dg/globalalias-2.c and gcc.dg/localalias-2.c fail on darwin with /opt/gcc/work/gcc/testsuite/gcc.dg/globalalias-2.c:20:2: warning: alias definitions not supported in Mach-O; ignored I think they should be protected by /* { dg-require-alias "" } */ Dominique

Re: calloc = malloc + memset

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 6:19 PM, Marc Glisse wrote: > On Mon, 23 Jun 2014, Richard Biener wrote: > >> On June 23, 2014 5:51:30 PM CEST, Marc Glisse >> wrote: >>> >>> On Mon, 23 Jun 2014, Jakub Jelinek wrote: >>> Ok for trunk, sorry for the delay. >>> >>> >>> Thanks. Richard has moved the pas

Re: [patch i386]: Combine memory and indirect jump

2014-06-23 Thread Richard Henderson
On 06/23/2014 09:22 AM, Jeff Law wrote: > On 06/23/14 08:32, Richard Biener wrote: >> Btw, there is now no DCE after peephole2? Is peephole2 expected to >> cleanup after itself? > There were cases where we wanted to change the insns we would output to fit > into the 4:1:1 issue model of the PPro,

Re: [GSoC][match-and-simplify] mark some more operators as commutative

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 4:38 PM, Richard Biener wrote: > On Mon, Jun 23, 2014 at 4:23 PM, Marc Glisse wrote: >> On Mon, 23 Jun 2014, Richard Biener wrote: >> >>> On Mon, Jun 23, 2014 at 3:32 PM, Prathamesh Kulkarni >>> wrote: * match.pd: Mark operators in some bitwise and plus-minus >>

Re: [Patch] Not very subtle fix for pr61510

2014-06-23 Thread Richard Biener
On Mon, 23 Jun 2014, James Greenhalgh wrote: > > Hi, > > pr61510 is a case where cgraphunit.c::analyze_functions can end up > dereferencing a NULL pointer. This is, to me, the obvious way to avoid > dereferencing NULL. > > However, I'm not very confident that this isn't just masking some > horr

Re: [PATCH] DWARFv5 Emit DW_TAG_atomic_type.

2014-06-23 Thread Tom Tromey
> "Mark" == Mark Wielaard writes: Mark> The following is just a prototype to try out a new qualifier type tag Mark> proposed for DWARFv5. There is not even a draft yet of DWARFv5, so this Mark> is just based on a proposal that might or might not be adopted and/or Mark> changed http://dwarfstd

Re: [PATCH] Fix up -march=native handling under KVM (PR target/61570)

2014-06-23 Thread H.J. Lu
On Sun, Jun 22, 2014 at 11:23 AM, Uros Bizjak wrote: > On Sat, Jun 21, 2014 at 8:07 PM, Jakub Jelinek wrote: > >>> > --- gcc/config/i386/driver-i386.c.jj2014-05-14 14:45:54.0 >>> > +0200 >>> > +++ gcc/config/i386/driver-i386.c 2014-06-20 18:59:57.805006358 >>> > +0200 >>> > @@

Re: [PATCH] Fix forwporp pattern (T)(P + A) - (T)P -> (T)A

2014-06-23 Thread Jeff Law
On 06/22/14 01:14, Bernd Edlinger wrote: Hi, I noticed that several testcases in the GMP-4.3.2 test suite are failing now which did not happen with GCC 4.9.0. I debugged the first one, mpz/convert, and found the file mpn/generic/get_str.c was miscompiled. It's interesting you stumbled on this.

Re: [patch i386]: Combine memory and indirect jump

2014-06-23 Thread Jeff Law
On 06/23/14 08:32, Richard Biener wrote: On Mon, Jun 23, 2014 at 4:13 PM, Richard Henderson wrote: On 06/20/2014 02:59 PM, Kai Tietz wrote: So I suggest following change of passes.def: Index: passes.def === --- passes.def (Revis

Re: [PATCH] Trust TREE_ADDRESSABLE

2014-06-23 Thread Jan Hubicka
> On June 23, 2014 6:15:10 PM CEST, Jan Hubicka wrote: > >> I don't like this very much. It's fragile and it will be very hard > >to > >> detect bugs caused by it. > >> > >> Please don't spread uses of the DECL_NONALIASED "hack". > >> > >> If we are only concerned about LTO I'd rather have a in

[Patch] Not very subtle fix for pr61510

2014-06-23 Thread James Greenhalgh
Hi, pr61510 is a case where cgraphunit.c::analyze_functions can end up dereferencing a NULL pointer. This is, to me, the obvious way to avoid dereferencing NULL. However, I'm not very confident that this isn't just masking some horrible and subtle bug, so I'd like some review feedback on the pat

Re: calloc = malloc + memset

2014-06-23 Thread Marc Glisse
On Mon, 23 Jun 2014, Richard Biener wrote: On June 23, 2014 5:51:30 PM CEST, Marc Glisse wrote: On Mon, 23 Jun 2014, Jakub Jelinek wrote: Ok for trunk, sorry for the delay. Thanks. Richard has moved the passes a bit since then, but I still have exactly one spot where the testsuite is ok :

Re: [PATCH] Trust TREE_ADDRESSABLE

2014-06-23 Thread Richard Biener
On June 23, 2014 6:15:10 PM CEST, Jan Hubicka wrote: >> I don't like this very much. It's fragile and it will be very hard >to >> detect bugs caused by it. >> >> Please don't spread uses of the DECL_NONALIASED "hack". >> >> If we are only concerned about LTO I'd rather have a in_lto_p check >>

Re: [PATCH] Trust TREE_ADDRESSABLE

2014-06-23 Thread Jan Hubicka
> I don't like this very much. It's fragile and it will be very hard to > detect bugs caused by it. > > Please don't spread uses of the DECL_NONALIASED "hack". > > If we are only concerned about LTO I'd rather have a in_lto_p check > in may_be_aliased and trust TREE_ADDRESSABLE there. I do not

Re: calloc = malloc + memset

2014-06-23 Thread Richard Biener
On June 23, 2014 5:51:30 PM CEST, Marc Glisse wrote: >On Mon, 23 Jun 2014, Jakub Jelinek wrote: > >> Ok for trunk, sorry for the delay. > >Thanks. Richard has moved the passes a bit since then, but I still have > >exactly one spot where the testsuite is ok :-) I need strlen to be >after >dom (for

Re: [AArch64] Implement ADD in vector registers for 32-bit scalar values.

2014-06-23 Thread James Greenhalgh
On Mon, Jun 23, 2014 at 01:53:28PM +0100, Kyrill Tkachov wrote: > On 19/06/14 14:12, James Greenhalgh wrote: > > diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md > > >index > > >266d7873a5a1b8dbb7f955c3f13cf370920a9c4a..7c5b5a566ebfd907b83b38eed2e214738e7e9bd4 > > > 10064

Re: [PATCH] Fix 61565 -- cmpelim vs non-call exceptions

2014-06-23 Thread Ramana Radhakrishnan
On 23/06/14 15:01, Richard Henderson wrote: On 06/23/2014 02:29 AM, Ramana Radhakrishnan wrote: On 20/06/14 21:28, Richard Henderson wrote: There aren't too many users of the cmpelim pass, and previously they were all small embedded targets without an FPU. I'm a bit surprised that Ramana d

Re: calloc = malloc + memset

2014-06-23 Thread Marc Glisse
On Mon, 23 Jun 2014, Jakub Jelinek wrote: Ok for trunk, sorry for the delay. Thanks. Richard has moved the passes a bit since then, but I still have exactly one spot where the testsuite is ok :-) I need strlen to be after dom (for calloc.C) and before vrp (for several strlenopt-*.c). I'll co

[Patch, AArch64] Restructure arm_neon.h vector types' implementation.

2014-06-23 Thread Tejas Belagod
Hi, Here is a patch that restructures neon builtins to use vector types based on standard base types. We previously defined arm_neon.h's neon vector types(int8x8_t) using gcc's front-end vector extensions. We now move away from that and use types built internally(e.g. __Int8x8_t). These inter

PR61583, stage2 and stage3 compare failure due to value range loss

2014-06-23 Thread Alan Modra
This fixes a bootstrap compare failure on current mainline and 4.9 branch configured with --disable-checking, caused by losing value range info when outputting debug info. Lack of value range info leads to loop bounds not being calculated, which in turn means a "j < n" test is not converted to "j

Re: [C++ Patch] PR 33101

2014-06-23 Thread Jason Merrill
On 06/22/2014 10:42 AM, Paolo Carlini wrote: I think the below would be most of it. Today, however, I did some archeology, noticed that we would essentially revert to pre-PR9278 behavior (thus, per its audit trail, make again unhappy some people in the template metaprogramming world?!? Was that k

Link not working on www.mail-archive.com

2014-06-23 Thread Lisa
Looks like there is a broken link on http://www.mail-archive.com/ftikumt2001@yahoogroups.com/msg00234.html to http://www.cs.cmu.edu/books.html. You might also want to add some of these resources I found useful... http://online.sju.edu/resource/engineering-technology/trends-in-instructional-desi

[PATCH] gcc: fix segfault from calling free on non-malloc'd area

2014-06-23 Thread Paul Gortmaker
We see the following on a 32bit gcc installed on 64 bit host: Reading symbols from ./i586-pokymllib32-linux-gcc...done. (gdb) run Starting program: x86-pokymllib32-linux/lib32-gcc/4.9.0-r0/image/usr/bin/i586-pokymllib32-linux-gcc Program received signal SIGSEGV, Segmentation fault. 0xf

Re: [Patch ARM/testsuite 00/22] Neon intrinsics executable tests

2014-06-23 Thread Christophe Lyon
On 11 June 2014 00:03, Ramana Radhakrishnan wrote: > On Thu, Jun 5, 2014 at 11:04 PM, Christophe Lyon > wrote: >> This is patch series is a more complete version of the patch I sent >> some time ago: >> https://gcc.gnu.org/ml/gcc-patches/2013-10/msg00624.html >> >> I have created a series of patc

Re: [C/C++ PATCH] Add -Wlogical-not-parentheses (PR c/49706)

2014-06-23 Thread Joseph S. Myers
On Mon, 23 Jun 2014, Marek Polacek wrote: > I think the latter is better, incidentally, g++ doesn't warn either. > The following one liner makes cc1 behave as cc1plus. Thanks for the > report. > > Regtested/bootstrapped on x86_64. Joseph, is this ok? > > 2014-06-23 Marek Polacek > >

Re: [PATCH] Fix arrays in rtx.u + add minor rtx verification

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 4:25 PM, Richard Henderson wrote: > On 06/20/2014 01:42 PM, Marek Polacek wrote: >> 2014-06-20 Marek Polacek >> >> * genpreds.c (verify_rtx_codes): New function. >> (main): Call it. >> * rtl.h (RTX_FLD_WIDTH, RTX_HWINT_WIDTH): Define. >> (struct r

[PATCH] Don't segv on __atomic_store (PR c/61553)

2014-06-23 Thread Marek Polacek
We ICEd on the following testcase since the void type has a NULL TYPE_SIZE_UNIT. I took Andrew's patch from gcc@ ML and added a testcase. Regtested/bootstrapped on x86_64-linux, ok for trunk? 2014-06-23 Marek Polacek Andrew MacLeod PR c/61553 * c-common.c (get_a

Re: [GSoC][match-and-simplify] mark some more operators as commutative

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 4:23 PM, Marc Glisse wrote: > On Mon, 23 Jun 2014, Richard Biener wrote: > >> On Mon, Jun 23, 2014 at 3:32 PM, Prathamesh Kulkarni >> wrote: >>> >>> * match.pd: Mark operators in some bitwise and plus-minus >>> patterns to be commutative. >> >> >> /* A - (A +- B) -> -+ B *

Re: [GSoC][match-and-simplify] Remove gen_gimple_match_fail

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 3:43 PM, Prathamesh Kulkarni wrote: > * genmatch.c (gen_gimple_match_fail): Remove. > (expr::gen_gimple_transform): Remove call to gen_gimple_match_fail. > Change fprintf (f, "if (!res)") to fprintf (f, "if (!res) return > false;\n") Thanks, committed. Richard. >

Re: [patch i386]: Combine memory and indirect jump

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 4:13 PM, Richard Henderson wrote: > On 06/20/2014 02:59 PM, Kai Tietz wrote: >> So I suggest following change of passes.def: >> >> Index: passes.def >> === >> --- passes.def (Revision 211850) >> +++ passes.def

[AArch64] Implement some vca*_f[32,64] intrinsics

2014-06-23 Thread Kyrill Tkachov
Hi all, This patch implements some absolute compare intrinsics in arm_neon.h. Execution tests are added. Tested aarch64-none-elf, aarch64_be-none-elf, bootstrapped on aarch64 linux Ok for trunk? 2014-06-23 Kyrylo Tkachov * config/aarch64/arm_neon.h (vcage_f64): New intrinsic. (vcag

RE: [PATCH] Fix forwporp pattern (T)(P + A) - (T)P -> (T)A

2014-06-23 Thread Bernd Edlinger
Hi, On Mon, 23 Jun 2014 10:40:53, Richard Biener wrote: > > On Sun, Jun 22, 2014 at 9:14 AM, Bernd Edlinger > wrote: >> Hi, >> >> I noticed that several testcases in the GMP-4.3.2 test suite are failing now >> which >> did not happen with GCC 4.9.0. I debugged the first one, mpz/convert, and >>

Re: [PATCH] Fix forwporp pattern (T)(P + A) - (T)P -> (T)A

2014-06-23 Thread Eric Botcazou
> I noticed that several testcases in the GMP-4.3.2 test suite are failing now > which did not happen with GCC 4.9.0. I debugged the first one, > mpz/convert, and found the file mpn/generic/get_str.c was miscompiled. > > mpn/get_str.c.132t.dse2: > pretmp_183 = (sizetype) chars_per_limb_80; >

Re: [PATCH] Fix arrays in rtx.u + add minor rtx verification

2014-06-23 Thread Richard Henderson
On 06/20/2014 01:42 PM, Marek Polacek wrote: > 2014-06-20 Marek Polacek > > * genpreds.c (verify_rtx_codes): New function. > (main): Call it. > * rtl.h (RTX_FLD_WIDTH, RTX_HWINT_WIDTH): Define. > (struct rtx_def): Use them. Looks pretty good. Just a few nits. > +stati

Re: [GSoC][match-and-simplify] mark some more operators as commutative

2014-06-23 Thread Marc Glisse
On Mon, 23 Jun 2014, Richard Biener wrote: On Mon, Jun 23, 2014 at 3:32 PM, Prathamesh Kulkarni wrote: * match.pd: Mark operators in some bitwise and plus-minus patterns to be commutative. /* A - (A +- B) -> -+ B */ (match_and_simplify - (minus @0 (plus @0 @1)) + (minus @0 (plus:c @0 @1))

Re: [patch i386]: Combine memory and indirect jump

2014-06-23 Thread Richard Henderson
On 06/20/2014 02:59 PM, Kai Tietz wrote: > So I suggest following change of passes.def: > > Index: passes.def > === > --- passes.def (Revision 211850) > +++ passes.def (Arbeitskopie) > @@ -384,7 +384,6 @@ along with GCC; see the fil

Re: [GSoC][match-and-simplify] mark some more operators as commutative

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 3:32 PM, Prathamesh Kulkarni wrote: > * match.pd: Mark operators in some bitwise and plus-minus > patterns to be commutative. /* A - (A +- B) -> -+ B */ (match_and_simplify - (minus @0 (plus @0 @1)) + (minus @0 (plus:c @0 @1)) (negate @0)) seems pointless /* ~x &

Re: [PATCH] Fix 61565 -- cmpelim vs non-call exceptions

2014-06-23 Thread Richard Henderson
On 06/23/2014 02:29 AM, Ramana Radhakrishnan wrote: > > > On 20/06/14 21:28, Richard Henderson wrote: >> There aren't too many users of the cmpelim pass, and previously they were all >> small embedded targets without an FPU. >> >> I'm a bit surprised that Ramana decided to enable this pass for aa

[GSoC][match-and-simplify] Remove gen_gimple_match_fail

2014-06-23 Thread Prathamesh Kulkarni
* genmatch.c (gen_gimple_match_fail): Remove. (expr::gen_gimple_transform): Remove call to gen_gimple_match_fail. Change fprintf (f, "if (!res)") to fprintf (f, "if (!res) return false;\n") Thanks and Regards, Prathamesh Index: gcc/genmatch.c =

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-06-23 Thread Roman Gareev
> It seems the patch1/patch2 files you attach have the Content-Type: > application/octet-stream. This makes it impossible to view them inline. > Could you send them as text files? Just calling them patch1.patch or > patch1.txt should make this work. Yes, sure. diff --git a/gcc/graphite-clast-to-gi

RE: [PATCH] Change default for --param allow-...-data-races to off

2014-06-23 Thread Bernd Edlinger
Hi Martin, >> >> Well actually, I am not sure if we ever wanted to have a race condition here. >> Have you seen any impact of --param allow-store-data-races on any benchmark? > > It's trivially to write one. The only pass that checks the param is > tree loop invariant motion and it does that when

[GSoC][match-and-simplify] mark some more operators as commutative

2014-06-23 Thread Prathamesh Kulkarni
* match.pd: Mark operators in some bitwise and plus-minus patterns to be commutative. Thanks and Regards, Prathamesh Index: gcc/match.pd === --- gcc/match.pd (revision 211893) +++ gcc/match.pd (working copy) @@ -138,7 +138,7 @@ along

[PATCH][match-and-simplify] Remove now dead code

2014-06-23 Thread Richard Biener
This removes the non-DT matching code. Committed. Richard. 2014-06-23 Richard Biener * genmatch.c (operand::gen_gimple_match): Remove. (predicate::gen_gimple_match): Likewise. (expr::gen_gimple_match): Likewise. (c_expr::gen_gimple_match): Likewise. (

Re: [AArch64] Implement ADD in vector registers for 32-bit scalar values.

2014-06-23 Thread Kyrill Tkachov
Hi James, On 19/06/14 14:12, James Greenhalgh wrote: diff --git a/gcc/config/aarch64/aarch64.md b/gcc/config/aarch64/aarch64.md >index 266d7873a5a1b8dbb7f955c3f13cf370920a9c4a..7c5b5a566ebfd907b83b38eed2e214738e7e9bd4 100644 >--- a/gcc/config/aarch64/aarch64.md >+++ b/gcc/config/aarch64/aarch

Re: [GSoC] Addition of ISL AST generation to Graphite

2014-06-23 Thread Roman Gareev
Thank you for the review! -- Cheers, Roman Gareev ChangeLog_entry1 Description: Binary data ChangeLog_entry2 Description: Binary data patch1 Description: Binary data patch2 Description: Binary data

Re: [PATCH, PR 61540] Do not ICE on impossible devirtualization

2014-06-23 Thread James Greenhalgh
On Thu, Jun 19, 2014 at 12:49:55PM +0100, Martin Jambor wrote: > Hi, > > On Wed, Jun 18, 2014 at 06:12:34PM +0200, Bernhard Reutner-Fischer wrote: > > On 18 June 2014 10:24:16 Martin Jambor wrote: > > > > >@@ -3002,10 +3014,8 @@ try_make_edge_direct_virtual_call (struct > > >cgraph_edge *ie, > >

Re: [RFC][ARM] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2014-06-23 Thread Jay Foad
On 2 May 2014 10:04, Kugan wrote: > Thanks for spotting it. Here is the updated patch that changes it to > ARM_FE_*. > +2014-05-02 Kugan Vivekanandarajah > + > + * config/arm/arm.c (TARGET_ATOMIC_ASSIGN_EXPAND_FENV): New define. > + (arm_builtins) : Add ARM_BUILTIN_GET_FPSCR and AR

  1   2   >