Re: [PATCH] Hoist loop invariant statements containing data refs with zero-step during loop-versioning in vectorization.

On 10/18/13 03:56, Richard Biener wrote: On Thu, 17 Oct 2013, Cong Hou wrote: I tested this case with -fno-tree-loop-im and -fno-tree-pre, and it seems that GCC could hoist j+1 outside of the i loop: t3.c:5:5: note: hoisting out of the vectorized loop: _10 = (sizetype) j_25; t3.c:5:5: note: ho

Re: [Patch] Change default executor to DFS in regex

On Fri, Oct 18, 2013 at 9:13 PM, Tim Shen wrote: > As the comment in this patch said, DFS approach is faster in simple > regex, but exponentially slower in complex(many quantifier) cases. Actually I suggest to use DFS where number of quantifiers < 2, to make this 'optimization' more conservative.

Re: [PATCH][i386]Fix PR 57756

On Thu, Oct 17, 2013 at 3:10 PM, Jakub Jelinek wrote: > On Thu, Oct 17, 2013 at 12:30:46PM -0700, Sriraman Tallam wrote: >> I checked my build again for these tests and they all pass. > > Even on x86_64-linux I can reproduce all of those with > -m32 -mno-sse. Figured out why this happens in -m32

[C11-atomic] Miscellaneous fixes 2/n

I've applied this patch to C11-atomic branch with more miscellaneous fixes. stdatomic.h had more typo fixes, and a substantive definition of kill_dependency that I hope is right (it seems to match libstdc++, and I think it matches the standard). Atomic increment and decrement are made to go throu

[Patch] Change default executor to DFS in regex

As the comment in this patch said, DFS approach is faster in simple regex, but exponentially slower in complex(many quantifier) cases. DFA optimization could be added, but I'm afraid it needs rewriting regex_automaton.*. Tested under -m32 and -m64. Thanks! -- Tim Shen a.patch Description: B

[jit] Various changes to expression-handling (API changes)

I've committed the following to dmalcolm/jit: Add unary ops. Add more binary ops. Add more comparison modes. Convert field access API from: extern gcc_jit_lvalue * gcc_jit_context_new_field_access (gcc_jit_context *ctxt, gcc_jit_location *loc,

Re: Fwd: [PATCH] Add gdb/gdb-index.h to gcc tree.

I'm not sure either, but if it's been approved in gdb and you're willing to cede control of it to gcc's policies, I'm OK with it. Note that this will be a new directory in gcc, and I think the automerge scripts will automatically pick it up. Which means, after committing it, any future changes m

Re: [PATCH][i386]Fix PR 57756

On Thu, Oct 17, 2013 at 7:47 PM, Sriraman Tallam wrote: > On Thu, Oct 17, 2013 at 4:51 PM, Sriraman Tallam wrote: >> On Thu, Oct 17, 2013 at 3:08 PM, Sriraman Tallam wrote: >>> On Thu, Oct 17, 2013 at 1:23 PM, Mike Stump wrote: On Oct 17, 2013, at 10:23 AM, Sriraman Tallam wrote: >> Y

Fwd: [PATCH] Add gdb/gdb-index.h to gcc tree.

DJ, Is the below patch your purview? If not, do you know whose it is? Sterling -- Forwarded message -- From: Sterling Augustine Date: Thu, Oct 17, 2013 at 11:52 AM Subject: [PATCH] Add gdb/gdb-index.h to gcc tree. To: gcc-patches , d...@redhat.com The enclosed patch to "merge

Re: [RFC] Isolate & simplify paths with undefined behaviour

On 10/18/13 15:15, Marc Glisse wrote: On Fri, 18 Oct 2013, Jeff Law wrote: On 10/18/13 14:31, Marc Glisse wrote: But once you have that pointer defined by a PHI containing a zero, you look at all its uses, trying to find one that proves the pointer is non-zero What are you going to do with t

Re: [C11-atomic] Miscellaneous fixes 1/n

On 10/18/2013 04:40 PM, Joseph S. Myers wrote: On Fri, 18 Oct 2013, Andrew MacLeod wrote: I had thought about making the type and value of atomic_flag hooks , but never got to it. There is currently one for the TRUE value which is exposed to the C++ templates as" __GCC_ATOMIC_TEST_AND_SET_TRUE

Re: [PATCH] decide edge's hotness when there is profile info

> Here is the patch updated to use the new parameter from r203830. > Passed bootstrap and regression tests. > > 2013-10-18 Jan Hubicka > Teresa Johnson > > * predict.c (handle_missing_profiles): New function. > (counts_to_freqs): Don't overwrite estimated frequenc

Re: [RFC] Isolate & simplify paths with undefined behaviour

On Fri, 18 Oct 2013, Jeff Law wrote: On 10/18/13 14:31, Marc Glisse wrote: But once you have that pointer defined by a PHI containing a zero, you look at all its uses, trying to find one that proves the pointer is non-zero What are you going to do with that information? Uh? I must have been

RE: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C (and C++)

Hi Jeff, Please see my comments below. Also, I am adding all these changes to the files as you requested in my local directory. Should I send you an updated patch along the way? Thanks, Balaji V. Iyer. > -Original Message- > From: Jeff Law [mailto:l...@redhat.com] > Sent: Thurs

Re: [wide-int] int_traits

On Fri, Oct 18, 2013 at 01:52:54PM -0700, Mike Stump wrote: > On Oct 18, 2013, at 6:11 AM, Kenneth Zadeck wrote: > >>> Does this look ok? Kenny, can you double check the cases, think I have > >>> them right, but? a double check would be good. > >> That works for me. > >> > > i talked to mike a

Re: [RFC] Isolate & simplify paths with undefined behaviour

On 10/18/13 14:31, Marc Glisse wrote: But once you have that pointer defined by a PHI containing a zero, you look at all its uses, trying to find one that proves the pointer is non-zero What are you going to do with that information? The only use I can see for this pass would be discovering mo

Re: [wide-int] int_traits

On Oct 18, 2013, at 6:11 AM, Kenneth Zadeck wrote: >>> Does this look ok? Kenny, can you double check the cases, think I have >>> them right, but? a double check would be good. >> That works for me. >> > i talked to mike about this last night, but did not follow up with an email > until now.

Re: [C11-atomic] Miscellaneous fixes 1/n

On Fri, 18 Oct 2013, Andrew MacLeod wrote: > I had thought about making the type and value of atomic_flag hooks , but never > got to it. There is currently one for the TRUE value which is exposed to the > C++ templates as" __GCC_ATOMIC_TEST_AND_SET_TRUEVAL" I'm tending to think of this, and alig

Re: [PATCH] decide edge's hotness when there is profile info

Here is the patch updated to use the new parameter from r203830. Passed bootstrap and regression tests. 2013-10-18 Jan Hubicka Teresa Johnson * predict.c (handle_missing_profiles): New function. (counts_to_freqs): Don't overwrite estimated frequencies when

Re: [RFC] Isolate & simplify paths with undefined behaviour

On Fri, 18 Oct 2013, Jeff Law wrote: On 10/18/13 12:47, Marc Glisse wrote: * tree-vrp has a function infer_nonnull_range, do you think we could share it? We now store the VRP ranges for integers, but not for pointers. If we did (or maybe just a non-null bit), the pass could just test that bit o

Re: [PATCH][RFC] fix reload causing ICE in subreg_get_info on m68k (PR58369)

Jeff Law writes: > On 09/28/13 09:30, Mikael Pettersson wrote: > > This patch fixes PR58369, an ICE in subreg_get_info when compiling > > boost for m68k-linux. > > > > choose_reload_regs attempts to reload a DFmode (8-byte) reg, finds > > an XFmode (12-byte) reg in "last_reg", and calls subre

Re: [patch 8/8] cfgloop.h includes basic-block.h

On 10/18/2013 12:06 PM, Jeff Law wrote: On 10/18/13 07:45, Andrew MacLeod wrote: bootstraps on x86_64-unknown-linux-gnu with no new regressions. OK? OK. jeff All 8 patches were committed at once, revision 203833. I'll submit another patch if any recommended followups surface. Andrew

Re: [RFC] Isolate & simplify paths with undefined behaviour

On 10/18/13 12:47, Marc Glisse wrote: Maybe a new -fretroactive-undefined-behavior? (for later, obviously) Something like that -- haven't thought much about the name. * should cfg_altered be static (or a member of the pass class)? At the minimum it should be static. Into the pass class woul

Re: [PATCH][i386]Fix PR 57756

> I see why pr57756.c could fail, if -msse4.2 is turned on by default. I > think this test needs {dg-options "-mno-sse4.2"}. This change allows the test to pass. The failure of gcc.target/i386/funcspec-5.c is /opt/gcc/work/gcc/testsuite/gcc.target/i386/funcspec-5.c:34:1: warning: SSE instructio

Re: [patch 1/8] Remove gimple-low.h from the tree-ssa.h include list.

On 10/18/2013 12:10 PM, Jeff Law wrote: On 10/18/13 07:37, Andrew MacLeod wrote: gimple_check_call_matching_types() was being called from 3 or 4 different files,and seemed more appropriate as a cgraph routine (which called it 3 times). So I moved that and its helper to cgraph.c. After that, I

[C++ Patch] PR 58607

Hi, this 4.9 Regression is just and ICE on invalid, but I think it points to a (minor) matter or principle: the body of a constexpr constructor may have, possibly nested, BIND_EXPRs, but in any case there should be no BIND_EXPR_VARS (for this specific testcase the VAR_DECL has the TREE_TYPE =

Re: [RFC] Isolate & simplify paths with undefined behaviour

On Fri, 18 Oct 2013, Jeff Law wrote: Back in 2011 I wrote code to detect cases when traversing a particular path could be proven to trigger undefined behaviour (such as a null pointer dereference). That original patch would find the control dependent edges leading to the dereference and elimi

Re: [patch 4/8] Remove tree-ssa-dom.h from the tree-ssa.h include list.

On 10/18/2013 11:59 AM, Jeff Law wrote: On 10/18/13 07:39, Andrew MacLeod wrote: degenerate_phi_result was defined in tree-ssa-dom.c, I moved it to tree-phinodes since all it does is determine whether the arguements of the phi which are not the same as the result are all the same. This reduced b

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 2/2

> What I would suggest is to have a -fgnu-strict-volatile-bit-fields Why a new option? The -fstrict-volatile-bitfields option is already GCC-specific, and I think it can do what you want anyway.

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 2/2

> We use the container mode where possible. > It is always possible for well-formed bit-fields. This is the only part I really need. > If necessary the user has to add anonymous bit field members, or > convert normal members to bit-fields. IIRC I added code to support normal members as well, th

Re: [PATCH] Do not append " *INTERNAL* " to the decl name

On Fri, Oct 18, 2013 at 10:39 AM, Jason Merrill wrote: > On 10/11/2013 01:59 PM, Dehao Chen wrote: >> >> It's hard to get a testcase without >> http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=201856 because >> none of these *INTERNAL* symbols will be emitted in debug info. > > > Why does tha

Re: [C11-atomic] Miscellaneous fixes 1/n

On 10/18/2013 01:27 PM, Joseph S. Myers wrote: On Fri, 18 Oct 2013, Andrew MacLeod wrote: right. We may re-visit it when we finalize the ABI changes for c++... Use of the attribute in c++ will ensure that C and C++ both treat an atomic object the same... My original discussions with lawrence

Re: [PATCH] Do not append " *INTERNAL* " to the decl name

On 10/11/2013 01:59 PM, Dehao Chen wrote: It's hard to get a testcase without http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=201856 because none of these *INTERNAL* symbols will be emitted in debug info. Why does that change cause one of these symbols to be emitted? As Cary says, that

Re: [PATCH][i386]Fix PR 57756

On Fri, Oct 18, 2013 at 10:27 AM, Sriraman Tallam wrote: > On Fri, Oct 18, 2013 at 3:03 AM, Dominique Dhumieres > wrote: >> Sriraman, >> >> The tests gcc.target/i386/funcspec-5.c and gcc.target/i386/pr57756.c fail >> on targets for which -msse is the default (see >> http://gcc.gnu.org/ml/gcc-tes

Re: [C++ Patch] PR 58466

OK. Jason

Re: Teaching emacs about GCC coding conventions (was Re: [PATCH] tree_code_name wrapper)

On Oct 18, 2013, at 6:36 AM, David Malcolm wrote: > Thanks everyone; I'm finding this very helpful. Thanks for the feedback and making enough noise such that we fixed the problem. :-)

Re: [C11-atomic] Miscellaneous fixes 1/n

On Fri, 18 Oct 2013, Andrew MacLeod wrote: > right. We may re-visit it when we finalize the ABI changes for c++... Use of > the attribute in c++ will ensure that C and C++ both treat an atomic object > the same... My original discussions with lawrence and jeffrey over atomics > concerned the de

Re: [PATCH][i386]Fix PR 57756

On Fri, Oct 18, 2013 at 3:03 AM, Dominique Dhumieres wrote: > Sriraman, > > The tests gcc.target/i386/funcspec-5.c and gcc.target/i386/pr57756.c fail > on targets for which -msse is the default (see > http://gcc.gnu.org/ml/gcc-testresults/2013-10/msg01365.html or > http://gcc.gnu.org/ml/gcc-testre

[RFC] Isolate & simplify paths with undefined behaviour

Back in 2011 I wrote code to detect cases when traversing a particular path could be proven to trigger undefined behaviour (such as a null pointer dereference). That original patch would find the control dependent edges leading to the dereference and eliminate those edges. The result being

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

On Oct 18, 2013, at 4:24 AM, Richard Biener wrote: > I agree. Btw, the "implementation defined" precision of PDI on SH-5 > definitely > looks interesting, but I wonder how you can perform "implementation defined" > arithmetic on that PDI mode then ;) Easy, perform it in the maximal size support

Re: [C11-atomic] Miscellaneous fixes 1/n

On 10/17/2013 05:50 PM, Joseph S. Myers wrote: I've applied this patch to the C11-atomic branch to fix various miscellaneous issues. excellent! I put a hack in the C++ front end to disable checks on atomic qualifiers so that libstdc++ builds - I think that if you want other people to help on

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 1/2

Sandra Loosemore wrote: >On 10/18/2013 04:50 AM, Richard Biener wrote: >> On Sat, Sep 28, 2013 at 4:19 AM, Sandra Loosemore >> wrote: >>> This patch fixes various -fstrict-volatile-bitfields wrong-code >bugs, >>> including instances where bitfield values were being quietly >truncated as >>> well

Re: [patch 6/8] Remove sbitmap.h from the tree-ssa.h include list.

On 10/18/13 07:41, Andrew MacLeod wrote: Also straightforward. includes sbitmap in the 5 files that need it. I also happened to notice that tree-switch-conversion.c was including tree-ssa-operands.h directly, and doesnt need it, so removed it too bootstraps on x86_64-unknown-linux-gnu with no ne

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 1/2

On 10/18/2013 04:50 AM, Richard Biener wrote: On Sat, Sep 28, 2013 at 4:19 AM, Sandra Loosemore wrote: This patch fixes various -fstrict-volatile-bitfields wrong-code bugs, including instances where bitfield values were being quietly truncated as well as bugs relating to using the wrong width.

Re: [Patch] Fix wide char locale support(like CJK charset) in regex

On Fri, Oct 18, 2013 at 5:39 AM, Paolo Carlini wrote: >>Oops that's only perfect Chinese version of "hello, world" under UTF-8 >>charset. Now it's hex format. >> >>I also make the char handling simpler. > > Great, thanks! -m32 and -m64 tested and committed. By the way, UTF-8 *encoding* is a more

[c++-concepts] Bugfix

Fixing 2 issues. A test for __is_convertible_to was missing in diagnose_trait, and *somehow* the logic for determining constraint ordering w.r.t. requires expressions was missing. Committed in 203826. 2013-10-16 Andrew Sutton * gcc/cp/logic.cc (left_requires), (decompose_left): Add

Re: [patch 1/8] Remove gimple-low.h from the tree-ssa.h include list.

On 10/18/13 07:37, Andrew MacLeod wrote: gimple_check_call_matching_types() was being called from 3 or 4 different files,and seemed more appropriate as a cgraph routine (which called it 3 times). So I moved that and its helper to cgraph.c. After that, I only needed to update 4 .c files to direc

Re: [patch 8/8] cfgloop.h includes basic-block.h

On 10/18/13 07:45, Andrew MacLeod wrote: Another basoc-block inclusion. cfgloop.h was including basic-block.h, which meant lots of other things were getting it from here too. The only routine in cfgloop.h which uses anything from basic-block.h was bb_loop_depth(). By moving that to cfgloop.c,

Re: [PATCH][ARM] New rtx costs table for Cortex A9

On 17/10/13 18:00, Kyrill Tkachov wrote: > Hi all, > > This patch adds the rtx costs table for the Cortex-A9 core. > An arm-none-eabi regression run tuned for A9 succeeded. > This costs tabled showed a slight improvement on some popular benchmarks and > no > performance regressions on others aga

Re: [patch 7/8] Remove basic-block.h from cgraph.h

On 10/18/13 07:43, Andrew MacLeod wrote: I also happened to notice that basic-block.h was being included directly by cgraph.h. The only thing cgraph.h and most of what use it need are the typedefs for gcov_type: typedef HOST_WIDEST_INT gcov_type; typedef unsigned HOST_WIDEST_INT gcov_type_unsig

[jit] Improvements to error-handling

Committed to dmalcolm/jit: Add defensive checks at the API boundary to gracefully reject various kinds of error. gcc/jit/ * internal-api.c (gcc::jit::context::get_type): Improve error message, and report the bogus value. (gcc::jit::context::new_binary_op): Likewise.

Re: [patch 5/8] Remove tree-cfgcleanup.h from the tree-ssa.h include list.

On 10/18/13 07:40, Andrew MacLeod wrote: This was slightly more interesting. I moved the cleanup_cfg_post_optimizing pass from tree-optimize.c to tree-cfgcleanup.c. And that left tree-optimize.c empty... so I deleted that file as well. Other than that, just include it in the other 7 files that

Re: [patch 2/8] Remove tree-ssa-address.h from the tree-ssa.h include list.

On 10/18/13 07:38, Andrew MacLeod wrote: This patch just does the direct thing.. included the file where it was needed (7 .c files) I was tempted to move copy_ref_info() to a different file... its actually the only routine in this file which is SSA based... and rename the file tree-address.[ch]

Re: [PATCH] Add debug counter to jump threading code

On 10/18/13 09:50, Jeff Law wrote: I was debugging a failure yesterday in the jump threading code that was best narrowed down with a debug counter. No sense in keeping that in my local tree. While adding the new #include, I saw a couple #includes that clearly didn't belong, so I zapped them.

Re: [patch 4/8] Remove tree-ssa-dom.h from the tree-ssa.h include list.

On 10/18/13 07:39, Andrew MacLeod wrote: degenerate_phi_result was defined in tree-ssa-dom.c, I moved it to tree-phinodes since all it does is determine whether the arguements of the phi which are not the same as the result are all the same. This reduced by half the number fo files which required

Re: [patch 3/8] Remove tree-ssa-threadedge.h from the tree-ssa.h include list.

On 10/18/13 07:38, Andrew MacLeod wrote: Straightforward. Just include tree-ssa-threadedge in the 4 .c files that need it. bootstraps on x86_64-unknown-linux-gnu with no new regressions. OK? OK. Jeff

[PATCH] Add debug counter to jump threading code

I was debugging a failure yesterday in the jump threading code that was best narrowed down with a debug counter. No sense in keeping that in my local tree. While adding the new #include, I saw a couple #includes that clearly didn't belong, so I zapped them. Bootstrapped and regression tes

Re: [PATCH]Fix computation of offset in ivopt

Hi Richard, Is the first patch OK? Since there is a patch depending on it. http://gcc.gnu.org/ml/gcc-patches/2013-09/msg01931.html Thanks. bin On Fri, Oct 18, 2013 at 7:18 PM, Richard Biener wrote: > On Thu, Oct 17, 2013 at 7:52 AM, bin.cheng wrote: >> Hi, >> As noted in previous messages, GCC

Re: Add predefined macros for library use in defining __STDC_IEC_559*

Note that the associated glibc patch is now approved, pending the GCC one. -- Joseph S. Myers jos...@codesourcery.com

Re: [GOOGLE] Add flag to enalbe AutoFDO accurate mode

ok. David On Tue, Oct 15, 2013 at 10:58 AM, Dehao Chen wrote: > This patch add a new flag to let user to tell compiler that the > AutoFDO profile is accurate. So the compiler will assume function > without any sample is UNLIKELY_EXECUTED. This could save 10%~20% text > section size. > > Bootstra

Re: [PATCH] PR58669: does not detect all cpu cores/threads

On 18 October 2013 03:27, Tom Tromey wrote: >> "Andrew" == Andrew writes: > > Andrew> +#ifdef HAVE_UNISTD_H > Andrew> + procs = sysconf(_SC_NPROCESSORS_ONLN); > Andrew> +#endif > > Space before the "(". > > Technically you should probably check for sysconf in configure.ac. > I'm not sure wh

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

On 10/18/13 03:53, Richard Biener wrote: I think we want a "proper" predicate in tree-cfg.c for this, like maybe a subset of tree_forwarder_block_p or whatever it will end up looking like (we need "effectively empty BB" elsewhere, for example in vectorization, add a flag to allow a condition end

Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion

On Fri, 18 Oct 2013, Joshua J Cogliati wrote: > This patch does not change any of the non-commented c and c++ code. > It changes the dg comments. > Example: > - fsi (3.1f); /* { dg-warning "conversion" } */ > + fsi (3.1f); /* { dg-warning "float-conversion" } */ > > If you want I can change it

Re: [Patch tree-ssa] RFC: Enable path threading for control variables (PR tree-optimization/54742).

On 10/18/13 05:05, James Greenhalgh wrote: On Fri, Oct 18, 2013 at 11:55:08AM +0100, Richard Biener wrote: I suppose with Jeffs recent work on jump-threading through paths this case in handled and the patch in this thread is obsolete or can be reworked? Yes, this patch is now obsolete, Jeff's

Re: patch to enable LRA for ppc

On Thu, Oct 3, 2013 at 5:02 PM, Vladimir Makarov wrote: > The following patch permits today trunk to use LRA for ppc by default. > To switch it off -mno-lra can be used. > > The patch was bootstrapped on ppc64. GCC testsuite does not have > regressions too (in comparison with reload). The change

Re: [Patch tree-ssa] RFC: Enable path threading for control variables (PR tree-optimization/54742).

On 10/18/13 04:55, Richard Biener wrote: On Fri, Jun 21, 2013 at 11:21 PM, Steve Ellcey wrote: On Fri, 2013-06-21 at 17:43 +0100, James Greenhalgh wrote: So to my mind, this is all far too tied up in pass ordering details to resolve. Given that all the threading opportunities for my patch are

Re: [patch] Rename tree-flow.h to tree-cfg.h.

On 10/17/2013 08:48 PM, Andrew MacLeod wrote: rs6000 and alpha were including tree-flow.h in their config/target.c file. I built stage 1 for each target as a cross compiler to confirm builds dont break due to something unresolved. rs6000.c no longer needed it, alpha needs num_ssa_names, so i

Re: [Ping] Re: [C++ Patch] Tidy a bit cp_parser_lookup_name

On 10/18/2013 03:57 PM, Jason Merrill wrote: OK. I thought I had already approved this, but apparently not. Thanks, applied. Can I also ask you to follow up to this exchange which remained hanging? http://gcc.gnu.org/ml/gcc-patches/2013-10/msg00827.html Thanks in advance! Paolo.

Re: [Patch] Handle profile counts truncated to 0 in coldness test

> > As noted above, the change to avoid the RDIV by runs decreases the > effect of the min_run_ratio (now unlikely_count_fraction) in half. So > we really need to increase this parameter to 32 to compare to what the > old version of the code was doing. > > Indeed, using 32 does fix the same set o

Re: [PATCH] Fix profile count updates during tail merging

> On Tue, Oct 15, 2013 at 2:05 PM, Jan Hubicka wrote: > >> This patch fixes a profile count insanity introduced by ssa tail > >> merging. When replacing bb1 with bb2, which has the same successors, > >> the bb counts were being merged, but the successor edge weights > >> were not. > >> > >> Bootst

Re: [PATCH] Fix profile count updates during tail merging

On Tue, Oct 15, 2013 at 2:05 PM, Jan Hubicka wrote: >> This patch fixes a profile count insanity introduced by ssa tail >> merging. When replacing bb1 with bb2, which has the same successors, >> the bb counts were being merged, but the successor edge weights >> were not. >> >> Bootstrapped and tes

Re: [Ping] Re: [C++ Patch] Tidy a bit cp_parser_lookup_name

OK. I thought I had already approved this, but apparently not. Jason

Re: [PATCH, rs6000] Don't convert a vector constant load into a splat illegally

Just a quick note that overnight testing of the posted patch was clean. Recap: There are three options on the table: - the posted patch - that patch with the (1 - start) change - replace nunits - 1 with nunits as the loop upper bound I'm happy to implement any of them, as you prefer. I lean t

Re: [RFC] By default if-convert only basic blocks that will be vectorized (take 2)

On Fri, Oct 18, 2013 at 05:45:15PM +0400, Sergey Ostanevich wrote: > failed on 403 of '06: > regclass.c: In function 'init_reg_sets': > regclass.c:277:1: internal compiler error: tree check: expected > ssa_name, have var_decl in copy_ssa_name_fn, at tree-ssanames.c:393 > init_reg_sets () > ^ Yea

[patch 8/8] cfgloop.h includes basic-block.h

Another basoc-block inclusion. cfgloop.h was including basic-block.h, which meant lots of other things were getting it from here too. The only routine in cfgloop.h which uses anything from basic-block.h was bb_loop_depth(). By moving that to cfgloop.c, its no longer required by the .h file.

Re: [RFC] By default if-convert only basic blocks that will be vectorized (take 2)

failed on 403 of '06: regclass.c: In function 'init_reg_sets': regclass.c:277:1: internal compiler error: tree check: expected ssa_name, have var_decl in copy_ssa_name_fn, at tree-ssanames.c:393 init_reg_sets () ^ 0xb74124 tree_check_failed(tree_node const*, char const*, int, char const*, ...)

[patch 7/8] Remove basic-block.h from cgraph.h

I also happened to notice that basic-block.h was being included directly by cgraph.h. The only thing cgraph.h and most of what use it need are the typedefs for gcov_type: typedef HOST_WIDEST_INT gcov_type; typedef unsigned HOST_WIDEST_INT gcov_type_unsigned; This patch moves gcov_type and gco

[patch 6/8] Remove sbitmap.h from the tree-ssa.h include list.

Also straightforward. includes sbitmap in the 5 files that need it. I also happened to notice that tree-switch-conversion.c was including tree-ssa-operands.h directly, and doesnt need it, so removed it too bootstraps on x86_64-unknown-linux-gnu with no new regressions. OK? Andrew * tree-swi

[patch 5/8] Remove tree-cfgcleanup.h from the tree-ssa.h include list.

This was slightly more interesting. I moved the cleanup_cfg_post_optimizing pass from tree-optimize.c to tree-cfgcleanup.c. And that left tree-optimize.c empty... so I deleted that file as well. Other than that, just include it in the other 7 files that require it bootstraps on x86_64-unkno

[patch 4/8] Remove tree-ssa-dom.h from the tree-ssa.h include list.

degenerate_phi_result was defined in tree-ssa-dom.c, I moved it to tree-phinodes since all it does is determine whether the arguements of the phi which are not the same as the result are all the same. This reduced by half the number fo files which required tree-ssa-dom.h. bootstraps on x86_64-

Re: libbacktrace patch committed (Was: Re: [jit] Update TODO.rst)

On Thu, 2013-10-17 at 21:28 -0700, Ian Lance Taylor wrote: > On Thu, Oct 17, 2013 at 8:54 PM, David Malcolm wrote: > > > > +* segfault seen in libbacktrace, when an ICE occurs > > That reminded me to commit this libbacktrace patch I worked up a > couple of weeks ago. Previously if some debug sec

[patch 3/8] Remove tree-ssa-threadedge.h from the tree-ssa.h include list.

Straightforward. Just include tree-ssa-threadedge in the 4 .c files that need it. bootstraps on x86_64-unknown-linux-gnu with no new regressions. OK? Andrew * tree-ssa.h: Don't include tree-ssa-threadedge.h. * tree-ssa-dom.c: Include tree-ssa-threadedge.h. * tree-ssa-loop-ch.c: Likewise.

[patch 2/8] Remove tree-ssa-address.h from the tree-ssa.h include list.

This patch just does the direct thing.. included the file where it was needed (7 .c files) I was tempted to move copy_ref_info() to a different file... its actually the only routine in this file which is SSA based... and rename the file tree-address.[ch]. Not sure where I'd copy it to, maybe

[patch 1/8] Remove gimple-low.h from the tree-ssa.h include list.

gimple_check_call_matching_types() was being called from 3 or 4 different files,and seemed more appropriate as a cgraph routine (which called it 3 times). So I moved that and its helper to cgraph.c. After that, I only needed to update 4 .c files to directly include gimple-low.h bootstraps

Re: Teaching emacs about GCC coding conventions (was Re: [PATCH] tree_code_name wrapper)

On Wed, 2013-10-16 at 11:32 -0700, Mike Stump wrote: > On Oct 16, 2013, at 9:26 AM, Tom Tromey wrote: > > Andreas> You could put it in .dir-locals.el, or put a hook on > > Andreas> find-file-hook that looks at buffer-file-name. > > > We checked in a .dir-locals.el for gdb. I recommend it for GCC

Re: libgo patch committed: Add system calls

On Fri, Oct 18, 2013 at 5:40 AM, Uros Bizjak wrote: > Hello! > >> This patch to libgo adds some system calls to the syscall package. >> Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. >> Committed to mainline and 4.8 branch, since these calls were in Go >> 1.1.2. > > Uros. > > Index

Re: [wide-int] int_traits

On Fri, Oct 18, 2013 at 3:13 PM, Kenneth Zadeck wrote: > Richi, > > Do you want me to back out the patch that changes the rep for unsigned > tree-csts? Not yet please. Thanks, Richard. > kenny

Re: [PATCH] Fix part of PR58712

> On Fri, Oct 18, 2013 at 12:10 PM, Markus Trippelsdorf > wrote: > > On 2013.10.15 at 12:49 +0200, Richard Biener wrote: > >> On Tue, Oct 15, 2013 at 12:31 PM, Markus Trippelsdorf > >> wrote: > >> > Valgrind complains: > >> > ==27870== Conditional jump or move depends on uninitialised value(s) >

Re: [wide-int] int_traits

Richi, Do you want me to back out the patch that changes the rep for unsigned tree-csts? kenny

Re: [wide-int] int_traits

On 10/18/2013 04:45 AM, Richard Biener wrote: On Thu, 17 Oct 2013, Mike Stump wrote: On Oct 17, 2013, at 1:46 AM, Richard Biener wrote: [This function shows another optimization issue: case BOOLEAN_TYPE: /* Cache false or true. */ limit = 2; if (wi::leu_p (cst, 1))

Re: [PATCH] Reducing number of alias checks in vectorization.

On Tue, Oct 15, 2013 at 12:43 AM, Cong Hou wrote: > Sorry for forgetting using plain-text mode. Resend it. > > > -- Forwarded message -- > From: Cong Hou > Date: Mon, Oct 14, 2013 at 3:29 PM > Subject: Re: [PATCH] Reducing number of alias checks in vectorization. > To: Richard Bie

Re: [c++-concepts] Shorthand notation

I know. When I started working on the project, Gaby asked that I keep all concept-related changes in the top-level Changelog.concepts with full paths for the file names. Andrew Sutton On Fri, Oct 18, 2013 at 8:53 AM, Paolo Carlini wrote: > Hi, > > > On 10/18/2013 02:23 PM, Andrew Sutton wrote:

Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion

On 10/14/2013 05:34 PM, Joseph S. Myers wrote: > On Mon, 14 Oct 2013, Dodji Seketeli wrote: > >>> This patch has passes the existing -Wconversion testcases. It >>> modifies Wconversion-real.c, Wconversion-real-integer.c and >>> pr35635.c to be more specific >> >> If the patch passes existing tes

Re: [c++-concepts] Shorthand notation

Hi, On 10/18/2013 02:23 PM, Andrew Sutton wrote: A small follow up change. This removes the "sorry" from concept name resolution. Committed in r203815. 2013-10-16 Andrew Sutton * gcc/cp/constraint.cc (finish_concept_name): Allow functions with the same name as concepts to r

Re: [PATCH] [ARM] Fix PR57909 : ICE with internal memcpy and -mno-unaligned-access

Ping^2 I forgot this one was still pending. On 13 August 2013 14:21, Yvan Roux wrote: > Ping. > > On 23 July 2013 16:18, Yvan Roux wrote: >> Hi, >> >> I forgot to add the test case with the PR fix, the attached patch add it. >> >> Thanks, >> Yvan >> >> ChangeLog >> >> gcc/testsuite >> >> 2013-0

Re: [PATCH] Reducing number of alias checks in vectorization.

On Wed, Oct 2, 2013 at 8:26 PM, Jakub Jelinek wrote: > On Wed, Oct 02, 2013 at 10:50:21AM -0700, Cong Hou wrote: >> >> + if (int_cst_value (p11.offset) != int_cst_value (p21.offset)) >> >> +return int_cst_value (p11.offset) < int_cst_value (p21.offset); >> > >> > This is going to ICE whenever

Re: libgo patch committed: Add system calls

Hello! > This patch to libgo adds some system calls to the syscall package. > Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. > Committed to mainline and 4.8 branch, since these calls were in Go > 1.1.2. Uros. Index: runtime/go-nosys.c =

Re: [PATCH]Fix computation of offset in ivopt

On Fri, Oct 18, 2013 at 2:26 PM, Bernd Schmidt wrote: > On 10/18/2013 02:10 PM, Richard Biener wrote: >> On Fri, Oct 18, 2013 at 2:02 PM, Bernd Schmidt >> wrote: >>> On 10/18/2013 01:18 PM, Richard Biener wrote: >>> Index: gcc/fold-const.c ==

Re: [PATCH]Fix computation of offset in ivopt

On 10/18/2013 02:10 PM, Richard Biener wrote: > On Fri, Oct 18, 2013 at 2:02 PM, Bernd Schmidt > wrote: >> On 10/18/2013 01:18 PM, Richard Biener wrote: >> >>> Index: gcc/fold-const.c >>> === >>> --- gcc/fold-const.c (revision 203267

Re: [c++-concepts] Shorthand notation

A small follow up change. This removes the "sorry" from concept name resolution. Committed in r203815. 2013-10-16 Andrew Sutton * gcc/cp/constraint.cc (finish_concept_name): Allow functions with the same name as concepts to resolve as call expressions in the usual way.

  1   2   >