RE: CR16 Port addition

2011-07-14 Thread Sumanth Gundapaneni
PING 3: For review Hi, Please review the attached patch and you can view the explanations for the earlier communication below. NOTE: From now on , Jayant (jayant.so...@kpitcummins.com) will be posting the patches related to CR16. Please feel free to contact him if you need any information r

[committed] Fix ada build on HP-UX 10.20

2011-07-14 Thread John David Anglin
The patch below fixes ada bootstrap on HP-UX 10. Patch preapproved by Eric. Tested on HP-UX 10.20. Dave -- J. David Anglin dave.ang...@nrc-cnrc.gc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6602) 2011-07-14 John David Anglin

[PATCH 5/9] dwarf2cfi: Remove dw_cfi_row_ref typedef.

2011-07-14 Thread Richard Henderson
--- gcc/dwarf2cfi.c | 23 +++ 1 files changed, 11 insertions(+), 12 deletions(-) diff --git a/gcc/dwarf2cfi.c b/gcc/dwarf2cfi.c index 745e137..51fb824 100644 --- a/gcc/dwarf2cfi.c +++ b/gcc/dwarf2cfi.c @@ -74,14 +74,13 @@ typedef struct GTY(()) dw_cfi_row_struct HOST_WIDE

[PATCH 9/9] dwarf2cfi: Generate and connect traces.

2011-07-14 Thread Richard Henderson
This kinda-sorta corresponds to Bernd's 007-dw2cfi patch. Certainly the same concepts of splitting the instruction stream into extended basic blocks is the same. This patch does a bit better job with the documentation. Also, I'm a bit more explicit about matching things up with the similar code

[PATCH 8/9] dwarf2cfi: Introduce dw_trace_info.

2011-07-14 Thread Richard Henderson
This patch only introduces the structure definition and adjusts the existing routines to use the new cur_trace global to access the variables that were moved into the structure. --- gcc/dwarf2cfi.c | 440 +-- 1 files changed, 266 insertions(+),

[RFC PATCH 0/9] CFG aware dwarf2 cfi generation

2011-07-14 Thread Richard Henderson
This finally brings us to something that can support shrink-wrapping. As mentioned in the description of the last patch, this is 95% of what Bernd had in his last 007-dw2cfg patch, except for the remember/ restore_state stuff. And hopefully with better comments. This is the first version of this

[PATCH 4/9] dwarf2cfi: Implement change_cfi_row.

2011-07-14 Thread Richard Henderson
Add a generic function to adjust cfi state from one row to another. Use this to implement text section switching. This will also be usable for arbitrary changes around a cfg for shrink-wrapping. --- gcc/dwarf2cfi.c | 376 +-- gcc/dwarf2out.c |

[PATCH 1/9] dwarf2cfi: Introduce a dw_cfi_row state.

2011-07-14 Thread Richard Henderson
Use it instead of old_cfa, old_args_size, and cfa_remember variables. Remove the global cfa variable, as it was usually a duplicate of old_cfa and otherwise confusing. Always make a local copy of the cur_row->cfa variable before modification instead. --- gcc/dwarf2cfi.c | 208 ++

[PATCH 6/9] dwarf2cfi: Convert queued_reg_save to a VEC.

2011-07-14 Thread Richard Henderson
Also, allocate it in the heap instead of garbage collected. --- gcc/dwarf2cfi.c | 51 ++- 1 files changed, 26 insertions(+), 25 deletions(-) diff --git a/gcc/dwarf2cfi.c b/gcc/dwarf2cfi.c index 51fb824..a800cb4 100644 --- a/gcc/dwarf2cfi.c +++ b/g

[PATCH 7/9] dwarf2cfi: Allocate reg_saved_in_data in the heap.

2011-07-14 Thread Richard Henderson
--- gcc/dwarf2cfi.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/gcc/dwarf2cfi.c b/gcc/dwarf2cfi.c index a800cb4..1d6413f 100644 --- a/gcc/dwarf2cfi.c +++ b/gcc/dwarf2cfi.c @@ -1109,13 +1109,13 @@ typedef struct GTY(()) reg_saved_in_data { } reg_save

[PATCH 2/9] dwarf2cfi: Rename cfi_insn to add_cfi_insn.

2011-07-14 Thread Richard Henderson
Make it consistent with add_cfi_vec. --- gcc/dwarf2cfi.c | 20 +++- 1 files changed, 11 insertions(+), 9 deletions(-) diff --git a/gcc/dwarf2cfi.c b/gcc/dwarf2cfi.c index 1c1b74f..eb59f28 100644 --- a/gcc/dwarf2cfi.c +++ b/gcc/dwarf2cfi.c @@ -86,7 +86,7 @@ static GTY(()) dw_cfi_

[PATCH 3/9] dwarf2cfi: Populate CUR_ROW->REG_SAVE.

2011-07-14 Thread Richard Henderson
To be actually used by a subsequent patch. --- gcc/dwarf2cfi.c | 27 +-- 1 files changed, 25 insertions(+), 2 deletions(-) diff --git a/gcc/dwarf2cfi.c b/gcc/dwarf2cfi.c index eb59f28..36fa7f8 100644 --- a/gcc/dwarf2cfi.c +++ b/gcc/dwarf2cfi.c @@ -285,6 +285,17 @@ add_cf

[pph] Add symbol table - Fix remaining asm differences (issue4732043)

2011-07-14 Thread Diego Novillo
This patch fixes the remaining assembly differences between non-pph and pph compiles. The idea is to make the pph compiler process functions and variables in the same order that they had been processed in the original compile. To do this, we intercept calls to rest_of_decl_compilation and alloca

Re: [PATCH] New IPA-CP with real function cloning - updated version

2011-07-14 Thread Jan Hubicka
> 2011-07-14 Martin Jambor > > * ipa-prop.h: Include alloc-pool.h, all sorts of updates to general > comments. > (ipcp_values_pool): Declare. > (ipcp_sources_pool): Likewise. > (ipcp_lattice): Changed to forward declaration. > (ipa_param_descriptor): Removed

[patch] Fix PR middle-end/49732

2011-07-14 Thread Eric Botcazou
Hi, this is a regression present on mainline and 4.6 branch. The compiler crashes during gimplification because there is a COMPOUND_EXPR shared between the TYPE_SIZE and TYPE_SIZE_UNIT expressions of an array type. Now this isn't supposed to happen because we run an unsharing pass before gimp

[4.6] Fix PR tree-optimization/49725

2011-07-14 Thread Eric Botcazou
Hi, this is the ICE at -O2 on ACATS c34005a introduced on the 4.6 branch by Martin's latest SRA patch. But it's actually the same PRE issue as: http://gcc.gnu.org/ml/gcc-patches/2011-03/msg02210.html Bootstrapped/regtested on i586-suse-linux, OK for 4.6 branch? 2011-07-14 Eric Botcazou

[patch] Fix PR target/48220 for the SPARC

2011-07-14 Thread Eric Botcazou
Hi, this adds support for DW_OP_GNU_entry_value/DW_TAG_GNU_call_site_parameter on SPARC-like architectures (architectures with register windows and explicit window save instruction). The transformation OUTGOING_REGNO -> INCOMING_REGNO is explicit for them and not tied to the call-to-subroutine

Re: [Patch, Fortran] Add caf_runtime_error to libgfortran/caf/single.c

2011-07-14 Thread Janne Blomqvist
On Thu, Jul 14, 2011 at 23:34, Tobias Burnus wrote: > Janne Blomqvist wrote: >> >>        * caf/mpi.c (caf_runtime_error): Remove "error" parameter. >>        Return EXIT_FAILURE instead. >> > From the patch: >> >>  /* FIXME: Shutdown the Fortran RTL to flush the buffer.  PR 43849.  */ >> >> This

Re: [PATCH] New IPA-CP with real function cloning

2011-07-14 Thread Jan Hubicka
> > Well, technically they survive until after inlining (because of > indirect inlining which also derives information from the lattices > corresponding to node->inlined_to node. Results of arithmetic > functions are not going to be accessed during inlining when compiling > any reasonable program

Re: [build] Move crtfastmath to toplevel libgcc

2011-07-14 Thread Uros Bizjak
On Thu, Jul 14, 2011 at 12:09 PM, Rainer Orth wrote: > Andreas Schwab writes: > >> Same on ia64: >> >> Configuration mismatch! >> Extra parts from gcc directory: crtbegin.o crtbeginS.o crtend.o crtendS.o >> Extra parts from libgcc: crtbegin.o crtend.o crtbeginS.o crtendS.o >> crtfastmath.o Alph

Re: [Patch, Fortran] Add caf_runtime_error to libgfortran/caf/single.c

2011-07-14 Thread Tobias Burnus
Janne Blomqvist wrote: * caf/mpi.c (caf_runtime_error): Remove "error" parameter. Return EXIT_FAILURE instead. > From the patch: /* FIXME: Shutdown the Fortran RTL to flush the buffer. PR 43849. */ This is unnecessary, as the call to exit() will call the libgfortran destruct

Re: [Patch, Fortran] Add caf_runtime_error to libgfortran/caf/single.c

2011-07-14 Thread Daniel Carrera
On 07/14/2011 09:48 PM, Janne Blomqvist wrote: 2011-07-14 Daniel Carrera * caf/mpi.c (caf_runtime_error): Remove "error" parameter. Return EXIT_FAILURE instead. Well, this changelog entry is incorrect; you're calling exit(EXIT_FAILURE) and not returning a value. Ok. What t

Re: [google] Backport patch r175881 from gcc-4_6-branch to google/gcc-4_6 (issue4695051)

2011-07-14 Thread Diego Novillo
On Wed, Jul 13, 2011 at 22:39, Carrot Wei wrote: > Hi Diego > > The previous patch was done with svn merge. > > This new version is done with svnmerge.py. Again tested with Great, thanks. This simplifies regular merges, since svnmerge.py will know that this rev was merged already. I think svnme

Re: [Patch, Fortran] Add caf_runtime_error to libgfortran/caf/single.c

2011-07-14 Thread Janne Blomqvist
On Thu, Jul 14, 2011 at 18:40, Daniel Carrera wrote: > And of course, here is the patch and ChangeLog. > > 2011-07-14  Daniel Carrera   >        * caf/mpi.c (caf_runtime_error): Remove "error" parameter. >        Return EXIT_FAILURE instead. Well, this changelog entry is incorrect; you're callin

Remove NetWare support

2011-07-14 Thread Rainer Orth
I've got a preliminary NetWare removal patch ready (yet untested), but have a couple of questions: * Given that there's a considerable amount of NetWare support still in src, toplevel support has to stay. On the other hand, the reference in config/elf.m4 is only used for the LTO plugin and ca

Re: Correct fix for scheduler bug PR11320

2011-07-14 Thread Richard Henderson
On 07/14/2011 09:43 AM, Bernd Schmidt wrote: > (Although now I wonder if we could instead use one of the speculative > load instructions? There's one that sets the NaT bit if the load would > fault, isn't there? It's been so long I can't remember.) We could, but we also have to insert a check load

gimplefe patch

2011-07-14 Thread Ketaki
Hi, This is the patch for gimple front end branch. I have written this code as a part of Google Summer of Code program. The patch consist of following changes: 1. The grammar rules for variable declaration are modified to include parameters. The code for the same is in gp_parse_var_decl function

Fix a testcase

2011-07-14 Thread Bernd Schmidt
I've committed the following as obvious. This showed up as a failure with C6X. Bernd Index: gcc/testsuite/ChangeLog === --- gcc/testsuite/ChangeLog (revision 176278) +++ gcc/testsuite/ChangeLog (working copy) @@ -1,10 +1,14 @

Re: Correct fix for scheduler bug PR11320

2011-07-14 Thread Bernd Schmidt
On 07/14/11 18:39, Richard Henderson wrote: > On 07/14/2011 09:19 AM, Bernd Schmidt wrote: >> Yes, but not using the fixed got pointer in r1, but a random other >> register which can have different values in the function. > > Oh, I think I see. > > So if this really had been a PLUS, as implied by

Re: Correct fix for scheduler bug PR11320

2011-07-14 Thread Richard Henderson
On 07/14/2011 09:19 AM, Bernd Schmidt wrote: > Yes, but not using the fixed got pointer in r1, but a random other > register which can have different values in the function. Oh, I think I see. So if this really had been a PLUS, as implied by the LO_SUM, we would have had garbage input, produced g

Re: Correct fix for scheduler bug PR11320

2011-07-14 Thread Bernd Schmidt
On 07/14/11 18:29, Richard Henderson wrote: > On 07/14/2011 09:23 AM, Bernd Schmidt wrote: >> Ok, with gen_const_mem hacked into gcc-3.3 (minus setting MEM_READONLY_P >> which doesn't exist in that tree) the load stays behind the branch where >> it should be. >> > > RTX_UNCHANGING_P was the bit ba

Re: [RFC PATCH] -grecord-gcc-switches (PR other/32998)

2011-07-14 Thread Jason Merrill
On 07/14/2011 12:29 PM, Jakub Jelinek wrote: On Thu, Jul 14, 2011 at 12:26:41PM -0400, Jason Merrill wrote: On 07/14/2011 05:41 AM, Jakub Jelinek wrote: Here is a PCH friendly variant of the patch which tries to set right producer from the start, but early in dwarf2out_finish double checks if P

Re: Correct fix for scheduler bug PR11320

2011-07-14 Thread Richard Henderson
On 07/14/2011 09:23 AM, Bernd Schmidt wrote: > Ok, with gen_const_mem hacked into gcc-3.3 (minus setting MEM_READONLY_P > which doesn't exist in that tree) the load stays behind the branch where > it should be. > RTX_UNCHANGING_P was the bit back then, I believe. r~

Re: [RFC PATCH] -grecord-gcc-switches (PR other/32998)

2011-07-14 Thread Jakub Jelinek
On Thu, Jul 14, 2011 at 12:26:41PM -0400, Jason Merrill wrote: > On 07/14/2011 05:41 AM, Jakub Jelinek wrote: > >Here is a PCH friendly variant of the patch which tries to set right > >producer from the start, but early in dwarf2out_finish double checks > >if PCH hasn't changed it and if it did, up

Re: [RFC PATCH] -grecord-gcc-switches (PR other/32998)

2011-07-14 Thread Jason Merrill
On 07/14/2011 05:41 AM, Jakub Jelinek wrote: Here is a PCH friendly variant of the patch which tries to set right producer from the start, but early in dwarf2out_finish double checks if PCH hasn't changed it and if it did, updates it back to the expected string. Why not just wait until then to

Re: Correct fix for scheduler bug PR11320

2011-07-14 Thread Bernd Schmidt
On 07/14/11 18:19, Bernd Schmidt wrote: > On 07/14/11 18:03, Richard Henderson wrote: >> On 07/14/2011 03:03 AM, Bernd Schmidt wrote: >>> +++ gcc/config/ia64/ia64.c (working copy) >>> @@ -1047,7 +1047,7 @@ >>>tmp = gen_rtx_PLUS (Pmode, tmp, pic_offset_table_rtx); >>>emit_insn (gen_

Re: Correct fix for scheduler bug PR11320

2011-07-14 Thread Bernd Schmidt
On 07/14/11 18:03, Richard Henderson wrote: > On 07/14/2011 03:03 AM, Bernd Schmidt wrote: >> +++ gcc/config/ia64/ia64.c (working copy) >> @@ -1047,7 +1047,7 @@ >>tmp = gen_rtx_PLUS (Pmode, tmp, pic_offset_table_rtx); >>emit_insn (gen_rtx_SET (VOIDmode, dest, tmp)); >> >> -

Re: Fix PR48542: reload register contents reuse crossing setjmp

2011-07-14 Thread Ulrich Weigand
Jeff Law wrote: > On 06/15/11 21:46, Hans-Peter Nilsson wrote: > > PR rtl-optimization/48542 > > * reload.c (find_equiv_reg): Stop looking when finding a > > setjmp-type call. > > * reload1.c (reload_as_needed): Invalidate all reload > > registers when crossing a setjmp-type cal

Re: [PATCH] New IPA-CP with real function cloning

2011-07-14 Thread Jan Hubicka
> > > if (dec < cs->count) > > > cs->count -= dec; > > > else > > > cs->count = 0; > > > } > > > > > > if (dump_file) > > > dump_profile_updates (orig_node, new_node); > > > } > > > > > > if (node->local.can_change_signature) > > > { > > > args_to_skip = BITM

Re: [PATCH] widening_mul: Do cost check when propagating mult into plus/minus expressions

2011-07-14 Thread Steven Bosscher
On Thu, Jul 14, 2011 at 11:40 AM, Richard Guenther wrote: > Generating RTL from GIMPLE passes just to be able to use rtx_cost is, > well ... gross. Indeed. And it is one of the major blockers for fully separating the RTL, GIMPLE and target code off into separate modules. It would be great to get

Re: Correct fix for scheduler bug PR11320

2011-07-14 Thread Richard Henderson
On 07/14/2011 03:03 AM, Bernd Schmidt wrote: > +++ gcc/config/ia64/ia64.c(working copy) > @@ -1047,7 +1047,7 @@ >tmp = gen_rtx_PLUS (Pmode, tmp, pic_offset_table_rtx); >emit_insn (gen_rtx_SET (VOIDmode, dest, tmp)); > > - tmp = gen_rtx_LO_SUM (Pmode, dest, src); > +

Re: [PATCH Atom][PR middle-end/44382] Tree reassociation improvement

2011-07-14 Thread Ilya Enkovich
> > You need the target hook that tells how big the reassociation based on the > type.  Machines have different numbers of functional units, for example, maybe > 3 integer units and 2 floating point units.  For example, in the PowerPC, I > would set the basic integer and binary floating point types

Re: [PATCH Atom][PR middle-end/44382] Tree reassociation improvement

2011-07-14 Thread Michael Meissner
On Thu, Jul 14, 2011 at 11:32:59AM +0200, Richard Guenther wrote: > On Thu, Jul 14, 2011 at 11:31 AM, Richard Guenther > wrote: > > 2011/7/14 Michael Meissner : > >> One minor note, you will need to update doc/invoke.texi to document the new > >> switch before checkin: -ftree-reassoc-width= > > >

Re: [Patch, Fortran] Add caf_runtime_error to libgfortran/caf/single.c

2011-07-14 Thread Daniel Carrera
And of course, here is the patch and ChangeLog. 2011-07-14 Daniel Carrera * caf/single.c: Include stdarg.h header. (caf_runtime_error): New function. Use "exit(EXIT_FAILURE)". (_gfortran_caf_register): Use caf_runtime_error. (_gfortran_caf_sync_images): Use "e

Re: [Patch, Fortran] Add caf_runtime_error to libgfortran/caf/single.c

2011-07-14 Thread Daniel Carrera
Hi Tobias, As per your suggestion, I'm copying to gfotran and gcc-patches. I've made the change your asked and I'm going to commit the patch. Cheers, Daniel. On 07/14/2011 05:31 PM, Tobias Burnus wrote: On 07/14/2011 05:05 PM, Daniel Carrera wrote: +caf_runtime_error (const char *message,

Re: [PATCH] New IPA-CP with real function cloning

2011-07-14 Thread Martin Jambor
Hi, like with the previous mail, I'll reply to the comments here and then post a new version of the patch in a separate thread. On Sun, Jul 10, 2011 at 07:04:21PM +0200, Jan Hubicka wrote: > > > > /* If checking is enabled, verify that no lattice is in the TOP state, i.e. > > not > >bottom,

[testsuite]: Some test case skips.

2011-07-14 Thread Georg-Johann Lay
This patchlet fixes two test cases: * gcc.dg/pr32912-2.c: TImode is overkill for AVR. * gcc.dg/pr44674.c: Test if -fprofile-generate is available. Ok to commit? Johann testsuite/ * gcc.dg/pr32912-2.c: Skip for AVR. * gcc.dg/pr44674.c: Add dg-require-profiling. Index: gcc.dg/pr

Re: [PATCH Atom][PR middle-end/44382] Tree reassociation improvement

2011-07-14 Thread Ilya Enkovich
> 2011/7/14 Richard Guenther : >> >> But then how comes the option to override it is useful?  It isn't dependent >> on the particular case.  At least the option should be a --param. >> >> Richard. >> > > Option is still useful if you want to try feature on platform with no > hook implemented and fo

Re: [PATCH (1/7)] New optab framework for widening multiplies

2011-07-14 Thread Andrew Stubbs
Ping. This is the last unreviewed patch in this series ... Thanks Andrew On 09/07/11 15:43, Andrew Stubbs wrote: On 23/06/11 15:37, Andrew Stubbs wrote: This patch should have no effect on the compiler output. It merely replaces one way to represent widening operations with another, and refac

Re: [Patch, AVR]: Fix PR49487 (ICE for wrong rotate scratch)

2011-07-14 Thread Richard Henderson
On 07/14/2011 12:41 AM, Georg-Johann Lay wrote: >> Ok to commit and back-port to 4.6? >> >> Johann >> >> PR target/49487 >> * config/avr/avr.md (rotl3): Generate SCRATCH instead >> of REG. >> (*rotw): Use const_int_operand for operands2. >> Use match_scatch for operands3.

[PATCH] Fix PR49651

2011-07-14 Thread Richard Guenther
This fixes PR49651 where we fail to handle aggregate dereferences in call arguments in PTA properly. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied where applicable. Richard. 2011-07-14 Richard Guenther PR tree-optimization/49651 * tree-ssa-structalias.c (get_c

Re: [PATCH (7/7)] Mixed-sign multiplies using narrowest mode

2011-07-14 Thread Richard Guenther
On Thu, Jul 14, 2011 at 4:38 PM, Andrew Stubbs wrote: > On 28/06/11 17:23, Andrew Stubbs wrote: >> >> On 23/06/11 15:43, Andrew Stubbs wrote: >>> >>> Patch 4 introduced support for using signed multiplies to code unsigned >>> multiplies in a narrower mode. Patch 5 then introduced support for >>> m

Re: [PATCH (7/7)] Mixed-sign multiplies using narrowest mode

2011-07-14 Thread Andrew Stubbs
On 28/06/11 17:23, Andrew Stubbs wrote: On 23/06/11 15:43, Andrew Stubbs wrote: Patch 4 introduced support for using signed multiplies to code unsigned multiplies in a narrower mode. Patch 5 then introduced support for mis-matched input modes. These two combined mean that there is case where on

Re: [PATCH (6/7)] More widening multiply-and-accumulate pattern matching

2011-07-14 Thread Richard Guenther
On Thu, Jul 14, 2011 at 4:34 PM, Andrew Stubbs wrote: > On 07/07/11 11:13, Richard Guenther wrote: >>> >>> This updates the context changed by my update to patch 3. >>> > >>> >  The content of this patch has not changed. >> >> Ok. > > I know this patch was already approved, but I discovered a bug

Re: [PATCH][1/N][C][C++][Fortran][Java] Change POINTER_PLUS_EXPR offset type requirements

2011-07-14 Thread Richard Henderson
On 07/14/2011 04:28 AM, Richard Guenther wrote: > On Tue, 12 Jul 2011, Richard Guenther wrote: > >> >> This patch is step 1, it abstracts away the type of the offset operand >> when building a POINTER_PLUS_EXPR. It does so by introducing >> fold_build_pointer_plus_expr{_hwi,_loc} helpers and use

Re: [PATCH (6/7)] More widening multiply-and-accumulate pattern matching

2011-07-14 Thread Andrew Stubbs
On 07/07/11 11:13, Richard Guenther wrote: This updates the context changed by my update to patch 3. > > The content of this patch has not changed. Ok. I know this patch was already approved, but I discovered a bug in this patch that missed optimizing the case where the input to multiply did

Re: [PATCH (5/7)] Widening multiplies for mis-matched mode inputs

2011-07-14 Thread Richard Guenther
On Thu, Jul 14, 2011 at 4:28 PM, Andrew Stubbs wrote: > I've updated this patch following the changes earlier in the patch series. > There isn't much left. > > This should obviate all the review comments. :) Indeed ;) > OK? Ok. Thanks, Richard. > Andrew >

Re: [PATCH (5/7)] Widening multiplies for mis-matched mode inputs

2011-07-14 Thread Andrew Stubbs
I've updated this patch following the changes earlier in the patch series. There isn't much left. This should obviate all the review comments. :) OK? Andrew 2011-07-14 Andrew Stubbs gcc/ * tree-ssa-math-opts.c (is_widening_mult_p): Remove FIXME. Ensure the the larger type is the first o

Re: [PATCH (4/7)] Unsigned multiplies using wider signed multiplies

2011-07-14 Thread Richard Guenther
On Thu, Jul 14, 2011 at 4:23 PM, Andrew Stubbs wrote: > On 12/07/11 15:07, Andrew Stubbs wrote: >> >> This update does the same thing as before, but updated for the changes >> earlier in the patch series. In particular, the build_and_insert_cast >> function and find_widening_optab_handler_and_mode

Re: [PATCH (4/7)] Unsigned multiplies using wider signed multiplies

2011-07-14 Thread Andrew Stubbs
On 12/07/11 15:07, Andrew Stubbs wrote: This update does the same thing as before, but updated for the changes earlier in the patch series. In particular, the build_and_insert_cast function and find_widening_optab_handler_and_mode changes have been moved up to patch 2. And this update changes t

Re: [PATCH (3/7)] Widening multiply-and-accumulate pattern matching

2011-07-14 Thread Andrew Stubbs
This update changes only the context modified by changes to patch 2. The patch has already been approved. I'm just posting it for completeness. Andrew 2011-07-14 Andrew Stubbs gcc/ * tree-ssa-math-opts.c (convert_plusminus_to_widen): Permit a single conversion statement separating multipl

Re: [PATCH (2/7)] Widening multiplies by more than one mode

2011-07-14 Thread Richard Guenther
On Thu, Jul 14, 2011 at 4:10 PM, Andrew Stubbs wrote: > On 12/07/11 12:04, Richard Guenther wrote: >> >> I wonder if we want to restrict the WIDEN_* operations to operate >> on types that have matching type/mode precision(**). > > I've now modified the patch to allow bitfields, or other case where

Re: [PATCH (2/7)] Widening multiplies by more than one mode

2011-07-14 Thread Andrew Stubbs
On 12/07/11 12:04, Richard Guenther wrote: I wonder if we want to restrict the WIDEN_* operations to operate on types that have matching type/mode precision(**). I've now modified the patch to allow bitfields, or other case where the precision is smaller than the mode-size. I've also addressed

Re: [PATCH] New IPA-CP with real function cloning

2011-07-14 Thread Martin Jambor
Hi, I'll send a new version of IPA-CP incorporating most of the feedback in a new thread but let me also comment on some of the points here: On Fri, Jul 08, 2011 at 08:24:31PM +0200, Jan Hubicka wrote: > > > > { > > > > /* Pointer to an array of structures describing individual formal > > > >

Re: [Patch, Fortran] Mark "token" of static coarrays "restrict"

2011-07-14 Thread Daniel Carrera
For what it's worth, it compiles and works on my 32bit Linux too. But this is such a simple patch it *had* to work. On 07/14/2011 11:01 AM, Tobias Burnus wrote: As the title says: Mark "token" of static coarrays "restrict" Bootstrapped and regtested on x86-64-linux. OK for the trunk? Tobias

Re: Correct fix for scheduler bug PR11320

2011-07-14 Thread Eric Botcazou
> ??? Original code: > >basic_block b = BLOCK_FOR_INSN (insn); > edge e; > for (e = b->succ; e; e = e->succ_next) > ! if ((e->flags & EDGE_FALLTHRU) == 0) > ! { > ! bitmap_operation (set, set, e->dest->global_live_at_start, > ! BITMAP_IOR); > !

[PATCH] More efficiently canoncialize operands in fold_stmt

2011-07-14 Thread Richard Guenther
We currently go through a tree expression generation when canonicalizing operand order. That's quite wasteful. The following patch re-orders things in a way to avoid this and remove some duplicate code. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2011-07-14 Richar

Re: [PATCH] widening_mul: Do cost check when propagating mult into plus/minus expressions

2011-07-14 Thread Andreas Krebbel
On Wed, Jul 13, 2011 at 09:58:08AM -0700, Richard Henderson wrote: > Why the force_operand? You've got register inputs. Either the target > is going to support the operation or it isn't. I agree that it doesn't seem to be necessary. I've used force_operand since ivopts (add_cost) is doing it wit

[PATCH] Fold to more canonical TRUHT_NOT_EXPRs

2011-07-14 Thread Richard Guenther
The following generates boolean-typed TRUTH_NOT_EXPRs instead of operating on converted boolean operands. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2011-07-14 Richard Guenther * fold-const.c (fold_binary_loc): Convert the !bool_var result,

Re: Correct fix for scheduler bug PR11320

2011-07-14 Thread Eric Botcazou
> Any particular bits you still see that don't get reverted with this patch? The ebb_compute_jump_reg_dependencies changes. The original patch has: * sched-ebb.c (compute_jump_reg_dependencies): New prototype. Mark registers live on entry of the fallthrough block and conditionall

Re: Correct fix for scheduler bug PR11320

2011-07-14 Thread Bernd Schmidt
On 07/14/11 14:18, Eric Botcazou wrote: >> Any particular bits you still see that don't get reverted with this patch? > > The ebb_compute_jump_reg_dependencies changes. The original patch has: > > * sched-ebb.c (compute_jump_reg_dependencies): New prototype. > Mark registers live on

Re: Correct fix for scheduler bug PR11320

2011-07-14 Thread Bernd Schmidt
On 07/14/11 13:57, Eric Botcazou wrote: >> The real problem here is that the ia64 backend lies to the rest of the >> compiler; it produces a load instruction without showing a MEM anywhere >> in the instruction pattern. Hence, the following patch, which reverts >> the bogus scheduler changes and ad

Re: Correct fix for scheduler bug PR11320

2011-07-14 Thread Eric Botcazou
> The real problem here is that the ia64 backend lies to the rest of the > compiler; it produces a load instruction without showing a MEM anywhere > in the instruction pattern. Hence, the following patch, which reverts > the bogus scheduler changes and adds a MEM to a pattern in ia64.md. This is p

Re: Ping: The TI C6X port

2011-07-14 Thread Bernd Schmidt
On 06/14/11 22:52, Vladimir Makarov wrote: > On 06/06/2011 07:26 AM, Bernd Schmidt wrote: >> Ping^3 for the C6X port. Now with extra patches: >> >> Additional preliminary scheduler tweaks: >> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg02408.html >> > It is ok for me. Thanks, Bernd. I've committ

Re: RFA: Avoid unnecessary clearing in union initialisers

2011-07-14 Thread Richard Sandiford
"H.J. Lu" writes: > This caused: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49736 Sorry for the breakage. It was due to a humiliating stupid mistake in the hunk to update all_zeros_p: @@ -5129,13 +5152,12 @@ mostly_zeros_p (const_tree exp) all_zeros_p (const_tree exp) { if (TREE_CODE

Re: [patch] fix typo in doc/extend.texi, committed as obvious

2011-07-14 Thread Matthias Klose
On 07/14/2011 01:44 PM, Richard Guenther wrote: > On Thu, Jul 14, 2011 at 1:41 PM, Matthias Klose wrote: >> fix a typo in doc/extend.texi, committed as obvious. > > Specify the architecture to generate code for when compiling the > -function. If you select the @code{"target("cpu=power7)"} attri

Re: [patch] fix typo in doc/extend.texi, committed as obvious

2011-07-14 Thread Richard Guenther
On Thu, Jul 14, 2011 at 1:41 PM, Matthias Klose wrote: > fix a typo in doc/extend.texi, committed as obvious. Specify the architecture to generate code for when compiling the -function. If you select the @code{"target("cpu=power7)"} attribute when +function. If you select the @code{"target("cp

Re: [patch 1/8 tree-optimization]: Bitwise logic for fold_truth_not_expr

2011-07-14 Thread Richard Guenther
On Wed, Jul 13, 2011 at 2:15 PM, Kai Tietz wrote: > 2011/7/13 Richard Guenther : >> On Wed, Jul 13, 2011 at 1:08 PM, Kai Tietz wrote: >>> 2011/7/13 Richard Guenther : On Wed, Jul 13, 2011 at 11:04 AM, Kai Tietz wrote: > Sorrty, the TRUTH_NOT_EXPR isn't here the point at all. The u

[patch] fix typo in doc/extend.texi, committed as obvious

2011-07-14 Thread Matthias Klose
fix a typo in doc/extend.texi, committed as obvious. Matthias 2011-07-14 Matthias Klose * doc/extend.texi (optimize attribute): Fix typo. Index: doc/extend.texi === --- doc/extend.texi (revision 176263) +++ doc/ext

Re: Correct fix for scheduler bug PR11320

2011-07-14 Thread Bernd Schmidt
On 07/14/11 13:20, Andrey Belevantsev wrote: > Hello Bernd, > > FWIW, we have discussed your change with Alexander and we think you are > right about the scheduler changes. One question is: > > On 14.07.2011 14:03, Bernd Schmidt wrote: >> --- gcc/sched-deps.c(revision 176195) >> +++ gcc/sche

Re: Correct fix for scheduler bug PR11320

2011-07-14 Thread Andrey Belevantsev
Hello Bernd, FWIW, we have discussed your change with Alexander and we think you are right about the scheduler changes. One question is: On 14.07.2011 14:03, Bernd Schmidt wrote: --- gcc/sched-deps.c(revision 176195) +++ gcc/sched-deps.c(working copy) @@ -568,7 +568,7 @@ (r

[PATCH] Only insert required conversions during gimplification

2011-07-14 Thread Richard Guenther
Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2011-07-14 Richard Guenther * gimplify.c (gimplify_expr): Only do required conversions. Index: gcc/gimplify.c === --- gcc/gimplify.c (revision

Re: [Patch, Fortran] Add caf_runtime_error to libgfortran/caf/single.c

2011-07-14 Thread Tobias Burnus
On 07/14/2011 12:14 PM, Daniel Carrera wrote: On 07/14/2011 12:04 PM, Tobias Burnus wrote: I was wondering - based on the discussion - whether one should remove the "int error" argument from caf_runtime_error and simply use "exit (EXIT_FAILURE)" for all exit() calls in mpi.c/single.c, cf. http:/

Re: [PATCH Atom][PR middle-end/44382] Tree reassociation improvement

2011-07-14 Thread Ilya Enkovich
2011/7/14 Richard Guenther : > > But then how comes the option to override it is useful?  It isn't dependent > on the particular case.  At least the option should be a --param. > > Richard. > Option is still useful if you want to try feature on platform with no hook implemented and for other perfo

Re: [build] Move crtfastmath to toplevel libgcc

2011-07-14 Thread Rainer Orth
Andreas Schwab writes: > Same on ia64: > > Configuration mismatch! > Extra parts from gcc directory: crtbegin.o crtbeginS.o crtend.o crtendS.o > Extra parts from libgcc: crtbegin.o crtend.o crtbeginS.o crtendS.o > crtfastmath.o I believe you need the following patch. As one of my next tasks, I

Re: [PATCH Atom][PR middle-end/44382] Tree reassociation improvement

2011-07-14 Thread Ilya Enkovich
> One minor note, you will need to update doc/invoke.texi to document the new > switch before checkin: -ftree-reassoc-width= > > -- > Michael Meissner, IBM Thanks for the note! Here is fixed patch. Ilya -- gcc/ 2011-07-14 Enkovich Ilya PR middle-end/44382 * target.def (reasso

Re: [Patch, Fortran] Add caf_runtime_error to libgfortran/caf/single.c

2011-07-14 Thread Daniel Carrera
On 07/14/2011 12:04 PM, Tobias Burnus wrote: I was wondering - based on the discussion - whether one should remove the "int error" argument from caf_runtime_error and simply use "exit (EXIT_FAILURE)" for all exit() calls in mpi.c/single.c, cf. http://gcc.gnu.org/ml/fortran/2011-07/msg00140.html B

Re: [PATCH Atom][PR middle-end/44382] Tree reassociation improvement

2011-07-14 Thread Richard Guenther
On Thu, Jul 14, 2011 at 11:59 AM, Ilya Enkovich wrote: > 2011/7/14 Richard Guenther : >> >> Btw, rather than a new target hook and an option I suggest to use >> a --param which default you can modify in the backend. >> >> Richard. >> > > Introduced target hook does not just define default value fo

Re: [Patch, Fortran] Allocate + CAF library

2011-07-14 Thread Daniel Carrera
*ping* ? On 07/11/2011 08:16 PM, Daniel Carrera wrote: Hello, This is my largest patch so far and the first that I'll commit myself. This patch improves support for the ALLOCATE statement when using the coarray library. Specifically, it adds support for the stat= and errmsg= attributes: ALLOCA

Re: [Patch, Fortran] Add caf_runtime_error to libgfortran/caf/single.c

2011-07-14 Thread Tobias Burnus
On 07/14/2011 11:48 AM, Daniel Carrera wrote: This patch adds a caf_runtime_error function to the non-MPI implementation of Coarray Fortran. It is based on the MPI function of the same name in mpi.c. Ok to commit? I was wondering - based on the discussion - whether one should remove the "in

Correct fix for scheduler bug PR11320

2011-07-14 Thread Bernd Schmidt
PR11320 was a scheduler problem where an instruction was moved backwards across a branch, leading to addl r14 = @ltoffx(.LC2), r1 ;; (p7) addl r14 = 1, r0 <--- r14 clobbered ;; (p7) st4 [r15] = r14 ld8.mov r14 = [r14], .LC2 <--- crash

Re: [PATCH Atom][PR middle-end/44382] Tree reassociation improvement

2011-07-14 Thread Ilya Enkovich
2011/7/14 Richard Guenther : > > Btw, rather than a new target hook and an option I suggest to use > a --param which default you can modify in the backend. > > Richard. > Introduced target hook does not just define default value for option. It is meant to make decision in each particular case. For

Re: [build] Remove crt0, mcrt0 support

2011-07-14 Thread Rainer Orth
Richard, >> what's your take on this? > > I'm fine with it if you install a deprecation patch on the 4.6 branch > and mention that in the 4.6 changes.html. ok, will do. Thanks. Rainer -- - Rainer Orth, Center f

Re: [build] Move crtfastmath to toplevel libgcc

2011-07-14 Thread Andreas Schwab
"H.J. Lu" writes: > On Wed, Jul 13, 2011 at 10:12 AM, Rainer Orth > wrote: >> Richard Henderson writes: >> >>> On 07/13/2011 09:57 AM, Rainer Orth wrote: Do you think the revised crtfastmath patch is safe enough to commit together to avoid this mess? >>> >>> Probably. >> >> Ok.  I'll

[Patch, Fortran] Add caf_runtime_error to libgfortran/caf/single.c

2011-07-14 Thread Daniel Carrera
This patch adds a caf_runtime_error function to the non-MPI implementation of Coarray Fortran. It is based on the MPI function of the same name in mpi.c. Ok to commit? ChangeLog: 2011-07-14 Daniel Carrera * caf/single.c: Include stdarg.h header. (caf_runtime_error): New f

Re: [build] Remove crt0, mcrt0 support

2011-07-14 Thread Richard Guenther
On Thu, 14 Jul 2011, Rainer Orth wrote: > Richard, > > [Talking about an immediate removal of the netware target...] > > > "Jan Beulich" writes: > > > > Rainer Orth 07/13/11 4:34 PM >>> > >>>which variant would you prefer: obsoletion now and removal in 4.8 or > >>>immediate removal? > >> >

Re: [RFC PATCH] -grecord-gcc-switches (PR other/32998)

2011-07-14 Thread Jakub Jelinek
On Wed, Jul 13, 2011 at 10:30:58AM -0400, Jason Merrill wrote: > On 07/13/2011 10:06 AM, Jakub Jelinek wrote: > >>>--- gcc/testsuite/lib/dg-pch.exp.jj2011-01-03 18:58:03.0 > >>>+0100 > >>>+++ gcc/testsuite/lib/dg-pch.exp 2011-07-12 23:13:50.943670171 +0200 > >>>- dg-test -keep-o

Re: [PATCH] widening_mul: Do cost check when propagating mult into plus/minus expressions

2011-07-14 Thread Richard Guenther
On Wed, Jul 13, 2011 at 11:49 PM, Steven Bosscher wrote: > On Wed, Jul 13, 2011 at 4:34 PM, Richard Guenther > wrote: >> On Wed, Jul 13, 2011 at 3:13 PM, Andreas Krebbel >> wrote: >>> Hi, >>> >>> the widening_mul pass might increase the number of multiplications in >>> the code by transforming >

Re: [PATCH Atom][PR middle-end/44382] Tree reassociation improvement

2011-07-14 Thread Richard Guenther
On Thu, Jul 14, 2011 at 11:31 AM, Richard Guenther wrote: > 2011/7/14 Michael Meissner : >> One minor note, you will need to update doc/invoke.texi to document the new >> switch before checkin: -ftree-reassoc-width= > > You also need approval and somebody to review the patch before checkin. Btw,

Re: [PATCH Atom][PR middle-end/44382] Tree reassociation improvement

2011-07-14 Thread Richard Guenther
2011/7/14 Michael Meissner : > One minor note, you will need to update doc/invoke.texi to document the new > switch before checkin: -ftree-reassoc-width= You also need approval and somebody to review the patch before checkin. Richard. > -- > Michael Meissner, IBM > 5 Technology Place Drive, M/S

  1   2   >