On 07/14/2011 11:48 AM, Daniel Carrera wrote:
This patch adds a caf_runtime_error function to the non-MPI implementation of Coarray Fortran. It is based on the MPI function of the same name in mpi.c.

Ok to commit?

I was wondering - based on the discussion - whether one should remove the "int error" argument from caf_runtime_error and simply use "exit (EXIT_FAILURE)" for all exit() calls in mpi.c/single.c, cf. http://gcc.gnu.org/ml/fortran/2011-07/msg00140.html
But one can also do so as follow up patch.

Thus, OK for the patch as is - or with replacing all exit(...) by "exit(EXIT_FAILURE)", which uses stdlib.h's EXIT_FAILURE. One then can also drop the "int error" argument to the caf_runtime_error function.

Thanks for the patch!

Tobias

ChangeLog:

2011-07-14  Daniel Carrera <dcarr...@gmail.com>

    * caf/single.c:  Include stdarg.h header.
    (caf_runtime_error): New function based on the function in
    mpi.c with the same name.
    (_gfortran_caf_init): Use caf_runtime_error.
    * caf/mpi.c (caf_runtime_error): Add a note to keep in sync
    with the function in single.c.

Reply via email to