Re: fix latent compare-debug problem in cprop

2011-06-05 Thread Alexandre Oliva
On Jun 4, 2011, Steven Bosscher wrote: > I'm curious, though: What CFG changes or other transformations are > performed without this patch? It could be a sign of a missed > optimization before CPROP. Have you looked at that too? IIRC the transformation that was possible but that hadn't been per

Re: fix left-over debug insns in DCE

2011-06-05 Thread Jakub Jelinek
On Mon, Jun 06, 2011 at 02:32:29AM -0300, Alexandre Oliva wrote: > Those that remove sets whose DESTs may still be receved by debug insns > ought to adjust debug insns, yeah. I think (hope) we have them all > covered. Do you know of any we missed? delete_trivially_dead_insns is already covered,

patch trunk: seek plugin also in a language specific directory when given a short name

2011-06-05 Thread Basile Starynkevitch
Hello All, Sorry I incorrectly sent that to gcc@ not to gcc-patches@ Front-end functions (e.g. pragma-related) are not available to all plugins (e.g. not to plugins fired from lto1). See the http://gcc.gnu.org/ml/gcc/2011-05/msg00321.html discussion. This patch document a little bit that, and se

Re: fix left-over debug insns in DCE

2011-06-05 Thread Alexandre Oliva
On Jun 3, 2011, Eric Botcazou wrote: >> Hmm... Maybe it could, I'm not sure. The problem is that DCE removes >> insns, and then DF associates remaining uses in debug insns to earlier >> DEFs. Adjusting debug insns in DCE is right per the VTA design motto: >> decide as if debug insns weren't t

Re: Patch: aesthetics for gcc/cp/cxx-pretty-print.c

2011-06-05 Thread Basile Starynkevitch
On Sun, 05 Jun 2011 19:17:48 -0700 Bruce Korb wrote: > It also caused a code analysis tool to wander off into the weeds. > + if (DECL_NONSTATIC_MEMBER_FUNCTION_P (t)) > +pp_cxx_decl_specifier_seq (pp, TREE_TYPE (TREE_TYPE (t))), break; > + /* FALLTHROUGH */ I believe the usual

AIX net/if_arp.h include fix for struct fc_softc

2011-06-05 Thread Peter O'Gorman
Hi, We ran across an issue with qt-4.7 built with gcc-4.4 on AIX 5.2, 5.3, 6.1, and 7.1 where some static constructors were not being called. It turned out to be a header file issue, see, for example, https://www.ibm.com/developerworks/forums/thread.jspa?threadID=211873&tstart=-2 Using fixinclude

C++ PATCH for c++/49134 (constexpr failures on ARM)

2011-06-05 Thread Jason Merrill
build_target_expr was making the assumption that the initializer for a temporary should have the same type as the temporary, but that isn't the case on ARM, where the ABI is changed to return 'this' from constructors. So I adjusted the assert. Tested x86_64-pc-linux-gnu, applying to trunk and

C++ PATCH for objc++/49221 (many EH fails in objc++ testsuite)

2011-06-05 Thread Jason Merrill
This was happening because objc_eh_runtime_type wanted to create global decls while we were in the middle of processing a function, and cp_finish_decl assumed that if we're in a function the decl must belong to the function. We can avoid that assumption by checking the DECL_CONTEXT rather than

Committed: fix PR49285, breakage building libgcc2 for MMIX

2011-06-05 Thread Hans-Peter Nilsson
I needed a baseline for PR48542 (problems with setjmp/longjmp), but building MMIX was broken on trunk. It was "bitten" by the fixups to predicate matching done recentlish. The comment above the MMIX truncdfsf2 expander complains about having to use an expander to force an operand to memory - and

[pph] TS_COMMON chain and trace edits (issue4564058)

2011-06-05 Thread Lawrence Crowl
We were not streaming the TS_COMMON field change. This patch adds a functions to stream TS_COMMON. It adds calls to them in existing code that handles trees. It also implements streaming of other C++-specific trees that inherit TS_COMMON. This patch fixes some ICEs, but the test still fail on l

Add myself to MAINTAINERS

2011-06-05 Thread Nenad Vukicevic
Added myself to MAINTAINERS. Thanks. 2011-06-05 Nenad Vukicevic * MAINTAINERS (Write After Approval): Add myself. Index: MAINTAINERS === --- MAINTAINERS (revision 174678) +++ MAINTAINERS (working copy) @@ -498,6 +498,7 @

Re: [trunk<-vta] Re: [vtab] Permit coalescing of user variables

2011-06-05 Thread Alexandre Oliva
On Jun 5, 2011, Alexandre Oliva wrote: > On Jun 4, 2011, Jakub Jelinek wrote: >> The following changes all look wrong to me, they make the tests totally >> useless. If both f and g are used in real code after the asm volatile, then >> the both f and g will likely live in some register or memo

Patch: aesthetics for gcc/cp/cxx-pretty-print.c

2011-06-05 Thread Bruce Korb
It also caused a code analysis tool to wander off into the weeds. 2011-06-05 Bruce Korb * gcc/cp/cxx-pretty-print.c (pp_cxx_decl_specifier_seq): Do not have a switch label pointing into an "else" clause for an "if". Index: gcc/cp/cxx-pretty-print.c ==

[SPARC] Fix another thinko

2011-06-05 Thread Eric Botcazou
This time introduced when -fno-delayed-branch was fixed in the back-end. Modifying %fp before a 'restore' instruction is a no-no because it is the base address used to reload spilled registers when the window stack is empty. It only affects __builtin_eh_return and presumably went unnoticed. Tes

Re: fix latent compare-debug problem in cprop

2011-06-05 Thread Eric Botcazou
> This patch fixes the problem, disregarding changes to debug insns as > “changed”. Regstrapped on x86_64-linux-gnu and i686-linux-gnu. Ok to > install? Yes, thanks. -- Eric Botcazou

Re: PR 49145: Another (zero_extend (const_int ...)) in combine

2011-06-05 Thread Eric Botcazou
> PR rtl-optimization/49145 > * combine.c (make_compound_operation): Handle ZERO_EXTEND specially. > > gcc/testsuite/ > PR rtl-optimization/49145 > From Ryan Mansfield > * gcc.c-torture/compile/pr49145.c: New test. OK, thanks. -- Eric Botcazou

[pph] Clean up PPH tests (issue4572042)

2011-06-05 Thread Lawrence Crowl
The purpose of this patch is to make PPH testing clean. Some tests have assembly comparison failures between regular compiles and PPH compiles. When this miscompare is exected, we now mark the test with a comment "pph asm xdiff". The driver lib/dg-pph.exp looks for this comment to report either

Re: [trunk<-vta] Re: [vtab] Permit coalescing of user variables

2011-06-05 Thread Alexandre Oliva
On Jun 4, 2011, Jakub Jelinek wrote: > The following changes all look wrong to me, they make the tests totally > useless. If both f and g are used in real code after the asm volatile, then > the both f and g will likely live in some register or memory. > The whole point of the construct in the

[patch, fortran]

2011-06-05 Thread Thomas Koenig
Hello world, the attached patch extends removing trailing TRIMs in assignments for cases like a // trim(b). Regression-tested. OK for trunk? Thomas 2011-05-06 Thomas König * frontend-passes.c (optimize_assignment): Follow chains of concatenation operators to the en

[PATCH, i386]: Remaining FP moves cleanups

2011-06-05 Thread Uros Bizjak
Hello! 2011-06-05 Uros Bizjak * config/i386/i386.md (*movdf_internal_rex64) : Remove MODE_TI handling. Remove SSE1 handling in attribute "mode" calculation. (*movdf_internal_rex64) : Remove MODE_TI handling. Simplify MODE_V1DF and MODE_V2SF handling.

Re: [Patch, Fortran] Fix -fcheck=pointer for F2008's NULL ptr to optional arguments

2011-06-05 Thread Thomas Koenig
Hi Tobias, The NULL pointer check (-fcheck=pointer) was wrong for Fortran 2008: It is now allowed to pass a null pointer (or not associated allocatables) to optional arguments to denote absent arguments. Build and regtested on x86-64-linux. OK for the trunk? OK. Thanks for the patch!

[v3] fix typos in ptr_traits.h and specialize for pointer adapter

2011-06-05 Thread Jonathan Wakely
2011-06-05 Jonathan Wakely * include/bits/ptr_traits.h (pointer_traits): Fix typos. * include/ext/pointer.h (pointer_traits): Add partial specialization for _Pointer_adapter. This fixes a couple of dumb mistakes in pointer_traits (type vs __type and not actually declari

Re: [Patch, Fortran] Fix -fcheck=pointer for F2008's NULL ptr to optional arguments

2011-06-05 Thread Tobias Burnus
*ping* On 1 June 2011, Tobias Burnus wrote: The NULL pointer check (-fcheck=pointer) was wrong for Fortran 2008: It is now allowed to pass a null pointer (or not associated allocatables) to optional arguments to denote absent arguments. Build and regtested on x86-64-linux. OK for the trunk?

PATCH [1/n]: Add initial -x32 support

2011-06-05 Thread H.J. Lu
Hi, I'd like to start submitting a series of patches to enable x32: https://sites.google.com/site/x32abi/ The GCC x32 branch is very stable. There are no unexpected failures in C, C++, Fortran and Objective C testsuites. SPEC CPU 2K/2006 compile and run correctly at -O2 and -O3. More than 90%

[x32] PATCH: Document -mx32

2011-06-05 Thread H.J. Lu
Hi, I checked this patch into x32 branch. H.J. --- commit d1dfec734d8981b05873187443fd758abc93973a Author: H.J. Lu Date: Sun Jun 5 12:10:01 2011 -0700 Document -mx32. diff --git a/gcc/ChangeLog.x32 b/gcc/ChangeLog.x32 index 3a5b9e7..8c52f9d 100644 --- a/gcc/ChangeLog.x32 +++ b/gcc/Chang

Re: never ending output from -fdump-fortran-original on ENTRY statement

2011-06-05 Thread Thomas Koenig
Hi Andreas, I have committed your patch with a slight variation to trunk as obvious after regression-testting. Will commit to 4.6 in a few days. No test case because we can't do test cases with -fdump-fortran-* at the moment. This patch is small enough so it does not need a copyright assignmen

Re: Fix for PR objc/49287

2011-06-05 Thread Mike Stump
On Jun 5, 2011, at 6:07 AM, Nicola Pero wrote: > This patch fixes PR objc/49287. The problem is that enabling the compiler > checks > for missing @interfaces triggered a couple of warnings of missing @interfaces > in some > testcases (this only showed up with the NeXT runtime because objc_getCl

Re: -fdump-passes -fenable-xxx=func_name_list

2011-06-05 Thread Xinliang David Li
Is this one ok? Thanks, David On Thu, Jun 2, 2011 at 12:12 AM, Xinliang David Li wrote: > This is the version of the patch that walks through pass lists. > > Ok with this one? > > David > > On Wed, Jun 1, 2011 at 12:45 PM, Xinliang David Li wrote: >> On Wed, Jun 1, 2011 at 12:29 PM, Richard Gu

Re: -fdump-passes -fenable-xxx=func_name_list

2011-06-05 Thread Xinliang David Li
Is this patch ok? Thanks, David On Wed, Jun 1, 2011 at 10:24 AM, Xinliang David Li wrote: > The attached is the split #1 patch that enhances -fenable/disable. > > Ok after testing? > > Thanks, > David > > On Wed, Jun 1, 2011 at 9:16 AM, Xinliang David Li wrote: >> On Wed, Jun 1, 2011 at 1:51 A

Re: [PATCH] fixincludes/Makefile for Interix

2011-06-05 Thread Bruce Korb
On 06/04/11 13:43, Douglas B Rupp wrote: Here's my proposed patch, along the lines you suggested. Hi Doug, Excellent. Just a couple nits: It is more normal and easier to read when you quote the entire shell script fragment, as below (removing unnecessary "eval", too): diff -rupN gcc.orig/f

Fix for PR objc/49287

2011-06-05 Thread Nicola Pero
This patch fixes PR objc/49287. The problem is that enabling the compiler checks for missing @interfaces triggered a couple of warnings of missing @interfaces in some testcases (this only showed up with the NeXT runtime because objc_getClass() is treated specially only with the NeXT runtime; we

libobjc: Fixed gnu-api-2-objc.m testcase

2011-06-05 Thread Nicola Pero
This patch fixes two errors in the gnu-api-2-objc.m testcase for libobjc's Modern Objective-C API. One of them is that class_addIvar() was called with the alignment, instead of the log2 of the alignment, being passed as argument. The error slipped in because a previous, buggy version of libobj