Go patch committed: Use backend interface for interface types

2011-05-05 Thread Ian Lance Taylor
This patch to the Go frontend uses the backend interface for interface types. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 37dae2a9c21b go/gogo-tree.cc --- a/go/gogo-tree.cc Wed May 04 08:38:47 2011 -0700 +++ b/go/gogo-tree.cc Wed May 04 22:18

Re: [patch] Fix DWARF so types with subprogram definitions don't get moved to type unit (issue4433068) (issue4433068)

2011-05-05 Thread Jason Merrill
OK. Jason

Re: [PATCH] Cleanup expand_shift

2011-05-05 Thread Hans-Peter Nilsson
On Thu, 5 May 2011, Richard Guenther wrote: > On Wed, 4 May 2011, Richard Guenther wrote: > > On Wed, 4 May 2011, Eric Botcazou wrote: > > Hm. I guess people will scream if something breaks (I can't imagine > > what though). AAAaaarghh! Building cris-elf is now broken. > I have applied the foll

Fix PR48900, powerpc duplicate __tls_get_addr calls

2011-05-05 Thread Alan Modra
My fix for PR44266 using the libcall machinery to ensure we had a proper stack frame allocated for __tls_get_addr calls sloppily used r3 as the arg to the dummy libcall. This made the call seem to depend on whatever was in r3 previously, at least until we get to the first split pass and the real a

[patch] Fix DWARF so types with subprogram definitions don't get moved to type unit (issue4433068) (issue4433068)

2011-05-05 Thread Cary Coutant
commit bf6ab23aad749d927108ace21ee01a94af31a38b Author: Cary Coutant Date: Mon Apr 25 13:54:19 2011 -0700 Check for classes that contain defining declarations of subprograms, and do not move such classes into a comdat type unit. I've updated the patch to assert that a type definiti

Re: [PATCH] Fix PR c++/48574

2011-05-05 Thread Jason Merrill
How about type_dependent_expression_p_push instead? Jason

Re: [PATCH, powerpc], Fix PR48857, pass/return V2DI as other vector types

2011-05-05 Thread David Edelsohn
On Tue, May 3, 2011 at 5:27 PM, Michael Meissner wrote: > When I added VSX support to the powerpc, I overlooked passing and return > V2DImode arguments, since the only machine operation that supports V2DI is > vector floating point conversion.  Consequentally, V2DI types were passed and > returned

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread David Edelsohn
On Thu, May 5, 2011 at 3:34 PM, Joseph S. Myers wrote: > On Thu, 5 May 2011, Michael Eager wrote: > >> David Edelsohn wrote: >> > On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers >> > wrote: >> > >> > > Two options, -mcmodel= and -mfpu=, had cases that fell through to the >> > > next case without

Re: [PATCH] Fix PR c++/48838

2011-05-05 Thread Jason Merrill
OK. Jason

[PATCH] Fix PR c++/48574

2011-05-05 Thread Dodji Seketeli
Hello, This is a leftover of the fix for PR c++/48574. When fold_non_dependent_expr sees the lvalue reference 'b' in the example of the patch below (because in finish_call_expr, make_args_non_dependent on 'b' calls build_non_dependent_expr which calls null_ptr_cst_p which calls fold_non_dependent

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Alan Modra
On Thu, May 05, 2011 at 11:29:13AM -0400, David Edelsohn wrote: > Alan, is mcmodel suppose to set m64? No, that was an accident. -- Alan Modra Australia Development Lab, IBM

Re: [PATCH] Fix PR c++/48838

2011-05-05 Thread Dodji Seketeli
Jason Merrill writes: > On 05/05/2011 03:52 PM, Dodji Seketeli wrote: >> + if (is_overloaded_fn (fn)) >> +fn = get_first_fn (fn); >> + else if (BASELINK_P (fn)) > > is_overloaded_fn should be true for a BASELINK. Correct. I should have seen that. I have bootstrapped the patch below then.

Re: [pph] Save keyed_classes, unemitted_tinfo_decls, TYPE_BINFO (issue4486042)

2011-05-05 Thread Lawrence Crowl
On 5/5/11, dnovi...@google.com wrote: > http://codereview.appspot.com/4486042/diff/1/gcc/cp/pph-streamer.h > File gcc/cp/pph-streamer.h (right): > > http://codereview.appspot.com/4486042/diff/1/gcc/cp/pph-streamer.h#newcode152 > gcc/cp/pph-streamer.h:152: for (i = 0; i < c; ++i) > +#if 0 > +static

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Michael Meissner
On Thu, May 05, 2011 at 03:08:43PM -0400, Michael Meissner wrote: > Yes, it was an error on my part. Sorry. I will fix the GCC 4.6 branch. I > will hold off fixing the on trunk, on the assumption this patch will go in. I > can fix it if desired. I committed the following patch on the GCC 4.6 b

Re: [pph] Save keyed_classes, unemitted_tinfo_decls, TYPE_BINFO (issue4486042)

2011-05-05 Thread dnovillo
http://codereview.appspot.com/4486042/diff/1/gcc/cp/pph-streamer.h File gcc/cp/pph-streamer.h (right): http://codereview.appspot.com/4486042/diff/1/gcc/cp/pph-streamer.h#newcode152 gcc/cp/pph-streamer.h:152: for (i = 0; i < c; ++i) +#if 0 +static inline void +pph_output_tree_array (pph_stream *s

Re: [patch] Fix DWARF so types with subprogram definitions don't get moved to type unit (issue4433068)

2011-05-05 Thread Jason Merrill
On 05/05/2011 05:33 PM, ccout...@google.com wrote: I couldn't convince myself that a subprogram definition inside a type declaration would never happen, so I took the defensive approach. If you're confident that it can't (or shouldn't) ever happen, then what if I leave the predicate contains_subp

Re: [patch] Fix DWARF so types with subprogram definitions don't get moved to type unit (issue4433068)

2011-05-05 Thread ccoutant
It's a good check to add, but if it returns true we should abort rather than just returning 0. I couldn't convince myself that a subprogram definition inside a type declaration would never happen, so I took the defensive approach. If you're confident that it can't (or shouldn't) ever happen, t

[pph] Save keyed_classes, unemitted_tinfo_decls, TYPE_BINFO (issue4486042)

2011-05-05 Thread Lawrence Crowl
Save and restored globals keyed_classes and unemitted_tinfo_decls. Save and restore member TYPE_BINFO. Index: gcc/cp/ChangeLog.pph 2011-05-05 Lawrence Crowl * pph.c (pph_write_file_contents): Save keyed_classes and unemitted_tinfo_decls. (pph_read_file_contents): Restor

[graphite] Merge from trunk

2011-05-05 Thread Sebastian Pop
Hi, I just merged the changes from trunk into the graphite branch: 2010-05-05 Sebastian Pop * Merge from mainline (170411:173446).

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Michael Eager
Joseph S. Myers wrote: On Thu, 5 May 2011, Michael Eager wrote: David Edelsohn wrote: On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers wrote: Two options, -mcmodel= and -mfpu=, had cases that fell through to the next case without comments to indicate if this was intended. I added comments t

Re: [PATCH, powerpc], Fix PR48857, pass/return V2DI as other vector types

2011-05-05 Thread Uros Bizjak
Hello! > In this case, GCC wasn't following the ABI. My patch will have GCC follow the > ABI. The XL compiler also follows the ABI. So we have to decide whether to > keep the current calling sequence which violates the ABI, or change the > compiler to follow the ABI, and break backwards compati

Re: [PATCH] Fix PR c++/48838

2011-05-05 Thread Jason Merrill
On 05/05/2011 03:52 PM, Dodji Seketeli wrote: + if (is_overloaded_fn (fn)) +fn = get_first_fn (fn); + else if (BASELINK_P (fn)) is_overloaded_fn should be true for a BASELINK. Jason

Re: [Patch, Fortran] -std=f2008tr, TR 29113 and OPTIONAL arguments with BIND(C)

2011-05-05 Thread Tobias Burnus
Build and regtested on x86-64-linux OK for the trunk? I forgot to include a run-time test case. Find one attached. Tobias ! { dg-do run } ! { dg-additional-sources bind_c_usage_24_c.c } ! ! PR fortran/48858 ! PR fortran/48820 ! ! TR 29113: BIND(C) with OPTIONAL ! module m use iso_c_binding

minor C++ PATCH to REFERENCE_REF_P

2011-05-05 Thread Jason Merrill
While working on something else I noticed that REFERENCE_REF_P was being clobbered by stabilize_expr, so this patch changes it to just use the type rather than a lang_flag. Tested x86_64-pc-linux-gnu, applying to trunk. commit f24566a2f2594c7d4c7d7d3e26a4341d87deaec6 Author: Jason Merrill Date

Re: [PATCH] Fix PR c++/48838

2011-05-05 Thread Dodji Seketeli
Jason Merrill writes: > I think using get_first_fn could make non_static_member_function_p a > lot shorter. Like this? Tested like the previous patch. gcc/cp PR c++/48838 * cp-tree.h (non_static_member_function_p): Declare new function. * tree.c (non_static_member_func

[PATCH, Ada] PR ada/47818 - Pragma Assert rejected with No_Implementation_Pragmas restriction

2011-05-05 Thread Eugeniy Meshcheryakov
Hello, Compilation of code containing pragma Assert fails if restriction No_Implementation_Pragmas is used, even with -gnat2005 or -gnat2012 flags: % cat test.adb pragma Restrictions(No_Implementation_Pragmas); procedure test(I : Integer) is begin pragma Assert(I /= 1); null; end; % gcc -c t

Re: [google] improves option mismatch handling for LIPO (issue4479045)

2011-05-05 Thread Diego Novillo
On Thu, May 5, 2011 at 01:36, David Li wrote: > This patch improves cross module option mismatch handling in LIPO mode -- > will be commited to google/main. > > 1) Remove duplicates in the option list before comparison; > 2) Force module incompatiblity when two modules disagree in -fexceptions >

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Joseph S. Myers
On Thu, 5 May 2011, Michael Eager wrote: > David Edelsohn wrote: > > On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers > > wrote: > > > > > Two options, -mcmodel= and -mfpu=, had cases that fell through to the > > > next case without comments to indicate if this was intended. I added > > > commen

Re: [PATCH, powerpc], Fix PR48857, pass/return V2DI as other vector types

2011-05-05 Thread Michael Meissner
On Wed, May 04, 2011 at 11:33:43AM +0200, Richard Guenther wrote: > On Wed, May 4, 2011 at 4:51 AM, David Edelsohn wrote: > > What does this do to the ABI?  Haven't we now broken the ABI and > > broken backwards compatibility? > > It at least looks like so. You need to add appropriate changes.ht

Re: [PATCH, powerpc], Fix PR48857, pass/return V2DI as other vector types

2011-05-05 Thread Michael Meissner
On Tue, May 03, 2011 at 10:51:51PM -0400, David Edelsohn wrote: > What does this do to the ABI? Haven't we now broken the ABI and > broken backwards compatibility? In this case, GCC wasn't following the ABI. My patch will have GCC follow the ABI. The XL compiler also follows the ABI. So we hav

rs6000_handle_option global state avoidance, part 2

2011-05-05 Thread Joseph S. Myers
This patch continues work on avoiding global state in rs6000_handle_option by cleaning up the handling of -mabi= options. The part using global state, a test for TARGET_SPE_ABI, is moved to rs6000_option_override_internal (so now testing the state after all options are applied). The -mabi= option

Re: [google][RFA] add extra text to stack frame warnings (issue4479046)

2011-05-05 Thread Andrew Pinski
On Thu, May 5, 2011 at 11:47 AM, Diego Novillo wrote: >> OK for google/main? Is there a reason why this cannot be an option that someone passes on the command line of GCC instead of a configure option? Also can you show an example of why this message would be changed? Thanks, Andrew Pinski

[Patch,Fortran] Minor libcaf cleanup

2011-05-05 Thread Tobias Burnus
Changes: - Remove (not working) critical functions; a normal coarray of LOCK type should be used instead. (Stub left in until it is removed the the front end.) - Added prototypes and stub implementations for registering/deregistering coarray (currently unused). - Small bug fixes. OK for th

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Michael Meissner
On Thu, May 05, 2011 at 10:08:24AM -0700, Michael Eager wrote: > David Edelsohn wrote: > >On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers > >wrote: > > > >>Two options, -mcmodel= and -mfpu=, had cases that fell through to the > >>next case without comments to indicate if this was intended. I add

Re: [google][RFA] add extra text to stack frame warnings (issue4479046)

2011-05-05 Thread Diego Novillo
On Thu, May 5, 2011 at 14:27, Chris Demetriou wrote: > Diego, > > I know this is a truly horrible and broken way to do this, but alternatives > (e.g., NLS) don't really work for us. > > bootstrapped without new configuration (x86-64 ubuntu lucid, didn't bother > to run tests), bootstrapped with op

Re: Committed: fd_truncate test-cases updated for recent libgfortran changes

2011-05-05 Thread Hans-Peter Nilsson
> Date: Thu, 5 May 2011 19:36:47 +0300 > From: Janne Blomqvist > On Thu, May 5, 2011 at 00:52, Hans-Peter Nilsson > wrote: > > This time, it happened in 173155:173168. > > > > Usually, there's also a brief question whether all changes were > > intended, or perhaps that some of the regressing tes

[google][RFA] add extra text to stack frame warnings (issue4479046)

2011-05-05 Thread Chris Demetriou
Diego, I know this is a truly horrible and broken way to do this, but alternatives (e.g., NLS) don't really work for us. bootstrapped without new configuration (x86-64 ubuntu lucid, didn't bother to run tests), bootstrapped with option (x86-64 ubuntu lucid, with full tests, no regressions). Manu

Re: newlib vs. libiberty mismatch breaks build (Re: [PATCH] Export psignal on all platforms)

2011-05-05 Thread DJ Delorie
IIRC there's a compile-time way to test for prototypes at least.

Re: [PATCH 2/4] Docs: extend.texi: Remove trailing blanks from lines

2011-05-05 Thread Michael Witten
On Thu, May 5, 2011 at 09:32, Richard Guenther wrote: > And yes, in "harm" I mostly refer to svn blame annoyances and to > patch/branch merge conflicts where context that causes the conflict > only changed in whitespace. Your tools are limiting the quality of your work. Are we not the toolmakers

Re: Committed: fd_truncate test-cases updated for recent libgfortran changes

2011-05-05 Thread Mike Stump
On May 5, 2011, at 9:36 AM, Janne Blomqvist wrote: > The testsuite uses the process return value to determine > success, right? But which values exactly constitute success > vs. failure? 0 is success, and != 0 is failure.

Re: newlib vs. libiberty mismatch breaks build (Re: [PATCH] Export psignal on all platforms)

2011-05-05 Thread Ulrich Weigand
DJ Delorie wrote: > No, we've always hard-coded what newlib does to avoid the link > problems. I think we should continue with that for now. > > I suspect we need to AC_DEFINE(HAVE_PSIGNAL) Corinna Vinschen had the same suggestion: > Sorry about that. I guess that should have been something alo

Re: Libiberty: POSIXify psignal definition

2011-05-05 Thread Andrew Pinski
On Thu, May 5, 2011 at 12:54 AM, Corinna Vinschen wrote: > On May  5 00:40, Andrew Pinski wrote: >> On Thu, May 5, 2011 at 12:30 AM, Corinna Vinschen >> wrote: >> > Thanks, >> > Corinna >> > >> > >> >        * strsignal.c (psignal): Change second parameter to const char *. >> >        Fix commen

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread Michael Eager
David Edelsohn wrote: On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers wrote: Two options, -mcmodel= and -mfpu=, had cases that fell through to the next case without comments to indicate if this was intended. I added comments to make the semantics explicit. Given the documentation, it may wel

Re: [google] Patch to support calling multi-versioned functions via new GCC builtin. (issue4440078)

2011-05-05 Thread Xinliang David Li
On Thu, May 5, 2011 at 2:16 AM, Richard Guenther wrote: > On Thu, May 5, 2011 at 12:19 AM, Xinliang David Li wrote: >>> >>> I can think of some more-or-less obvious high-level forms, one would >>> for example simply stick a new DISPATCH tree into gimple_call_fn >>> (similar to how we can have OBJ

Re: newlib vs. libiberty mismatch breaks build (Re: [PATCH] Export psignal on all platforms)

2011-05-05 Thread DJ Delorie
> You don't mean the prototype, do you? IMHO the char * should still be > changed to const char * to adhere to POSIX. So far, it's served as a good tool for detecting when libiberty's configure isn't doing its job :-) At this point, we should avoid "fixing" it until the newlib/configure issue i

Re: newlib vs. libiberty mismatch breaks build (Re: [PATCH] Export psignal on all platforms)

2011-05-05 Thread DJ Delorie
No, we've always hard-coded what newlib does to avoid the link problems. I think we should continue with that for now. I suspect we need to AC_DEFINE(HAVE_PSIGNAL)

Re: newlib vs. libiberty mismatch breaks build (Re: [PATCH] Export psignal on all platforms)

2011-05-05 Thread Corinna Vinschen
On May 5 18:44, Ulrich Weigand wrote: > DJ Delorie wrote: > > > I don't know how to avoid this problem in configure, other than by adding > > > AC_LIBOBJ([psignal]). > > > > Right, the correct solution is - libiberty shouldn't provide psignal > > if newlib does. Making it match newlib is the wro

Re: newlib vs. libiberty mismatch breaks build (Re: [PATCH] Export psignal on all platforms)

2011-05-05 Thread Corinna Vinschen
On May 5 11:29, DJ Delorie wrote: > > > I don't know how to avoid this problem in configure, other than by adding > > AC_LIBOBJ([psignal]). > > Right, the correct solution is - libiberty shouldn't provide psignal > if newlib does. Making it match newlib is the wrong solution. You don't mean th

Re: newlib vs. libiberty mismatch breaks build (Re: [PATCH] Export psignal on all platforms)

2011-05-05 Thread Ulrich Weigand
DJ Delorie wrote: > > I don't know how to avoid this problem in configure, other than by adding > > AC_LIBOBJ([psignal]). > > Right, the correct solution is - libiberty shouldn't provide psignal > if newlib does. Making it match newlib is the wrong solution. I guess I agree, but the problem is e

Re: Committed: fd_truncate test-cases updated for recent libgfortran changes

2011-05-05 Thread Janne Blomqvist
On Thu, May 5, 2011 at 00:52, Hans-Peter Nilsson wrote: > Once or twice a year some regression results from changed I/O > in libgfortran, such that some existing test-case starts > calling libgfortran/io/unix.c:raw_truncate, which on > limited-I/O-bare-iron targets will emit "required ftruncate or

Re: copy_tree_r and STATEMENT_LIST (was Re: C++ PATCHes relating to c++/48834, c++/40975 (array new))

2011-05-05 Thread Richard Henderson
On 05/05/2011 07:09 AM, Jason Merrill wrote: > No, but the rationale isn't documented. It was added by the patch > that introduced STATEMENT_LIST, > > http://gcc.gnu.org/ml/gcc-patches/2003-11/msg00879.html > > but doesn't appear in the ChangeLog entry. I notice that in that > patch unsave_r c

Re: [PATCH] don't use build_function_type in the ObjC/C++ frontends

2011-05-05 Thread Mike Stump
On May 4, 2011, at 8:17 PM, Nathan Froyd wrote: > The last remaining uses of build_function_type in the ObjC/C++ frontends > comes from this pattern: > OK to commit? Ok. >

[Ada] Fix ICE on assignment of aggregate with discriminated record type

2011-05-05 Thread Eric Botcazou
This is PR ada/48844, a regression present on the mainline and 4.6 branch. The compiler aborts on an assignment of an aggregate to another object, if the nominal subtype of the former is a discriminated record type with a variant part for which the variants all have the same size and one of the v

RFA: Improve jump threading 5 of N

2011-05-05 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I should have included these in the last patch of infrastructure changes. The main change is create_block_for_threading no longer calls remove_ctrl_stmt_and_useless_edges and instead its callers are expected to handle that, when needed. This will al

Re: newlib vs. libiberty mismatch breaks build (Re: [PATCH] Export psignal on all platforms)

2011-05-05 Thread DJ Delorie
> I don't know how to avoid this problem in configure, other than by adding > AC_LIBOBJ([psignal]). Right, the correct solution is - libiberty shouldn't provide psignal if newlib does. Making it match newlib is the wrong solution.

Re: rs6000_handle_option global state avoidance, part 1

2011-05-05 Thread David Edelsohn
On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers wrote: > Two options, -mcmodel= and -mfpu=, had cases that fell through to the > next case without comments to indicate if this was intended.  I added > comments to make the semantics explicit.  Given the documentation, it > may well be intentional

Re: [PATCH] Fix up typed DWARF stack support for POINTERS_EXTEND_UNSIGNED targets (PR debug/48853)

2011-05-05 Thread Jason Merrill
On 05/05/2011 10:56 AM, Jakub Jelinek wrote: We can't handle Pmode void* like other pointers? mem_mode == VOIDmode doesn't mean a void* pointer, mem_mode != VOIDmode means mem_loc_descriptor is called on some MEM's address and gives the mode of the MEM, while VOIDmode mem_mode means it isn't a

Re: [Patch ARM] PR47930 Fix documentation for marm / mthumb

2011-05-05 Thread Richard Earnshaw
On Thu, 2011-05-05 at 14:00 +0100, Ramana Radhakrishnan wrote: > > The arm.opt change is OK, but 'Report' should stay; and it should also > > be added to the -marm case. > > Ok with this change ? Rebuilt docs and built a cross with arm-linux-gnueabi ? > > 2011-05-05 Ramana Radhakrishnan > >

Re: [PATCH] Fix up typed DWARF stack support for POINTERS_EXTEND_UNSIGNED targets (PR debug/48853)

2011-05-05 Thread Jakub Jelinek
On Thu, May 05, 2011 at 10:25:53AM -0400, Jason Merrill wrote: > >+ && (mode != Pmode > >+ || GET_MODE_SIZE (ptr_mode) != DWARF2_ADDR_SIZE > > This test seems overly cautious; it seems implausible to have > DWARF2_ADDR_SIZE smaller than GET_MODE_SIZE (ptr_mode), and having >

C++ PATCH for c++/48873 (unnecessary dtor calls in new-expressions)

2011-05-05 Thread Jason Merrill
Here the issue was that build_new_1 wants to stabilize any constructor arguments so that the EH region for deleting the allocated memory can be as small as possible. But stabilize_expr was being over-eager, making a copy of a class with trivial constructors, but a non-trivial (and indeed non-c

Re: [PATCH] Fix up typed DWARF stack support for POINTERS_EXTEND_UNSIGNED targets (PR debug/48853)

2011-05-05 Thread Jason Merrill
+ && (mode != Pmode + || GET_MODE_SIZE (ptr_mode) != DWARF2_ADDR_SIZE This test seems overly cautious; it seems implausible to have DWARF2_ADDR_SIZE smaller than GET_MODE_SIZE (ptr_mode), and having it be larger doesn't seem like a problem. + || m

[gomp3.1] Adjust omp_in_final

2011-05-05 Thread Jakub Jelinek
Hi! According to a clarification on OpenMP forums, if(0) which creates an undeferred task doesn't mean if the implementation chooses to schedule it right away that it is included task. Included tasks are thus only the children tasks of some final task. Fixed thusly: 2011-05-05 Jakub Jelinek

copy_tree_r and STATEMENT_LIST (was Re: C++ PATCHes relating to c++/48834, c++/40975 (array new))

2011-05-05 Thread Jason Merrill
On 05/04/2011 06:57 PM, Eric Botcazou wrote: But you're unilaterally choosing one special handling (copying) among several ones (copying, not copying, aborting) just because of one caller, for no good reason IMO. It seems pretty straightforward to me that a function named copy_tree_r should co

Re: [PATCH][Revised] fix --enable-build-with-cxx on darwin

2011-05-05 Thread Richard Guenther
On Thu, May 5, 2011 at 2:58 PM, Jack Howarth wrote: > Currently the bootstrap with --enable-build-with-cxx is broken due to > compiler errors of the form > "error: converting 'false' to pointer type 'varpool_node*' > [-Werror=conversion-null]". The attached > patch changes the last remaing insta

Re: [Testsuite Fortran, Patch] Add coarray/ directory for coarray compile and run-time tests

2011-05-05 Thread Rainer Orth
Tobias, I know Mike already approved that patch. Just a few nits. > # Test coarray support. > # > # For the compilation tests, all files are compiles with the ^ d > # option -fcoarray=single and with -fcoarray=lib

Re: [testsuite] Compile gfortran.dg/fmt_g0_6.f08 with -ffloat-store [fwd: tobias.bur...@physik.fu-berlin.de]

2011-05-05 Thread Rainer Orth
Jerry, > My goal is to completely not use any floating point operations for that > section of code. We have a concept on how to do it. I am still working > out tweaks to 48787, then I will turn my attention to this. Feel free to > quiet that test case any way you wish in the meantime. ok, I've

Re: [PATCH, ARM] fix PR pch/45979 regression on ARM

2011-05-05 Thread Ramana Radhakrishnan
> > OK for trunk? I have now committed this to trunk for you and will backport this to release branches at some point in the next few days. cheers Ramana > > -- Michael > > gcc/ > > 2011-05-02  Michael Hope   > >        PR pch/45979 >        * config/host-linux.c (TRY_EMPTY_VM_SPACE): Define fo

Re: [PATCH} fix --enable-build-with-cxx

2011-05-05 Thread Gabriel Dos Reis
On Thu, May 5, 2011 at 8:02 AM, Jack Howarth wrote: > On Thu, May 05, 2011 at 07:56:20AM -0500, Gabriel Dos Reis wrote: >> On Thu, May 5, 2011 at 7:55 AM, Jack Howarth >> wrote: >> > On Thu, May 05, 2011 at 02:02:19PM +0200, Eric Botcazou wrote: >> >> > Currently the bootstrap with --enable-buil

Re: [PATCH} fix --enable-build-with-cxx

2011-05-05 Thread Eric Botcazou
>I didn't see that patch so just reduce mine down to the change for > change for gcc/varpool.c. Odd that the gcc/varpool.c issue isn't seen on > other targets besides darwin apparently. No problem. Please install the entire patch (with Dmitry's name as second name) as Dmitry hasn't got commi

Re: [PATCH} fix --enable-build-with-cxx

2011-05-05 Thread Jack Howarth
On Thu, May 05, 2011 at 07:56:20AM -0500, Gabriel Dos Reis wrote: > On Thu, May 5, 2011 at 7:55 AM, Jack Howarth wrote: > > On Thu, May 05, 2011 at 02:02:19PM +0200, Eric Botcazou wrote: > >> > Currently the bootstrap with --enable-build-with-cxx is broken due to > >> > compiler errors of the form

Re: [Patch ARM] PR47930 Fix documentation for marm / mthumb

2011-05-05 Thread Ramana Radhakrishnan
> The arm.opt change is OK, but 'Report' should stay; and it should also > be added to the -marm case. Ok with this change ? Rebuilt docs and built a cross with arm-linux-gnueabi ? 2011-05-05 Ramana Radhakrishnan PR target/47930 * config/arm/arm.opt (marm): Document it. (

[PATCH][Revised] fix --enable-build-with-cxx on darwin

2011-05-05 Thread Jack Howarth
Currently the bootstrap with --enable-build-with-cxx is broken due to compiler errors of the form "error: converting 'false' to pointer type 'varpool_node*' [-Werror=conversion-null]". The attached patch changes the last remaing instance of false to NULL and restores the --enable-build-with-cxx

Re: [PATCH} fix --enable-build-with-cxx

2011-05-05 Thread Gabriel Dos Reis
On Thu, May 5, 2011 at 7:55 AM, Jack Howarth wrote: > On Thu, May 05, 2011 at 02:02:19PM +0200, Eric Botcazou wrote: >> > Currently the bootstrap with --enable-build-with-cxx is broken due to >> > compiler errors of the form "error: converting 'false' to pointer type >> > 'varpool_node*' [-Werror=

Re: [PATCH} fix --enable-build-with-cxx

2011-05-05 Thread Jack Howarth
On Thu, May 05, 2011 at 02:02:19PM +0200, Eric Botcazou wrote: > > Currently the bootstrap with --enable-build-with-cxx is broken due to > > compiler errors of the form "error: converting 'false' to pointer type > > 'varpool_node*' [-Werror=conversion-null]". The attached patch changes > > these in

Re: [PATCH, ARM] Fix NEON vset_lane for D registers

2011-05-05 Thread Richard Earnshaw
On Thu, 2011-05-05 at 13:08 +0100, Julian Brown wrote: > On Tue, 03 May 2011 15:49:38 +0100 > Richard Earnshaw wrote: > > > > > On Tue, 2011-05-03 at 13:49 +0100, Julian Brown wrote: > > > Hi, > > > > > > This patch fixes vset_lane intrinsic variants for D-register sized > > > variables. A typ

Re: [PATCH] Cleanup expand_shift

2011-05-05 Thread Richard Guenther
On Wed, 4 May 2011, Richard Guenther wrote: > On Wed, 4 May 2011, Eric Botcazou wrote: > > > > I think I did it that way because the old code tried to re-construct > > > the type of the original amount. I can surely simply use op1 here > > > if that is preferred. > > > > Right, but it used the

[PATCH, testsuite]: Fix gcc.target/i386/opt-[12].c on AVX target

2011-05-05 Thread Uros Bizjak
Hello! Add --param min-insn-to-prefetch-ratio=0 to avoid "Not prefetching -- instruction to prefetch ratio (6) too small" aprefetch pass rejection. 2011-05-05 Uros Bizjak * gcc.target/i386/opt-1.c: Add --param min-insn-to-prefetch -ratio=0 to dg-options. * gcc.target/i

Re: [PATCH, ARM] Fix NEON vset_lane for D registers

2011-05-05 Thread Julian Brown
On Tue, 03 May 2011 15:49:38 +0100 Richard Earnshaw wrote: > > On Tue, 2011-05-03 at 13:49 +0100, Julian Brown wrote: > > Hi, > > > > This patch fixes vset_lane intrinsic variants for D-register sized > > variables. A typo meant that the wrong lane would be set in many > > circumstances. > > >

[committed] Add testcase for PR rtl-optimization/48381

2011-05-05 Thread Jakub Jelinek
Hi! This PR has been fixed without testcase being added, fixed thusly, regtested on x86_64-linux and i686-linux, committed to trunk. 2011-05-05 Jakub Jelinek PR rtl-optimization/48381 * gcc.c-torture/compile/pr48381.c: New test. --- gcc/testsuite/gcc.c-torture/compile/pr48381

Re: [PATCH} fix --enable-build-with-cxx

2011-05-05 Thread Eric Botcazou
> Currently the bootstrap with --enable-build-with-cxx is broken due to > compiler errors of the form "error: converting 'false' to pointer type > 'varpool_node*' [-Werror=conversion-null]". The attached patch changes > these instances of false to NULL and restores the --enable-build-with-cxx > boo

[PATCH] Improve debug info for optimized away parameters passed in memory

2011-05-05 Thread Jakub Jelinek
Hi! On the attached enhanced typeddwarf.c testcase there is no location info for the 3 vars in f4 function with -O2 -m32 -g. The parameter is unused during expansion except for debug stmts, but DECL_INCOMING_RTL isn't a hard register or MEM with hard register as address that would be represented

Re: [google]: initialize language field for clone function struct

2011-05-05 Thread Eric Botcazou
> Hm, ok. I was more looking at removing the calls from fold-const.c where > it seems to protect things like folding x <= +Inf to x == x, stuff unlikely > to appear in type sizes. I can imagine the Ada FE wanting to do > things with type sizes and variable_size's wrapping looks like merely > an o

Re: Toplevel newlib/libgloss disabling cleanup

2011-05-05 Thread Paolo Bonzini
There is indeed more simplification possible (alpha-vms for example caught my attention while reviewing), but proceeding incrementally does not hurt. This patch is okay, thanks. Paolo 2011/5/4, Joseph S. Myers : > This patch separates cases disabling newlib and libgloss for various > target OSe

[PATCH} fix --enable-build-with-cxx

2011-05-05 Thread Jack Howarth
Currently the bootstrap with --enable-build-with-cxx is broken due to compiler errors of the form "error: converting 'false' to pointer type 'varpool_node*' [-Werror=conversion-null]". The attached patch changes these instances of false to NULL and restores the --enable-build-with-cxx bootstrap.

[PATCH, i386]: Simplify if conditions in i386.md

2011-05-05 Thread Uros Bizjak
Hello! No functional change. 2011-05-05 Uros Bizjak * config/i386/i386.md (*movdf_internal_rex64): Simplify nested "if" conditions. (*movdf_internal): Ditto. (*movdf_internal_nointeger): Ditto. (*movsf_internal): Ditto. Tested on x86_64-pc-linux-gnu {,

Re: [pph] Add streamer hook for preloading common nodes (issue4478043)

2011-05-05 Thread Diego Novillo
On Thu, May 5, 2011 at 07:07, Richard Guenther wrote: > For LTO we have type-merging for that, and we'd continue to pre-load > the type merger with the (LTO frontend specific) common tree nodes. OK. For LTO it may make sense to eventually make this hook a nop, then. > I suppose you are not doi

Re: [pph] Add streamer hook for preloading common nodes (issue4478043)

2011-05-05 Thread Richard Guenther
On Thu, May 5, 2011 at 1:03 PM, Diego Novillo wrote: > On Thu, May 5, 2011 at 05:06, Richard Guenther > wrote: > >> I think we should move away from pre-loading the streamer cache, that >> has caused enough trouble when the common nodes are originating from >> different Frontends and when compili

Re: [pph] Add streamer hook for preloading common nodes (issue4478043)

2011-05-05 Thread Diego Novillo
On Thu, May 5, 2011 at 05:06, Richard Guenther wrote: > I think we should move away from pre-loading the streamer cache, that > has caused enough trouble when the common nodes are originating from > different Frontends and when compiling units with different flags which > happen to change those n

Re: [google]: initialize language field for clone function struct

2011-05-05 Thread Richard Guenther
On Thu, May 5, 2011 at 12:07 PM, Eric Botcazou wrote: >> But where do you expand it without the SAVE_EXPR?  The same >> restrictions apply there.  So I suppose you expand it to a function >> in which case there is the context where the SAVE_EXPR can be >> expanded exactly once. > > You don't have

Re: [google]: initialize language field for clone function struct

2011-05-05 Thread Eric Botcazou
> But where do you expand it without the SAVE_EXPR? The same > restrictions apply there. So I suppose you expand it to a function > in which case there is the context where the SAVE_EXPR can be > expanded exactly once. You don't have SAVE_EXPRs so you're precisely controlling what you're doing.

Re: [PATCH] Remove useless build_variant_type call from create_tmp_var_raw

2011-05-05 Thread Richard Guenther
On Thu, May 5, 2011 at 11:25 AM, Jakub Jelinek wrote: > Hi! > > create_tmp_var_raw calls build_type_variant, but doesn't actually use > it in any way (other than set its TYPE_ATTRIBUTES, that's why > -Wunused-but-set-variable hasn't reported it. Ok. Thanks, Richard. > 2011-05-05  Jakub Jelinek

[commit, spu] Provide TARGET_ASM_OUTPUT_MI_THUNK implementation

2011-05-05 Thread Ulrich Weigand
Hello, this patch fixes the long-standing failure: FAIL: g++.old-deja/g++.jason/thunk3.C (test for excess errors) by providing a TARGET_ASM_OUTPUT_MI_THUNK implementation for SPU. Tested on spu-elf, committed to mainline. Bye, Ulrich ChangeLog: * config/spu/spu.c (TARGET_ASM_OUTPUT_MI

Re: [google]: initialize language field for clone function struct

2011-05-05 Thread Richard Guenther
On Thu, May 5, 2011 at 11:23 AM, Eric Botcazou wrote: >> Sure, but that's a limitation of out SAVE_EXPR handling (given that it >> would be ok to expand the SAVE_EXPR multiple times - once per >> "instantiation context"). > > You need to expand the initializer exactly once and you need to make sur

Re: [PATCH, ARM] PR47855 Compute attr length for thumb2 insns, 3/3 (issue4475042)

2011-05-05 Thread Richard Earnshaw
On Thu, 2011-05-05 at 14:51 +0800, Guozhi Wei wrote: > Hi > > This is the third part of the fixing for > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47855 > > This patch contains the length computation/refinement for insn patterns > "*thumb2_movsi_insn", "*thumb2_cbz" and "*thumb2_cbnz". > >

Re: [PATCH 2/4] Docs: extend.texi: Remove trailing blanks from lines

2011-05-05 Thread Richard Guenther
On Thu, May 5, 2011 at 1:57 AM, Mike Stump wrote: > On May 4, 2011, at 11:40 AM, Gerald Pfeifer wrote: >> Documentation may be a bit more relaxed, and if you have one doc >> maintainer approve and the other abstain that may be more boring >> that you might hope for. :-) > > Actually, I was aiming

[PATCH] Remove useless build_variant_type call from create_tmp_var_raw

2011-05-05 Thread Jakub Jelinek
Hi! create_tmp_var_raw calls build_type_variant, but doesn't actually use it in any way (other than set its TYPE_ATTRIBUTES, that's why -Wunused-but-set-variable hasn't reported it. 2011-05-05 Jakub Jelinek * gimplify.c (create_tmp_var_raw): Don't call build_type_variant. --- gcc/gim

Re: [google]: initialize language field for clone function struct

2011-05-05 Thread Eric Botcazou
> Sure, but that's a limitation of out SAVE_EXPR handling (given that it > would be ok to expand the SAVE_EXPR multiple times - once per > "instantiation context"). You need to expand the initializer exactly once and you need to make sure that this occurrence is invoked before all the others at r

Re: newlib vs. libiberty mismatch breaks build (Re: [PATCH] Export psignal on all platforms)

2011-05-05 Thread Corinna Vinschen
On May 5 11:09, Ulrich Weigand wrote: > This list does not include psignal, which indeed newlib did not provide > -- until yesterday, when that patch was committed ... > > > I'm not quite sure how to fix this ... any suggestions? Did this problem > occur in the past when newlib was extende

Re: [patch] Remove support for pending sizes

2011-05-05 Thread Bernd Schmidt
On 05/05/2011 09:38 AM, Eric Botcazou wrote: > Hi, > > this entirely removes the support for pending sizes from the compiler. The > prerequisite is Joseph's patch from yesterday. > > Bootstrapped/regtested on x86_64-suse-linux, OK for the mainline? OK. Bernd

[PATCH] Fix up typed DWARF stack support for POINTERS_EXTEND_UNSIGNED targets (PR debug/48853)

2011-05-05 Thread Jakub Jelinek
Hi! My typed DWARF stack changes apparently broke ia64-hpux and H.J.'s out of tree x32 target. There are several issues: 1) for SUBREG mem_loc_descriptor's 3rd argument was wrong, found by code inspection 2) CONST/SYMBOL_REF/LABEL_REF when in MEM addresses on POINTERS_EXTEND_UNSIGNED target

  1   2   >