Re: GIMPLE problem

On Wed, Jun 24, 2020 at 1:36 AM Gary Oblock via Gcc wrote: > > I'm somehow misusing GIMPLE (probably in multiple ways) and I need > some help in straightening out this little mess I've made. > > I'm trying to do the following: > > In an attempt at structure reorganization (instance interleaving) a

Re: Automatically generated ChangeLog files - script

On 6/22/20 3:15 PM, Alexandre Oliva wrote: On May 26, 2020, Martin Liška wrote: On 5/26/20 12:15 PM, Pierre-Marie de Rodat wrote:     * contracts.adb, einfo.adb, exp_ch9.adb, sem_ch12.adb, It's not supported right now and it will make the filename parsing much more complicated. Hell

[PATCH v2 1/5] gcc-plugins/stackleak: Don't instrument itself

There is no need to try instrumenting functions in kernel/stackleak.c. Otherwise that can cause issues if the cleanup pass of stackleak gcc plugin is disabled. Signed-off-by: Alexander Popov Acked-by: Kees Cook --- kernel/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/Makef

[PATCH v2 0/5] Improvements of the stackleak gcc plugin

This is the v2 of the patch series with various improvements of the stackleak gcc plugin. The first three patches disable unneeded gcc plugin instrumentation for some files. The fourth patch is the main improvement. It eliminates an unwanted side-effect of kernel code instrumentation performed by

[PATCH v2 3/5] arm64: vdso: Don't use gcc plugins for building vgettimeofday.c

Don't use gcc plugins for building arch/arm64/kernel/vdso/vgettimeofday.c to avoid unneeded instrumentation. Signed-off-by: Alexander Popov --- arch/arm64/kernel/vdso/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/

[PATCH v2 2/5] ARM: vdso: Don't use gcc plugins for building vgettimeofday.c

Don't use gcc plugins for building arch/arm/vdso/vgettimeofday.c to avoid unneeded instrumentation. Signed-off-by: Alexander Popov --- arch/arm/vdso/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/vdso/Makefile b/arch/arm/vdso/Makefile index d3c9f03e7e79..a5

[PATCH v2 5/5] gcc-plugins/stackleak: Add 'verbose' plugin parameter

Add 'verbose' plugin parameter for stackleak gcc plugin. It can be used for printing additional info about the kernel code instrumentation. For using it add the following to scripts/Makefile.gcc-plugins: gcc-plugin-cflags-$(CONFIG_GCC_PLUGIN_STACKLEAK) \ += -fplugin-arg-stackleak_plugin-verb

[PATCH v2 4/5] gcc-plugins/stackleak: Use asm instrumentation to avoid useless register saving

The kernel code instrumentation in stackleak gcc plugin works in two stages. At first, stack tracking is added to GIMPLE representation of every function (except some special cases). And later, when stack frame size info is available, stack tracking is removed from the RTL representation of the fun

Re: [PATCH v2 3/5] arm64: vdso: Don't use gcc plugins for building vgettimeofday.c

On Wed, Jun 24, 2020 at 03:33:28PM +0300, Alexander Popov wrote: > Don't use gcc plugins for building arch/arm64/kernel/vdso/vgettimeofday.c > to avoid unneeded instrumentation. > > Signed-off-by: Alexander Popov > --- > arch/arm64/kernel/vdso/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 2/5] ARM: vdso: Don't use gcc plugins for building vgettimeofday.c

On Wed, Jun 24, 2020 at 03:33:27PM +0300, Alexander Popov wrote: > Don't use gcc plugins for building arch/arm/vdso/vgettimeofday.c to > avoid unneeded instrumentation. > > Signed-off-by: Alexander Popov But why is skipping it safe? Luis

Re: [PATCH v2 5/5] gcc-plugins/stackleak: Add 'verbose' plugin parameter

On Wed, Jun 24, 2020 at 03:33:30PM +0300, Alexander Popov wrote: > Add 'verbose' plugin parameter for stackleak gcc plugin. > It can be used for printing additional info about the kernel code > instrumentation. > > For using it add the following to scripts/Makefile.gcc-plugins: > gcc-plugin-cfla

Re: [PATCH v2 2/5] ARM: vdso: Don't use gcc plugins for building vgettimeofday.c

On 24.06.2020 15:52, Luis Chamberlain wrote: > On Wed, Jun 24, 2020 at 03:33:27PM +0300, Alexander Popov wrote: >> Don't use gcc plugins for building arch/arm/vdso/vgettimeofday.c to >> avoid unneeded instrumentation. >> >> Signed-off-by: Alexander Popov > > But why is skipping it safe? Hello Lu

Re: [PATCH v2 5/5] gcc-plugins/stackleak: Add 'verbose' plugin parameter

On 24.06.2020 15:53, Luis Chamberlain wrote: > On Wed, Jun 24, 2020 at 03:33:30PM +0300, Alexander Popov wrote: >> Add 'verbose' plugin parameter for stackleak gcc plugin. >> It can be used for printing additional info about the kernel code >> instrumentation. >> >> For using it add the following t

Re: [PATCH v2 0/5] Improvements of the stackleak gcc plugin

On Wed, 24 Jun 2020 15:33:25 +0300, Alexander Popov wrote: > This is the v2 of the patch series with various improvements of the > stackleak gcc plugin. > > The first three patches disable unneeded gcc plugin instrumentation for > some files. > > The fourth patch is the main improvement. It elimi

Re: [PATCH v2 5/5] gcc-plugins/stackleak: Add 'verbose' plugin parameter

On Wed, Jun 24, 2020 at 04:09:20PM +0300, Alexander Popov wrote: > On 24.06.2020 15:53, Luis Chamberlain wrote: > > On Wed, Jun 24, 2020 at 03:33:30PM +0300, Alexander Popov wrote: > >> Add 'verbose' plugin parameter for stackleak gcc plugin. > >> It can be used for printing additional info about t

Re: [PATCH v2 3/5] arm64: vdso: Don't use gcc plugins for building vgettimeofday.c

On Wed, Jun 24, 2020 at 03:33:28PM +0300, Alexander Popov wrote: > Don't use gcc plugins for building arch/arm64/kernel/vdso/vgettimeofday.c > to avoid unneeded instrumentation. > > Signed-off-by: Alexander Popov It looks like Will has taken this already, but: Acked-by: Kees Cook -- Kees Coo

Re: [PATCH v2 1/5] gcc-plugins/stackleak: Don't instrument itself

On Wed, Jun 24, 2020 at 03:33:26PM +0300, Alexander Popov wrote: > There is no need to try instrumenting functions in kernel/stackleak.c. > Otherwise that can cause issues if the cleanup pass of stackleak gcc plugin > is disabled. > > Signed-off-by: Alexander Popov > Acked-by: Kees Cook Thanks!

Re: [PATCH v2 2/5] ARM: vdso: Don't use gcc plugins for building vgettimeofday.c

On Wed, Jun 24, 2020 at 03:33:27PM +0300, Alexander Popov wrote: > Don't use gcc plugins for building arch/arm/vdso/vgettimeofday.c to > avoid unneeded instrumentation. > > Signed-off-by: Alexander Popov Applied to for-next/gcc-plugins. -- Kees Cook

Re: [PATCH v2 5/5] gcc-plugins/stackleak: Add 'verbose' plugin parameter

On Wed, Jun 24, 2020 at 03:33:30PM +0300, Alexander Popov wrote: > Add 'verbose' plugin parameter for stackleak gcc plugin. > It can be used for printing additional info about the kernel code > instrumentation. > > For using it add the following to scripts/Makefile.gcc-plugins: > gcc-plugin-cfla

Re: GIMPLE problem

Richard, First off I did suspect INDIRECT_REF wasn't supported, thanks for confirming that. I tried what you said in the original code before I posted but I suspect how I went at it is the problem. I'm probably doing something(s) in a glaringly stupid way. Can you spot it, because everything I'm

Modula-2 into the GCC tree on master?

Hello GCC Steering Committee and fellow GCC developers, I was wondering whether now might be a sensible time to graft GNU Modula-2 into the GCC tree? (on the master branch only). At present gm2 fully implements PIM2, PIM3, PIM4 and ISO dialects of Modula-2. All the ISO libraries are implement

Re: Modula-2 into the GCC tree on master?

Hi, Gaius Thanks for your diligent effort to complete this port of Modula-2 and prepare it for inclusion in GCC. I have forwarded the proposal to the GCC Steering Committee. Thanks, David On Wed, Jun 24, 2020 at 5:03 PM Gaius Mulley via Gcc wrote: > > > Hello GCC Steering Committee and fellow