Re: [PATCH v1 1/2] drm/msm/dp: Fix support of LTTPR handling

2025-03-11 Thread Abel Vesa
On 25-03-10 22:05:51, Aleksandrs Vinarskis wrote: > Take into account LTTPR capabilities when selecting maximum allowed > link rate, number of data lines. Initialize LTTPR before > msm_dp_panel_read_sink_caps, as > a) Link params computation need to take into account LTTPR's caps > b) It appears DP

Re: [PATCH v5 1/2] drm/bridge: split HDMI Audio from DRM_BRIDGE_OP_HDMI

2025-03-11 Thread Maxime Ripard
On Mon, Mar 10, 2025 at 08:42:29PM +0200, Dmitry Baryshkov wrote: > On Mon, 10 Mar 2025 at 16:55, Maxime Ripard wrote: > > > > Hi, > > > > On Fri, Mar 07, 2025 at 07:55:52AM +0200, Dmitry Baryshkov wrote: > > > From: Dmitry Baryshkov > > > > > > As pointed out by Laurent, OP bits are supposed to

Re: [PATCH v1 2/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-11 Thread Johan Hovold
Hi Aleksandrs, Just a drive-by comment. On Mon, Mar 10, 2025 at 10:05:52PM +0100, Aleksandrs Vinarskis wrote: > @@ -1084,10 +1091,13 @@ static int msm_dp_ctrl_update_vx_px(struct > msm_dp_ctrl_private *ctrl) > } > > static bool msm_dp_ctrl_train_pattern_set(struct msm_dp_ctrl_private *ctrl,

[PATCH v1 1/2] drm/msm/dp: Fix support of LTTPR handling

2025-03-11 Thread Aleksandrs Vinarskis
Take into account LTTPR capabilities when selecting maximum allowed link rate, number of data lines. Initialize LTTPR before msm_dp_panel_read_sink_caps, as a) Link params computation need to take into account LTTPR's caps b) It appears DPTX shall (re)read DPRX caps after LTTPR detection Return lt

Re: [PATCH v5 1/2] drm/bridge: split HDMI Audio from DRM_BRIDGE_OP_HDMI

2025-03-11 Thread Maxime Ripard
On Tue, Mar 11, 2025 at 05:50:09PM +0200, Dmitry Baryshkov wrote: > On Tue, Mar 11, 2025 at 09:36:37AM +0100, Maxime Ripard wrote: > > On Mon, Mar 10, 2025 at 08:42:29PM +0200, Dmitry Baryshkov wrote: > > > On Mon, 10 Mar 2025 at 16:55, Maxime Ripard wrote: > > > > > > > > Hi, > > > > > > > > On F

Re: [PATCH v2 09/10] drm/bridge: anx7625: update bridge_ops and sink detect logic

2025-03-11 Thread Dmitry Baryshkov
On Tue, Mar 11, 2025 at 05:54:44PM +0530, Ayushi Makhija wrote: > The anx7625_link_bridge() checks if a device is not a panel > bridge and add DRM_BRIDGE_OP_HPD and DRM_BRIDGE_OP_DETECT to > the bridge operations. However, on port 1 of the anx7625 > bridge, any device added is always treated as a p

[PATCH v4 04/25] drm/gem-shmem: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 8. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_shmem_helper.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/d

[PATCH v4 21/25] drm/virtio: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 4. Signed-off-by: Thomas Zimmermann Cc: David Airlie Cc: Gerd Hoffmann Cc: Gurchetan Singh Cc: Chia-I Wu --- drivers/gpu/drm/virtio/virtgpu_gem.c | 11 +-- 1 file changed

[PATCH v4 03/25] drm/gem-dma: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 8. Push the current calculation into the only direct caller imx. Imx's hardware requires the framebuffer width to be aligned to 8. The driver's current approach is actually incorrect,

[PATCH v4 12/25] drm/mediatek: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 8. Signed-off-by: Thomas Zimmermann Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: Matthias Brugger Cc: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_gem.c | 13 --

[PATCH v4 10/25] drm/imx/ipuv3: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. The hardware requires the framebuffer width to be a multiple of 8. The scanline pitch has be large enough to support this. Therefore compute the byte size of 8 pixels in the given color mode and align the pitch accordi

[PATCH v4 25/25] drm/xlnx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch according to hardware requirements. Signed-off-by: Thomas Zimmermann Cc: Laurent Pinchart Cc: Tomi Valkeinen --- drivers/gpu/drm/xlnx/zynqmp_kms.c | 7 +-- 1 file changed, 5 insertions(+), 2 de

[PATCH v4 20/25] drm/tegra: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch according to hardware requirements. Signed-off-by: Thomas Zimmermann Acked-by: Thierry Reding Cc: Thierry Reding Cc: Mikko Perttunen --- drivers/gpu/drm/tegra/gem.c | 8 +--- 1 file changed, 5

[PATCH v4 16/25] drm/qxl: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. No alignment required. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_dumb.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/dr

Re: [PATCH v5 2/2] drm/msm/dp: reuse generic HDMI codec implementation

2025-03-11 Thread Dmitry Baryshkov
On Tue, Mar 11, 2025 at 09:41:13AM +0100, Maxime Ripard wrote: > Hi, > > On Mon, Mar 10, 2025 at 08:53:24PM +0200, Dmitry Baryshkov wrote: > > On Mon, 10 Mar 2025 at 17:08, Maxime Ripard wrote: > > > > > > On Fri, Mar 07, 2025 at 07:55:53AM +0200, Dmitry Baryshkov wrote: > > > > From: Dmitry Bary

Re: [PATCH v5 1/2] drm/bridge: split HDMI Audio from DRM_BRIDGE_OP_HDMI

2025-03-11 Thread Dmitry Baryshkov
On Tue, Mar 11, 2025 at 09:36:37AM +0100, Maxime Ripard wrote: > On Mon, Mar 10, 2025 at 08:42:29PM +0200, Dmitry Baryshkov wrote: > > On Mon, 10 Mar 2025 at 16:55, Maxime Ripard wrote: > > > > > > Hi, > > > > > > On Fri, Mar 07, 2025 at 07:55:52AM +0200, Dmitry Baryshkov wrote: > > > > From: Dmit

Re: [PATCH v2 06/10] arm64: dts: qcom: sa8775p: add Display Serial Interface device nodes

2025-03-11 Thread Dmitry Baryshkov
On Tue, Mar 11, 2025 at 05:54:41PM +0530, Ayushi Makhija wrote: > Add device tree nodes for the DSI0 and DSI1 controllers > with their corresponding PHYs found on Qualcomm SA8775P SoC. > > Signed-off-by: Ayushi Makhija > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 186 +

Re: [PATCH v2 08/10] drm/bridge: anx7625: enable HPD interrupts

2025-03-11 Thread Dmitry Baryshkov
On Tue, Mar 11, 2025 at 05:54:43PM +0530, Ayushi Makhija wrote: > When device enters the suspend state, it prevents > HPD interrupts from occurring. To address this, > add an additional PM runtime vote in hpd_enable(). > This vote is removed in hpd_disable(). Is it really enough to toggle the HPD

Re: [PATCH v2 04/10] drm/msm/dsi: add DSI PHY configuration on SA8775P

2025-03-11 Thread Dmitry Baryshkov
On Tue, Mar 11, 2025 at 05:54:39PM +0530, Ayushi Makhija wrote: > The SA8775P SoC uses the 5nm (v4.2) DSI PHY driver with > different enable regulator load. > > Signed-off-by: Ayushi Makhija > --- > drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 ++ > drivers/gpu/drm/msm/dsi/phy/dsi_phy.h |

Re: [PATCH v2 05/10] drm/msm/dsi: add DSI support for SA8775P

2025-03-11 Thread Dmitry Baryshkov
On Tue, Mar 11, 2025 at 05:54:40PM +0530, Ayushi Makhija wrote: > Add DSI Controller v2.5.1 support for SA8775P SoC. > > Signed-off-by: Ayushi Makhija > --- > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 18 ++ > drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + > 2 files changed, 19 insertions(+

[bug report] drm/msm/a6xx: Introduce GMU wrapper support

2025-03-11 Thread Dan Carpenter
Hello Konrad Dybcio, Commit 5a903a44a984 ("drm/msm/a6xx: Introduce GMU wrapper support") from Jun 16, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/gpu/drm/msm/adreno/a6xx_gmu.c:1844 a6xx_gmu_wrapper_init() warn: 'gmu->cxpd' can also be NULL dri

[PATCH v4 00/25] drm/dumb-buffers: Fix and improve buffer-size calculation

2025-03-11 Thread Thomas Zimmermann
Dumb-buffer pitch and size is specified by width, height, bits-per-pixel plus various hardware-specific alignments. The calculation of these values is inconsistent and duplicated among drivers. The results for formats with bpp < 8 are sometimes incorrect. This series fixes this for most drivers. D

[PATCH v4 02/25] drm/dumb-buffers: Provide helper to set pitch and size

2025-03-11 Thread Thomas Zimmermann
Add drm_modes_size_dumb(), a helper to calculate the dumb-buffer scanline pitch and allocation size. Implementations of struct drm_driver.dumb_create can call the new helper for their size computations. There is currently quite a bit of code duplication among DRM's memory managers. Each calculates

[PATCH v4 01/25] drm/dumb-buffers: Sanitize output on errors

2025-03-11 Thread Thomas Zimmermann
The ioctls MODE_CREATE_DUMB and MODE_MAP_DUMB return results into a memory buffer supplied by user space. On errors, it is possible that intermediate values are being returned. The exact semantics depends on the DRM driver's implementation of these ioctls. Although this is most-likely not a securit

[PATCH v4 07/25] drm/exynos: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. No alignment required. Signed-off-by: Thomas Zimmermann Cc: Inki Dae Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: Krzysztof Kozlowski Cc: Alim Akhtar --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 8 +--- 1 file

[PATCH v4 13/25] drm/msm: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Alignment is specified in bytes, but the hardware requires the scanline pitch to be a multiple of 32 pixels. Therefore compute the byte size of 32 pixels in the given color mode and align the pitch accordingly. This re

[PATCH v4 14/25] drm/nouveau: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 256. Signed-off-by: Thomas Zimmermann Reviewed-by: Lyude Paul Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_display.c | 7 --- 1 fi

[PATCH v4 09/25] drm/hibmc: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 128. The hibmc driver's new hibmc_dumb_create() is similar to the one in GEM VRAM helpers. The driver was the only caller of drm_gem_vram_fill_create_dumb(). Remove the now unused help

[PATCH v4 11/25] drm/loongson: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch according to hardware requirements. Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng Cc: Sui Jingfeng --- drivers/gpu/drm/loongson/lsdc_gem.c | 29 - 1 file ch

[PATCH v4 05/25] drm/gem-vram: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Inline code from drm_gem_vram_fill_create_dumb() without the existing size computation. Align the pitch to a multiple of 8. Only hibmc and vboxvideo use gem-vram. Hibmc invokes the call to drm_gem_vram_fill_create_dum

[PATCH v4 06/25] drm/armada: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 128. v4: - align pitch to 128 bytes (Russell) Signed-off-by: Thomas Zimmermann Cc: Russell King --- drivers/gpu/drm/armada/armada_gem.c | 16 +++- 1 file changed, 7 ins

[PATCH v4 08/25] drm/gma500: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 64. Signed-off-by: Thomas Zimmermann Cc: Patrik Jakobsson --- drivers/gpu/drm/gma500/gem.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a

[PATCH v4 17/25] drm/renesas/rcar-du: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch according to hardware requirements. Signed-off-by: Thomas Zimmermann Cc: Laurent Pinchart Cc: Kieran Bingham --- drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c | 7 +-- 1 file changed, 5 inserti

[PATCH v4 24/25] drm/xen: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 8. Signed-off-by: Thomas Zimmermann Cc: Oleksandr Andrushchenko --- drivers/gpu/drm/xen/xen_drm_front.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH v4 23/25] drm/xe: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 8. Align the buffer size according to hardware requirements. Xe's internal calculation allowed for 64-bit wide buffer sizes, but the ioctl's internal checks always verified against 32-

[PATCH v4 19/25] drm/rockchip: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 64. Signed-off-by: Thomas Zimmermann Acked-by: Heiko Stuebner Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Andy Yan --- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 12 ++--

[PATCH v4 22/25] drm/vmwgfx: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. No alignment required. Signed-off-by: Thomas Zimmermann Reviewed-by: Zack Rusin Cc: Zack Rusin Cc: Broadcom internal kernel review list --- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 21 - 1 fi

[PATCH v4 18/25] drm/renesas/rz-du: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch according to hardware requirements. Signed-off-by: Thomas Zimmermann Cc: Biju Das --- drivers/gpu/drm/renesas/rz-du/rzg2l_du_kms.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

[PATCH v4 15/25] drm/omapdrm: Compute dumb-buffer sizes with drm_mode_size_dumb()

2025-03-11 Thread Thomas Zimmermann
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and buffer size. Align the pitch to a multiple of 8. Signed-off-by: Thomas Zimmermann Reviewed-by: Tomi Valkeinen Cc: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_gem.c | 15 +++ 1 file changed, 7 insertions(+), 8 d

Re: [PATCH v3 18/21] drm/msm/dpu: Implement 10-bit color alpha for v12.0 DPU

2025-03-11 Thread Krzysztof Kozlowski
On 21/02/2025 17:25, Dmitry Baryshkov wrote: >> -static void _dpu_crtc_setup_blend_cfg(struct dpu_crtc_mixer *mixer, >> -struct dpu_plane_state *pstate, const struct msm_format *format) >> +static void _dpu_crtc_setup_blend_cfg(const struct dpu_hw_ctl *ctl, >> +

Re: [PATCH 3/4] drm/vc4: use new helper to get ACR values

2025-03-11 Thread Maxime Ripard
On Mon, Mar 10, 2025 at 10:18:04PM +0200, Dmitry Baryshkov wrote: > On Mon, Mar 10, 2025 at 03:51:53PM +0100, Maxime Ripard wrote: > > On Sun, Mar 09, 2025 at 10:13:58AM +0200, Dmitry Baryshkov wrote: > > > From: Dmitry Baryshkov > > > > > > Use drm_hdmi_acr_get_n_cts() helper instead of calculat

Re: [PATCH v5 2/2] drm/msm/dp: reuse generic HDMI codec implementation

2025-03-11 Thread Maxime Ripard
Hi, On Mon, Mar 10, 2025 at 08:53:24PM +0200, Dmitry Baryshkov wrote: > On Mon, 10 Mar 2025 at 17:08, Maxime Ripard wrote: > > > > On Fri, Mar 07, 2025 at 07:55:53AM +0200, Dmitry Baryshkov wrote: > > > From: Dmitry Baryshkov > > > > > > The MSM DisplayPort driver implements several HDMI codec f

Re: [PATCH 1/4] drm/display: hdmi: provide central data authority for ACR params

2025-03-11 Thread Maxime Ripard
On Mon, Mar 10, 2025 at 10:14:52PM +0200, Dmitry Baryshkov wrote: > On Mon, Mar 10, 2025 at 03:46:33PM +0100, Maxime Ripard wrote: > > On Sun, Mar 09, 2025 at 10:13:56AM +0200, Dmitry Baryshkov wrote: > > > From: Dmitry Baryshkov > > > > > > HDMI standard defines recommended N and CTS values for

Re: [PATCH v1 2/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-11 Thread Abel Vesa
On 25-03-10 22:05:52, Aleksandrs Vinarskis wrote: > DisplayPort requires per-segment link training when LTTPR are switched > to non-transparent mode, starting with LTTPR closest to the source. > Only when each segment is trained individually, source can link train > to sink. > > Implement per-segm

[PATCH v2 02/10] dt-bindings: msm: dsi-controller-main: document the SA8775P DSI CTRL

2025-03-11 Thread Ayushi Makhija
Document the DSI CTRL on the SA8775P Platform. Signed-off-by: Ayushi Makhija --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetre

[PATCH v2 10/10] drm/bridge: anx7625: change the gpiod_set_value API

2025-03-11 Thread Ayushi Makhija
Use gpiod_set_value_cansleep() instead of gpiod_set_value() to fix the below call trace in the boot log: [5.690534] Call trace: [5.690536] gpiod_set_value+0x40/0xa4 [5.690540] anx7625_runtime_pm_resume+0xa0/0x324 [anx7625] [5.690545] __rpm_callback+0x48/0x1d8 [5.690549] rpm

[PATCH v2 08/10] drm/bridge: anx7625: enable HPD interrupts

2025-03-11 Thread Ayushi Makhija
When device enters the suspend state, it prevents HPD interrupts from occurring. To address this, add an additional PM runtime vote in hpd_enable(). This vote is removed in hpd_disable(). Signed-off-by: Ayushi Makhija --- drivers/gpu/drm/bridge/analogix/anx7625.c | 18 ++ 1 file

[PATCH v2 07/10] arm64: dts: qcom: sa8775p-ride: add anx7625 DSI to DP bridge nodes

2025-03-11 Thread Ayushi Makhija
Add anx7625 DSI to DP bridge device nodes. Signed-off-by: Ayushi Makhija --- arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 208 - 1 file changed, 207 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.

[PATCH v2 03/10] dt-bindings: display: msm: document DSI controller and phy on SA8775P

2025-03-11 Thread Ayushi Makhija
Document DSI controller and phy on SA8775P platform. Signed-off-by: Ayushi Makhija --- .../display/msm/qcom,sa8775p-mdss.yaml| 188 ++ 1 file changed, 188 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/de

[PATCH v2 05/10] drm/msm/dsi: add DSI support for SA8775P

2025-03-11 Thread Ayushi Makhija
Add DSI Controller v2.5.1 support for SA8775P SoC. Signed-off-by: Ayushi Makhija --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 18 ++ drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + 2 files changed, 19 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/d

[PATCH v2 01/10] dt-bindings: display: msm-dsi-phy-7nm: document the SA8775P DSI PHY

2025-03-11 Thread Ayushi Makhija
Document the DSI PHY on the SA8775P Platform. Signed-off-by: Ayushi Makhija --- Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/d

[PATCH v2 06/10] arm64: dts: qcom: sa8775p: add Display Serial Interface device nodes

2025-03-11 Thread Ayushi Makhija
Add device tree nodes for the DSI0 and DSI1 controllers with their corresponding PHYs found on Qualcomm SA8775P SoC. Signed-off-by: Ayushi Makhija --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 186 +- 1 file changed, 185 insertions(+), 1 deletion(-) diff --git a/arch/arm64

[PATCH v1 2/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-11 Thread Aleksandrs Vinarskis
DisplayPort requires per-segment link training when LTTPR are switched to non-transparent mode, starting with LTTPR closest to the source. Only when each segment is trained individually, source can link train to sink. Implement per-segment link traning when LTTPR(s) are detected, to support extern

[PATCH v2 04/10] drm/msm/dsi: add DSI PHY configuration on SA8775P

2025-03-11 Thread Ayushi Makhija
The SA8775P SoC uses the 5nm (v4.2) DSI PHY driver with different enable regulator load. Signed-off-by: Ayushi Makhija --- drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 2 ++ drivers/gpu/drm/msm/dsi/phy/dsi_phy.h | 1 + drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 27 +++

[PATCH v1 0/2] drm/msm/dp: Introduce link training per-segment for LTTPRs

2025-03-11 Thread Aleksandrs Vinarskis
Recently added Initial LTTPR support in msm/dp has configured LTTPR(s) to non-transparent mode to enable video output on X1E-based devices that come with LTTPR on the motherboards. However, video would not work if additional LTTPR(s) are present between sink and source, which is the case for USB Ty

Re: [PATCH 05/10] dt-bindings: display/msm: Add Qualcomm SAR2130P

2025-03-11 Thread Krzysztof Kozlowski
On Sat, Mar 08, 2025 at 03:42:23AM +0200, Dmitry Baryshkov wrote: > +patternProperties: > + "^display-controller@[0-9a-f]+$": > +type: object > +additionalProperties: true > + Drop blank line > +properties: > + compatible: > +const: qcom,sar2130p-dpu > + > + "^displaypo

Re: [PATCH v5 1/2] drm/bridge: split HDMI Audio from DRM_BRIDGE_OP_HDMI

2025-03-11 Thread Maxime Ripard
Hi, On Fri, Mar 07, 2025 at 07:55:52AM +0200, Dmitry Baryshkov wrote: > From: Dmitry Baryshkov > > As pointed out by Laurent, OP bits are supposed to describe operations. > Split DRM_BRIDGE_OP_HDMI_AUDIO from DRM_BRIDGE_OP_HDMI instead of > overloading DRM_BRIDGE_OP_HDMI. > > Signed-off-by: Dmi

Re: [PATCH 3/4] drm/vc4: use new helper to get ACR values

2025-03-11 Thread Dmitry Baryshkov
On Mon, Mar 10, 2025 at 03:51:53PM +0100, Maxime Ripard wrote: > On Sun, Mar 09, 2025 at 10:13:58AM +0200, Dmitry Baryshkov wrote: > > From: Dmitry Baryshkov > > > > Use drm_hdmi_acr_get_n_cts() helper instead of calculating N and CTS > > values in the VC4 driver. > > > > Signed-off-by: Dmitry B

Re: [PATCH 03/11] dt-bindings: power: qcom,kpss-acc-v2: Add MSM8916 compatible

2025-03-11 Thread Dmitry Baryshkov
On Thu, Mar 06, 2025 at 07:11:15PM +0100, Konrad Dybcio wrote: > From: Konrad Dybcio > > MSM8916 seems to reuse the same hardware as MSM8974 and friends (for > whom this binding document was created). Add a new compatible for it. Ok, I should have read dt-bindigns before sending a comment. But t

[PATCH v2 09/10] drm/bridge: anx7625: update bridge_ops and sink detect logic

2025-03-11 Thread Ayushi Makhija
The anx7625_link_bridge() checks if a device is not a panel bridge and add DRM_BRIDGE_OP_HPD and DRM_BRIDGE_OP_DETECT to the bridge operations. However, on port 1 of the anx7625 bridge, any device added is always treated as a panel bridge, preventing connector_detect function from being called. To

Re: [PATCH 02/10] dt-bindings: display/msm: dsi-controller-main: describe SAR2130P

2025-03-11 Thread Krzysztof Kozlowski
On Sat, Mar 08, 2025 at 03:42:20AM +0200, Dmitry Baryshkov wrote: > From: Dmitry Baryshkov > > Describe MIPI DSI controller present on Qualcomm SAR2130P platform. > > Signed-off-by: Dmitry Baryshkov > --- > Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ > 1 file

[PATCH 08/11] arm64: dts: qcom: sc8180x: Rename AOSS_QMP to power-management

2025-03-11 Thread Konrad Dybcio
From: Konrad Dybcio The node is currently named power-controller, which requires the device underneath is a power domain provider. Rename it to align with other SoCs and resolve this sort of warnings: power-controller@c31: '#power-domain-cells' is a required property Fixes: 8575f197b077 ("a

Re: [PATCH v3 19/21] drm/msm/dpu: Implement CTL_PIPE_ACTIVE for v12.0 DPU

2025-03-11 Thread Krzysztof Kozlowski
On 21/02/2025 17:26, Dmitry Baryshkov wrote: > Minot nit below > >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c >> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c >> index >> 43a254cf57da571e2ec8aad38028477652f9283c..3e0bdd1100ebb0d302a852ceeaf8af86835e69a1 >> 100644 >> --- a/drivers/g

Re: [PATCH v2 03/10] dt-bindings: display: msm: document DSI controller and phy on SA8775P

2025-03-11 Thread Dmitry Baryshkov
On Tue, Mar 11, 2025 at 05:54:38PM +0530, Ayushi Makhija wrote: > Document DSI controller and phy on SA8775P platform. > > Signed-off-by: Ayushi Makhija > --- > .../display/msm/qcom,sa8775p-mdss.yaml| 188 ++ > 1 file changed, 188 insertions(+) > > diff --git > a/Docume

Re: [PATCH 1/4] drm/display: hdmi: provide central data authority for ACR params

2025-03-11 Thread Dmitry Baryshkov
On Tue, Mar 11, 2025 at 08:59:45AM +0100, Maxime Ripard wrote: > On Mon, Mar 10, 2025 at 10:14:52PM +0200, Dmitry Baryshkov wrote: > > On Mon, Mar 10, 2025 at 03:46:33PM +0100, Maxime Ripard wrote: > > > On Sun, Mar 09, 2025 at 10:13:56AM +0200, Dmitry Baryshkov wrote: > > > > From: Dmitry Baryshko

Re: [PATCH 3/4] drm/vc4: use new helper to get ACR values

2025-03-11 Thread Dmitry Baryshkov
On Tue, Mar 11, 2025 at 09:07:10AM +0100, Maxime Ripard wrote: > On Mon, Mar 10, 2025 at 10:18:04PM +0200, Dmitry Baryshkov wrote: > > On Mon, Mar 10, 2025 at 03:51:53PM +0100, Maxime Ripard wrote: > > > On Sun, Mar 09, 2025 at 10:13:58AM +0200, Dmitry Baryshkov wrote: > > > > From: Dmitry Baryshko

[PATCH v2 00/10] Add DSI display support for SA8775P target

2025-03-11 Thread Ayushi Makhija
This series enables the support for DSI to DP bridge ports (labled as DSI0 and DSI1) of the Qualcomm's SA8775P Ride platform. SA8775P SoC has DSI controller v2.5.1 and DSI PHY v4.2. The Ride platform is having ANX7625 DSI to DP bridge chip from Analogix. --- This patch depends on following series

Re: [PATCH v5 1/2] drm/bridge: split HDMI Audio from DRM_BRIDGE_OP_HDMI

2025-03-11 Thread Dmitry Baryshkov
On Tue, Mar 11, 2025 at 04:58:59PM +0100, Maxime Ripard wrote: > On Tue, Mar 11, 2025 at 05:50:09PM +0200, Dmitry Baryshkov wrote: > > On Tue, Mar 11, 2025 at 09:36:37AM +0100, Maxime Ripard wrote: > > > On Mon, Mar 10, 2025 at 08:42:29PM +0200, Dmitry Baryshkov wrote: > > > > On Mon, 10 Mar 2025 a

[PATCH v4 05/19] dt-bindings: display/msm: qcom,sm8750-mdss: Add SM8750

2025-03-11 Thread Krzysztof Kozlowski
Add MDSS/MDP display subsystem for Qualcomm SM8750 SoC, next generation with two revisions up of the IP block comparing to SM8650. Reviewed-by: Rob Herring (Arm) Signed-off-by: Krzysztof Kozlowski --- Changes in v3: 1. Properly described interconnects 2. Use only one compatible and contains for

[PATCH v4 06/19] drm/msm/dpu: Add missing "fetch" name to set_active_pipes()

2025-03-11 Thread Krzysztof Kozlowski
The set_active_pipes() callback configures CTL_FETCH_PIPE_ACTIVE and newer DPU v12.0 comes with CTL_PIPE_ACTIVE, thus rename it to set_active_fetch_pipes() to better match the purpose. Reviewed-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang Signed-off-by: Krzysztof Kozlowski --- Changes in v2

[PATCH v4 03/19] dt-bindings: display/msm: dp-controller: Add SM8750

2025-03-11 Thread Krzysztof Kozlowski
Add DisplayPort controller for Qualcomm SM8750 SoC which so far looks fully compatible with earlier SM8650 variant - both are of version v1.5.1 of the IP block. Datasheet also mentions that both support 4x MST for DPTX0 and 2x MST for DPTX1. Acked-by: Rob Herring (Arm) Reviewed-by: Dmitry Barysh

[PATCH v4 04/19] dt-bindings: display/msm: qcom,sm8650-dpu: Add SM8750

2025-03-11 Thread Krzysztof Kozlowski
Add DPU for Qualcomm SM8750 SoC which has several differences, new blocks and changes in registers, making it incompatible with SM8650. Acked-by: Rob Herring (Arm) Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml | 1 + 1 file changed, 1

[PATCH v4 02/19] dt-bindings: display/msm: dsi-controller-main: Add SM8750

2025-03-11 Thread Krzysztof Kozlowski
Add DSI controller for Qualcomm SM8750 SoC which is quite different from previous (SM8650) generation. It does not allow the display clock controller clocks like "byte" and "pixel" to be reparented to DSI PHY PLLs while the DSI PHY PLL is not configured (not prepared, rate not set). Therefore ass

[PATCH v4 00/19] drm/msm: Add support for SM8750

2025-03-11 Thread Krzysztof Kozlowski
Hi, Dependency / Rabased on top of == https://lore.kernel.org/all/20241214-dpu-drop-features-v1-0-988f0662c...@linaro.org/ Merging === DSI pieces here might not be ready - I got modetest writeback working, but DSI panel on MTP8750 still shows darkness. Therefore w

[PATCH v4 07/19] drm/msm/dpu: Clear CTL_FETCH_PIPE_ACTIVE on mixer reset

2025-03-11 Thread Krzysztof Kozlowski
Resetting mixers should also include resetting active fetch pipes. Fixes: ae4d721ce100 ("drm/msm/dpu: add an API to reset the encoder related hw blocks") Reviewed-by: Dmitry Baryshkov Signed-off-by: Krzysztof Kozlowski --- Changes in v3: 1. New patch, split from previous big DPU v12.0. --- dr

[PATCH v4 01/19] dt-bindings: display/msm: dsi-phy-7nm: Add SM8750

2025-03-11 Thread Krzysztof Kozlowski
Add DSI PHY v7.0 for Qualcomm SM8750 SoC which is quite different from previous (SM8650) generation. Acked-by: Rob Herring (Arm) Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentatio

[PATCH v4 18/19] drm/msm/dpu: Implement LM crossbar for v12.0 DPU

2025-03-11 Thread Krzysztof Kozlowski
v12.0 DPU on SM8750 comes with new LM crossbar that requires each pipe rectangle to be programmed separately in blend stage. Implement support for this along with a new CTL_LAYER_ACTIVE register and setting the blend stage in layer mixer code. Reviewed-by: Dmitry Baryshkov Signed-off-by: Krzyszt

[PATCH v4 19/19] drm/msm/mdss: Add support for SM8750

2025-03-11 Thread Krzysztof Kozlowski
Add support for the Qualcomm SM8750 platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/msm_mdss.c | 33 + drivers/gpu/drm/msm/msm_mdss.h | 1 + 2 files changed, 34 insertions(+) diff --git a/drivers/gpu/drm/msm/ms

[PATCH v4 17/19] drm/msm/dpu: Implement CTL_PIPE_ACTIVE for v12.0 DPU

2025-03-11 Thread Krzysztof Kozlowski
v12.0 DPU on SM8750 comes with new CTL_PIPE_ACTIVE register for selective activation of pipes, which replaces earlier dpu_hw_ctl_setup_blendstage() code path for newer devices. Reviewed-by: Dmitry Baryshkov Signed-off-by: Krzysztof Kozlowski --- Changes in v4: 1. Lowercase hex 2. Add Dmitry's t

[PATCH v4 14/19] drm/msm/dsi: Add support for SM8750

2025-03-11 Thread Krzysztof Kozlowski
Add support for DSI on Qualcomm SM8750 SoC with notable difference: DSI PHY PLLs, the parents of pixel and byte clocks, cannot be used as parents before DSI PHY is configured and the PLLs are prepared with initial rate is set. Therefore assigned-clock-parents are not working here and driver is re

[PATCH v4 15/19] drm/msm/dpu: Add support for SM8750

2025-03-11 Thread Krzysztof Kozlowski
Add DPU version v12.0 support for the Qualcomm SM8750 platform. Reviewed-by: Dmitry Baryshkov Signed-off-by: Krzysztof Kozlowski --- Changes in v2: 1. Add CDM --- .../drm/msm/disp/dpu1/catalog/dpu_12_0_sm8750.h| 496 + drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

[PATCH v4 13/19] drm/msm/dsi/phy: Add support for SM8750

2025-03-11 Thread Krzysztof Kozlowski
Add support for DSI PHY v7.0 on Qualcomm SM8750 SoC which comes with an incompatible hardware interface change: ICODE_ACCUM_STATUS_LOW and ALOG_OBSV_BUS_STATUS_1 registers - their offsets were just switched. Currently these registers are not used in the driver, so the easiest is to document both

[PATCH v4 08/19] drm/msm/dpu: Clear CTL_FETCH_PIPE_ACTIVE on ctl_path reset

2025-03-11 Thread Krzysztof Kozlowski
Resetting entire CTL path should also include resetting active fetch pipes. Fixes: e1a950eec256 ("drm/msm/dpu: add reset_intf_cfg operation for dpu_hw_ctl") Reviewed-by: Dmitry Baryshkov Signed-off-by: Krzysztof Kozlowski --- Changes in v3: 1. New patch, split from previous big DPU v12.0. ---

[PATCH v4 11/19] drm/msm/dpu: Add LM_7, DSC_[67], PP_[67] and MERGE_3D_5

2025-03-11 Thread Krzysztof Kozlowski
Add IDs for new blocks present in MDSS/MDP v12 for LM, DSC, PINGPONG and MERGE_3D blocks. Reviewed-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/driver

[PATCH v4 16/19] drm/msm/dpu: Implement 10-bit color alpha for v12.0 DPU

2025-03-11 Thread Krzysztof Kozlowski
v12.0 DPU on SM8750 comes with 10-bit color alpha. Add register differences and new implementations of setup_alpha_out, setup_border_color and so one for this. Signed-off-by: Krzysztof Kozlowski --- Changes in v4: 1. Lowercase hex, use spaces for define indentation 2. _dpu_crtc_setup_blend_cfg

[PATCH v4 09/19] drm/msm/dpu: Clear CTL_FETCH_PIPE_ACTIVE before blend setup

2025-03-11 Thread Krzysztof Kozlowski
Before blend setup, all existing blend stages are cleared, so shall be active fetch pipes. Fixes: b3652e87c03c ("drm/msm/disp/dpu1: add support to program fetch active in ctl path") Reviewed-by: Dmitry Baryshkov Signed-off-by: Krzysztof Kozlowski --- Changes in v3: 1. New patch, split from pre

[PATCH v4 10/19] drm/msm/dpu: Drop useless comments

2025-03-11 Thread Krzysztof Kozlowski
Drop comments about SoC before each 'struct dpu_lm_sub_blks' for given SoC because it's duplicating the actual name of structure. Reviewed-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 8 1 file

[PATCH v4 12/19] drm/msm/dpu: Add handling of LM_6 and LM_7 bits in pending flush mask

2025-03-11 Thread Krzysztof Kozlowski
MDSS/MDP v12 comes with new bits in flush registers (e.g. MDP_CTL_0_FLUSH) for Layer Mixer 6 and 7. Reviewed-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH v4 1/5] iommu/arm-smmu: Save additional information on context fault

2025-03-11 Thread Will Deacon
On Tue, Mar 04, 2025 at 11:56:47AM -0500, Connor Abbott wrote: > This will be used by drm/msm for GPU page faults, replacing the manual > register reading it does. > > Signed-off-by: Connor Abbott > --- > drivers/iommu/arm/arm-smmu/arm-smmu-qcom-debug.c | 4 ++-- > drivers/iommu/arm/arm-smmu/ar

Re: [PATCH v4 2/5] iommu/arm-smmu-qcom: Don't read fault registers directly

2025-03-11 Thread Will Deacon
On Tue, Mar 04, 2025 at 11:56:48AM -0500, Connor Abbott wrote: > In some cases drm/msm has to resume a stalled transaction directly in > its fault handler. Experimentally this doesn't work on SMMU500 if the > fault hasn't already been acknowledged by clearing FSR. Rather than > trying to clear FSR

Re: [PATCH v4 4/5] iommu/arm-smmu-qcom: Make set_stall work when the device is on

2025-03-11 Thread Will Deacon
On Tue, Mar 04, 2025 at 11:56:50AM -0500, Connor Abbott wrote: > Up until now we have only called the set_stall callback during > initialization when the device is off. But we will soon start calling it > to temporarily disable stall-on-fault when the device is on, so handle > that by checking if t

Re: [PATCH 05/10] dt-bindings: display/msm: Add Qualcomm SAR2130P

2025-03-11 Thread Rob Herring
On Fri, Mar 7, 2025 at 11:09 PM Dmitry Baryshkov wrote: > > On Fri, Mar 07, 2025 at 09:40:56PM -0600, Rob Herring (Arm) wrote: > > > > On Sat, 08 Mar 2025 03:42:23 +0200, Dmitry Baryshkov wrote: > > > From: Dmitry Baryshkov > > > > > > Describe the Mobile Display SubSystem (MDSS) device present o

Re: [PATCH 1/4] drm/display: hdmi: provide central data authority for ACR params

2025-03-11 Thread Maxime Ripard
On Sun, Mar 09, 2025 at 10:13:56AM +0200, Dmitry Baryshkov wrote: > From: Dmitry Baryshkov > > HDMI standard defines recommended N and CTS values for Audio Clock > Regeneration. Currently each driver implements those, frequently in > somewhat unique way. Provide a generic helper for getting those

Re: [PATCH v4 2/5] iommu/arm-smmu-qcom: Don't read fault registers directly

2025-03-11 Thread Connor Abbott
On Tue, Mar 11, 2025 at 2:08 PM Will Deacon wrote: > > On Tue, Mar 04, 2025 at 11:56:48AM -0500, Connor Abbott wrote: > > In some cases drm/msm has to resume a stalled transaction directly in > > its fault handler. Experimentally this doesn't work on SMMU500 if the > > fault hasn't already been ac

Re: [PATCH v4 1/5] iommu/arm-smmu: Save additional information on context fault

2025-03-11 Thread Connor Abbott
On Tue, Mar 11, 2025 at 2:06 PM Will Deacon wrote: > > On Tue, Mar 04, 2025 at 11:56:47AM -0500, Connor Abbott wrote: > > This will be used by drm/msm for GPU page faults, replacing the manual > > register reading it does. > > > > Signed-off-by: Connor Abbott > > --- > > drivers/iommu/arm/arm-sm

Re: [PATCH v2 0/5] drm/msm/dpu: enable CDM for all supported platforms

2025-03-11 Thread Dmitry Baryshkov
From: Dmitry Baryshkov On Thu, 20 Feb 2025 05:59:21 +0200, Dmitry Baryshkov wrote: > Enable CDM block on all the platforms where it is supposed to be > present. Notably, from the platforms being supported by the DPU driver > it is not enabled for SM6115 (DPU 6.3), QCM2290 (DPU 6.5) and SM6375 >

Re: [PATCH v4 4/5] iommu/arm-smmu-qcom: Make set_stall work when the device is on

2025-03-11 Thread Connor Abbott
On Tue, Mar 11, 2025 at 2:11 PM Will Deacon wrote: > > On Tue, Mar 04, 2025 at 11:56:50AM -0500, Connor Abbott wrote: > > Up until now we have only called the set_stall callback during > > initialization when the device is off. But we will soon start calling it > > to temporarily disable stall-on-

Re: [PATCH v4 2/5] iommu/arm-smmu-qcom: Don't read fault registers directly

2025-03-11 Thread Rob Clark
On Tue, Mar 11, 2025 at 12:42 PM Connor Abbott wrote: > > On Tue, Mar 11, 2025 at 2:08 PM Will Deacon wrote: > > > > On Tue, Mar 04, 2025 at 11:56:48AM -0500, Connor Abbott wrote: > > > In some cases drm/msm has to resume a stalled transaction directly in > > > its fault handler. Experimentally t

Re: [PATCH 1/4] drm/display: hdmi: provide central data authority for ACR params

2025-03-11 Thread Dmitry Baryshkov
On Mon, Mar 10, 2025 at 03:46:33PM +0100, Maxime Ripard wrote: > On Sun, Mar 09, 2025 at 10:13:56AM +0200, Dmitry Baryshkov wrote: > > From: Dmitry Baryshkov > > > > HDMI standard defines recommended N and CTS values for Audio Clock > > Regeneration. Currently each driver implements those, freque

Re: [PATCH 3/4] drm/vc4: use new helper to get ACR values

2025-03-11 Thread Maxime Ripard
On Sun, Mar 09, 2025 at 10:13:58AM +0200, Dmitry Baryshkov wrote: > From: Dmitry Baryshkov > > Use drm_hdmi_acr_get_n_cts() helper instead of calculating N and CTS > values in the VC4 driver. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 10 +++--- > drivers/

  1   2   >