Re: [PATCH v2 04/11] drm/msm: adreno: add GMU_BW_VOTE feature flag

2024-11-27 Thread neil . armstrong
On 27/11/2024 17:00, Akhil P Oommen wrote: On 11/25/2024 1:46 PM, Neil Armstrong wrote: On 23/11/2024 20:43, Akhil P Oommen wrote: On Tue, Nov 19, 2024 at 06:56:39PM +0100, Neil Armstrong wrote: The Adreno GMU Management Unit (GNU) can also scale the DDR Bandwidth along the Frequency and Power

Re: [PATCH 1/4] dt-bindings: phy: Add eDP PHY compatible for qcs8300

2024-11-27 Thread Krzysztof Kozlowski
On 27/11/2024 09:15, Yongxing Mou wrote: > Add compatible string for the supported eDP PHY on qcs8300 platform. What is supported eDP PHY? Can it be unsupported? Anyway, this repeats the diff. Say something useful instead, like why this is not compatible with sa8775p. Best regards, Krzysztof

Re: [PATCH v3 2/3] drm/msm/mdss: reuse defined bitfields for UBWC 2.0

2024-11-27 Thread Abhinav Kumar
On 11/27/2024 6:04 AM, Dmitry Baryshkov wrote: Follow other msm_mdss_setup_ubwc_dec_nn functions and use individual bits instead of just specifying the value to be programmed to the UBWC_STATIC register. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 17 +-

Re: [PATCH v3 1/3] drm/msm/mdss: define bitfields for the UBWC_STATIC register

2024-11-27 Thread Abhinav Kumar
On 11/27/2024 6:04 AM, Dmitry Baryshkov wrote: Rather than hand-coding UBWC_STATIC value calculation, define corresponding bitfields and use them to setup the register value. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 38 +++---

Re: [PATCH v2 04/11] drm/msm: adreno: add GMU_BW_VOTE feature flag

2024-11-27 Thread Akhil P Oommen
On 11/25/2024 1:46 PM, Neil Armstrong wrote: > On 23/11/2024 20:43, Akhil P Oommen wrote: >> On Tue, Nov 19, 2024 at 06:56:39PM +0100, Neil Armstrong wrote: >>> The Adreno GMU Management Unit (GNU) can also scale the DDR Bandwidth >>> along the Frequency and Power Domain level, but by default we le

Re: [PATCH v2 08/11] drm/msm: adreno: request for maximum bus bandwidth usage

2024-11-27 Thread neil . armstrong
On 27/11/2024 16:46, Akhil P Oommen wrote: On 11/25/2024 1:44 PM, Neil Armstrong wrote: On 23/11/2024 23:59, Akhil P Oommen wrote: On Tue, Nov 19, 2024 at 06:56:43PM +0100, Neil Armstrong wrote: When requesting a DDR bandwidth level along a GPU frequency level via the GMU, we can also specify

Re: [PATCH v2 05/11] drm/msm: adreno: add plumbing to generate bandwidth vote table for GMU

2024-11-27 Thread neil . armstrong
On 27/11/2024 16:29, Akhil P Oommen wrote: On 11/25/2024 1:42 PM, Neil Armstrong wrote: On 23/11/2024 23:46, Akhil P Oommen wrote: On Sun, Nov 24, 2024 at 02:52:46AM +0530, Akhil P Oommen wrote: On Tue, Nov 19, 2024 at 06:56:40PM +0100, Neil Armstrong wrote: The Adreno GMU Management Unit (GM

Re: [PATCH v2 08/11] drm/msm: adreno: request for maximum bus bandwidth usage

2024-11-27 Thread Akhil P Oommen
On 11/25/2024 1:44 PM, Neil Armstrong wrote: > On 23/11/2024 23:59, Akhil P Oommen wrote: >> On Tue, Nov 19, 2024 at 06:56:43PM +0100, Neil Armstrong wrote: >>> When requesting a DDR bandwidth level along a GPU frequency >>> level via the GMU, we can also specify the bus bandwidth usage in a >>> 16

Re: [PATCH v2 05/11] drm/msm: adreno: add plumbing to generate bandwidth vote table for GMU

2024-11-27 Thread Akhil P Oommen
On 11/25/2024 1:42 PM, Neil Armstrong wrote: > On 23/11/2024 23:46, Akhil P Oommen wrote: >> On Sun, Nov 24, 2024 at 02:52:46AM +0530, Akhil P Oommen wrote: >>> On Tue, Nov 19, 2024 at 06:56:40PM +0100, Neil Armstrong wrote: The Adreno GMU Management Unit (GMU) can also scale DDR Bandwidth alo

[PATCH v3 2/3] drm/msm/mdss: reuse defined bitfields for UBWC 2.0

2024-11-27 Thread Dmitry Baryshkov
Follow other msm_mdss_setup_ubwc_dec_nn functions and use individual bits instead of just specifying the value to be programmed to the UBWC_STATIC register. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 17 + drivers/gpu/drm/msm/msm_mdss.h | 1 - 2 files c

[PATCH v3 3/3] drm/msm/mdss: use boolean values for macrotile_mode

2024-11-27 Thread Dmitry Baryshkov
The macrotile_mode is a flag, not a bit value. Use true/false values to set it rather than 1/0. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 16 drivers/gpu/drm/msm/msm_mdss.h | 2 +- 2 files changed, 9 insertions(+), 9 deleti

[PATCH v3 1/3] drm/msm/mdss: define bitfields for the UBWC_STATIC register

2024-11-27 Thread Dmitry Baryshkov
Rather than hand-coding UBWC_STATIC value calculation, define corresponding bitfields and use them to setup the register value. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 38 +++--- drivers/gpu/drm/msm/msm_mdss.h | 1

[PATCH v3 0/3] drm/msm/mdss: rework UBWC registers programming

2024-11-27 Thread Dmitry Baryshkov
Current way of programming of the UBWC-related registers has been inherited from vendor's drivers. The ubwc_static was supposed to contain raw data to be programmed to the hardware, but was later repurposed to define of the bits. As it can be seen by the commit 3e30296b374a ("drm/msm: fix the highe

Re: [PATCH 0/5] Display enablement changes for Qualcomm QCS8300 platform

2024-11-27 Thread Dmitry Baryshkov
On Wed, Nov 27, 2024 at 06:54:10PM +0800, Yongxing Mou wrote: > > > On 2024/11/27 15:13, Krzysztof Kozlowski wrote: > > On 27/11/2024 08:05, Yongxing Mou wrote: > > > This series introduces support to enable the Mobile Display Subsystem > > > (MDSS) > > > and Display Processing Unit (DPU) for th

Re: [PATCH 2/5] dt-bindings: display/msm: Document the DPU for QCS8300

2024-11-27 Thread Dmitry Baryshkov
On Wed, Nov 27, 2024 at 03:05:02PM +0800, Yongxing Mou wrote: > Document the DPU for Qualcomm QCS8300 platform. > > Signed-off-by: Yongxing Mou > --- > Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/Documentation/de

Re: [PATCH 4/5] drm/msm/dpu: Add QCS8300 support

2024-11-27 Thread Dmitry Baryshkov
On Wed, Nov 27, 2024 at 03:05:04PM +0800, Yongxing Mou wrote: > Add definitions for the display hardware used on the > Qualcomm QCS8300 platform. > > Signed-off-by: Yongxing Mou > --- > .../drm/msm/disp/dpu1/catalog/dpu_8_4_qcs8300.h| 485 > + > drivers/gpu/drm/msm/disp/

Re: [PATCH 3/5] drm/msm: mdss: Add QCS8300 support

2024-11-27 Thread Dmitry Baryshkov
On Wed, Nov 27, 2024 at 03:05:03PM +0800, Yongxing Mou wrote: > Add Mobile Display Subsystem (MDSS) support for the QCS8300 platform. Please mention, why do you need it at all. I see that the UBWC swizzle and HBB settings are different. Is this really the case? Is it because of the different memor

Re: [PATCH 4/4] drm/msm/dp: Add DisplayPort controller for QCS8300

2024-11-27 Thread Dmitry Baryshkov
On Wed, Nov 27, 2024 at 04:15:51PM +0800, Yongxing Mou wrote: > The Qualcomm QCS8300 platform comes with a DisplayPort controller > with same base offset with SA8775P, add support for this in the > DisplayPort driver. Can we reuse SA8775P config then? And SA8775p compatible as a fallback, not requ

Re: [PATCH 2/4] phy: qcom: edp: Add support for eDP PHY on QCS8300

2024-11-27 Thread Dmitry Baryshkov
On Wed, Nov 27, 2024 at 04:15:49PM +0800, Yongxing Mou wrote: > Add support for eDP PHY v5 found on the Qualcomm QCS8300 platform. > > Signed-off-by: Yongxing Mou > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/phy/qualcomm/ph

Re: [PATCH 0/5] Display enablement changes for Qualcomm QCS8300 platform

2024-11-27 Thread Krzysztof Kozlowski
On 27/11/2024 11:54, Yongxing Mou wrote: > > > On 2024/11/27 15:13, Krzysztof Kozlowski wrote: >> On 27/11/2024 08:05, Yongxing Mou wrote: >>> This series introduces support to enable the Mobile Display Subsystem (MDSS) >>> and Display Processing Unit (DPU) for the Qualcomm QCS8300 target. It >>>

Re: [PATCH 1/5] dt-bindings: display/msm: Document MDSS on QCS8300

2024-11-27 Thread Krzysztof Kozlowski
On 27/11/2024 12:02, Yongxing Mou wrote: >> >> doc reference errors (make refcheckdocs): >> >> See >> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241127-mdss_qcs8300-v1-1-29b2c3ee9...@quicinc.com >> >> The base for the serie

Re: [PATCH 0/5] Display enablement changes for Qualcomm QCS8300 platform

2024-11-27 Thread Yongxing Mou
On 2024/11/27 19:06, Tingwei Zhang wrote: On 11/27/2024 6:54 PM, Yongxing Mou wrote: On 2024/11/27 15:13, Krzysztof Kozlowski wrote: On 27/11/2024 08:05, Yongxing Mou wrote: This series introduces support to enable the Mobile Display Subsystem (MDSS) and Display Processing Unit (DPU) for

Re: [PATCH 0/5] Display enablement changes for Qualcomm QCS8300 platform

2024-11-27 Thread Tingwei Zhang
On 11/27/2024 6:54 PM, Yongxing Mou wrote: On 2024/11/27 15:13, Krzysztof Kozlowski wrote: On 27/11/2024 08:05, Yongxing Mou wrote: This series introduces support to enable the Mobile Display Subsystem (MDSS) and Display Processing Unit (DPU) for the Qualcomm QCS8300 target. It includes the

Re: [PATCH 1/5] dt-bindings: display/msm: Document MDSS on QCS8300

2024-11-27 Thread Yongxing Mou
unfinished jobs make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1442: dt_binding_check] Error 2 make: *** [Makefile:224: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241127-mdss_qcs8300-v1-1

Re: [PATCH 0/5] Display enablement changes for Qualcomm QCS8300 platform

2024-11-27 Thread Yongxing Mou
On 2024/11/27 15:13, Krzysztof Kozlowski wrote: On 27/11/2024 08:05, Yongxing Mou wrote: This series introduces support to enable the Mobile Display Subsystem (MDSS) and Display Processing Unit (DPU) for the Qualcomm QCS8300 target. It includes the addition of the hardware catalog, compatible

Re: [PATCH 1/5] dt-bindings: display/msm: Document MDSS on QCS8300

2024-11-27 Thread Rob Herring (Arm)
. make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1442: dt_binding_check] Error 2 make: *** [Makefile:224: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241127-mdss_qcs8300-v1-1-29b2c3ee9...@quici

[PATCH 4/4] drm/msm/dp: Add DisplayPort controller for QCS8300

2024-11-27 Thread Yongxing Mou
The Qualcomm QCS8300 platform comes with a DisplayPort controller with same base offset with SA8775P, add support for this in the DisplayPort driver. Signed-off-by: Yongxing Mou --- drivers/gpu/drm/msm/dp/dp_display.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/msm/

[PATCH 3/4] dt-bindings: display: msm: dp-controller: document QCS8300 compatible

2024-11-27 Thread Yongxing Mou
Add compatible string for the DisplayPort controller found on the Qualcomm QCS8300 platform. Signed-off-by: Yongxing Mou --- Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/dp-contr

[PATCH 0/4] Add support for DisplayPort on QCS8300 platform

2024-11-27 Thread Yongxing Mou
| 6 ++ drivers/phy/qualcomm/phy-qcom-edp.c | 8 4 files changed, 16 insertions(+) --- base-commit: 414c97c966b69e4a6ea7b32970fa166b2f9b9ef0 change-id: 20241127-qcs8300_dp-272c591c3aea Best regards, -- Yongxing Mou

[PATCH 2/4] phy: qcom: edp: Add support for eDP PHY on QCS8300

2024-11-27 Thread Yongxing Mou
Add support for eDP PHY v5 found on the Qualcomm QCS8300 platform. Signed-off-by: Yongxing Mou --- drivers/phy/qualcomm/phy-qcom-edp.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c index f1b51018683d51df064

[PATCH 1/4] dt-bindings: phy: Add eDP PHY compatible for qcs8300

2024-11-27 Thread Yongxing Mou
Add compatible string for the supported eDP PHY on qcs8300 platform. Signed-off-by: Yongxing Mou --- Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bin