On Wed, Nov 27, 2024 at 03:05:03PM +0800, Yongxing Mou wrote:
> Add Mobile Display Subsystem (MDSS) support for the QCS8300 platform.
Please mention, why do you need it at all. I see that the UBWC swizzle
and HBB settings are different. Is this really the case? Is it because
of the different memory being used on those platforms?
>
> Signed-off-by: Yongxing Mou <quic_yong...@quicinc.com>
> ---
> drivers/gpu/drm/msm/msm_mdss.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c
> index
> b7bd899ead44bf86998e7295bccb31a334fa6811..90d8fe469d3134ec73f386153509ac257d75930a
> 100644
> --- a/drivers/gpu/drm/msm/msm_mdss.c
> +++ b/drivers/gpu/drm/msm/msm_mdss.c
> @@ -568,6 +568,16 @@ static const struct msm_mdss_data qcm2290_data = {
> .reg_bus_bw = 76800,
> };
>
> +static const struct msm_mdss_data qcs8300_data = {
> + .ubwc_enc_version = UBWC_4_0,
> + .ubwc_dec_version = UBWC_4_0,
> + .ubwc_swizzle = 6,
> + .ubwc_static = 1,
> + .highest_bank_bit = 3,
> + .macrotile_mode = 1,
> + .reg_bus_bw = 74000,
> +};
> +
> static const struct msm_mdss_data sa8775p_data = {
> .ubwc_enc_version = UBWC_4_0,
> .ubwc_dec_version = UBWC_4_0,
> @@ -715,6 +725,7 @@ static const struct of_device_id mdss_dt_match[] = {
> { .compatible = "qcom,mdss" },
> { .compatible = "qcom,msm8998-mdss", .data = &msm8998_data },
> { .compatible = "qcom,qcm2290-mdss", .data = &qcm2290_data },
> + { .compatible = "qcom,qcs8300-mdss", .data = &qcs8300_data },
> { .compatible = "qcom,sa8775p-mdss", .data = &sa8775p_data },
> { .compatible = "qcom,sdm670-mdss", .data = &sdm670_data },
> { .compatible = "qcom,sdm845-mdss", .data = &sdm845_data },
>
> --
> 2.34.1
>
--
With best wishes
Dmitry
