Re: Full 32bit flowid from igb(4)

2015-04-14 Thread hiren panchasara
On 04/03/15 at 12:15P, Adrian Chadd wrote: > On 3 April 2015 at 10:02, hiren panchasara wrote: > > On 04/03/15 at 10:00P, Adrian Chadd wrote: > >> On 3 April 2015 at 09:54, hiren panchasara > >> wrote: > >> > On 03/31/15 at 11:15P, Adrian Chadd wrote: > >> >> Yeah, I think the right thing to do

Re: Full 32bit flowid from igb(4)

2015-04-03 Thread Adrian Chadd
On 3 April 2015 at 10:02, hiren panchasara wrote: > On 04/03/15 at 10:00P, Adrian Chadd wrote: >> On 3 April 2015 at 09:54, hiren panchasara >> wrote: >> > On 03/31/15 at 11:15P, Adrian Chadd wrote: >> >> Yeah, I think the right thing to do is: >> >> >> >> * If the descriptor says it's RSS, then

Re: Full 32bit flowid from igb(4)

2015-04-03 Thread hiren panchasara
On 04/03/15 at 10:00P, Adrian Chadd wrote: > On 3 April 2015 at 09:54, hiren panchasara wrote: > > On 03/31/15 at 11:15P, Adrian Chadd wrote: > >> Yeah, I think the right thing to do is: > >> > >> * If the descriptor says it's RSS, then use the flowid + rss type > > So, if we have multiqueue, we d

Re: Full 32bit flowid from igb(4)

2015-04-03 Thread Adrian Chadd
On 3 April 2015 at 09:54, hiren panchasara wrote: > On 03/31/15 at 11:15P, Adrian Chadd wrote: >> Yeah, I think the right thing to do is: >> >> * If the descriptor says it's RSS, then use the flowid + rss type > So, if we have multiqueue, we do everything needed to get RSS > flowid/type. That mean

Re: Full 32bit flowid from igb(4)

2015-04-03 Thread hiren panchasara
On 03/31/15 at 11:15P, Adrian Chadd wrote: > Yeah, I think the right thing to do is: > > * If the descriptor says it's RSS, then use the flowid + rss type So, if we have multiqueue, we do everything needed to get RSS flowid/type. That means, with num_queues > 1 we can just expose those. > * else,

Re: Full 32bit flowid from igb(4)

2015-03-31 Thread Adrian Chadd
Yeah, I think the right thing to do is: * If the descriptor says it's RSS, then use the flowid + rss type * else, set it to queue id and set the type to opaque. -a ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freeb

Re: Full 32bit flowid from igb(4)

2015-03-31 Thread hiren panchasara
On 03/30/15 at 10:53P, Adrian Chadd wrote: > No, you're absolutely right. However, you (a) get flowid for L3/L4 > V4/v6 but not other things, and (b) I was worried about changing the > default behaviour of the driver, and who knows what other weird crap > people may have done to their local driver.

Re: Full 32bit flowid from igb(4)

2015-03-30 Thread Adrian Chadd
No, you're absolutely right. However, you (a) get flowid for L3/L4 V4/v6 but not other things, and (b) I was worried about changing the default behaviour of the driver, and who knows what other weird crap people may have done to their local driver. stuff like enabled checksums instead, or hacked in

Re: Full 32bit flowid from igb(4)

2015-03-30 Thread hiren panchasara
On 03/30/15 at 04:33P, Adrian Chadd wrote: > So, the 32 bit field that has the flowid in the rx descriptor can mean > multiple things - not just the flowid. > > For igb it can also mean one of the RX checksums. I care about igb(4) right now and I350 specifically. I checked the spec and section 7.

Re: Full 32bit flowid from igb(4)

2015-03-30 Thread Adrian Chadd
So, the 32 bit field that has the flowid in the rx descriptor can mean multiple things - not just the flowid. For igb it can also mean one of the RX checksums. for ixgbe it can also mean RX checksum, or flowdirector flow information, or a few other thngs. -adrian ___

Re: Full 32bit flowid from igb(4)

2015-03-30 Thread hiren panchasara
On 03/24/15 at 01:51P, Adrian Chadd wrote: > Hi, > > The main reason I didn't add it outside of RSS is that I didn't want > to impact the behaviour that was there before. Before, it wasn't using > the flowid - only the msix/queue id. It'd break things if not all igb chips behave the same way in t

Re: Full 32bit flowid from igb(4)

2015-03-24 Thread Adrian Chadd
Hi, The main reason I didn't add it outside of RSS is that I didn't want to impact the behaviour that was there before. Before, it wasn't using the flowid - only the msix/queue id. I read the intel datasheets about that particular field - I'm pretty sure that by default we'll only see RSS hashed

Re: Full 32bit flowid from igb(4)

2015-03-24 Thread hiren panchasara
On 03/23/15 at 04:58P, Jack Vogel wrote: > I think that line was there at one time outside the RSS define, I believe this was added by Adrian as part of RSS work and was not there before. I may be wrong. > I'd have to > take a look at > the code a bit more, or maybe Eric will I'll wait for th

Re: Full 32bit flowid from igb(4)

2015-03-23 Thread Jack Vogel
I think that line was there at one time outside the RSS define, I'd have to take a look at the code a bit more, or maybe Eric will Jack On Mon, Mar 23, 2015 at 4:42 PM, hiren panchasara < hi...@strugglingcoder.info> wrote: > Correcting Eric's email and subject line. > > On 03/23/15 at 04:39