On 3 April 2015 at 09:54, hiren panchasara <hi...@strugglingcoder.info> wrote: > On 03/31/15 at 11:15P, Adrian Chadd wrote: >> Yeah, I think the right thing to do is: >> >> * If the descriptor says it's RSS, then use the flowid + rss type > So, if we have multiqueue, we do everything needed to get RSS > flowid/type. That means, with num_queues > 1 we can just expose those. > >> * else, set it to queue id and set the type to opaque. > > This part becomes irrelevant as it's a single queue case. Do we care > about setting flowid value/type in case of single queue?
My whole point with not always setting it is that people may do things to /other/ parts of the driver and suddenly the RSS field isn't the RSS field anymore. Doubly so if you start playing with multiqueue + flowdirector on ixgbe. :) So I'd rather the driver be right and correct - checking if the field /is/ RSS and only setting the flowid+flowtype /if/ the value in that register is an RSS flowid, rather than setting it to whatever's there and hoping it's an RSS value. :) -adrian _______________________________________________ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
