On 03/30/15 at 10:53P, Adrian Chadd wrote: > No, you're absolutely right. However, you (a) get flowid for L3/L4 > V4/v6 but not other things, and (b) I was worried about changing the > default behaviour of the driver, and who knows what other weird crap > people may have done to their local driver. stuff like enabled > checksums instead, or hacked in flowtable support. :) > > So, I'm totally fine if you want to populate the flowid for a given > flow. Totally okay. You just can't set it blindly - you can only set > it when the relevant descriptor bits say "it's a flowid!".
Thanks for taking time and answering. Totally agree. Looking at the code, igb does setup everything correctly to get RSS hash in flowid when num_queues > 1. I'm not sure and I've not checked what other chipsets do but I350 looks fine. If needed I am okay to guard this with mac_type check. Jack/Eric: Let me know what you guys think. Cheers, Hiren
pgpLl1RmRWjVw.pgp
Description: PGP signature
