Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-23 Thread Andre Oppermann
Ian FREISLICH wrote: > > Julian Elischer wrote: > > On Tue, 22 Jun 2004, Ian FREISLICH wrote: > > > Andre Oppermann wrote: > > > > Here is the next preview patch for the ipfw to pfil_hooks conversion: > > > > > > > > http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff > > > > > >

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-23 Thread Ian FREISLICH
Julian Elischer wrote: > On Tue, 22 Jun 2004, Ian FREISLICH wrote: > > Andre Oppermann wrote: > > > Here is the next preview patch for the ipfw to pfil_hooks conversion: > > > > > > http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff > > > > > > This patch significantly cleans up

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Bruce M Simpson
Just to note that I've posted you feedback on this patch off-list. Regards, BMS ___ [EMAIL PROTECTED] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Julian Elischer
On Tue, 22 Jun 2004, Ian FREISLICH wrote: > Andre Oppermann wrote: > > Here is the next preview patch for the ipfw to pfil_hooks conversion: > > > > http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff > > > > This patch significantly cleans up ip_input.c and ip_output.c. > >

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Maxim Konovalov
On Tue, 22 Jun 2004, 13:38+0200, Andre Oppermann wrote: > Maxim Konovalov wrote: > > > > Hi Andre, > > > > On Mon, 21 Jun 2004, 23:36+0200, Andre Oppermann wrote: > > > > > Here is the next preview patch for the ipfw to pfil_hooks conversion: > > > > > > http://www.nrg4u.com/freebsd/ipfw-pfilhook

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Andre Oppermann
Luigi Rizzo wrote: > > On Mon, Jun 21, 2004 at 11:36:21PM +0200, Andre Oppermann wrote: > > Here is the next preview patch for the ipfw to pfil_hooks conversion: > > > > http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff > > > > This patch significantly cleans up ip_input.c and i

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Ian FREISLICH
Andre Oppermann wrote: > > There have been about 5 PRs (most with patches) in the past years > > which all claim to fix this problem indicating that here is a need > > for a fix. We rely on the fix in kern/64240 to collect traffic > > accounting information for billing and statistical purposes. T

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Andre Oppermann
Angelo Turetta wrote: > > - Original Message - > From: "Andre Oppermann" <[EMAIL PROTECTED]> > Sent: Monday, June 21, 2004 11:36 PM > > > This patch significantly cleans up ip_input.c and ip_output.c. > > > > The following is included in this patch: > > > > o Remove all ipfw related cru

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Andre Oppermann
Maxim Konovalov wrote: > > On Tue, 22 Jun 2004, 02:06-0700, Luigi Rizzo wrote: > > > On Tue, Jun 22, 2004 at 12:15:21PM +0400, Maxim Konovalov wrote: > > ... > > > > Consider this a FYI. It is very much a WIP at the moment. I want > > > > to get this into the tree in before 5.3 code freeze. > >

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Andre Oppermann
Ian FREISLICH wrote: > > Andre Oppermann wrote: > > Here is the next preview patch for the ipfw to pfil_hooks conversion: > > > > http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff > > > > This patch significantly cleans up ip_input.c and ip_output.c. > > That would be a very a

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Andre Oppermann
Maxim Konovalov wrote: > > Hi Andre, > > On Mon, 21 Jun 2004, 23:36+0200, Andre Oppermann wrote: > > > Here is the next preview patch for the ipfw to pfil_hooks conversion: > > > > http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff > > > > This patch significantly cleans up ip_i

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Dag-Erling Smørgrav
Maxim Konovalov <[EMAIL PROTECTED]> writes: > $ ident /usr/src-5-current/sys/kern/uipc_syscalls.c Wrong file - but this is pointless, anyway. You are generalizing from a single data point. I can show you a room full of servers that can't run 5.2.1 due to bugs in the ACPI support code and in two

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Maxim Konovalov
On Tue, 22 Jun 2004, 11:49+0200, Dag-Erling Sm?rgrav wrote: > Maxim Konovalov <[EMAIL PROTECTED]> writes: > > Yesterday -CURRENT leaks kernel memory very quickly and panics after > > 10 - 15 mins up. > > Nope. That bug was introduced on June 9th, almost two weeks ago, and Nope :-) $ ident /usr/

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Angelo Turetta
- Original Message - From: "Andre Oppermann" <[EMAIL PROTECTED]> Sent: Monday, June 21, 2004 11:36 PM > This patch significantly cleans up ip_input.c and ip_output.c. > > The following is included in this patch: > > o Remove all ipfw related cruft from ip_input() and ip_output() > o

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Luigi Rizzo
On Mon, Jun 21, 2004 at 11:36:21PM +0200, Andre Oppermann wrote: > Here is the next preview patch for the ipfw to pfil_hooks conversion: > > http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff > > This patch significantly cleans up ip_input.c and ip_output.c. > assorted comment

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Dag-Erling Smørgrav
Maxim Konovalov <[EMAIL PROTECTED]> writes: > Yesterday -CURRENT leaks kernel memory very quickly and panics after > 10 - 15 mins up. Nope. That bug was introduced on June 9th, almost two weeks ago, and it was fixed less than twelve hours later. I have several machines already running yesterday'

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Maxim Konovalov
On Tue, 22 Jun 2004, 02:06-0700, Luigi Rizzo wrote: > On Tue, Jun 22, 2004 at 12:15:21PM +0400, Maxim Konovalov wrote: > ... > > > Consider this a FYI. It is very much a WIP at the moment. I want > > > to get this into the tree in before 5.3 code freeze. > > > > In fact, our real world tests sho

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Maxim Konovalov
On Tue, 22 Jun 2004, 11:23+0200, Dag-Erling Sm?rgrav wrote: > Maxim Konovalov <[EMAIL PROTECTED]> writes: > > In fact, our real world tests shown the current -CURRENT comparing to > > RELENG_5_2 is in a very bad shape. > > You'll have to substantiate that. All *my* real world tests show that > -C

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Dag-Erling Smørgrav
Maxim Konovalov <[EMAIL PROTECTED]> writes: > In fact, our real world tests shown the current -CURRENT comparing to > RELENG_5_2 is in a very bad shape. You'll have to substantiate that. All *my* real world tests show that -CURRENT is a lot more stable and functional than RELENG_5_2. >

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Luigi Rizzo
On Tue, Jun 22, 2004 at 12:15:21PM +0400, Maxim Konovalov wrote: ... > > Consider this a FYI. It is very much a WIP at the moment. I want > > to get this into the tree in before 5.3 code freeze. > > In fact, our real world tests shown the current -CURRENT comparing to > RELENG_5_2 is in a very b

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Ian FREISLICH
Andre Oppermann wrote: > Here is the next preview patch for the ipfw to pfil_hooks conversion: > > http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff > > This patch significantly cleans up ip_input.c and ip_output.c. That would be a very a nice thing, but it looks like this bre

Re: New preview patch for ipfw to pfil_hooks conversion

2004-06-22 Thread Maxim Konovalov
Hi Andre, On Mon, 21 Jun 2004, 23:36+0200, Andre Oppermann wrote: > Here is the next preview patch for the ipfw to pfil_hooks conversion: > > http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff > > This patch significantly cleans up ip_input.c and ip_output.c. > > The following is

New preview patch for ipfw to pfil_hooks conversion

2004-06-21 Thread Andre Oppermann
Here is the next preview patch for the ipfw to pfil_hooks conversion: http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff This patch significantly cleans up ip_input.c and ip_output.c. The following is included in this patch: o Remove all ipfw related cruft from ip_input() and ip_o