Re: Ephemeral ports patch (fixed)

2008-03-04 Thread Rui Paulo
On Tue, Mar 04, 2008 at 05:09:14AM -0200, Fernando Gont wrote: > At 03:23 a.m. 04/03/2008, Mike Silbersack wrote: > >> Too optimistic: >> >> ! #define IPPORT_EPHEMERALLAST 655535 >> >> Otherwise the patch looks good to me. It looked a bit strange in unified >> diff format, I needed to look at

Re: Ephemeral ports patch (fixed)

2008-03-04 Thread Rui Paulo
On Mon, Mar 03, 2008 at 11:23:16PM -0600, Mike Silbersack wrote: > > > On Mon, 3 Mar 2008, Fernando Gont wrote: > >> At 04:11 a.m. 03/03/2008, Mike Silbersack wrote: >> Here's the same patch, but with the first ephemeral port changed from 1024 to 1. >>> >>> Now that I've actuall

Re: Ephemeral ports patch (fixed)

2008-03-03 Thread Fernando Gont
At 03:23 a.m. 04/03/2008, Mike Silbersack wrote: Too optimistic: ! #define IPPORT_EPHEMERALLAST 655535 Otherwise the patch looks good to me. It looked a bit strange in unified diff format, I needed to look at it in context format. (Strange, since I usually prefer unified.) Doh! I had fi

Re: Ephemeral ports patch (fixed)

2008-03-03 Thread Mike Silbersack
On Mon, 3 Mar 2008, Fernando Gont wrote: At 04:11 a.m. 03/03/2008, Mike Silbersack wrote: Here's the same patch, but with the first ephemeral port changed from 1024 to 1. Now that I've actually gone to try to apply the patch (so I can view the two codepaths side by side, rather than i

Re: Ephemeral ports patch (fixed)

2008-03-03 Thread Fernando Gont
At 04:11 a.m. 03/03/2008, Mike Silbersack wrote: Here's the same patch, but with the first ephemeral port changed from 1024 to 1. Now that I've actually gone to try to apply the patch (so I can view the two codepaths side by side, rather than in diff form), I'm finding that I can't apply

Re: Ephemeral ports patch (fixed)

2008-03-02 Thread Mike Silbersack
On Mon, 3 Mar 2008, Fernando Gont wrote: Folks, Here's the same patch, but with the first ephemeral port changed from 1024 to 1. Now that I've actually gone to try to apply the patch (so I can view the two codepaths side by side, rather than in diff form), I'm finding that I can't app

Ephemeral ports patch (fixed)

2008-03-02 Thread Fernando Gont
Folks, Here's the same patch, but with the first ephemeral port changed from 1024 to 1. Index: in.h === RCS file: /home/ncvs/src/sys/netinet/in.h,v retrieving revision 1.100 diff -u -r1.100 in.h --- in.h12 Jun 2007 16: