[Differential] [Commented On] D1879: Don't allocate memory for operations that do not insert

pjd added inline comments. INLINE COMMENTS lib/libnv/nvlist.c:276 'false' should be returned here. lib/libnv/nvlist.c:1094 'false' instead of '0'. lib/libnv/nvlist.c: 'false', not '0'. REVISION DETAIL https://reviews.freebsd.org/D1879 To: rstone, jfvogel Cc: freebsd-net, pjd

[Differential] [Commented On] D1878: Add function to force an nvlist into the error state

pjd added a comment. Other that the minor nit above, it looks good. INLINE COMMENTS lib/libnv/nvlist.c:144 I'd assert that error is != 0. REVISION DETAIL https://reviews.freebsd.org/D1878 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@fr

[Differential] [Commented On] D1877: Implement asprintf in libkern

pjd added inline comments. INLINE COMMENTS sys/conf/files:3185 Please sort properly (asprintf.c goes after arc4random.c). REVISION DETAIL https://reviews.freebsd.org/D1877 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing

[Differential] [Accepted] D1876: Add tests for dnvlist_take_*

pjd accepted this revision. pjd added a reviewer: pjd. pjd added a comment. Looks good. REVISION DETAIL https://reviews.freebsd.org/D1876 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/

[Differential] [Accepted] D1875: Add tests for dnv_get_*

pjd accepted this revision. pjd added a reviewer: pjd. pjd added a comment. Looks good. REVISION DETAIL https://reviews.freebsd.org/D1875 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/

[Differential] [Accepted] D1874: Add tests for nvlist_free* functions

pjd accepted this revision. pjd added a reviewer: pjd. pjd added a comment. Looks good. REVISION DETAIL https://reviews.freebsd.org/D1874 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/

[Differential] [Accepted] D1873: Add tests for nvlist_take_*

pjd accepted this revision. pjd added a reviewer: pjd. pjd added a comment. Looks good. REVISION DETAIL https://reviews.freebsd.org/D1873 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/

[Differential] [Accepted] D1871: Add tests for nvlist_pack/unpack

pjd accepted this revision. pjd added a reviewer: pjd. REVISION DETAIL https://reviews.freebsd.org/D1871 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To un

[Differential] [Accepted] D1872: Add test cases for nvlist_move_*

pjd accepted this revision. pjd added a reviewer: pjd. pjd added a comment. Looks good to me. REVISION DETAIL https://reviews.freebsd.org/D1872 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebs

[Differential] [Commented On] D1871: Add tests for nvlist_pack/unpack

pjd added a comment. Looks good to me. REVISION DETAIL https://reviews.freebsd.org/D1871 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any

[Differential] [Commented On] D1870: Add tests for nvlist_clone

pjd added inline comments. INLINE COMMENTS lib/libnv/tests/nv_tests.cc:324-331 Don't you want to test the clone here? If the values wre properly copied, if there is only one element, etc.? Now you are testing the source nvlist. REVISION DETAIL https://reviews.freebsd.org/D1870 To: rstone,

[Differential] [Commented On] D1869: Tests of basic nvlist add functions

pjd added a comment. I like it. REVISION DETAIL https://reviews.freebsd.org/D1869 To: rstone, jfvogel Cc: freebsd-net, pjd ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

[Differential] [Commented On] D1868: Make libnv headers includable from C++

pjd added a comment. Looks good to me, apart from the small nit above. INLINE COMMENTS lib/libnv/nv.h:66 Could you please add an empty line after this one for consistency? Thanks. REVISION DETAIL https://reviews.freebsd.org/D1868 To: rstone, jfvogel Cc: freebsd-net, pjd ___

Re: 9.0-RC1 panic in tcp_input: negative winow.

On Thu, Dec 29, 2011 at 11:12:59AM -0500, John Baldwin wrote: > On Sunday, December 25, 2011 11:01:33 am Коньков Евгений wrote: > > Здравствуйте, John. > > > > Вы писали 20 декабря 2011 г., 16:52:44: > > > > JB> On Saturday, December 17, 2011 6:21:27 pm Pawe

Re: 9.0-RC1 panic in tcp_input: negative winow.

tch as the fix. Unfortunately it paniced today. Take a look at: http://people.freebsd.org/~pjd/misc/tcp_panic.jpg -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am!

Re: 9.0-RC1 panic in tcp_input: negative winow.

tch as the fix. Sorry for the delay, but I'm just rebooting the box that triggered the panic with John's patch. I should know more in a day or two. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.

Re: 9.0-RC1 panic in tcp_input: negative winow.

ers' as I'm not 100% sure if the same pointer always represents the same connection or if it is reused. > [...] What I don't > quite get is why we haven't had a lot more reports of this issue... Maybe because my TCP/IP stack is heavly modified? ...not:) No idea to

Re: 9.0-RC1 panic in tcp_input: negative winow.

On Mon, Oct 24, 2011 at 08:14:22AM -0400, John Baldwin wrote: > On Sunday, October 23, 2011 11:58:28 am Pawel Jakub Dawidek wrote: > > On Sun, Oct 23, 2011 at 11:44:45AM +0300, Kostik Belousov wrote: > > > On Sun, Oct 23, 2011 at 08:10:38AM +0200, Pawel Jakub Dawidek wrote: >

Re: 9.0-RC1 panic in tcp_input: negative winow.

On Sun, Oct 23, 2011 at 11:44:45AM +0300, Kostik Belousov wrote: > On Sun, Oct 23, 2011 at 08:10:38AM +0200, Pawel Jakub Dawidek wrote: > > My suggestion would be that if we won't be able to fix it before 9.0, > > we should turn this assertion off, as the system seems to be

Re: 9.0-RC1 panic in tcp_input: negative winow.

On Sun, Oct 23, 2011 at 12:35:15PM +1100, Lawrence Stewart wrote: > On 10/22/11 19:49, Pawel Jakub Dawidek wrote: > > The panic message says: > > > > panic: tcp_input negative window: tp 0xfe007763e000 rcv_nxt > > 3718269252 rcv_adv 3718268291 > > > &g

9.0-RC1 panic in tcp_input: negative winow.

The panic message says: panic: tcp_input negative window: tp 0xfe007763e000 rcv_nxt 3718269252 rcv_adv 3718268291 I only have picture of the backtrace: http://people.freebsd.org/~pjd/misc/panic_negative_window.jpg -- Pawel Jakub Dawidek http

Re: ZFS and 'traditional' nfs-export

You can safely use /etc/exports without touching sharenfs property. -- Pawel Jakub Dawidek http://www.wheel.pl p...@freebsd.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! pgpX62VJDmMh1.pgp Description: PGP signature

PF's divert-to and divert-reply functionality.

ooking for reviewers and testers. PS. IPv6 support is partially implemented (it isn't also for IPFIREWALL_FORWARD option). -- Pawel Jakub Dawidek http://www.wheel.pl p...@freebsd.org http://www.FreeBSD.org FreeBSD committer

Re: Firewall redirect doesn't work any more...

On Mon, Sep 22, 2008 at 06:11:35PM +0400, Roman Kurakin wrote: > Pawel Jakub Dawidek wrote: > >On Mon, Sep 22, 2008 at 05:31:08PM +0400, Roman Kurakin wrote: > > > >>So, could you draw you connections and related firewall rules. And the > >>one you > >&

Re: Firewall redirect doesn't work any more...

treated as gateway, eg. server# nc -l 12345 client# route add 1.0.0.0/24 10.0.5.123 client# nc 10.0.0.2 12345 > PS. Also check the mac address issue that was discussed here (case where the > brdige0 and the first bridge member share the same MAC). That's not the case on my test machi

Re: Firewall redirect doesn't work any more...

y ideas how to make it work with TCP? PS. The same functionality doesn't work at all with ipfw(8) (because of if_bridge(4)?). -- Pawel Jakub Dawidek http://www.wheel.pl [EMAIL PROTECTED] http://www.FreeBSD.org FreeBSD committer

Re: Firewall redirect doesn't work any more...

On Fri, Sep 19, 2008 at 09:56:33AM +0200, Pawel Jakub Dawidek wrote: > ...or am I missing something? > > I've a box running: > > FreeBSD whiplash.wheel.pl 7.0-STABLE FreeBSD 7.0-STABLE #0: Wed Jul 23 > 11:41:31 CEST 2008 [EMAIL PROTECTED]:/usr/obj/usr/src/sys/WHIPL

Firewall redirect doesn't work any more...

packet leaving the box: IP 10.0.0.2.60806 > 10.0.5.123.88: S [...] I tried to redirect packet on the second box with IPFW, but also failed (yes IPFIREWALL_FORWARD was compiled in). Does something got broken or am I missing some configuration hint? -- Pawel Jakub Dawidek

Re: Can I pursuade someone to commit this patch? (Re: Multiple IP addresses in a jail.)

e one can bind selected IP addresses to. - Currently Bjoern Zeeb is working on those patches and IPv6 for jails, so he is the right person to ask the question. PS. I'm CCing it. -- Pawel Jakub Dawidek http://www.wheel.pl [EMAIL PROTECTED]

Re: [REVIEW/TEST] polling(4) changes

o 0 by default. If adding DEVICE_POLLING to the kernel doesn't cost additional locking, etc. in network data flow paths (which could lead to performance impact in some specific environments) can we just compile the code in always? -- Pawel Jakub Dawidek http://www.wheel

ath(4) panic: bus_dmamap_load_sg: no mbuf packet header!

bus_dmamap_load_sg: no mbuf packet header! And the backtrace: panic() bus_dmamap_load_sg()+0x2a ath_start()+0x2ae taskqueue_run()+0xaf taskqueue_swi_run()+0x13 ithread_loop() ... Any ideas? -- Pawel Jakub Dawidek http://www.wheel.pl [EMAIL PROTECTED]

Re: Giant-free polling [PATCH]

al mutex, which protects those fields. +> > +> > +> +> you need to add an interface method that has access to it.. I was thinking more about moving interface mutex into ifnet structure, but Robert has some objections IIRC. -- Pawel Jakub Dawidek http://www.wh

Re: Giant-free polling [PATCH]

ccess tointerface's internal mutex, which protects those fields. -- Pawel Jakub Dawidek http://www.wheel.pl [EMAIL PROTECTED] http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! pgptRhaa0bjn4.pgp Description: PGP signature

Re: Giant-free polling [PATCH]

ock); +> } +> +> so additional polling processes after the first one will not +> block on busy interfaces and move forward instead. +> This should remove a bit of contention, and let separate processes actually +> work on different interfaces. I think we should just implement per-in

Re: INADDR_ANY bind in a multiip jail

On Sat, Dec 04, 2004 at 11:38:09PM +0100, Andre Oppermann wrote: +> Meno Abels wrote: +> > +> > Hello, +> > +> > i just found a patch from Pawel Jakub Dawidek(mijail5) which do not +> > need the pcb bind +> > to multiple ip's. He solve the probl

Re: Socket selection.

On Thu, May 20, 2004 at 11:01:46PM +0200, Andre Oppermann wrote: +> Pawel Jakub Dawidek wrote: +> > +> > Hello. +> > +> > In in_pcblookup_hash() function, in the last loop if we find exact +> > match, we return immediately, if it is "wild", we store

Re: ia_netbroadcast

ver I'm not yet sure we (better I) understand all implications of +> removing the things you do in your patch. Please hold off for a moment +> until I've finished thinking and looking through the implications. Don't worry. I'm not going to commit it before I hear clear &q

Socket selection.

ded? Shouldn't it be: http://people.freebsd.org/~pjd/patches/in_pcb.c.2.patch ? While I'm here, I want to improve code readability a bit: http://people.freebsd.org/~pjd/patches/in_pcb.c.3.patch Is it ok? -- Pawel Jakub Dawidek http://ww

Re: ia_netbroadcast

On Tue, May 18, 2004 at 03:47:56AM -0700, Luigi Rizzo wrote: +> On Tue, May 18, 2004 at 12:05:03PM +0200, Pawel Jakub Dawidek wrote: +> ... +> > +> > Do we still need ia_netboradcast field? It is calculated depending on +> > +> > old-fashion classes (A, B, C). Is it

Network performance, netperf patches and more.

probably only on freebsd-performance@, so please, remove other lists while replying. -- Pawel Jakub Dawidek http://www.FreeBSD.org [EMAIL PROTECTED] http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am

Re: ia_netbroadcast

On Tue, May 18, 2004 at 03:47:56AM -0700, Luigi Rizzo wrote: +> On Tue, May 18, 2004 at 12:05:03PM +0200, Pawel Jakub Dawidek wrote: +> ... +> > +> > Do we still need ia_netboradcast field? It is calculated depending on +> > +> > old-fashion classes (A, B, C). Is it

Re: ia_netbroadcast

On Tue, May 18, 2004 at 02:43:46AM -0700, Luigi Rizzo wrote: +> On Tue, May 18, 2004 at 11:24:39AM +0200, Pawel Jakub Dawidek wrote: +> > Hi. +> > +> > Do we still need ia_netboradcast field? It is calculated depending on +> > old-fashion classes (A, B, C). Is it u

ia_netbroadcast

lias. When I tested something and there were ~1 aliases on interface it worked really slow. This slowdown probably exists in more places. It exists in NetBSD and OpenBSD as well. -- Pawel Jakub Dawidek http://www.FreeBSD.org [EMAIL PROTECTED]

Re: em(4) problems.

On Wed, May 05, 2004 at 12:42:48PM +0200, Pawel Jakub Dawidek wrote: +> Hi. +> +> I've problems with em(4) and IPSEC/FAST_IPSEC and TCP_STREAM netperf test. +> While running netperf tests between two FreeBSD machines directly connected +> em0 goes down once every few minutes

em(4) problems.

14556076 - 2722142 - - Any ideas? -- Pawel Jakub Dawidek http://www.FreeBSD.org [EMAIL PROTECTED] http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! pgpxUvIMDptz9.pgp Description: PGP signature

Unused argument in in_pcballoc() function.

Hi. I've found unused argument in in_pcballoc() function: http://people.freebsd.org/~pjd/patches/in_pcballoc.patch Is it possible to commit it, as it affect ipv6 code as well? -- Pawel Jakub Dawidek http://www.FreeBSD.org [EMAIL PROT

Re: in_pcbbind_setup(), etc.

be a lot easier to do than with a thread reference. +> +> How does this sound? It would completely eliminate the issue of "er, +> which thread is that", which is really an unnecessary issue given that all +> we're interested in is the credential.

Re: in_pcbbind_setup(), etc.

nd_setup(): if (td == NULL) printf("NULL td in %s\n", __func__); if (td != curthread) printf("td != curthread in %s\n", __func__); And I'm seeing 2nd printf() while mounting NFS file systems. If so, I think using td->td

in_pcbbind_setup(), etc.

): [...] * k - only accessed by curthread [...] struct ucred*td_ucred; /* (k) Reference to credentials. */ [...] Not telling that we can just remove this argument if this is always current thread. -- Pawel Jakub Dawidek http://www.FreeBSD.org [EMAIL PROTECTED]

New failure detection algorithm for ng_one2many(4).

#x27;one' interface have to be always avaliable. Any comments, etc. are of course welcome. -- Pawel Jakub Dawidek http://www.FreeBSD.org [EMAIL PROTECTED] http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I