Hello.

In in_pcblookup_hash() function, in the last loop if we find exact
match, we return immediately, if it is "wild", we store a pointer and
we countinue looking for exact match.
I wonder if this is ok, that we change pointer every time we find a
"wild" match. Is it inteded? Shouldn't it be:

        http://people.freebsd.org/~pjd/patches/in_pcb.c.2.patch

?

While I'm here, I want to improve code readability a bit:

        http://people.freebsd.org/~pjd/patches/in_pcb.c.3.patch

Is it ok?

-- 
Pawel Jakub Dawidek                       http://www.FreeBSD.org
[EMAIL PROTECTED]                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!

Attachment: pgpKUIG0p3zgD.pgp
Description: PGP signature

Reply via email to