Re: File locking, closes and performance in a distributed filesystemenv

2002-05-15 Thread Terry Lambert
"Andrew R. Reiter" wrote: > :He could also maintain a local cache of this per vnode, basically > :maintain a mirror of the lock list locally in order to see if a remote > :op must be done. > > Isn't this sorta like coda? Lock cache, not data cache. It's "sort of like": http://www.blackflag.ru/

Re: File locking, closes and performance in a distributed filesystemenv

2002-05-15 Thread Terry Lambert
Alfred Perlstein wrote: > He could also maintain a local cache of this per vnode, basically > maintain a mirror of the lock list locally in order to see if a remote > op must be done. I think we are talking past each other. This is what I've been suggesting since my first message, but suggested

Re: File locking, closes and performance in a distributed filesystemenv

2002-05-15 Thread Richard Sharpe
On Tue, 14 May 2002, Terry Lambert wrote: > Richard Sharpe wrote: > > Hmmm, I wasn't very clear ... > > > > What I am proposing is a 'simple' fix that simply changes > > > > p->p_flag |= P_ADVLOCK; > > > > to > > > > fp->l_flag |= P_ADVLOCK; > > > > And never resets it, and t

Re: File locking, closes and performance in a distributed filesystemenv

2002-05-15 Thread Alfred Perlstein
* Andrew R. Reiter <[EMAIL PROTECTED]> [020515 09:54] wrote: > On Wed, 15 May 2002, Alfred Perlstein wrote: > > :* Terry Lambert <[EMAIL PROTECTED]> [020515 01:36] wrote: > :> Alfred Perlstein wrote: > :> > As Terry stated you can't do that, however you could cache that the > :> > VNODE has a loc

Re: File locking, closes and performance in a distributed filesystemenv

2002-05-15 Thread Andrew R. Reiter
On Wed, 15 May 2002, Alfred Perlstein wrote: :* Terry Lambert <[EMAIL PROTECTED]> [020515 01:36] wrote: :> Alfred Perlstein wrote: :> > As Terry stated you can't do that, however you could cache that the :> > VNODE has a lock, that would reduce the requirement for calling the :> > ADVLOCK VOP. :>

Re: File locking, closes and performance in a distributed filesystemenv

2002-05-15 Thread Alfred Perlstein
* Terry Lambert <[EMAIL PROTECTED]> [020515 01:36] wrote: > Alfred Perlstein wrote: > > As Terry stated you can't do that, however you could cache that the > > VNODE has a lock, that would reduce the requirement for calling the > > ADVLOCK VOP. > You'd really have to know when the lock list went t

Re: File locking, closes and performance in a distributed filesystemenv

2002-05-15 Thread Terry Lambert
Alfred Perlstein wrote: > As Terry stated you can't do that, however you could cache that the > VNODE has a lock, that would reduce the requirement for calling the > ADVLOCK VOP. You'd really have to know when the lock list went to NULL, to get any benefit out of it, since locking would still end

Re: File locking, closes and performance in a distributed filesystemenv

2002-05-14 Thread Alfred Perlstein
* Terry Lambert <[EMAIL PROTECTED]> [020514 22:58] wrote: > Richard Sharpe wrote: > > Hmmm, I wasn't very clear ... > > > > What I am proposing is a 'simple' fix that simply changes > > > > p->p_flag |= P_ADVLOCK; > > > > to > > > > fp->l_flag |= P_ADVLOCK; As Terry stated you

Re: File locking, closes and performance in a distributed filesystemenv

2002-05-14 Thread Terry Lambert
Richard Sharpe wrote: > Hmmm, I wasn't very clear ... > > What I am proposing is a 'simple' fix that simply changes > > p->p_flag |= P_ADVLOCK; > > to > > fp->l_flag |= P_ADVLOCK; > > And never resets it, and then in closef, > > if ((fp->l_flag & P_ADVLOCK) && fp->f_t

Re: File locking, closes and performance in a distributed filesystemenv

2002-05-14 Thread Richard Sharpe
On Tue, 14 May 2002, Terry Lambert wrote: Hmmm, I wasn't very clear ... What I am proposing is a 'simple' fix that simply changes p->p_flag |= P_ADVLOCK; to fp->l_flag |= P_ADVLOCK; And never resets it, and then in closef, if ((fp->l_flag & P_ADVLOCK) && fp->f_type