Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-11 Thread Andriy Gapon
After all the preparatory changes are committed, this is a final[*] notice/warning that I am going to start committing the following patchset really soon now[**[: http://people.freebsd.org/~avg/zfsboot.patches.9.diff [*] unless circumstances change [**] maybe next hour, even -- Andriy Gapon

Re: bootargs.h [Was: [review request] zfsboot/zfsloader: support accessing filesystems within a pool]

2012-05-09 Thread John Baldwin
On 5/9/12 5:32 AM, Andriy Gapon wrote: > > Here is a subversion diff to make use of the new bootargs.h header in pc98 > cdboot and loader, and i386 cdboot and pxeldr: > http://people.freebsd.org/~avg/bootargs.diff > Could you please review it? > Thank you! Looks good. > MFi386 of BTX changes for

bootargs.h [Was: [review request] zfsboot/zfsloader: support accessing filesystems within a pool]

2012-05-09 Thread Andriy Gapon
Here is a subversion diff to make use of the new bootargs.h header in pc98 cdboot and loader, and i386 cdboot and pxeldr: http://people.freebsd.org/~avg/bootargs.diff Could you please review it? Thank you! MFi386 of BTX changes for support of KARGS_FLAGS_EXTARG is pending. Do you think that it sh

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-08 Thread Andriy Gapon
on 08/05/2012 17:15 John Baldwin said the following: > Bruce might even suggest adding a ba_ prefix to all the members of > struct bootargs btw. I would not be opposed, but you've already done > a fair bit of work on this patch. Thank you for sparing me :-) So I hope to get busy committing this s

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-08 Thread John Baldwin
On 5/8/12 3:14 AM, Andriy Gapon wrote: > on 07/05/2012 20:43 John Baldwin said the following: >> On Monday, May 07, 2012 10:47:05 am Andriy Gapon wrote: >>> on 07/05/2012 16:53 John Baldwin said the following: > [snip] >>> What do you think about the -LOCORE- change that Bruce inspired? >> >> In ge

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-08 Thread Andriy Gapon
on 07/05/2012 20:43 John Baldwin said the following: > On Monday, May 07, 2012 10:47:05 am Andriy Gapon wrote: >> on 07/05/2012 16:53 John Baldwin said the following: [snip] >> What do you think about the -LOCORE- change that Bruce inspired? > > In general I think this looks good. I have only one

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-07 Thread John Baldwin
On Monday, May 07, 2012 11:15:53 am Andriy Gapon wrote: > on 07/05/2012 17:47 Andriy Gapon said the following: > > on 07/05/2012 16:53 John Baldwin said the following: > >> Ok. Maybe add one comment to the bootargs.h head to explain that the > >> 'bootargs' > >> struct starts at ARGOFF and can gr

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-07 Thread John Baldwin
On Monday, May 07, 2012 10:47:05 am Andriy Gapon wrote: > on 07/05/2012 16:53 John Baldwin said the following: > > On Saturday, May 05, 2012 5:53:07 am Andriy Gapon wrote: > [snip] > >> The new patchset: http://people.freebsd.org/~avg/zfsboot.patches.7.diff > > > > Looks great, thanks! A few repl

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-07 Thread Andriy Gapon
on 07/05/2012 17:47 Andriy Gapon said the following: > on 07/05/2012 16:53 John Baldwin said the following: >> Ok. Maybe add one comment to the bootargs.h head to explain that the >> 'bootargs' >> struct starts at ARGOFF and can grow up, while struct bootinfo is copied >> such that >> it's end i

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-07 Thread Andriy Gapon
on 07/05/2012 16:53 John Baldwin said the following: > On Saturday, May 05, 2012 5:53:07 am Andriy Gapon wrote: [snip] >> The new patchset: http://people.freebsd.org/~avg/zfsboot.patches.7.diff > > Looks great, thanks! A few replies below: Here's a followup patch for the suggestions: http://peop

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-07 Thread Andriy Gapon
on 05/05/2012 13:49 Bruce Evans said the following: > On Sat, 5 May 2012, Andriy Gapon wrote: > >> on 04/05/2012 18:25 John Baldwin said the following: >>> On Thursday, May 03, 2012 11:23:51 am Andriy Gapon wrote: on 03/05/2012 18:02 Andriy Gapon said the following: > > Here's the lat

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-07 Thread John Baldwin
On Saturday, May 05, 2012 5:53:07 am Andriy Gapon wrote: > on 05/05/2012 12:31 Andriy Gapon said the following: > > on 04/05/2012 18:25 John Baldwin said the following: > >> On Thursday, May 03, 2012 11:23:51 am Andriy Gapon wrote: > >>> on 03/05/2012 18:02 Andriy Gapon said the following: > >

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-05 Thread Bruce Evans
On Sat, 5 May 2012, Andriy Gapon wrote: on 04/05/2012 18:25 John Baldwin said the following: On Thursday, May 03, 2012 11:23:51 am Andriy Gapon wrote: on 03/05/2012 18:02 Andriy Gapon said the following: Here's the latest version of the patches: http://people.freebsd.org/~avg/zfsboot.patches

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-05 Thread Andriy Gapon
on 05/05/2012 12:31 Andriy Gapon said the following: > on 04/05/2012 18:25 John Baldwin said the following: >> On Thursday, May 03, 2012 11:23:51 am Andriy Gapon wrote: >>> on 03/05/2012 18:02 Andriy Gapon said the following: Here's the latest version of the patches: http://people.fr

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-05 Thread Andriy Gapon
on 04/05/2012 18:25 John Baldwin said the following: > On Thursday, May 03, 2012 11:23:51 am Andriy Gapon wrote: >> on 03/05/2012 18:02 Andriy Gapon said the following: >>> >>> Here's the latest version of the patches: >>> http://people.freebsd.org/~avg/zfsboot.patches.4.diff >> >> I've found a cou

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-04 Thread John Baldwin
On Thursday, May 03, 2012 11:23:51 am Andriy Gapon wrote: > on 03/05/2012 18:02 Andriy Gapon said the following: > > > > Here's the latest version of the patches: > > http://people.freebsd.org/~avg/zfsboot.patches.4.diff > > I've found a couple of problems in the previous version, so here's anoth

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-03 Thread Andriy Gapon
on 03/05/2012 18:02 Andriy Gapon said the following: > > Here's the latest version of the patches: > http://people.freebsd.org/~avg/zfsboot.patches.4.diff I've found a couple of problems in the previous version, so here's another one: http://people.freebsd.org/~avg/zfsboot.patches.5.diff The impo

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-03 Thread Andriy Gapon
Here's the latest version of the patches: http://people.freebsd.org/~avg/zfsboot.patches.4.diff John, the first of the patches implements the approach that we previously discussed. All arguments are passed starting at a fixed offset that should provide enough space for extending argument list. T

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-05-01 Thread Marius Strobl
On Mon, Apr 30, 2012 at 10:04:17AM +0300, Andriy Gapon wrote: > on 29/04/2012 19:46 Marius Strobl said the following: > > Given that you certainly have a well better knowledge of ZFS, it > > would be great if we could do it the other way around, i.e. commit > > the sparc64 support first and then yo

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-30 Thread Andriy Gapon
on 29/04/2012 19:46 Marius Strobl said the following: > Given that you certainly have a well better knowledge of ZFS, it > would be great if we could do it the other way around, i.e. commit > the sparc64 support first and then your patch after adapting > whatever you have in mind with things becomi

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-29 Thread Marius Strobl
On Fri, Apr 27, 2012 at 12:06:08PM +0300, Andriy Gapon wrote: > on 23/04/2012 00:21 Marius Strobl said the following: > > On Sat, Apr 14, 2012 at 06:37:54PM +0300, Andriy Gapon wrote: > [snip] > >> I am particularly interested in reviews of my attempt to make ZFS boot > >> support > >> arch-indepe

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-27 Thread Andriy Gapon
on 27/04/2012 13:37 Andrey V. Elsukov said the following: > What you think about this concept: > We can implement some MI API to query disks count and each disk parameters > (mediasize, > sectorsize). This MI code will use some IOCTL that will act with MD "disk"'s > devsw->ioctl. > > devicename.

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-27 Thread Andrey V. Elsukov
On 27.04.2012 13:14, Andriy Gapon wrote: >> I also have some WIP related to moving partition table handling into MD Oh, i did mean MI part. >> part. You can look here: http://people.freebsd.org/~ae/sys_boot.diff > > I like this patch. OTOH, I couldn't help by wonder if it is possible to > someh

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-27 Thread Andriy Gapon
on 23/04/2012 09:23 Andrey V. Elsukov said the following: > On 23.04.2012 1:21, Marius Strobl wrote: >> I can't say much about these patches as a whole as they are rather big >> and I'm not aware of all the details of ZFS. However, one bit that makes >> the current implementation x86-specific is zf

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-27 Thread Andriy Gapon
on 23/04/2012 00:21 Marius Strobl said the following: > On Sat, Apr 14, 2012 at 06:37:54PM +0300, Andriy Gapon wrote: [snip] >> I am particularly interested in reviews of my attempt to make ZFS boot >> support >> arch-independent. The arches, of course, would have to add some code to make >> use

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-22 Thread Andrey V. Elsukov
On 23.04.2012 1:21, Marius Strobl wrote: > I can't say much about these patches as a whole as they are rather > big and I'm not aware of all the details of ZFS. However, one bit that > makes the current implementation x86-specific is zfs_dev_init(). If > you could move it to the MD part in the cour

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-22 Thread Marius Strobl
On Sat, Apr 14, 2012 at 06:37:54PM +0300, Andriy Gapon wrote: > > I would like to ask for a review and/or testing of the following three > patches: > http://people.freebsd.org/~avg/zfsboot.patches.diff > > These patches add support for booting from an arbitrary filesystem of any > detected ZFS p

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-18 Thread John Baldwin
On Wednesday, April 18, 2012 11:00:18 am Andriy Gapon wrote: > on 18/04/2012 17:40 Ian Lepore said the following: > > On Wed, 2012-04-18 at 17:36 +0300, Andriy Gapon wrote: > >> on 18/04/2012 17:22 Ian Lepore said the following: > >>> YES! A size field (preferably as the first field in the struct)

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-18 Thread Andriy Gapon
on 18/04/2012 17:40 Ian Lepore said the following: > On Wed, 2012-04-18 at 17:36 +0300, Andriy Gapon wrote: >> on 18/04/2012 17:22 Ian Lepore said the following: >>> YES! A size field (preferably as the first field in the struct) along >>> with a flag to indicate that it's a new-style boot info st

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-18 Thread Ian Lepore
On Wed, 2012-04-18 at 17:36 +0300, Andriy Gapon wrote: > on 18/04/2012 17:22 Ian Lepore said the following: > > YES! A size field (preferably as the first field in the struct) along > > with a flag to indicate that it's a new-style boot info struct that > > starts with a size field, will allow fut

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-18 Thread Ian Lepore
On Wed, 2012-04-18 at 17:36 +0300, Andriy Gapon wrote: > on 18/04/2012 17:22 Ian Lepore said the following: > > YES! A size field (preferably as the first field in the struct) along > > with a flag to indicate that it's a new-style boot info struct that > > starts with a size field, will allow fut

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-18 Thread Andriy Gapon
on 18/04/2012 17:22 Ian Lepore said the following: > YES! A size field (preferably as the first field in the struct) along > with a flag to indicate that it's a new-style boot info struct that > starts with a size field, will allow future changes without a lot of > drama. It can allow code that h

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-18 Thread Ian Lepore
On Wed, 2012-04-18 at 09:41 -0400, John Baldwin wrote: > On Wednesday, April 18, 2012 2:02:22 am Andriy Gapon wrote: > > on 17/04/2012 23:43 John Baldwin said the following: > > > On Tuesday, April 17, 2012 4:22:19 pm Andriy Gapon wrote: > > >> We already have a flag for ZFS (KARGS_FLAGS_ZFS, 0x4).

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-18 Thread John Baldwin
On Wednesday, April 18, 2012 2:02:22 am Andriy Gapon wrote: > on 17/04/2012 23:43 John Baldwin said the following: > > On Tuesday, April 17, 2012 4:22:19 pm Andriy Gapon wrote: > >> We already have a flag for ZFS (KARGS_FLAGS_ZFS, 0x4). So the new flag > >> could be > >> named something ZFS-speci

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-18 Thread Andriy Gapon
on 15/04/2012 04:01 Bob Friesenhahn said the following: > It would be nice if the updated FreeBSD bootloader could have the ability to > boot both Solaris and FreeBSD root filesystems in the same pool so that one > could switch between several zfs-based operating systems without needing to > use >

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-18 Thread Andriy Gapon
on 14/04/2012 18:37 Andriy Gapon said the following: > > I would like to ask for a review and/or testing of the following three > patches: > http://people.freebsd.org/~avg/zfsboot.patches.diff I've put a new version of the patch here: http://people.freebsd.org/~avg/zfsboot.patches.2.diff Most p

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-17 Thread Andriy Gapon
on 17/04/2012 23:43 John Baldwin said the following: > On Tuesday, April 17, 2012 4:22:19 pm Andriy Gapon wrote: >> We already have a flag for ZFS (KARGS_FLAGS_ZFS, 0x4). So the new flag >> could be >> named something ZFS-specific (as silly as KARGS_FLAGS_ZFS2) or something more >> general such a

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-17 Thread John Baldwin
On Tuesday, April 17, 2012 4:22:19 pm Andriy Gapon wrote: > on 16/04/2012 16:56 John Baldwin said the following: > > On Saturday, April 14, 2012 1:35:35 pm Andriy Gapon wrote: > >> on 14/04/2012 18:37 Andriy Gapon said the following: > >>> > >>> I would like to ask for a review and/or testing of th

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-17 Thread Andriy Gapon
on 16/04/2012 16:56 John Baldwin said the following: > On Saturday, April 14, 2012 1:35:35 pm Andriy Gapon wrote: >> on 14/04/2012 18:37 Andriy Gapon said the following: >>> >>> I would like to ask for a review and/or testing of the following three >>> patches: >>> http://people.freebsd.org/~avg/z

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-16 Thread John Baldwin
On Saturday, April 14, 2012 1:35:35 pm Andriy Gapon wrote: > on 14/04/2012 18:37 Andriy Gapon said the following: > > > > I would like to ask for a review and/or testing of the following three > > patches: > > http://people.freebsd.org/~avg/zfsboot.patches.diff > > > > These patches add support

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-14 Thread Garrett Cooper
On Apr 14, 2012, at 6:01 PM, Bob Friesenhahn wrote: > It would be nice if the updated FreeBSD bootloader could have the ability to > boot both Solaris and FreeBSD root filesystems in the same pool so that one > could switch between several zfs-based operating systems without needing to > use a

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-14 Thread Bob Friesenhahn
It would be nice if the updated FreeBSD bootloader could have the ability to boot both Solaris and FreeBSD root filesystems in the same pool so that one could switch between several zfs-based operating systems without needing to use a different partition for each one. Is this within the bounds

Re: [review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-14 Thread Andriy Gapon
on 14/04/2012 18:37 Andriy Gapon said the following: > > I would like to ask for a review and/or testing of the following three > patches: > http://people.freebsd.org/~avg/zfsboot.patches.diff > > These patches add support for booting from an arbitrary filesystem of any > detected ZFS pool. A f

[review request] zfsboot/zfsloader: support accessing filesystems within a pool

2012-04-14 Thread Andriy Gapon
I would like to ask for a review and/or testing of the following three patches: http://people.freebsd.org/~avg/zfsboot.patches.diff These patches add support for booting from an arbitrary filesystem of any detected ZFS pool. A filesystem could be selected in zfsboot and thus will affectfrom wher