On Sat, 23 Nov 2002, Brooks Davis wrote:
> On Tue, Nov 19, 2002 at 02:15:34PM -0800, Nate Lawson wrote:
> > On Tue, 19 Nov 2002, Brooks Davis wrote:
> > > On Fri, Nov 01, 2002 at 10:54:23AM -0800, Brooks Davis wrote:
> > > > I'm trying to get some review for the following patch. I realize it's
> >
On Tue, Nov 19, 2002 at 02:15:34PM -0800, Nate Lawson wrote:
> On Tue, 19 Nov 2002, Brooks Davis wrote:
> > On Fri, Nov 01, 2002 at 10:54:23AM -0800, Brooks Davis wrote:
> > > I'm trying to get some review for the following patch. I realize it's
> > > quite large, but most it is is trivial. The i
Brooks Davis wrote:
> On Tue, Nov 19, 2002 at 01:06:28PM -0800, Julian Elischer wrote:
> > why is this ent to hackers? it's a -current patch..
> > should it not be sent to -current or -net?
>
> I initialy asked for review on -net, but didn't get any response. I
> sort of randomly chose as the pla
On Tue, 19 Nov 2002, Brooks Davis wrote:
> On Fri, Nov 01, 2002 at 10:54:23AM -0800, Brooks Davis wrote:
> > I'm trying to get some review for the following patch. I realize it's
> > quite large, but most it is is trivial. The ipfw code is the only thing
> > that worries me significantly. I have
On Tue, Nov 19, 2002 at 01:06:28PM -0800, Julian Elischer wrote:
> why is this ent to hackers? it's a -current patch..
> should it not be sent to -current or -net?
I initialy asked for review on -net, but didn't get any response. I
sort of randomly chose as the place to try for wider review. IMO
why is this ent to hackers? it's a -current patch..
should it not be sent to -current or -net?
FWIW I see no huge problems.. as you say, it's mechanical changes
mostly.
On Tue, 19 Nov 2002, Brooks Davis wrote:
> On Fri, Nov 01, 2002 at 10:54:23AM -0800, Brooks Davis wrote:
> > I'm trying to get
On Fri, Nov 01, 2002 at 10:54:23AM -0800, Brooks Davis wrote:
> I'm trying to get some review for the following patch. I realize it's
> quite large, but most it is is trivial. The ipfw code is the only thing
> that worries me significantly. I have promised Kris that I will fix
> ports that break
On Fri, Nov 01, 2002 at 01:15:45PM -0800, Nate Lawson wrote:
> On Fri, 1 Nov 2002, Brooks Davis wrote:
> > The bigger deal is breaking
> > the network interface API and ABI which in turn breaks a few user land
> > programs that use libkvm ("netstat -r" for exmaple). That's why this is
> > a .0 f
On Fri, 1 Nov 2002, Brooks Davis wrote:
> The bigger deal is breaking
> the network interface API and ABI which in turn breaks a few user land
> programs that use libkvm ("netstat -r" for exmaple). That's why this is
> a .0 feature.
>
> Thanks,
> Brooks
Please check the libdnet port and possib
On Fri, Nov 01, 2002 at 12:07:05PM -0800, Nate Lawson wrote:
> Couple comments.
>
> * You interchangeably use strlcpy and snprintf(... "%s", ...) and even
> strncpy/strcpy(!). You probably want to go with just strlcpy.
I forgot to sweep for those again. I'll do another pass shortly.
> * There
You might also try -net or -arch.
On Fri, 1 Nov 2002, Brooks Davis wrote:
> I'm trying to get some review for the following patch. I realize it's
> quite large, but most it is is trivial. The ipfw code is the only thing
> that worries me significantly. I have promised Kris that I will fix
> por
t 2002 20:50:38 -0700
To: [EMAIL PROTECTED]
Subject: [PATCH] switching to if_xname
As previously discussed, I've created a patch to replace if_unit and
if_name with if_xname in struct ifnet following the example of NetBSD
and OpenBSD. I've tried to place the more intresting parts of the diff
12 matches
Mail list logo
