On Tue, Nov 19, 2002 at 02:15:34PM -0800, Nate Lawson wrote: > On Tue, 19 Nov 2002, Brooks Davis wrote: > > On Fri, Nov 01, 2002 at 10:54:23AM -0800, Brooks Davis wrote: > > > I'm trying to get some review for the following patch. I realize it's > > > quite large, but most it is is trivial. The ipfw code is the only thing > > > that worries me significantly. I have promised Kris that I will fix > > > ports that break with this change so you don't need to worry about that > > > issue. > > > > I've uploaded a new version of the patch addressing the concerns I've > > heard to: > > > > http://people.freebsd.org/~brooks/patches/if_xname.diff > > Thanks for fixing things. Are all the uses of sprintf() below safe and > intentional?
No, they weren't intentional. I managed to forget to scan for those. Most of them were safe, but I've removed all of them. (Grep still hits a few due to ipf using sprintf). I've uploaded a new version. I'm now testing a world build on panther. -- Brooks -- Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4
msg38275/pgp00000.pgp
Description: PGP signature
