I'm trying to get some review for the following patch. I realize it's quite large, but most it is is trivial. The ipfw code is the only thing that worries me significantly. I have promised Kris that I will fix ports that break with this change so you don't need to worry about that issue.
I'd like to commit this prior to 5.0-R pending RE approval (post DP2 would be fine if that would help get it out the door). Thanks, Brooks ----- Forwarded message from Brooks Davis <[EMAIL PROTECTED]> ----- From: Brooks Davis <[EMAIL PROTECTED]> Date: Wed, 23 Oct 2002 20:50:38 -0700 To: [EMAIL PROTECTED] Subject: [PATCH] switching to if_xname As previously discussed, I've created a patch to replace if_unit and if_name with if_xname in struct ifnet following the example of NetBSD and OpenBSD. I've tried to place the more intresting parts of the diff near the top. This patch will break ports which use libkvm to read interface statistics. This effects at least wmnet and wmnet2 (though both segfault on current without this patch). The patches to fix this should be trivial since most of those applications probably support NetBSD or OpenBSD and I plan to bump __FreeBSD_version. Other then those issues and a generalization of interface globing in IPFW, this patch should be a giant no-op from the user perspective. Real features will come later, but the API/ABI change needs to happen soon or it's going to be a 6.0 feature. I'm running this patch on my laptop with a GENERIC kernel without any problems so far. For all it's size, most of the changes are log() or printf() calls plus a fairly consistant change to each network driver's attach function so this should be generally low impact. The patch is available at the URL below. I tried to send a copy to the list, but it looks like it got silently tossed as too large. If you want a copy e-mailed to you, feel free to ask me for one. http://people.freebsd.org/~brooks/patches/if_xname.diff Please review. Thanks, Brooks -- Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 ----- End forwarded message -----
msg37777/pgp00000.pgp
Description: PGP signature
