RE: Falcon test failure

2012-12-03 Thread Gordon Smith
2012 10:45 PM To: flex-dev@incubator.apache.org Subject: Re: Falcon test failure Hey gordon So every class has now a few tests except CSSManager. But I've got still one question. Is there a specific reason why CSSCombinator doesn't extend CSSNodeBase? Cyrill On Fri, Nov 30, 2012 at 7

Re: Falcon test failure

2012-12-02 Thread Cyrill Zadra
27; } >> >> >> instead of >> >> >> Button { fontFamily: "Times Roman" } >> >> >> ? If the old compiler allowed this, Falcon should probably allow it. >> >> - Gordon >> >> -Original Message- &g

Re: Falcon test failure

2012-11-30 Thread Cyrill Zadra
@adobe.com] > Sent: Friday, November 30, 2012 5:18 PM > To: flex-dev@incubator.apache.org > Subject: RE: Falcon test failure > > I'm not an expert on CSS syntax. Are you supposed to be able to use either > double quotes or single quotes for style values? > > - Gordon > &g

RE: Falcon test failure

2012-11-30 Thread Gordon Smith
vember 30, 2012 5:18 PM To: flex-dev@incubator.apache.org Subject: RE: Falcon test failure I'm not an expert on CSS syntax. Are you supposed to be able to use either double quotes or single quotes for style values? - Gordon -Original Message- From: Cyrill Zadra [mailto:cyrill.za...

RE: Falcon test failure

2012-11-30 Thread Gordon Smith
bject: Re: Falcon test failure Hi Gordon Oh I forgot to comment the one line I exended the method getSingleArgumentFromRaw() to remove single quotes. But before I commit that I first wanted to ask first here on the list if this method is really supposed to do that. I'm probably too c

Re: Falcon test failure

2012-11-30 Thread Cyrill Zadra
Hi Gordon Oh I forgot to comment the one line I exended the method getSingleArgumentFromRaw() to remove single quotes. But before I commit that I first wanted to ask first here on the list if this method is really supposed to do that. I'm probably too cautious in commiting ;-) So single quot

Falcon test failure

2012-11-30 Thread Gordon Smith
@Cyril: Thanks for adding some unit tests for CSS nodes. One test, CSSFunctionCallPropertyValue_static_getSingleArgumentFromRaw(), is failing for me. It's expecting "Test" but getting "'Test'". Does it pass for you? - Gordon