The developers who implemented the CSS support is no longer at Adobe. But I don't know of any reason why it shouldn't extend CSSNodeBase, so feel free to make it do so.
- Gordon -----Original Message----- From: Cyrill Zadra [mailto:cyrill.za...@gmail.com] Sent: Sunday, December 02, 2012 10:45 PM To: flex-dev@incubator.apache.org Subject: Re: Falcon test failure Hey gordon So every class has now a few tests except CSSManager. But I've got still one question. Is there a specific reason why CSSCombinator doesn't extend CSSNodeBase? Cyrill On Fri, Nov 30, 2012 at 7:05 PM, Cyrill Zadra <cyrill.za...@gmail.com> wrote: > Yes the old compiler allows both examples... so I'll commit my change > for CSSFunctionCallPropertyValue and then this last failing test will > also will turn to "Ok" :). > > On Fri, Nov 30, 2012 at 5:37 PM, Gordon Smith <gosm...@adobe.com> wrote: >> I.e., >> >> <fx:Style> >> Button { fontFamily: 'Times Roman' } </fx:Style> >> >> instead of >> >> <fx:Style> >> Button { fontFamily: "Times Roman" } </fx:Style> >> >> ? If the old compiler allowed this, Falcon should probably allow it. >> >> - Gordon >> >> -----Original Message----- >> From: Gordon Smith [mailto:gosm...@adobe.com] >> Sent: Friday, November 30, 2012 5:18 PM >> To: flex-dev@incubator.apache.org >> Subject: RE: Falcon test failure >> >> I'm not an expert on CSS syntax. Are you supposed to be able to use either >> double quotes or single quotes for style values? >> >> - Gordon >> >> -----Original Message----- >> From: Cyrill Zadra [mailto:cyrill.za...@gmail.com] >> Sent: Friday, November 30, 2012 4:12 PM >> To: flex-dev@incubator.apache.org >> Subject: Re: Falcon test failure >> >> Hi Gordon >> >> Oh I forgot to comment the one line.... >> >> I exended the method getSingleArgumentFromRaw() to remove single quotes. >> But before I commit that I first wanted to ask first here on the list >> if this method is really supposed to do that. I'm probably too >> cautious in commiting ;-) >> >> So single quotes should they also be removed if they exists at the beginning >> and end of a rawArgument? >> >> Cyrill >> >> >> >> Am 30.11.2012 um 13:03 schrieb Gordon Smith <gosm...@adobe.com>: >> >>> @Cyril: Thanks for adding some unit tests for CSS nodes. One test, >>> CSSFunctionCallPropertyValue_static_getSingleArgumentFromRaw(), is failing >>> for me. It's expecting "Test" but getting "'Test'". >>> >>> Does it pass for you? >>> >>> - Gordon