I don't think you can do 'ant package' without Cygwin.
- Gordon
-Original Message-
From: Alex Harui [mailto:aha...@adobe.com]
Sent: Friday, February 24, 2012 3:12 PM
To: flex-dev@incubator.apache.org
Subject: Re: [CODE] Short cleanup
On 2/24/12 1:59 PM, "
On 2/24/12 1:59 PM, "Gordon Smith" wrote:
> Windows builds already require Cygwin and sed seems to be part of the default
> Cygwin installation.
>
> It would be nice, though, if Cygwin wasn't required.
>
> - Gordon Smith, Adobe
I build all the time without Cygwin on Windows. At least the ma
Hi,
> I think it would be better to have the VERSION constant injected by the
> compiler.
That would be my preferred option but only if it's easily possible. I assume
it's a little harder to do than a a couple of files of ANT? I assume we
wouldn't want this added to all classes just the SDK one
On Fri, Feb 24, 2012 at 4:26 PM, Gordon Smith wrote:
> I think it would be better to have the VERSION constant injected by the
> compiler. Alex wants it in every class but we sometimes forget to put in
> the include statement or an explicit VERSION constant. And then it's just a
> build option an
eprocessed.
- Gordon Smith, Adobe
-Original Message-
From: omup...@gmail.com [mailto:omup...@gmail.com] On Behalf Of Om
Sent: Friday, February 24, 2012 2:20 PM
To: flex-dev@incubator.apache.org
Subject: Re: [CODE] Short cleanup
I like this approach. This is how we bake in application versi
I don't like this approach. The replaced tag will surely get submitted.
I really don't understand why so much attention has been devoted to this
today. There are so many other things to do.
Carol
On 2/24/12 5 :19PM, "Om" wrote:
>I like this approach. This is how we bake in application versi
I like this approach. This is how we bake in application version numbers,
build timestamp, etc. while compiling release builds of Flex apps we ship.
> Minor issue with this is that now the Version.as files are out of sync
> with SVN, could accidentally be checked back in with wrong version numb
Hi,
ANT can do this quite easily.
If we change all Version.as files to be like so:
mx_internal static const VERSION:String = "@release@";
Then this target will inject the version number into all Version.as files:
We have these currently in the build file:
So that would replac
51 PM
To: flex-dev@incubator.apache.org
Subject: Re: [CODE] Short cleanup
On Fri, Feb 24, 2012 at 1:47 PM, Left Right wrote:
> Erm... sed is just as crossplatform as Ant :) but, really, I didn't mean to
> argue.
Meant that in the sense that we require ant to be present for builds alr
On Fri, Feb 24, 2012 at 1:47 PM, Left Right wrote:
> Erm... sed is just as crossplatform as Ant :) but, really, I didn't mean to
> argue.
Meant that in the sense that we require ant to be present for builds
already, and while you can expect that sed is installed on OS X and
*nix platforms, we ca
Erm... sed is just as crossplatform as Ant :) but, really, I didn't mean to
argue. I'm used to compile with patches, besides, since signed RSLs are no
longer an option, (so far I understand it) - that doesn't matter, if I'll
compile for production, I'll probably have much more patches to apply, so
On Fri, Feb 24, 2012 at 1:22 PM, Left Right wrote:
> But, whatever,
> it doesn't hurt me to run sed -i s/inculde ...// before compiling :)
If you're adamant about this, you may even be able to convince Apache
to accept this as an optional flag to the official build scripts (I
think ant's filters
Nothing real-time, but yeah, that's part of my job... like many of other
programmers hear... well, I guess. I never needed version numbers, besides
SDK versions and my (or other developer) project versions. But, whatever,
it doesn't hurt me to run sed -i s/inculde ...// before compiling :)
On 2/24/12 12:50 PM, "olegsivo...@gmail.com" wrote:
> Ah, so you mean you were recompiling a module SWF and reloading it, while
> the other half was still in debugger? I'm not sure, but I think that the
> policy as to load and unload is per domain... but, that's something I
> really don't know
Ah, so you mean you were recompiling a module SWF and reloading it, while
the other half was still in debugger? I'm not sure, but I think that the
policy as to load and unload is per domain... but, that's something I
really don't know. Is it possible that after unloading a SWF only some
class defin
If the swfs come from a server then things like caching can apply. Also:
when debugging it is a little stressful to compare the classes against
each-other.
yours
Martin.
And that would mean that you didn't know what classes you loaded, and what
classes where there before? Nah, unlikely... In the very worst case you can
just look up what class is in what SWF.
On 25/02/2012 04:42, Left Right wrote:
Well, you still have the source code. Debugging w/o the source is very
unproductive, so you'd face many other issues before the absence of the
version would become an issue. Lastly, why on the per class basis? And why,
if you so much wanted to be consistent,
Well, you still have the source code. Debugging w/o the source is very
unproductive, so you'd face many other issues before the absence of the
version would become an issue. Lastly, why on the per class basis? And why,
if you so much wanted to be consistent, you don't provide it for internal
(priva
We could format the entire SDK after it's available. In doing so, we would
gain initial uniformity.
If we decide to go this route, we can export all of the formatting settings
and come to a consensus about the format on-list. Afterwards, it would be
the responsibility of each developer to adhere t
On 2/24/12 11:18 AM, "olegsivo...@gmail.com" wrote:
>> Sorry, I don't understand your response.
> Look at what file you are debugging, copy the name, cat, grep, you see what
> you need...
I don't think that works given that the filename path is based on what the
build machine had, not what is
> Sorry, I don't understand your response.
Look at what file you are debugging, copy the name, cat, grep, you see what
you need...
On 25/02/2012 03:44, Alex Harui wrote:
Helped me a few times. Seems worth it to me. Don't we have bigger fish to
fry?
My question was: Can I clean that up? And up until now I haven't found a
good
reason as to why I couldn't. I have never ... never ever had that
problem but I can
somehow acce
On 2/24/12 10:13 AM, "olegsivo...@gmail.com" wrote:
>> Where does this show up in the debugger?
> (fdb) file
> ney?
Sorry, I don't understand your response.
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
On 2/24/12 10:38 AM, "Martin Heidegger" wrote:
> Not too helpful imho.
Helped me a few times. Seems worth it to me. Don't we have bigger fish to
fry?
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
We don't have to test since there is an include.
The include just makes sure that the class has a different hash at every
release. This hash does not get checked
for swcs or runtime loading - I just reconfirmed that. Compiler as well
as flash.display.Loader ignore the hash and the version
nu
Sorry, that was too short.
My opinion on versions - once per SWF is enough, no need to do it on per
class basis. (how other flash.* classes can live happily with only one
version defined in the player?) That's enough information, because if you
find yourself in a situation that some API you used h
> Where does this show up in the debugger?
(fdb) file
ney?
>
> I have some settings I use for FlexFormatter, I've just never compared
> them to what Adobe may be using, etc. I attached them to this email, not
> sure if it'll go through. Not saying these are exactly what we should use,
> but we need to start from somewhere.
>
> --
> Omar Gonzalez
> s9tpep..
On 2/24/12 1:04 AM, "Martin Heidegger" wrote:
>
> The proposal would make it easier to integrate version numbers but its
> the version numbers
> themselves that are a problem, included by "include" or build process or
> that new compiler feature.
What is the problem?
>
> What is the current
On Fri, Feb 24, 2012 at 9:09 AM, Martin Heidegger wrote:
> On 25/02/2012 02:00, Yennick Trevels wrote:
>
>> I've got nothing against flexformatter, but it's an eclipse based plugin,
>> so we have to make sure that we don't make the rules too strict (aka
>> flexformatter specific) since also other
On 25/02/2012 02:00, Yennick Trevels wrote:
I've got nothing against flexformatter, but it's an eclipse based plugin,
so we have to make sure that we don't make the rules too strict (aka
flexformatter specific) since also other IDE's are being used.
You have a point there: FDT does not support
On Fri, Feb 24, 2012 at 9:00 AM, Yennick Trevels
wrote:
> I've got nothing against flexformatter, but it's an eclipse based plugin,
> so we have to make sure that we don't make the rules too strict (aka
> flexformatter specific) since also other IDE's are being used.
>
> On Fri, Feb 24, 2012 at 4:
On 2/24/12 3:46 AM, "olegsivo...@gmail.com" wrote:
>
> There are other ways to identify the version -
>
> * @langversion 3.0
> * @playerversion Flash 9
> * @playerversion AIR 1.1
> * @productversion Flex 3
>
> I don't see why this is not enough.
Where does this show up in the debugg
I've got nothing against flexformatter, but it's an eclipse based plugin,
so we have to make sure that we don't make the rules too strict (aka
flexformatter specific) since also other IDE's are being used.
On Fri, Feb 24, 2012 at 4:29 PM, Martin Heidegger wrote:
> On 25/02/2012 00:26, David Franc
On 25/02/2012 00:26, David Francis Buhler wrote:
Can we use FlexFormatter (BSD License?) and share a formatting properties
file that adheres to a format reached by consensus?
[1] http://sourceforge.net/projects/flexformatter/
I don't see why not. The formatter properties could be hosted in the
Can we use FlexFormatter (BSD License?) and share a formatting properties
file that adheres to a format reached by consensus?
[1] http://sourceforge.net/projects/flexformatter/
On Fri, Feb 24, 2012 at 10:03 AM, Carol Frampton wrote:
> Alex may not care about tabs but I much prefer 4 spaces so
Alex may not care about tabs but I much prefer 4 spaces so that when I use
various editors/tools that aren't configured for a tab to be 4 spaces the
code isn't misaligned.
On the subject of includes I know that two of the spark DataGrid
itemRenderers use an include. I don't remember why it was do
>
> Left Right,
>
> What are the benefits / disadvantages of
>
>if (collection[item] !== undefined) ...
>
> versus
>
>if (item in collection) ...
>
These are two different things. The key may exist inside the hash, but be
mapped to 'undefined', the other expression verifies whether
>
> There really is a huge advantage to being polite, especially in a mediated
> environment like a mailing list where we don't see the people we're talking
> to.
>
>
Very well put Rui. Seeing as we're all adults here I don't see why we can't
keep the
conversations civilized. I know that us develop
Original Message
> From: "David Arno"
>
> I suspect that asking him to leave is as unhelpful to the group as the
> original rudeness. The gentle way I was asked to tone down my language
> without any accompanying threats is probably the best way to keep us
more
> "colourful" fo
Original Message
> From: "Omar Gonzalez"
> Sent: sexta-feira, 24 de Fevereiro de 2012 8:06
>
> I don't think you can rename a branch, but maybe that's a good idea.
Name
> it patchStaging?
You can change Subversion branches. They're just basically folders, so
renaming them is
> From: Rui Silva [mailto:f...@rduartes.net]
> Sent: 24 February 2012 12:02
>
> Please restrain from using this kind of tone in your messages.
> It does not help and if you're not here to help, please leave.
I suspect that asking him to leave is as unhelpful to the group as the
original rudenes
> From: Left Right [mailto:olegsivo...@gmail.com]
> Sent: 24 February 2012 11:10
> OMG!!! Seriously, you are writing SDK code and you don't know what's the
> difference between using `in' operator and calling a method defined on
> Object.prototype is?
Interesting. Seeing someone else by rude br
Original Message
> From: "Left Right"
> Sent: sexta-feira, 24 de Fevereiro de 2012 11:10
> To: flex-dev@incubator.apache.org
> Subject: Re: [CODE] Short cleanup
>
> OMG!!! Seriously, you are writing SDK code and you don't know what
On 24/02/2012 20:09, Left Right wrote:
OMG!!! Seriously, you are writing SDK code and you don't know what's the
difference between using `in' operator and calling a method defined on
Object.prototype is?
Insulting doesn't help. I just haven't had the need to use this
structure up until now. (s
Before, when I tried to patch the framework code, I'd routinely delete
`include "core/Version.as"' lines, it didn't seem to have any impact on the
existing code. This can be imprecise, because I'd usually try to reduce the
number of classes to compile, but it looks more like it wasn't used often
en
OMG!!! Seriously, you are writing SDK code and you don't know what's the
difference between using `in' operator and calling a method defined on
Object.prototype is?
First of all, they are testing for different things. `in' is testing for a
key in a collection, key may or may not be a property, for
On 24/02/2012 17:02, Alex Harui wrote:
One day, folks started rejecting commits that had tabs. The developer
most likely to have instituted such a policy expressed surprise at the
policy as well, so I don't know who wanted it. Spaces are currently in
the style guide, although there was a rule t
Hi,
>> An easier solution may be using the build scripts to stick in the version
>> number?
> Can that work when developing as an FB project?
Don't see why not. As I've played about with the build scripts a bit I'll take
a look at it.
Justin
On 2/24/12 12:10 AM, "Justin Mclean" wrote:
> Hi,
>
>> I thought it was you that proposed having the compiler stick in values it
>> knows about. Seems like that could be extended to stick in a version
>> number.
> An easier solution may be using the build scripts to stick in the version
> nu
Hi,
> I thought it was you that proposed having the compiler stick in values it
> knows about. Seems like that could be extended to stick in a version
> number.
An easier solution may be using the build scripts to stick in the version
number?
Justin
On Fri, Feb 24, 2012 at 12:04 AM, Alex Harui wrote:
>
>
>
> On 2/23/12 11:55 PM, "Justin Mclean" wrote:
>
> > Hi,
> >
> >> I think using the localechanges branch should be fine, no? We could use
> it
> >> to stage all the things we'd like to bring in as soon as Mustella makes
> its
> >> way in a
On Thu, Feb 23, 2012 at 11:55 PM, Justin Mclean wrote:
> Hi,
>
> > I think using the localechanges branch should be fine, no? We could use
> it
> > to stage all the things we'd like to bring in as soon as Mustella makes
> its
> > way in and we can test the framework.
>
> Might be better it it had
On 2/23/12 11:55 PM, "Justin Mclean" wrote:
> Hi,
>
>> I think using the localechanges branch should be fine, no? We could use it
>> to stage all the things we'd like to bring in as soon as Mustella makes its
>> way in and we can test the framework.
>
> Might be better it it had a different
On 2/23/12 11:32 PM, "Martin Heidegger" wrote:
> On 24/02/2012 15:17, Alex Harui wrote:
>> Somehow, the policy became 4 spaces. Personally I don't care if it is
>> a four-space tab or four spaces, but definitely not 8 spaces although
>> some of that did get in there.
>
> What do you mean "som
Hi,
> I think using the localechanges branch should be fine, no? We could use it
> to stage all the things we'd like to bring in as soon as Mustella makes its
> way in and we can test the framework.
Might be better it it had a different name if it contains more than the locale
changes.
Justin
I think using the localechanges branch should be fine, no? We could use it
to stage all the things we'd like to bring in as soon as Mustella makes its
way in and we can test the framework.
--
Omar Gonzalez
s9tpep...@apache.org
Apache Flex PPMC Member
On 24/02/2012 15:17, Alex Harui wrote:
Somehow, the policy became 4 spaces. Personally I don't care if it is
a four-space tab or four spaces, but definitely not 8 spaces although
some of that did get in there.
What do you mean "somehow"? I don't care as well - there are bad
arguments for eith
Hi,
> today I read/skimmed over the Flex SDK and found a lot of missing ";"
Semicolons are optional in a lot of cases but I it would be good to see them in
there for constancy sake.
> a few unused private methods or method arguments and imports.
It most cases I agree they should be removed. In
I believe "in" works only on dynamic classes, like plain Object. You have
to use hasOwnProperty() when the key is declared as a member of a class, or
a 'sealed class'. At least that's how it works in loops.
--
Omar Gonzalez
s9tpep...@apache.org
Apache Flex PPMC Member
On 2/23/12 9:28 PM, "Martin Heidegger" wrote:
> However I wondered about a few things related to the Flex coding style:
>
> - Spaces or tabs? I found that various files currently mix spaces and
> tabs, some have more tabs some more spaces (what was the policy again?)
Somehow, the policy bec
Hello List,
today I read/skimmed over the Flex SDK and found a lot of missing ";" in
the Flex SDK, as well as a few unused private methods or method
arguments and imports.
I committed the ones I found to a github fork [1]. Perhaps some changes
can go into the SDK?
However I wondered about a
63 matches
Mail list logo
