Re: [FFmpeg-devel] [PATCH] avformat/mov: fix memleak

> On Jun 28, 2020, at 5:09 AM, Andreas Rheinhardt > wrote: > > Zhao Zhili: >> Remove the check on dv_demux since dv_fctx will leak if allocate >> dv_demux failed. >> --- >> libavformat/mov.c | 7 +++ >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/libavformat/mov.c b/

Re: [FFmpeg-devel] [PATCH v1 2/2] configure: Fix for the configure failed for vmaf

> On Nov 14, 2019, at 8:56 AM, Limin Wang wrote: > > On Thu, Nov 14, 2019 at 01:03:09AM +0800, Zhao Zhili wrote: >> >> >>> On Nov 13, 2019, at 9:41 PM, Zhong Li wrote: >>> >>> Just curious why this issue hasn't been found earlier. >> >> I think it's a regression of libvmaf: >> libvmaf

Re: [FFmpeg-devel] [PATCH] avcodec/vp8: fix multiple ff_thread_finish_setup() calls

> On Nov 14, 2019, at 1:25 AM, Ronald S. Bultje wrote: > > Hi, > > On Wed, Nov 13, 2019 at 2:00 AM > wrote: > >> From: Zhao Zhili >> >> vp7 decoder doesn't set update_thread_context field >> --- >> libavcodec/vp8.c | 3 ++- >> 1 file changed, 2 insertions(+),

Re: [FFmpeg-devel] [PATCH v2] avcodec/vp8: fix multiple ff_thread_finish_setup() calls

Ping for review, thanks! > On Nov 14, 2019, at 12:29 PM, quinkbl...@foxmail.com wrote: > > From: Zhao Zhili > > webp decoder doesn't set update_thread_context field > > $ ffmpeg -i rgb_q80.webp -f null - > [webp @ 0x7ffbd5823200] Multiple ff_thread_finish_setup() calls > --- > libavcodec/vp8.c

Re: [FFmpeg-devel] TCP timeout for HTTP/HTTPS connections.

> On Nov 18, 2019, at 4:11 PM, Tom Gaudasiński > wrote: > > I essentially have a thread that I need to have exit immediately. I > thought tweaking timeouts would be one way to get this done, but I'm > starting to think that's a bad approach. > > So, let me, maybe, rephrase the question: Is t

Re: [FFmpeg-devel] [PATCH 1/2] avformat/url.h add av_find_protocol_by_name for find URLProtocol by name

> On Nov 22, 2019, at 4:56 PM, Steven Liu wrote: > > Signed-off-by: Steven Liu > --- > doc/APIchanges | 3 +++ > libavformat/protocols.c | 16 > libavformat/url.h | 9 + > libavformat/version.h | 2 +- > 4 files changed, 29 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH v2] avcodec/vp8: fix multiple ff_thread_finish_setup() calls

Please help to merge the patch if it’s acceptable, thanks! > On Nov 18, 2019, at 7:00 PM, Peter Ross wrote: > > On Mon, Nov 18, 2019 at 10:34:32AM +0800, zhilizhao wrote: >> Ping for review, thanks! > > approve. 还有这块补丁也跟vp7有关，可以在推送前改一下。 Since the vp7 decoder does

Re: [FFmpeg-devel] [PATCH] libavdevice/lavfi: check avfilter_graph_dump return value

Ping for review, thanks! > On Nov 21, 2019, at 3:08 PM, quinkbl...@foxmail.com wrote: > > From: Zhao Zhili > > --- > libavdevice/lavfi.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/libavdevice/lavfi.c b/libavdevice/lavfi.c > index ca8f05f3f7..c949ff7e12 1

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/buffersrc: deprecate sws_param option

> On Dec 2, 2019, at 9:49 PM, Nicolas George wrote: > > quinkbl...@foxmail.com (12019-12-02): >> From: Zhao Zhili >> >> --- >> doc/filters.texi| 4 +--- >> libavfilter/buffersrc.c | 8 ++-- >> 2 files changed, 7 insertions(+), 5 deletions(-) > > Ok. But ideally you would include de

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/buffersrc: remove write-only variable

> On Dec 2, 2019, at 9:33 PM, Nicolas George wrote: > > quinkbl...@foxmail.com (12019-12-02): >> From: Zhao Zhili >> >> --- >> libavfilter/buffersrc.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/buffersink: remove AVBufferSinkParams and AVABufferSinkParams

Please ignore patch 3/3. FFmpeg user may pass AVBufferSinkParams to avfilter_graph_create_filter with the opaque pointer, which is ignored by implementation. It should be marked as obsolete. > On Dec 6, 2019, at 1:14 PM, quinkbl...@foxmail.com wrote: > > From: Zhao Zhili > > The patch breaks A

Re: [FFmpeg-devel] [PATCH v2 4/4] avfilter/avfilter: update documentation of avfilter_graph_create_filter

> On Dec 6, 2019, at 3:06 PM, quinkbl...@foxmail.com wrote: > > From: Zhao Zhili > > --- > libavfilter/avfilter.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h > index 3eaa8a4089..197e12a625 100644 > --- a/libavfilter/a

Re: [FFmpeg-devel] [PATCH v2] avfilter/formats: optimize ff_all_formats

> On Dec 10, 2019, at 4:20 AM, Tomas Härdin wrote: > > lör 2019-12-07 klockan 01:06 +0800 skrev Zhao Zhili: >> This is a micro-optimization. Saving almost 200 reallocations makes >> it >> worth a try. >> --- >> fix commit message typo: relocations -> reallocations >> >> libavfilter/formats.c |

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_histogram: clean up code

Hi Paul, > On Dec 13, 2019, at 10:00 PM, Paul B Mahol wrote: > > Please provide some explanation. No functional changes, just use temporary variables to make code more readable, and may improve a little bit of performance. > > On 12/13/19, quinkbl...@foxmail.com wrote: >> From: Zhao Zhili >

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_histogram: clean up code

> On Dec 15, 2019, at 12:35 AM, Carl Eugen Hoyos wrote: > > Am Sa., 14. Dez. 2019 um 08:28 Uhr schrieb zhilizhao : > >>> On Dec 13, 2019, at 10:00 PM, Paul B Mahol wrote: >>> >>> Please provide some explanation. >> >> No functional chan

Re: [FFmpeg-devel] [PATCH v2] avfilter/formats: optimize ff_all_formats

> On Dec 24, 2019, at 4:32 AM, Michael Niedermayer > wrote: > > On Mon, Dec 23, 2019 at 04:11:53PM +0100, Nicolas George wrote: >> Tomas Härdin (12019-12-09): >>> As far as I can tell this is OK, and it passes FATE. But it just looks >>> very very wrong. Why does this function even exist if al

Re: [FFmpeg-devel] [PATCH v2] avfilter/formats: optimize ff_all_formats

Hi Nicolas, > On Dec 24, 2019, at 6:50 PM, Nicolas George wrote: > > zhilizhao (12019-12-24): >> 1. AV_PIX_FMT_NB depends on !gaps, unless we calculate and set it manually > > NB is not really the "number of". > >> 2. The reason to deprecated

Re: [FFmpeg-devel] [PATCH v4] avfilter/buffersrc: deprecate sws_param option

Hi Nicolas, > On Dec 23, 2019, at 8:23 PM, Nicolas George wrote: > > myp...@gmail.com (12019-12-12): >> LGTM, but need to wait next release cycle? > > What do you mean? There is all the necessary code to let the option > disappear automatically at the next release. > > I shall push soon, unle

Re: [FFmpeg-devel] [PATCH 6/8] swscale/tests/swscale: remove access of AV_PIX_FMT_NB

> On Dec 31, 2019, at 7:49 PM, Michael Niedermayer > wrote: > > On Mon, Dec 30, 2019 at 09:54:17PM +0800, quinkbl...@foxmail.com > wrote: >> From: Zhao Zhili mailto:zhiliz...@tencent.com>> >> >> --- >> libswscale/tests/swscale.c |

Re: [FFmpeg-devel] [PATCH v5] avfilter/buffersrc: deprecate sws_param option

> On Dec 31, 2019, at 9:08 PM, James Almer wrote: > > On 12/31/2019 10:05 AM, James Almer wrote: >> On 12/30/2019 7:25 AM, Nicolas George wrote: >>> quinkbl...@foxmail.com (12019-12-30): From: Zhao Zhili --- Rebase patch on master. doc/filters.texi| 8 +

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_gblur: fix divide by zero

> On Jan 4, 2020, at 7:04 PM, Paul B Mahol wrote: > > I do not like this “fix" What do you suggest? It’s numerical unstable for small sigma. > > On 1/4/20, quinkbl...@foxmail.com wrote: >> From: Zhao Zhili >> >> ./ffmpeg -i ~/Pictures/test.jpg -vf 'gblur=sigma=0' -f null - >> ... >> src/

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_gblur: fix divide by zero

> On Jan 4, 2020, at 9:09 PM, Paul B Mahol wrote: > > On 1/4/20, zhilizhao wrote: >> >> >>> On Jan 4, 2020, at 7:04 PM, Paul B Mahol wrote: >>> >>> I do not like this “fix" >> >> What do you suggest? It’s numerical unsta

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_gblur: fix divide by zero

> On Jan 4, 2020, at 9:43 PM, zhilizhao wrote: > > > >> On Jan 4, 2020, at 9:09 PM, Paul B Mahol > <mailto:one...@gmail.com>> wrote: >> >> On 1/4/20, zhilizhao > <mailto:quinkbl...@foxmail.com>> wrote: >>> >>> &g

Re: [FFmpeg-devel] [PATCH] af_volume: fix integer clip

> On Jan 27, 2020, at 6:28 PM, Zhao Zhili wrote: > > > >> On Jan 27, 2020, at 12:59 AM, Carl Eugen Hoyos > > wrote: >> >> Am So., 26. Jan. 2020 um 17:13 Uhr schrieb Zhao Zhili >> mailto:quinkbl...@foxmail.com>>: >>> >>> --- >>> Or specify an upper limit on volume

Re: [FFmpeg-devel] [PATCH] avfilter/af_anlmdn: add AArch64 SIMD for compute_distance_ssd

> On Jan 25, 2020, at 12:13 AM, Carl Eugen Hoyos wrote: > > Am Fr., 24. Jan. 2020 um 10:15 Uhr schrieb Zhao Zhili >: >> >> ./ffmpeg -threads 1 -f lavfi -t 60 -i anoisesrc -af 'anlmdn' -f null >> -benchmark - >> >> Test results on Snapdragon 845: >>Before:

Re: [FFmpeg-devel] [PATCH] avfilter/af_afir: add AArch64 SIMD for fcmul_add

> On Jan 24, 2020, at 6:54 PM, Paul B Mahol wrote: > > Seems very trivial. Yes it is. Please help review the patch, thanks! > > On 1/18/20, Zhao Zhili wrote: >> ./ffmpeg -threads 1 -f lavfi -i anoisesrc -f lavfi -t 30 -i anoisesrc -t >> 600 -lavfi afir -benchmark -f null - >> >> Test re

Re: [FFmpeg-devel] [PATCH] af_volume: fix integer clip

> On Feb 1, 2020, at 8:00 PM, Michael Niedermayer > wrote: > > On Sat, Feb 01, 2020 at 06:06:39PM +0800, zhilizhao wrote: >> >> >>> On Jan 27, 2020, at 6:28 PM, Zhao Zhili wrote: >>> >>> >>> >>>> On Jan 27, 20

Re: [FFmpeg-devel] [PATCH V2] fate/filter-video.mak: do not use bit-exact check for dnn_processing

> On Feb 1, 2020, at 10:50 PM, Guo, Yejun wrote: > > > >> -Original Message- >> From: Guo, Yejun >> Sent: Wednesday, January 22, 2020 9:45 PM >> To: ffmpeg-devel@ffmpeg.org >> Cc: Guo, Yejun >> Subject: [PATCH V2] fate/filter-video.mak: do not use bit-exact check for >> dnn_processin

Re: [FFmpeg-devel] [PATCH] avfilter/scene_sad: add AArch64 SIMD

> On Feb 2, 2020, at 4:26 AM, Marton Balint wrote: > > > > On Sat, 1 Feb 2020, quinkbl...@foxmail.com > wrote: > >> From: Zhao Zhili >> >> For 8 bit depth: >> ./ffmpeg -threads 1 -f lavfi -t 10 -i >> 'yuvtestsrc=size=4096x2048,format=yuv444p' -vf 'freeze

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolboxenc: fix use after destroy

> On Aug 28, 2020, at 8:55 AM, Steven Liu wrote: > > 于2020年8月27日周四 下午5:39写道： >> >> From: Zhao Zhili >> >> The lock is used in clear_frame_queue(). >> --- >> libavcodec/videotoolboxenc.c | 11 +++ >> 1 file changed, 7 insertions(+), 4 deletions(-) >> >> diff --git a/libavcodec/videot

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/isom: add comment to mov_mdhd_language_map

Hi Michael, > On Jul 1, 2020, at 5:27 PM, Michael Niedermayer > wrote: > > On Sat, Jun 27, 2020 at 10:26:43PM +0800, Zhao Zhili wrote: >> --- >> The following code is used to do the reformat: >> https://gist.github.com/quink-black/8643d8fab8b3f49ff6ace6916111d2c4 >> >> libavformat/isom.c | 158

Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC

> On Jul 17, 2020, at 5:47 AM, Steinar H. Gunderson > wrote: > > On Thu, Jul 16, 2020 at 06:34:31PM -0300, James Almer wrote: >>> static AVMutex codec_mutex = AV_MUTEX_INITIALIZER; >>> +static const uint8_t usa_country_code = 0xB5; >>> +static const uint16_t smpte_provider_code = 0x003C; >>> +

Re: [FFmpeg-devel] [PATCH 1/2] lavc/aac_ac3_parser: fix the potential overflow

> On Jul 24, 2020, at 9:40 AM, myp...@gmail.com wrote: > > On Fri, Jul 24, 2020 at 4:43 AM Alexander Strasser > wrote: >> >> On 2020-07-01 21:05 +0200, Alexander Strasser wrote: >>> On 2020-07-01 16:23 +0200, Anton Khirnov wrote: Quoting Jun Zhao (2020-06-29 15:23

Re: [FFmpeg-devel] AVWriter again (was: v2 1/2] avformat/url: check double dot is not to parent directory)

> On Jul 28, 2020, at 4:05 PM, Nicolas George wrote: > > Jean-Baptiste Kempf (12020-07-28): >> How is that different from open_memstream, which is done for this exact >> purpose? > > I am not sure what you are referring to, I do not find a function by > that name in FFmpeg. I think jb is ref

Re: [FFmpeg-devel] AVWriter again (was: v2 1/2] avformat/url: check double dot is not to parent directory)

> On Jul 28, 2020, at 8:02 PM, Nicolas George wrote: > > zhilizhao (12020-07-28): >> I think jb is referring to >> >> FILE *open_memstream(char **bufp, size_t *sizep); >> https://linux.die.net/man/3/open_memstream >> <https://linux.die.net/man/

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

> On Jul 31, 2020, at 3:08 AM, Alexander Strasser wrote: > > Hi! > > On 2020-07-30 12:16 +, Zane van Iperen wrote: >> On Fri, 31 Jul 2020 00:55:56 +0800 >> "zongwave" wrote: > [...] >> >>> ++static av_cold int xcam_init(AVFilterContext *ctx) >>> ++{ >>> ++XCAMContext *s = ctx->priv;

Re: [FFmpeg-devel] Pull Request - Support Windows Subsystem for Linux

> On Jul 31, 2020, at 3:19 PM, Julio César Rocha wrote: > > I didn't find any documentation that refers to building with WSL. > Can builds with WSL be achieved without any patching? > > Also, how should I split the patch, if it's only modifying one file? Modify a part of the file, git add &&

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: Remove unnecessary initializations

Please help review the patch, thanks! > On Jul 26, 2020, at 1:30 PM, Zhao Zhili wrote: > > pre_tag_size is always reset by avio_rb32(). For AVFormatContext > start_time, as the document says, "NEVER set this value directly: > It is deduced from the AVStream values." > --- > fix commit subject >

Re: [FFmpeg-devel] [PATCH] Increasing the max length of control URI to 2048 characters, as urls of some RTSP streams do exceed this limit.

> On Aug 6, 2020, at 6:38 AM, Yiğit (Yeet) Uyan > wrote: > > Hello everyone, > > This is the first time for me to send a patch via email. Is this the > correct format? > > I would appreciate it if someone could confirm, and if there is anything > else I need to do to get it into upcoming rel

Re: [FFmpeg-devel] [PATCH] Increasing the max length of control URI to 2048 characters, as urls of some RTSP streams do exceed this limit.

> On Aug 6, 2020, at 10:46 AM, zhilizhao wrote: > > > >> On Aug 6, 2020, at 6:38 AM, Yiğit (Yeet) Uyan >> wrote: >> >> Hello everyone, >> >> This is the first time for me to send a patch via email. Is this the >> correct format? >

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: Avoid allocation for AVBSFInternal

> On Aug 11, 2020, at 8:14 AM, Andreas Rheinhardt > wrote: > > James Almer: >> On 8/10/2020 8:12 PM, Andreas Rheinhardt wrote: >>> James Almer: On 8/10/2020 7:11 PM, Nicolas George wrote: > James Almer (12020-08-10): >> Personally, i don't like it. It's extra complexity to save a

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: Avoid allocation for AVBSFInternal

> On Aug 11, 2020, at 5:48 PM, Nicolas George wrote: > > Andreas Rheinhardt (12020-08-11): >> Imagine the context to only contain elements that require a alignment of >> 4 and the internal structure to require an alignment of eight. Then it >> is perfectly possible for &ctx[1] to only have an a

Re: [FFmpeg-devel] [PATCH] avutil/video_enc_params: fix code comment

> On Aug 13, 2020, at 11:57 AM, leozhang wrote: > > Signed-off-by: leozhang > --- > libavutil/video_enc_params.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/video_enc_params.h b/libavutil/video_enc_params.h > index 43fa443..e3b422d 100644 > --- a/libavuti

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

Hi Steven, > On Aug 17, 2020, at 8:49 AM, Steven Liu wrote: > > output a warning message if the target duration of the segment. The sentence is incomplete. > and modify the target duration to one packet duration, > because there maybe have bframe and then split not by keyframe, > and the segme

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

> On Aug 17, 2020, at 11:02 AM, Steven Liu wrote: > > zhilizhao mailto:quinkbl...@foxmail.com>> > 于2020年8月17日周一 上午10:54写道： >> >> Hi Steven, >> >>> On Aug 17, 2020, at 8:49 AM, Steven Liu >> <mailto:l...@chinaffmpeg.org>> wrote: >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

> On Aug 17, 2020, at 11:18 AM, Steven Liu wrote: > > zhilizhao mailto:quinkbl...@foxmail.com>> > 于2020年8月17日周一 上午11:15写道： >> >> >> >>> On Aug 17, 2020, at 11:02 AM, Steven Liu >> <mailto:lingjiujia...@gmail.com>

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

> On Aug 17, 2020, at 4:05 PM, Nicolas George wrote: > > Steven Liu (12020-08-17): >> Output a warning message if the target duration of the segment is negative. >> Suggest user increase the hls_time value, >> and modify the target duration to one packet duration, >> because there maybe have bf

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check duration value correct before split segment

> On Aug 17, 2020, at 5:53 PM, Steven Liu wrote: > > fix ticket: 8847 > check the timestamps of current packets minus last segment end_pts > if the duration is negative, plus the places where the muxer should split. > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 2 +- > 1 file ch

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: fix infinite loop with udp transport

Please help review the patch, thanks! > On Aug 6, 2020, at 4:50 PM, quinkbl...@foxmail.com wrote: > > From: Zhao Zhili > > User report: http://ffmpeg.org/pipermail/ffmpeg-user/2020-August/049494.html > > server: > ./ffmpeg -i test.mp4 -c copy -f rtsp -rtsp_transport udp > rtsp://localhost:12

Re: [FFmpeg-devel] [PATCH] avcodec/proresenc: add support for PQ and HLG

> On Aug 20, 2020, at 10:36 AM, Michael Bradshaw > wrote: > > Signed-off-by: Michael Bradshaw > --- > libavcodec/proresenc_anatoliy.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/proresenc_anatoliy.c b/libavcodec/proresenc_anatoliy.c > index 1128978330

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: don't wait when flushing data

> On Aug 27, 2020, at 10:53 AM, Steven Liu wrote: > > From: Tian Qi > > because there is run in thread mode, few times will block > the workflow at the wait, so check the status is flushing data, > don't wait when flushing data. > > Signed-off-by: Tian Qi > Signed-off-by: Steven Liu > ---

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: move pthread_cond_signal after add buffer to the queue

> On Aug 28, 2020, at 9:13 AM, Steven Liu wrote: > > From: Tian Qi > > In the VT encoding insertion by FFmpeg, > and vtenc_q_push is callback to add the encoded data > to the singly linked list group in VTEncContext, > and consumers are notified to fetch it. > However, because it first inform

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/allfilters: Don't cast const away

> On Aug 28, 2020, at 3:33 PM, Moritz Barsnick wrote: > > On Sun, Aug 23, 2020 at 23:31:45 +0800, Zhao Zhili wrote: I have a same patch long time ago. http://ffmpeg.org/pipermail/ffmpeg-devel/2019-October/252193.html

Re: [FFmpeg-devel] [PATCH 9/9] checkasm/hevc_pel: Fix stack buffer overreads

> On Sep 28, 2021, at 10:41 PM, Andreas Rheinhardt > wrote: > > This patch increases several stack buffers in order to fix > stack-buffer-overflows (e.g. in put_hevc_qpel_uni_hv_9 in > line 814 of hevcdsp_template.c) detected with ASAN in the hevc_pel > checkasm test. > The buffers are increas

Re: [FFmpeg-devel] [PATCH] lavc/{av1, h264, h265}_metadata_bsf: fix description of tick_rate

Ping for review. > On Aug 27, 2021, at 3:13 PM, Zhao Zhili wrote: > > Users may take the description literally which leads to inverted > results. > --- > doc/bitstream_filters.texi | 8 > libavcodec/av1_metadata_bsf.c | 2 +- > libavcodec/h264_metadata_bsf.c | 2 +- > libavcodec/h265_

Re: [FFmpeg-devel] [PATCH 5/5] avformat/libsrt: add snddropdelay parameter for srt

> On Sep 30, 2021, at 9:14 AM, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/protocols.texi | 10 ++ > libavformat/libsrt.c | 7 +++ > 2 files changed, 17 insertions(+) > > diff --git a/doc/protocols.texi b/doc/protocols.texi > inde

Re: [FFmpeg-devel] [PATCH v2] avformat/libsrt: add snddropdelay parameter for srt

> On Oct 10, 2021, at 11:17 AM, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/protocols.texi | 9 + > libavformat/libsrt.c | 7 +++ > 2 files changed, 16 insertions(+) > > diff --git a/doc/protocols.texi b/doc/protocols.texi > index

Re: [FFmpeg-devel] [PATCH v3] avformat/libsrt: add snddropdelay parameter for srt

> On Oct 11, 2021, at 9:26 AM, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > doc/protocols.texi | 6 ++ > libavformat/libsrt.c | 7 +++ > 2 files changed, 13 insertions(+) > LGTM. ___ ffmpeg-dev

Re: [FFmpeg-devel] [PATCH] libavcodec/avpacket: add av_packet_remove_side_data

> On Oct 12, 2021, at 2:20 AM, Marton Balint wrote: > > On Mon, 11 Oct 2021, Zhao Zhili wrote: > >> --- >> doc/APIchanges | 3 +++ >> libavcodec/avpacket.c | 15 +++ >> libavcodec/packet.h | 5 + >> libavcodec/tests/avpacket.c | 9 + >> libavco

[FFmpeg-devel] [share a stupid and fun patch] avformat: add a fileptr protocol

Just share a patch, not meant for merge. Basically, the patch adds a new protocol which looks like fd:// or pipe:, but deals with FILE *. You may ask why? It’s useless if the FILE *ptr is a regular one, unless combined with FILE * open_memstream(char **bufp, size_t *sizep); FILE

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/argo_asf: cleanup and NULL-terminate name field in header

> On Oct 12, 2021, at 7:02 PM, Zane van Iperen wrote: > > Signed-off-by: Zane van Iperen > --- > libavformat/argo_asf.c | 8 > libavformat/argo_asf.h | 3 ++- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c > index 7e

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/argo_asf: cleanup and NULL-terminate name field in header

> On Oct 14, 2021, at 8:25 PM, Zane van Iperen wrote: > > > > On 14/10/21 10:11 pm, "zhilizhao(赵志立)" wrote: > >>> typedef struct ArgoASFFileHeader { >>> uint32_tmagic; /*< Magic Number, {'A', 'S',

Re: [FFmpeg-devel] [PATCH] avformat/isom_tags: fix 'ipcm' with samplesize equal to 16

> On Oct 29, 2021, at 3:49 PM, Zhao Zhili wrote: > > Use PCM_S16 so the codec_id will be updated later according to > bits_per_coded_sample. Here is the sample file: https://yayunhui-1251820392.cos.ap-beijing.myqcloud.com/zhilizhao/sample/mp4/

Re: [FFmpeg-devel] [PATCH] libavcodec/avpacket: add av_packet_remove_side_data

> On Oct 12, 2021, at 10:42 AM, zhilizhao(赵志立) wrote: > >> On Oct 12, 2021, at 2:20 AM, Marton Balint wrote: >> >> On Mon, 11 Oct 2021, Zhao Zhili wrote: >> >>> --- >>> doc/APIchanges | 3 +++ >>> libavcodec/avpa

Re: [FFmpeg-devel] [PATCH] avutil: deprecate AVRational field inside AVOption::default_val

> On Oct 21, 2021, at 5:23 PM, Zhao Zhili wrote: > > It's not being used. For backward compatibility, AV_OPT_TYPE_RATIONAL > cannot be changed to use it. > --- > libavutil/opt.h | 2 ++ > libavutil/version.h | 3 +++ > 2 files changed, 5 insertions(+) > Ping. __

Re: [FFmpeg-devel] [PATCH 1/3] avformat/dashenc: enabling streaming automatically for ldash

Ping for the patch set. > On Oct 21, 2021, at 4:15 PM, Zhao Zhili wrote: > > There is a little chance that user specified contradicted options > like -streaming 0 -ldash 1, however, it's more likely that user > didn't know or forgot to enable streaming for ldash. So enabling > streaming automati

Re: [FFmpeg-devel] [PATCH] lavc/{av1, h264, h265}_metadata_bsf: fix description of tick_rate

> On Sep 29, 2021, at 11:21 AM, zhilizhao(赵志立) wrote: > > Ping for review. > >> On Aug 27, 2021, at 3:13 PM, Zhao Zhili wrote: >> >> Users may take the description literally which leads to inverted >> results. >> --- >> doc/bitst

Re: [FFmpeg-devel] [PATCH 06/11] avcodec: use s210 fourcc for 10-bit 4:2:2 packed

> On Nov 12, 2021, at 6:22 PM, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > s210 is used by AWS Elemental Live encoder so I prefer to use same to support > 4:2:2 10-bit packed uncompressed video. Refer to: > https://docs.aws.amazon.com/elemental-live/latest/ug/codec-vod-outputs.html

Re: [FFmpeg-devel] [PATCH] avformat/aviobuf: remove unnecessary label in ffio_fdopen

> On Dec 1, 2021, at 11:25 AM, Steven Liu wrote: > > From: Steven Liu > > Because the s->buffer has been freed by av_freep in avio_closep. > It should not av_freep the buffer in label fail after avio_closep. > Then just move the av_freep before avio_closep and remove the label fail. The pat

Re: [FFmpeg-devel] [PATCH v2] fate/ffmpeg: Fix shortest tests

> On Dec 2, 2021, at 6:04 PM, Andreas Rheinhardt > wrote: > > The mpeg4 encoder is slice-threaded and its output depends upon > the number of threads used. Therefore all tests of this encoder > use a hardcoded number of threads (ENC_OPTS in fate-run.sh contains > "-threads 1"; only the vsynth

Re: [FFmpeg-devel] [PATCH 4/5] avformat/movenc: reduce tfra box size when every sample is a sync sample

> On Dec 3, 2021, at 1:06 PM, Zhao Zhili wrote: > > --- > libavformat/movenc.c | 8 + > libavformat/movenc.h | 1 + > tests/ref/fate/movenc | 80 +-- > 3 files changed, 49 insertions(+), 40 deletions(-) > > diff --git a/libavformat/movenc.c b/libav

Re: [FFmpeg-devel] [PATCH] libavcodec/avpacket: add av_packet_remove_side_data

v 4, 2021, at 4:02 PM, zhilizhao(赵志立) wrote: > > > >> On Oct 12, 2021, at 10:42 AM, zhilizhao(赵志立) wrote: >> >>> On Oct 12, 2021, at 2:20 AM, Marton Balint wrote: >>> >>> On Mon, 11 Oct 2021, Zhao Zhili wrote: >>> >>>>

Re: [FFmpeg-devel] [PATCH 4/5] avformat/movenc: reduce tfra box size when every sample is a sync sample

> On Dec 3, 2021, at 9:33 PM, Michael Niedermayer > wrote: > > On Fri, Dec 03, 2021 at 01:06:56PM +0800, Zhao Zhili wrote: >> --- >> libavformat/movenc.c | 8 + >> libavformat/movenc.h | 1 + >> tests/ref/fate/movenc | 80 +-- >> 3 files changed, 4

Re: [FFmpeg-devel] [PATCH 2/2] lavf/libsrt: deduplicate libsrt_network_wait_fd_timeout

> On Feb 8, 2021, at 2:36 AM, Marton Balint wrote: > > > > On Mon, 8 Feb 2021, Zhao Zhili wrote: > >> --- >> libavformat/libsrt.c | 45 +--- >> 1 file changed, 17 insertions(+), 28 deletions(-) > > Hmm, it seems my latest srt patches conflics with this

Re: [FFmpeg-devel] [PATCH 1/2] avformat/network: fix timeout inaccurate in wait_fd_timeout

> On Feb 9, 2021, at 6:03 AM, Marton Balint wrote: > >> >> The wait_start was about POLLING_TIME larger which leads to timeout >> 100ms late than the option setting. >> --- >> libavformat/network.c | 13 ++--- >> 1 file changed, 6 insertions(+), 7 deletions(-) >> >> diff --git a/libavf

Re: [FFmpeg-devel] [PATCH v2 1/2] lavf/network: add wait fd callback to ff_network_wait_fd_timeout

Ping. > On Feb 8, 2021, at 11:04 AM, Zhao Zhili wrote: > > --- > libavformat/libamqp.c | 4 ++-- > libavformat/network.c | 16 ++-- > libavformat/network.h | 14 +- > libavformat/tcp.c | 6 -- > 4 files changed, 33 insertions(+), 7 deletions(-) > > diff --git a/lib

Re: [FFmpeg-devel] [PATCH v2] examples/decode_video: flush parser to fix missing frame

Ping. I have got multiple users report about the issue when they use the example as a tutorial. > On Oct 12, 2020, at 12:47 AM, Zhao Zhili wrote: > > Ping for review. > >> On Sep 24, 2020, at 2:01 AM, Zhao Zhili wrote: >> >> To reproduce, run decode_video with a single frame sample. No fram

Re: [FFmpeg-devel] [PATCH v1 6/8] avformat/mtv: check av_strdup() return value and fix memleak

> On Oct 10, 2019, at 11:40 AM, Steven Liu wrote: > > Signed-off-by: Steven Liu > --- > libavformat/mtv.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/libavformat/mtv.c b/libavformat/mtv.c > index 728f4a4781..c664ae14c7 100644 > --- a/libavformat/mtv.

Re: [FFmpeg-devel] [PATCH v1 4/8] avformat/libsrt: check av_strdup() return value and fix memleak

> On Oct 10, 2019, at 11:40 AM, Steven Liu wrote: > > Signed-off-by: Steven Liu > --- > libavformat/libsrt.c | 15 ++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c > index b5568089fa..91e8c4b55b 100644 > --- a/libavf

Re: [FFmpeg-devel] [PATCH v1 6/8] avformat/mtv: check av_strdup() return value and fix memleak

> On Oct 10, 2019, at 12:59 PM, Steven Liu wrote: > > > >> 在 2019年10月10日，12:53，zhilizhao(赵志立) 写道： >> >> >> >>> On Oct 10, 2019, at 11:40 AM, Steven Liu wrote: >>> >>> Signed-off-by: Steven Liu >>> --- >>

Re: [FFmpeg-devel] [PATCH v1 8/8] avformat/sapdec: check av_strdup() return value and fix memleak

> On Oct 10, 2019, at 11:40 AM, Steven Liu wrote: > > Signed-off-by: Steven Liu > --- > libavformat/sapdec.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavformat/sapdec.c b/libavformat/sapdec.c > index eddeddeaea..4cce700b40 100644 > --- a/libavformat/sapdec.c > +++ b/liba

Re: [FFmpeg-devel] [PATCH 2/2] FATE/dnn: add .gitignore

> On Oct 16, 2019, at 9:08 AM, Guo, Yejun wrote: > > > >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >> Zhao Zhili >> Sent: Wednesday, October 16, 2019 12:21 AM >> To: ffmpeg-devel@ffmpeg.org >> Cc: Zhao Zhili >> Subject: [FFmpeg-dev

Re: [FFmpeg-devel] [PATCH] avfilter: remove useless cast

> On Oct 29, 2019, at 9:15 PM, Paul B Mahol wrote: > > On 10/29/19, Michael Niedermayer wrote: >> On Mon, Oct 28, 2019 at 11:18:04AM +0800, myp...@gmail.com wrote: >>> On Mon, Oct 28, 2019 at 12:03 AM Zhao Zhili >>> wrote: --- libavfilter/allfilters.c | 2 +- 1 file change

Re: [FFmpeg-devel] [PATCH] avfilter/f_sidedata: fix Wtautological-constant-out-of-range-compare

> On Oct 16, 2019, at 1:17 AM, Zhao Zhili wrote: > > --- > How about add AV_FRAME_DATA_NONE to AVFrameSideDataType? Ping for the patch. > > libavfilter/f_sidedata.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/f_sidedata.c b/libavfilter/f_sidedata.c >

Re: [FFmpeg-devel] [PATCH 1/2] frame: handle add side data with the same type

Ping for review, thanks! > On Oct 25, 2019, at 1:00 PM, quinkbl...@foxmail.com wrote: > > From: Zhao Zhili > > --- > libavutil/frame.c | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/libavutil/frame.c b/libavutil/frame.c > index dcf1fc3d17..bb20e99331 100644 > --- a/liba

Re: [FFmpeg-devel] [PATCH v2 1/4] frame: handle add side data with the same type

> On Nov 1, 2019, at 8:13 PM, Hendrik Leppkes wrote: > > On Fri, Nov 1, 2019 at 1:03 PM wrote: >> >> From: Zhao Zhili >> >> --- >> libavutil/frame.c | 13 + >> libavutil/frame.h | 4 >> 2 files changed, 17 insertions(+) >> > > I believe there have been some use-cases, espe

Re: [FFmpeg-devel] [PATCH v2 1/4] frame: handle add side data with the same type

> On Nov 4, 2019, at 5:04 AM, Michael Niedermayer > wrote: > > On Fri, Nov 01, 2019 at 06:16:38PM +0100, Marton Balint wrote: >> >> >> On Fri, 1 Nov 2019, "zhilizhao(赵志立)" wrote: >> >>> >>> >>>> On Nov 1, 2019, a

Re: [FFmpeg-devel] [PATCH] avfilter: remove useless cast

> On Oct 29, 2019, at 10:28 PM, zhilizhao(赵志立) wrote: > > >> On Oct 29, 2019, at 9:15 PM, Paul B Mahol wrote: >> >> On 10/29/19, Michael Niedermayer wrote: >>> On Mon, Oct 28, 2019 at 11:18:04AM +0800, myp...@gmail.com wrote: >>>> On Mon,

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: set DataRateLimits for hevc

> On Apr 25, 2021, at 11:31 PM, Rick Kern wrote: > > On Sun, Apr 25, 2021 at 4:06 AM Zhao Zhili wrote: > >> From the comment it's not available on old version. It works now >> by testing on macOS 11.2.1. There is no document about since when. >> So trying to set the configuration and ignore

Re: [FFmpeg-devel] [PATCH v2] avformat/libsrt: log streamid in listener mode

> On Jun 9, 2021, at 6:04 AM, Marton Balint wrote: > > > On Tue, 1 Jun 2021, Zhao Zhili wrote: > >> It's useful for test client which pass streamid to ffmpeg/ffplay. >> For example, use ffmpeg to test streamid support in VLC: >> ./ffmpeg -v info -re -i foo.mp4 -c copy -f mpegts -mode listener

Re: [FFmpeg-devel] [PATCH 1/2] avformat/libsrt: support bidirectional transmission

Ping for review, thanks! > On May 19, 2021, at 12:03 AM, Zhao Zhili wrote: > > --- > There is no good use case yet. Patch 2/2 is only used for test. > > libavformat/libsrt.c | 35 +++ > 1 file changed, 27 insertions(+), 8 deletions(-) > > diff --git a/libavformat

Re: [FFmpeg-devel] [RFC PATCH] ffmpeg_videotoolbox: skip memory copy if hwaccel_output_format match

Ping. > On Apr 27, 2021, at 1:09 PM, Zhao Zhili wrote: > > From: zhilizhao > > Simple test results: > > Command: > ./ffmpeg -y -hwaccel videotoolbox -hwaccel_output_format videotoolbox_vld \ > -i test.mp4 -an -c:v h264_videotoolbox -benchmark out.mp4 > >

Re: [FFmpeg-devel] [PATCH] lavfi/drawtext: Add localtime_ms for millisecond precision

> On Jun 15, 2021, at 3:14 AM, Thilo Borgmann wrote: > > Am 08.06.21 um 18:42 schrieb Thilo Borgmann: >> Hi, >> >> add %{localtime_ms} function to the drawtext filter. Same as %{localtime} >> but with additional millisecond part. > > Ping for a volunteer to actually have a look at the patch

Re: [FFmpeg-devel] [PATCH v3] avformat/libsrt: log streamid in listener mode

Ping for review, thanks! > On Jun 10, 2021, at 11:58 AM, Zhao Zhili wrote: > > It's useful for test client which pass streamid to ffmpeg/ffplay. > For example, use ffmpeg to test streamid support in VLC: > ./ffmpeg -v info -re -i foo.mp4 -c copy -f mpegts -mode listener > srt://127.0.0.1:9000 >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/libsrt: support bidirectional transmission

Ping again. > On Jun 10, 2021, at 12:13 PM, zhilizhao(赵志立) wrote: > > Ping for review, thanks! > >> On May 19, 2021, at 12:03 AM, Zhao Zhili wrote: >> >> --- >> There is no good use case yet. Patch 2/2 is only used for te

Re: [FFmpeg-devel] [PATCH 1/3] avformat/rtsp: Fix floating point exception for low min/max port range

> On Apr 4, 2021, at 11:36 PM, Andriy Gelman wrote: > > From: Andriy Gelman > > Fixed by setting port offset to zero when it cannot be computed. > > To reproduce: > $ ffmpeg -min_port 32000 -max_port 32001 -i > rtsp://wowzaec2demo.streamlock.net/vod/mp4:BigBuckBunny_115k.mov -f null - > [1

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Fix declaration-after-statement warning

> On Jul 19, 2021, at 3:23 AM, Andreas Rheinhardt > wrote: > > Andreas Rheinhardt: >> Signed-off-by: Andreas Rheinhardt >> --- >> What is actually the reason that we stick to this C90 rule? >> Is it because of compability with ancient compilers? (Given that we >> already require several C99 f

Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: remove first_audio_pts and first_pts

> On Jul 20, 2021, at 3:50 PM, Steven Liu wrote: > > Thilo Borgmann 于2021年7月20日周二 下午3:37写道： >> >> Am 20.07.21 um 03:46 schrieb Andreas Rheinhardt: >>> Steven Liu: From: Steven Liu Because these two member of AVFContext not be used. Signed-off-by: Steven Liu -

Re: [FFmpeg-devel] [PATCH v4] avformat/libsrt: print streamid at client

> On Jul 23, 2021, at 5:59 PM, Raghavendra Rao Sidlagatta > wrote: > > > On Monday, March 22, 2021 06:45 GMT, "Raghavendra Rao Sidlagatta" > wrote: > > On Wednesday, January 20, 2021 09:48 GMT, "Raghavendra Rao Sidlagatta" > wrote: > > On Tuesday, October 06, 2020 08:18 BST, raghave

Re: [FFmpeg-devel] libavformat/rtsp.c: fix RTSP not setup the UDP stream in SDP

> On Jul 30, 2021, at 10:55 AM, Chiu, Yung-Hsiang wrote: > > Hi, > > Our RTSP video server reply two streams in SDP are UDP and RTP/AVP/UDP. >>> m=video 0 UDP 33 >>> m=video 0 RTP/AVP/UDP 33 > > ffmpeg now setup twice with the same transport "RTP/AVP/UDP" > > The first time is >>> SETUP rtsp

  1   2   3   4   >