> On Nov 1, 2019, at 8:13 PM, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > > On Fri, Nov 1, 2019 at 1:03 PM <quinkbl...@foxmail.com> wrote: >> >> From: Zhao Zhili <zhiliz...@tencent.com> >> >> --- >> libavutil/frame.c | 13 +++++++++++++ >> libavutil/frame.h | 4 ++++ >> 2 files changed, 17 insertions(+) >> > > I believe there have been some use-cases, especially around > closed-captions, where multiple blocks of the same type have been > used, somehow. Since this is really an API change, not sure its such a > good idea.
I guess it may be too late to change the behavior. Whether keep the current behavior or not, remove_side_data is broken. It can remove multiple side data and miss a few. It can be fixed in two different ways: 1. Remove the first side data of the supplied type, like get_side_data(). 2. Remove all side data of the supplied type. The first solution match current documentation. > > - Hendrik > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
