Re: [FFmpeg-devel] [PATCH 1/4] hevcdec: export cropping information instead of handling it internally

2017-05-08 Thread wm4
On Mon, 8 May 2017 15:46:22 -0300 James Almer wrote: > From: Anton Khirnov > > --- > This merges commit a02ae1c6837a54ed9e7735da2b1f789b2f4b6e13 from libav > Any specific reason you're posting them to the list? ___ ffmpeg-devel mailing list ffmpeg-

Re: [FFmpeg-devel] img2dec: jpeg_probe logic

2017-05-09 Thread wm4
On Mon, 8 May 2017 16:25:43 -0400 Vadim Kalinsky wrote: > Hey, > > Trying to fix a bug #6113, I stumbled upon some strange logic in > libavformat/img2dec.c:jpeg_probe. It accepts first 2048 bytes of jpeg stream, > and tries to read it with some state machine. If it doesn't look like jpeg > st

Re: [FFmpeg-devel] [PATCH] avcodec/webp: Reinitilaize VP8 decoder on pixel format mismatch

2017-05-10 Thread wm4
On Wed, 10 May 2017 15:39:45 +0200 Michael Niedermayer wrote: > On Wed, May 10, 2017 at 08:10:23AM -0400, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, May 9, 2017 at 9:24 PM, Michael Niedermayer > > wrote: > > > > > On Tue, May 09, 2017 at 09:08:08PM -0400, Ronald S. Bultje wrote: > > >

Re: [FFmpeg-devel] configure: Prioritize 'sdl2-config'-check

2017-05-11 Thread wm4
On Thu, 11 May 2017 12:53:33 +0200 Reino Wijnsma wrote: > See https://trac.ffmpeg.org/ticket/6377. > By prioritizing the 'sdl2-config'-check the librarylist that's needed to > build FFPlay is setup automatically and one doesn't have to patch > 'sdl2.pc' anymore. Wouldn't it be more appropriate t

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Limit the number of side data elements per packet

2017-05-11 Thread wm4
On Thu, 11 May 2017 13:01:36 +0200 Michael Niedermayer wrote: > Fixes: 1293/clusterfuzz-testcase-minimized-6054752074858496 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/avcodec.

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Limit the number of side data elements per packet

2017-05-11 Thread wm4
On Thu, 11 May 2017 23:27:37 +0200 Michael Niedermayer wrote: > On Thu, May 11, 2017 at 06:54:16PM +0200, wm4 wrote: > > On Thu, 11 May 2017 13:01:36 +0200 > > Michael Niedermayer wrote: > > > > > Fixes: 1293/clusterfuzz-testcase-minimized-6054752074858496 >

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: Limit the number of side data elements per packet

2017-05-12 Thread wm4
On Fri, 12 May 2017 10:59:50 -0300 James Almer wrote: > On 5/12/2017 9:20 AM, Michael Niedermayer wrote: > > On Fri, May 12, 2017 at 06:16:38AM +0200, wm4 wrote: > >> On Thu, 11 May 2017 23:27:37 +0200 > >> Michael Niedermayer wrote: > >> > >>&g

Re: [FFmpeg-devel] [PATCH] avfilter: don't anonymously typedef structs

2017-05-12 Thread wm4
On Fri, 12 May 2017 20:01:54 +0200 Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-12 Thread wm4
On Fri, 12 May 2017 18:21:07 +0200 Nicolas George wrote: > Le tridi 23 floréal, an CCXXV, Paul B Mahol a écrit : > > I told you that its unacceptable. > > And I told you, before you pushed, that your cowboy-style parser was > unacceptable. You chose to disregard it. AFAIK all of our subtitle

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: Made execution of reap_filters() more deterministic with respect to when headers are written

2017-05-12 Thread wm4
On Fri, 12 May 2017 13:28:14 -0700 Aaron Levinson wrote: > Purpose: Made execution of reap_filters() more deterministic with > respect to when headers are written in relationship with the > initialization of output streams and the processing of input audio > and/or video frames. This change fixe

Re: [FFmpeg-devel] [PATCH] avcodec/xpmdec: Fix multiple pointer/memory issues

2017-05-12 Thread wm4
On Fri, 12 May 2017 20:55:13 +0200 Michael Niedermayer wrote: > On Fri, May 12, 2017 at 03:29:52PM +0200, Paul B Mahol wrote: > > On 5/12/17, Michael Niedermayer wrote: > > > On Thu, May 11, 2017 at 11:17:33AM +0200, Michael Niedermayer wrote: > > >> On Thu, May 11, 2017 at 09:01:57AM +0200,

Re: [FFmpeg-devel] [PATCH] videotoolbox: add hwcontext support

2017-05-15 Thread wm4
On Sun, 7 May 2017 12:01:11 -0700 Aaron Levinson wrote: > Are you also planning to change ffmpeg_videotoolbox.c? See below for > more comments. > > Aaron Levinson > Pushed. Changed what I felt like I could change. Thanks for the review. ___ ffmpeg-

Re: [FFmpeg-devel] [PATCH]Two patches from github

2017-05-15 Thread wm4
On Mon, 15 May 2017 12:40:23 +0200 Carl Eugen Hoyos wrote: > From 42766f345dbf398716c6fd9072f072f5fa91c940 Mon Sep 17 00:00:00 2001 > From: Steve Kondik > Date: Tue, 16 Dec 2014 01:37:57 -0800 > Subject: [PATCH 2/2] avutil: Use _SC_NPROCESSORS_CONF > > * On most Android devices, CPUs can appea

Re: [FFmpeg-devel] [PATCH] libavformat aviobuf: Fixed dst pointer initialization in fill_buffer

2017-05-15 Thread wm4
On Mon, 15 May 2017 17:55:28 + Rob Meyers wrote: > Of course. > > We noticed when reading data from a named pipe the first 10 bytes would get > dropped. I traced this to the affected code in fill_buffer(). The > assignment of "dst" was always set to the beginning of the buffer, and if > it h

Re: [FFmpeg-devel] [PATCH]Two patches from github

2017-05-16 Thread wm4
On Tue, 16 May 2017 12:40:03 +0200 Carl Eugen Hoyos wrote: > 2017-05-15 12:53 GMT+02:00 wm4 : > > On Mon, 15 May 2017 12:40:23 +0200 > > Carl Eugen Hoyos wrote: > > > >> From 42766f345dbf398716c6fd9072f072f5fa91c940 Mon Sep 17 00:00:00 2001 > >> From: St

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_dxva2: Don't improperly free IDirect3DSurface9 objects

2017-05-16 Thread wm4
On Tue, 16 May 2017 05:04:36 -0700 Aaron Levinson wrote: > Add dxva2_pool_release_dummy() and use it in call to > av_buffer_create() in dxva2_pool_alloc(). > > Prior to this change, av_buffer_create() was called with NULL for the > third argument, which indicates that av_buffer_default_free() sh

Re: [FFmpeg-devel] [PATCH] libavformat/hls: Observe Set-Cookie headers

2017-05-17 Thread wm4
On Sat, 6 May 2017 14:28:10 -0400 Micah Galizia wrote: > On 2017-05-05 09:28 PM, wm4 wrote: > > On Fri, 5 May 2017 20:55:05 -0400 > > Micah Galizia wrote: > > > >> Signed-off-by: Micah Galizia > >> --- > >> libavformat/hls.c | 12 +++

Re: [FFmpeg-devel] [PATCH v2] avfilter: take_samples: do not directly return frame when samples are skipped

2017-05-21 Thread wm4
On Sat, 20 May 2017 20:12:15 +0200 Nicolas George wrote: > Le primidi 1er prairial, an CCXXV, Muhammad Faiz a écrit : > > > I will push this soon. > > Pushed and backported to 3.3 branch. > > Well, I was probably ok with this patch, but we will never know, will > we? > > Can you explain the

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mlpdec: Check quant_step_size against huff_lsbs

2017-05-21 Thread wm4
On Sat, 20 May 2017 23:01:04 +0200 Michael Niedermayer wrote: > This reorders the operations so as to avoid computations with the above > arguments > before they have been initialized. > Fixes part of 1708/clusterfuzz-testcase-minimized-5035111957397504 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH] Use AVOnce as a static variable consistently

2017-05-22 Thread wm4
On Mon, 22 May 2017 12:06:19 +0200 Hendrik Leppkes wrote: > Using AVOnce as a stack variable makes no sense as the state is lost > when the function exists. > > This fixes repeated calls to av(filter/device)_register_all > --- > libavdevice/alldevices.c | 2 +- > libavfilter/allfilters.c | 2 +-

Re: [FFmpeg-devel] [PATCH] lavf/concatdec: do not transfer custom IO flag

2017-05-22 Thread wm4
On Mon, 22 May 2017 16:54:31 +0200 Clément Bœsch wrote: > From: Clément Bœsch > > If the source is using a custom IO, setting this flag causes heavy leaks > since the segments will not have their avio context closed. > > Regression since f5da453b068f55d335ca403d2e2b4dd2ac3d4331. > --- > libav

[FFmpeg-devel] [PATCH] lavf: consider codec timebase for framerate detection

2017-05-23 Thread wm4
Fixes detection of some TV sample as 24.5 FPS. With the patch applied, it's detected as 25 FPS. --- libavformat/utils.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index fbd8b58ac2..778a82aeee 100644 --- a/libavformat/utils.

Re: [FFmpeg-devel] [PATCH] lavf: consider codec timebase for framerate detection

2017-05-23 Thread wm4
On Tue, 23 May 2017 13:36:51 +0200 wm4 wrote: > Fixes detection of some TV sample as 24.5 FPS. With the patch applied, > it's detected as 25 FPS. > --- > libavformat/utils.c | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/libavfo

[FFmpeg-devel] [PATCH] videotoolbox: log errors

2017-05-24 Thread wm4
With the new decode API, you can't handle errors directly in the API user - you only know that the hwaccel did not initialize at all. Add some approximate logging. --- libavcodec/videotoolbox.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videot

Re: [FFmpeg-devel] [PATCH] avfilter: add audio surround upmixer

2017-05-26 Thread wm4
On Fri, 26 May 2017 13:08:10 +0200 Nicolas George wrote: > Le septidi 7 prairial, an CCXXV, Paul B Mahol a écrit : > > > This belongs in libswresample > > No it does not. > > I think it does too. There's plenty of precedent of not moving filters into libswresample or libswscale, even if in

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-05-26 Thread wm4
On Thu, 25 May 2017 19:32:06 +0200 Michael Niedermayer wrote: > This reduces the number of strstr() calls per byte > > Fixes timeout > Fixes: 1817/clusterfuzz-testcase-minimized-5104230530547712 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

2017-05-26 Thread wm4
On Thu, 25 May 2017 16:10:49 +0200 Michael Niedermayer wrote: > Fixes: 1735/clusterfuzz-testcase-minimized-5350472347025408 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/fft_tem

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

2017-05-27 Thread wm4
7 at 11:18:12PM +0200, Hendrik Leppkes wrote: > > > > > > On Fri, May 26, 2017 at 11:11 PM, Michael Niedermayer > > > > > > wrote: > > > > > > > On Fri, May 26, 2017 at 03:20:14PM +0100, Rostislav Pehlivanov > > > wrote: > > > &g

Re: [FFmpeg-devel] [PATCH] lavf: remove the libnut library wrapper

2017-05-29 Thread wm4
On Sun, 28 May 2017 20:28:30 +0100 Rostislav Pehlivanov wrote: > libnut is outdated and not developed anymore, all nut developments > happens in this repo, so users are getting mislead > --- > Changelog| 1 + > MAINTAINERS | 1 - > configure| 6

Re: [FFmpeg-devel] [PATCH] lavc: remove libschroedinger encoding and decoding wrappers

2017-05-29 Thread wm4
On Sun, 28 May 2017 22:04:41 +0100 Rostislav Pehlivanov wrote: > The library has stopped being developed and Debian has removed it > from its repositories citing security issues. > The native Dirac decoder supports everything the library has and encoding > support is still provided via the native

Re: [FFmpeg-devel] [PATCH] udp: ignore UDP packets without payload

2017-05-29 Thread wm4
On Sun, 28 May 2017 21:20:12 +0200 Nicolas George wrote: > As is, this patch would make something that is currently possible with > the API (implementing protocols that rely on empty packets) impossible, > and that cannot be accepted. Which ones? ___ f

Re: [FFmpeg-devel] [PATCH] lavf: consider codec timebase for framerate detection

2017-05-30 Thread wm4
On Tue, 23 May 2017 13:36:51 +0200 wm4 wrote: > Fixes detection of some TV sample as 24.5 FPS. With the patch applied, > it's detected as 25 FPS. > --- > libavformat/utils.c | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/libavfo

Re: [FFmpeg-devel] [PATCH] lavf: consider codec timebase for framerate detection

2017-05-30 Thread wm4
On Tue, 30 May 2017 18:46:36 -0300 James Almer wrote: > On 5/30/2017 9:07 AM, wm4 wrote: > > On Tue, 23 May 2017 13:36:51 +0200 > > wm4 wrote: > > > >> Fixes detection of some TV sample as 24.5 FPS. With the patch applied, > >> it's detected as 25

Re: [FFmpeg-devel] [PATCH] avformat/hls: Disallow local file access by default

2017-05-31 Thread wm4
On Wed, 31 May 2017 11:29:56 +0200 Michael Niedermayer wrote: > On Wed, May 31, 2017 at 09:03:34AM +0200, Hendrik Leppkes wrote: > > On Wed, May 31, 2017 at 2:09 AM, Michael Niedermayer > > wrote: > > > On Wed, May 31, 2017 at 01:14:58AM +0200, Hendrik Leppkes wrote: > > >> On Wed, May 31, 2

Re: [FFmpeg-devel] [PATCH] videotoolbox: log errors

2017-05-31 Thread wm4
On Wed, 24 May 2017 15:47:36 +0200 wm4 wrote: > With the new decode API, you can't handle errors directly in the API > user - you only know that the hwaccel did not initialize at all. > > Add some approximate logging. > --- > libavcodec/videotoolbox.c | 6 ++ > 1

Re: [FFmpeg-devel] [PATCH] avformat/hls: Disallow local file access by default

2017-05-31 Thread wm4
On Wed, 31 May 2017 12:51:35 +0200 Michael Niedermayer wrote: > On Wed, May 31, 2017 at 11:52:06AM +0200, wm4 wrote: > > On Wed, 31 May 2017 11:29:56 +0200 > > Michael Niedermayer wrote: > > > > > On Wed, May 31, 2017 at 09:03:34AM +0200, Hendrik Leppkes wrote:

Re: [FFmpeg-devel] [PATCH] avformat/hls: Disallow local file access by default

2017-05-31 Thread wm4
On Wed, 31 May 2017 14:49:19 +0200 Michael Niedermayer wrote: > On Wed, May 31, 2017 at 01:13:50PM +0200, wm4 wrote: > > On Wed, 31 May 2017 12:51:35 +0200 > > Michael Niedermayer wrote: > > > > > On Wed, May 31, 2017 at 11:52:06AM +0200, wm4 wrote: > &

[FFmpeg-devel] [PATCH] lavf: consider codec framerate for framerate detection

2017-05-31 Thread wm4
Fixes detection of some TV sample as 24.5 FPS. With the patch applied, it's detected as 25 FPS. This is enabled for mpegts only. --- libavformat/internal.h | 5 + libavformat/mpegts.c | 2 ++ libavformat/utils.c| 10 ++ 3 files changed, 17 insertions(+) diff --git a/libavform

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

2017-05-31 Thread wm4
On Wed, 31 May 2017 20:59:07 +0200 Paul B Mahol wrote: > On 5/31/17, Matthias Troffaes wrote: > > Dear Moritz, > > > > On Wed, May 31, 2017 at 2:17 PM, Moritz Barsnick wrote: > >> On Wed, May 31, 2017 at 13:31:14 +0100, Matthias C. M. Troffaes wrote: > >>> @@ -2,6 +2,7 @@ Entries are sorted

Re: [FFmpeg-devel] [PATCH 2/3] avutil/avstring: Fix av_match_name() with seperators in the name itself

2017-06-01 Thread wm4
On Thu, 1 Jun 2017 13:44:45 +0200 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavutil/avstring.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/libavutil/avstring.c b/libavutil/avstring.c > index f03dd25141..c1348b3a1

Re: [FFmpeg-devel] [PATCH] avformat/options: log filename on open

2017-06-02 Thread wm4
On Fri, 2 Jun 2017 15:05:27 +0200 Michael Niedermayer wrote: > The loglevel is choosen so that the main filename and any images of > multi image sequences are shown only at debug level to avoid > clutter. > > This makes exploits in playlists more visible. As they would show > accesses to privat

Re: [FFmpeg-devel] [PATCH] compat: LoadLibrary isn't available on UWP/WinRT

2017-06-02 Thread wm4
On Fri, 2 Jun 2017 15:29:07 +0200 Hugo Beauzée-Luyssen wrote: > --- > compat/w32dlfcn.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/compat/w32dlfcn.h b/compat/w32dlfcn.h > index bc9bb8c9f5..308763be53 100644 > --- a/compat/w32dlfcn.h > +++ b/compat/w32dlfcn.h > @@ -71,7 +71,11

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

2017-06-03 Thread wm4
On Sat, 3 Jun 2017 13:18:30 +0200 (CEST) Jan Engelhardt wrote: > > The layout of struct AVCodec changed. Four function pointers were > inserted in the middle, shifting void (*flush) to a new address. The > size of AVCodec also changed, which would have required a full MAJOR > bump. Those are

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

2017-06-03 Thread wm4
On Sat, 3 Jun 2017 14:07:30 +0200 (CEST) Jan Engelhardt wrote: > On Saturday 2017-06-03 13:34, Hendrik Leppkes wrote: > >On Sat, Jun 3, 2017 at 1:18 PM, Jan Engelhardt wrote: > >> > >>The layout of struct AVCodec changed. Four function pointers were > >>inserted in the middle, shifting void (*

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

2017-06-03 Thread wm4
On Sat, 3 Jun 2017 14:19:25 +0200 (CEST) Jan Engelhardt wrote: > >Anyway, in general, I recommend not pretending that FFmpeg has ABI > >compatibility. Especially not across major releases > > That would be fine with me - could ffmpeg then ensure that the > major is in fact bumped on major rele

Re: [FFmpeg-devel] ABI break between 3.0 and 3.3 without symvers/SONAME changes

2017-06-03 Thread wm4
On Sat, 3 Jun 2017 14:31:31 +0200 (CEST) Jan Engelhardt wrote: > On Saturday 2017-06-03 14:27, Timo Rothenpieler wrote: > > > >> could ffmpeg then ensure that the major is in fact bumped on major > >> releases? In distro context, a bump is easier to swallow than a > >> non-bump.. > > > > It i

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

2017-06-03 Thread wm4
On Fri, 2 Jun 2017 18:17:22 -0700 Sasi Inguva wrote: > Fixes t/6421 > > Signed-off-by: Sasi Inguva > --- > libavformat/mov.c| 57 -- > tests/ref/fate/h264-twofields-packet | 60 > ++-- > 2 files changed, 70 i

Re: [FFmpeg-devel] [PATCH] avfilter/af_sofalizer: switch to libmysofa

2017-06-03 Thread wm4
On Sat, 3 Jun 2017 14:42:59 +0200 Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- And libmysofa can't be NIH'ed? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/hls: Check file extensions

2017-06-03 Thread wm4
On Sat, 3 Jun 2017 14:58:19 +0200 Michael Niedermayer wrote: > Do you object to fixing this security issue that has a working exploit? > Can you provide a testcase the fix breaks ? So i can look into what > can be done about it ? (multiple testcases would be even better so > theres a lower chanc

Re: [FFmpeg-devel] libavformat: deprecated AVStream member suggests usage of private field

2017-06-03 Thread wm4
On Sat, 3 Jun 2017 21:15:01 +0200 "Tom M." wrote: > This is pretty confusing. Those "All fields below this line are not part of > the public API." comments are completely ignored by doxygen. And this is > where most people look at, I doubt they parse the raw header files > themselves. Wouldnt it

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

2017-06-06 Thread wm4
On Sat, 3 Jun 2017 19:31:37 -0700 Sasi Inguva wrote: > > -// Offset the DTS by ctts[0] to make the PTS of the first frame 0 > > -if (ctts_data_old && ctts_count_old > 0) { > > -edit_list_dts_entry_end -= ctts_data_old[0].duration; > > -av_log(mov->fc, AV_LOG_DEBUG, "Offset

Re: [FFmpeg-devel] [PATCH 3/3] avformat: set the default whitelist to disable hls

2017-06-06 Thread wm4
On Tue, 6 Jun 2017 04:59:58 +0200 Michael Niedermayer wrote: > I disagree that the issue is minor and far fetched. > > The exploit that i have was successfully used against multiple > companies (it was a demonstration and AFAIK no harm was done). > That same attack works against all recent relea

Re: [FFmpeg-devel] [PATCH 3/3] avformat/utils: Slightly un-clutter code in determinable_frame_size() by using a switch

2017-06-06 Thread wm4
On Sun, 4 Jun 2017 02:25:46 +0200 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/utils.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index c5f1eac185..bbc7a7b547 100644 >

Re: [FFmpeg-devel] [PATCH] compat: LoadLibrary isn't available on UWP/WinRT

2017-06-06 Thread wm4
On Sat, 3 Jun 2017 10:54:08 -0700 Aaron Levinson wrote: > On 6/2/2017 7:11 AM, wm4 wrote: > > On Fri, 2 Jun 2017 15:29:07 +0200 > > Hugo Beauzée-Luyssen wrote: > > > >> --- > >> compat/w32dlfcn.h | 4 > >> 1 file changed, 4 insertio

Re: [FFmpeg-devel] [PATCH] lavf: consider codec framerate for framerate detection

2017-06-07 Thread wm4
On Wed, 31 May 2017 18:26:01 +0200 wm4 wrote: > Fixes detection of some TV sample as 24.5 FPS. With the patch applied, > it's detected as 25 FPS. > > This is enabled for mpegts only. > --- > libavformat/internal.h | 5 + > libavformat/mpegts.c | 2 ++ >

Re: [FFmpeg-devel] [PATCH] lavf: consider codec framerate for framerate detection

2017-06-08 Thread wm4
On Wed, 7 Jun 2017 21:23:12 +0200 (CEST) Marton Balint wrote: > On Wed, 7 Jun 2017, wm4 wrote: > > > On Wed, 31 May 2017 18:26:01 +0200 > > wm4 wrote: > > > >> Fixes detection of some TV sample as 24.5 FPS. With the patch applied, > >> it's det

Re: [FFmpeg-devel] [PATCH] avfilter: add native headphone spatialization filter

2017-06-08 Thread wm4
On Thu, 8 Jun 2017 08:13:48 +0200 Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- Feeding the coefficients as additional audio inputs, and using amovie to load them, seems like an extremely awkward choice. It would make sense to me if there actually were a set of input coefficients per

Re: [FFmpeg-devel] [PATCH] avfilter: add native headphone spatialization filter

2017-06-08 Thread wm4
On Thu, 8 Jun 2017 11:36:02 +0200 Paul B Mahol wrote: > On 6/8/17, wm4 wrote: > > On Thu, 8 Jun 2017 08:13:48 +0200 > > Paul B Mahol wrote: > > > >> Signed-off-by: Paul B Mahol > >> --- > > > > Feeding the coefficients as additional aud

Re: [FFmpeg-devel] [PATCH] avfilter: add native headphone spatialization filter

2017-06-08 Thread wm4
On Thu, 8 Jun 2017 13:24:39 +0200 Paul B Mahol wrote: > On 6/8/17, wm4 wrote: > > On Thu, 8 Jun 2017 11:36:02 +0200 > > Paul B Mahol wrote: > > > >> On 6/8/17, wm4 wrote: > >> > On Thu, 8 Jun 2017 08:13:48 +0200 > >> > Paul B Maho

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

2017-06-08 Thread wm4
On Thu, 8 Jun 2017 12:28:41 -0700 Sasi Inguva wrote: > Ping! > If nobody has another comment, I guess I can push it tomorrow or next week. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/htmlsubtitles: Protect very slow redundant sscanf() calls by optimized use of strchr()

2017-06-09 Thread wm4
On Thu, 8 Jun 2017 23:53:55 +0200 Michael Niedermayer wrote: > Fixes Timeout > Fixes: 2127/clusterfuzz-testcase-minimized-6595787859427328 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/htmlsubtitles.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH 2/2] tools: add sofa2wavs

2017-06-09 Thread wm4
On Fri, 9 Jun 2017 13:44:01 +0200 Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > Makefile | 1 + > tools/Makefile| 1 + > tools/sofa2wavs.c | 79 > +++ > 3 files changed, 81 insertions(+) > create mode 100644 tools

Re: [FFmpeg-devel] [PATCH 2/2] tools: add sofa2wavs

2017-06-09 Thread wm4
On Fri, 9 Jun 2017 17:02:37 +0200 Paul B Mahol wrote: > On 6/9/17, wm4 wrote: > > On Fri, 9 Jun 2017 13:44:01 +0200 > > Paul B Mahol wrote: > > > >> Signed-off-by: Paul B Mahol > >> --- > >> Makefile | 1 + > >&g

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

2017-06-09 Thread wm4
On Fri, 9 Jun 2017 11:34:26 +0300 Ivan Kalvachev wrote: > > If I understand correctly, the root of the problem is the undefined behavior > of the compiler and the C standard. > Is there any chance that FFmpeg project could initiate a change in the > next C standard, so this thing would be define

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

2017-06-09 Thread wm4
On Fri, 9 Jun 2017 00:10:49 +0200 Michael Niedermayer wrote: > On Sat, May 27, 2017 at 12:24:16PM +0200, wm4 wrote: > > On Sat, 27 May 2017 03:56:42 +0200 > > Michael Niedermayer wrote: > > > > > On Fri, May 26, 2017 at 07:06:44PM -0400, Ronald

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

2017-06-09 Thread wm4
On Tue, 6 Jun 2017 11:16:01 -0700 Sasi Inguva wrote: > Fixes t/6421. If the videos starts with B frame, then the minimum composition > time as computed by stts + ctts will be non-zero. Hence we need to shift the > DTS, so that the first pts is zero. This was the intention of that > code-block

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

2017-06-10 Thread wm4
On Sat, 10 Jun 2017 02:50:11 +0300 Ivan Kalvachev wrote: > On 6/9/17, wm4 wrote: > > On Fri, 9 Jun 2017 00:10:49 +0200 > > Michael Niedermayer wrote: > > > >> On Sat, May 27, 2017 at 12:24:16PM +0200, wm4 wrote: > >> > On Sat, 27 May 2017 03:56:

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/htmlsubtitles: Protect very slow redundant sscanf() calls by optimized use of strchr()

2017-06-10 Thread wm4
On Fri, 9 Jun 2017 19:39:36 +0200 Michael Niedermayer wrote: > On Fri, Jun 09, 2017 at 04:32:41PM +0200, wm4 wrote: > > On Thu, 8 Jun 2017 23:53:55 +0200 > > Michael Niedermayer wrote: > > > > > Fixes Timeout > > > Fixes: 2127/clusterf

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

2017-06-11 Thread wm4
On Sun, 11 Jun 2017 03:58:30 +0300 Ivan Kalvachev wrote: > Of course, as FFmpeg developer, it is your right to initiate a vote > that would prevent Michael from trying to make FFmpeg more secure. > He has always complied with official decisions. Nothing but polemic nonsense intended to scare oth

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

2017-06-11 Thread wm4
On Sun, 11 Jun 2017 13:26:44 +0200 Michael Niedermayer wrote: > Iam fighting on this issue because i see this pushing FFmpeg into a > direction where the code is harder to understand and harder to maintain > and we already have many open bugs That's funny, because whenever I see something strang

Re: [FFmpeg-devel] [PATCH] Add support for RockChip Media Process Platform This adds hardware decoding for h264 / HEVC / VP8 using MPP Rockchip API. Will return frames holding a av_drmprime struct tha

2017-06-11 Thread wm4
On Sun, 11 Jun 2017 05:24:16 + "LongChair ." wrote: > From: LongChair > > --- > Changelog | 1 + > configure | 12 ++ > libavcodec/Makefile| 4 + > libavcodec/allcodecs.c | 6 + > libavcodec/drmprime.h | 17 ++ > libavcodec/rkmppdec.c | 522 > ++

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Replace very slow redundant sscanf() calls by cleaner and faster code

2017-06-12 Thread wm4
On Sun, 11 Jun 2017 17:58:45 +0200 Michael Niedermayer wrote: > This reduces the worst case from O(n²) to O(n) time > > Fixes Timeout > Fixes: 2127/clusterfuzz-testcase-minimized-6595787859427328 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/htmlsubtitles.c | 20 +++---

Re: [FFmpeg-devel] [PATCH] Add support for RockChip Media Process Platform

2017-06-13 Thread wm4
On Tue, 13 Jun 2017 11:17:35 +0100 Mark Thompson wrote: > > +vp8_rkmpp_hwaccel_deps="rkmpp" > > vp9_d3d11va_hwaccel_deps="d3d11va DXVA_PicParams_VP9" > > vp9_d3d11va_hwaccel_select="vp9_decoder" > > vp9_dxva2_hwaccel_deps="dxva2 DXVA_PicParams_VP9" > > Why do these hwaccels exist? They don

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Factor open brace handling into its own function

2017-06-13 Thread wm4
On Tue, 13 Jun 2017 00:01:04 +0200 Michael Niedermayer wrote: > Suggested-by: wm4 > Signed-off-by: Michael Niedermayer > --- > libavcodec/htmlsubtitles.c | 44 ++-- > 1 file changed, 26 insertions(+), 18 deletions(-) > > di

Re: [FFmpeg-devel] [PATCH 01/24] hwcontext_vaapi: Try to support the VDPAU wrapper

2017-06-13 Thread wm4
d on a patch by wm4 . > > (cherry picked from commit e791b915c774408fbc0ec9e7270b021899e08ccc) > --- > libavutil/hwcontext_vaapi.c | 79 > ++--- > libavutil/hwcontext_vaapi.h | 7 > 2 files changed, 52 insertions(+), 34 dele

Re: [FFmpeg-devel] [PATCH 09/24] vf_deinterlace_vaapi: Add support for field rate output

2017-06-13 Thread wm4
On Mon, 12 Jun 2017 23:40:26 +0100 Mark Thompson wrote: > In order to work correctly with the i965 driver, this also fixes the > direction of forward/backward references - forward references are > intended to be those from the past to the current frame, not from the > current frame to the future.

Re: [FFmpeg-devel] [PATCH 00/24] Generic hardware device setup and miscellaneous related merges

2017-06-13 Thread wm4
On Mon, 12 Jun 2017 23:40:17 +0100 Mark Thompson wrote: > This merges a set of stuff from libav to do with hardware codecs/processing. All patches LGTM. I don't think it makes sense to delay pushing those either. ___ ffmpeg-devel mailing list ffmpeg-de

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: drop an state

2017-06-13 Thread wm4
On Tue, 13 Jun 2017 15:09:54 +0200 Michael Niedermayer wrote: > Simplifies code but changes handling of multiple an tags > > Suggested-by: wm4 > Signed-off-by: Michael Niedermayer > --- > libavcodec/htmlsubtitles.c | 11 +-- > tests/ref/fate/sub-srt | 2 +-

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: drop an state

2017-06-13 Thread wm4
On Tue, 13 Jun 2017 16:30:42 +0200 Clément Bœsch wrote: > On Tue, Jun 13, 2017 at 03:09:54PM +0200, Michael Niedermayer wrote: > [...] > > -Dialogue: 0,0:00:24.50,0:00:26.50,Default,,0,0,0,,{\an4}This text should > > be at the\Nmiddle and horizontally at the left\N(The second position must > >

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-14 Thread wm4
On Wed, 14 Jun 2017 23:03:39 +0100 Mark Thompson wrote: > It's also 8-bit YUV 4:2:0. > --- > Most visible with streams downloaded from hardware to encode properly with > libx264, which will typically be NV12. > > > ffmpeg.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff -

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-15 Thread wm4
On Thu, 15 Jun 2017 09:42:48 +0530 Gyan wrote: > On Thu, Jun 15, 2017 at 4:59 AM, wm4 wrote: > > > > > > av_log(NULL, AV_LOG_WARNING, > > > "No pixel format specified, %s for H.264 encoding > > chosen.\n" &

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-15 Thread wm4
On Thu, 15 Jun 2017 16:12:00 +0530 Gyan wrote: > On Thu, Jun 15, 2017 at 3:04 PM, wm4 wrote: > > > > It's wrong and dumb because the pixfmt is not enough to tell whether > > the encoder will produce a file with w widely compatible profile. > > > &g

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-15 Thread wm4
On Thu, 15 Jun 2017 18:17:37 +0530 Gyan wrote: > On Thu, Jun 15, 2017 at 4:44 PM, wm4 wrote: > > > > Forcing the "High" or maybe "Main" profile is enough to ensure > > compatibility. > > > > Result of encoding a PNG s

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-15 Thread wm4
On Thu, 15 Jun 2017 16:22:34 +0200 Michael Niedermayer wrote: > no, but that doesnt mean we can make false statments about other > people or their work. > > Theres the moral wrong > > Theres the technical wrong, of not correctly stating the problem and > that potentially affecting work on the p

Re: [FFmpeg-devel] [PATCH] ffmpeg: Don't offer H.264 compatibility warning for NV12 input

2017-06-15 Thread wm4
On Thu, 15 Jun 2017 12:10:27 -0300 James Almer wrote: > On 6/15/2017 11:43 AM, wm4 wrote: > > On Thu, 15 Jun 2017 16:22:34 +0200 > > Michael Niedermayer wrote: > > > >> no, but that doesnt mean we can make false statments about other > >> people or

[FFmpeg-devel] [PATCH] ffmpeg: remove misleading and incorrect error messages

2017-06-15 Thread wm4
It is wrong/incorrect in two aspects: 1. The pixel format is not enough to guarantee that the resulting file will be any more compatible with media players. 2. Media players not supporting higher profiles are not necessarily outdated (in fact this is simply an arrogant statement that libav

Re: [FFmpeg-devel] [PATCH] ffmpeg: remove misleading and incorrect error messages

2017-06-15 Thread wm4
Those are warnings, not error messages. Fixed locally. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Why the tag “DURATION” is a necessity in Matroska files?

2017-06-16 Thread wm4
On Fri, 16 Jun 2017 02:32:10 +0200 21na...@gmail.com wrote: > Hello, > > > I would like to know why the tag “DURATION” in Matroska files (.mkv) is > a necessity? Even mkvmerge lets the choice to use it or not with > “--enable-durations”, in addition it is written “Write durations for all > bl

Re: [FFmpeg-devel] Why the tag “DURATION” is a necessity in Matroska files?

2017-06-16 Thread wm4
On Fri, 16 Jun 2017 13:51:20 +0200 21na...@gmail.com wrote: > Le 16/06/2017 à 12:55, wm4 a écrit : > > On Fri, 16 Jun 2017 02:32:10 +0200 > > 21na...@gmail.com wrote: > > > >> Hello, > >> > >> > >> I would like to know why the tag “DUR

Re: [FFmpeg-devel] Why the tag “DURATION” is a necessity in Matroska files?

2017-06-16 Thread wm4
On Fri, 16 Jun 2017 15:43:51 +0200 21na...@gmail.com wrote: > Le 16/06/2017 à 14:25, wm4 a écrit : > > On Fri, 16 Jun 2017 13:51:20 +0200 > > 21na...@gmail.com wrote: > > > >> Le 16/06/2017 à 12:55, wm4 a écrit : > >>> On Fri, 16 Jun 2017 02

Re: [FFmpeg-devel] [PATCH 0/1] ffmpeg: Switch cuvid to generic hwaccel

2017-06-16 Thread wm4
On Fri, 16 Jun 2017 20:31:14 +0200 Timo Rothenpieler wrote: > Am 16.06.2017 um 16:41 schrieb Philip Langdale: > > This is mechanically simple, but does the fact that additional command line > > arguments have to be used to get the same results count as a compatibility > > break? Do we need to fix

Re: [FFmpeg-devel] [PATCH] libavcodec/htmlsubtitles: skip newline characters at the beginning of the subtitle

2017-06-16 Thread wm4
On Fri, 16 Jun 2017 21:30:44 +0300 Evgeny Shulgin wrote: > Info about this patch: > > Working with one video, I noticed that ffmpeg incorrectly extracts out > subtitles. Some subtitles have disappeared. > I have a video file as Matroska (.mkv) container, subtitles are there in > the SubRip (.srt

Re: [FFmpeg-devel] hev1 vs. hvc1

2017-06-19 Thread wm4
On Sun, 18 Jun 2017 13:32:42 + Eran Kornblau wrote: > Hi all, > > We're trying to make ffmpeg output a format tag of 'hvc1' for HEVC, since it > seems that only hvc1 works in iOS 11 beta. > We saw that '-tag:v hvc1' does the trick, but it only works in 'mov' format, > and not in 'mp4' form

Re: [FFmpeg-devel] [PATCH 1/4] ffmpeg: Flush output BSFs when encode reaches EOF

2017-06-19 Thread wm4
On Sun, 18 Jun 2017 23:09:23 +0100 Mark Thompson wrote: > Before this, output bitstream filters would never see EOF and > therefore would not be able to flush any delayed packets. > > (cherry picked from commit f64d1100a54d12c78ce436181bb64229c56da6b3) > --- > ffmpeg.c | 30 +++-

Re: [FFmpeg-devel] Why the tag “DURATION” is a necessity in Matroska files?

2017-06-19 Thread wm4
On Mon, 19 Jun 2017 09:38:19 +0200 Tobias Rapp wrote: > On 19.06.2017 02:04, 21na...@gmail.com wrote: > > Le 18/06/2017 à 00:57, Sasi Inguva a écrit : > >> Hi, > >> > >> I was the one who made that change. We needed a way to obtain individual > >> stream durations from a Matroska file without

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: Set default output format for cuvid hwaccel

2017-06-19 Thread wm4
On Sun, 18 Jun 2017 16:27:30 -0700 Philip Langdale wrote: > The cuvid hwaccel is weird because it's not a real hwaccel. This > means that requesting the hwaccel by itself does nothing as the > right decoder and encoder have to be request to take advantage of > it. > > On the other hand, requesti

Re: [FFmpeg-devel] [PATCH] ffmpeg: remove misleading and incorrect error messages

2017-06-20 Thread wm4
On Sun, 18 Jun 2017 20:41:39 +0200 Paul B Mahol wrote: > On 6/15/17, wm4 wrote: > > Those are warnings, not error messages. Fixed locally. > > ___ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > http://f

Re: [FFmpeg-devel] [PATCH] libavcodec/htmlsubtitles: skip newline characters at the beginning of the subtitle

2017-06-20 Thread wm4
On Fri, 16 Jun 2017 23:40:32 +0300 Evgeny Shulgin wrote: > > Anyway, I don't understand why this makes subtitle lines actually > > disappear? > > Because SubRip format does not allow to have empty lines, that is: > >1. Subtitle text itself on one or more lines >2. A blank line contain

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: Add metadata to identify hardware backed codecs

2017-11-29 Thread wm4
On Mon, 27 Nov 2017 20:46:00 -0800 Philip Langdale wrote: > If hardware acceleration is implemented through an HWAccel, then it's > easy to recognise, but some hardware implementations are best suited > to implementation as full decoders, and these are not easy to identify. > Clients typically ne

Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-11-29 Thread wm4
On Tue, 28 Nov 2017 00:43:25 + Mark Thompson wrote: > ... > > Ok; done, plus some trivial testing to make sure it works. If you're happy > with this and noone else says anything then I'll push it tomorrow. > > Relatedly: your name on patches does not match your full name - I've > preserv

<    1   2   3   4   5   6   7   8   9   10   >