[FFmpeg-devel] [PATCH 5/8] avcodec/mediacodecenc: Remove write only variable

2024-04-16 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavcodec/mediacodecenc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavcodec/mediacodecenc.c b/libavcodec/mediacodecenc.c index e562181120..8caaad729a 100644 --- a/libavcodec/mediacodecenc.c +++ b/libavcodec

[FFmpeg-devel] [PATCH 1/8] configure: Lower Android API level requirement of mediandk

2024-04-16 Thread Zhao Zhili
From: Zhao Zhili AImage_delete is introduced in API level 24, while AMediaFormat_new is introduced in API level 21. We only need API level 21 to support NDK mediacodec. This change doesn't break or change of android_camera_indev since camera2ndk still needs API level 24. --- configure | 2

[FFmpeg-devel] [PATCH 2/8] avcodec/mediacodec_wrapper: link to NDK mediacodec API directly

2024-04-16 Thread Zhao Zhili
From: Zhao Zhili Drop support of Android version before 5.0. --- configure | 2 +- libavcodec/mediacodec_wrapper.c | 164 +++- 2 files changed, 36 insertions(+), 130 deletions(-) diff --git a/configure b/configure index 47ec215f8c..d0d0e8430b

[FFmpeg-devel] [PATCH 6/8] avcodec/mediacodecenc: Add global header support

2024-04-16 Thread Zhao Zhili
From: Zhao Zhili The extradata is generated by encoding a dummy frame, then reset the encoder state by mediacodec flush(). It only works for pixel format other than AV_PIX_FMT_MEDIACODEC, since I'm not sure how to create a dummy frame safely with AV_PIX_FMT_MEDIACODEC. Signed-off-by: Zhao

[FFmpeg-devel] [PATCH 7/8] avcodec/mediacodecenc: add AV_CODEC_CAP_ENCODER_FLUSH support

2024-04-16 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavcodec/mediacodecenc.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/libavcodec/mediacodecenc.c b/libavcodec/mediacodecenc.c index 64816ccf0a..c87a0d86c5 100644 --- a/libavcodec/mediacodecenc.c +++ b

[FFmpeg-devel] [PATCH 8/8] fftools: Fix implicit-const-int-float-conversion warning

2024-04-16 Thread Zhao Zhili
From: Zhao Zhili --- fftools/cmdutils.c | 2 +- fftools/ffmpeg_opt.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 2120fc7935..a8f5c6d89b 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -311,7 +311,7 @@ static

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-04-19 Thread Zhao Zhili
> -Original Message- > From: ffmpeg-devel On Behalf Of Niklas Haas > Sent: 2024年4月19日 22:50 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation > > On Thu, 18 Apr 2024 22:53:51 +0200 Michael Niedermayer > wrote: > > A plugin sys

[FFmpeg-devel] [PATCH] avcodec/mediacodecenc: Flush bsf after create extradata

2024-04-23 Thread Zhao Zhili
From: Zhao Zhili Avoid leaving any data inside bsf while also avoid keep bsf in EOF state. --- libavcodec/mediacodecenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/mediacodecenc.c b/libavcodec/mediacodecenc.c index c87a0d86c5..bbf570e7be 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH WIP 0/9] Refactor DNN

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili During the refactor progress, I have found some serious issues, which is not resolved by the patchset: 1. Tensorflow backend is broken. I think it doesn't work since 2021 at least. For example, it destroy a thread and create a new thread for each frame, and it destr

[FFmpeg-devel] [PATCH WIP 2/9] avfilter/dnn_backend_openvino: Fix free context at random place

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili It will be freed again by ff_dnn_uninit. --- libavfilter/dnn/dnn_backend_openvino.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index c4b0682f11..769ba0a54b 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH WIP 1/9] avfilter/dnn: Refactor DNN parameter configuration system

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili This patch trying to resolve mulitiple issues related to parameter configuration: Firstly, each DNN filters duplicate DNN_COMMON_OPTIONS, which should be the common options of backend. Secondly, backend options are hidden behind the scene. It's a AV_OPT_TYPE_S

[FFmpeg-devel] [PATCH WIP 6/9] avfilter/dnn_backend_tf: Simplify memory allocation

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 33 +--- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 3b4de6d13f..c7716e696d 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH WIP 3/9] avfilter/dnn_backend_openvino: simplify memory allocation

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 47 +++--- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 769ba0a54b..1acc54b791 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH WIP 5/9] avfilter/dnn_backend_tf: Fix free context at random place

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili It will be freed again by ff_dnn_uninit. --- libavfilter/dnn/dnn_backend_tf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 60f9e57fb7..3b4de6d13f 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH WIP 4/9] avfilter/dnn_backend_tf: Remove one level of indentation

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 63 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index d24591b90b..60f9e57fb7 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH WIP 8/9] avfilter/dnn: Remove a level of dereference

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili For code such as 'model->model = ov_model' is confusing. We can just drop the member variable and use cast to get the subclass. --- libavfilter/dnn/dnn_backend_openvino.c | 17 - libavfilter/dnn/dnn_backend_tf.c | 19 +-- li

[FFmpeg-devel] [PATCH WIP 7/9] avfilter/dnn_backend_torch: Simplify memory allocation

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_torch.cpp | 31 +++ 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_torch.cpp b/libavfilter/dnn/dnn_backend_torch.cpp index abdef1f178..818ec5b713 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH WIP 9/9] avfilter/dnn: Use dnn_backend_info_list to search for dnn module

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 1 + libavfilter/dnn/dnn_backend_tf.c | 1 + libavfilter/dnn/dnn_backend_torch.cpp | 1 + libavfilter/dnn/dnn_interface.c| 26 -- libavfilter/dnn_interface.h| 1 + 5 files

[FFmpeg-devel] [PATCH WIP v2 8/9] avfilter/dnn: Remove a level of dereference

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili For code such as 'model->model = ov_model' is confusing. We can just drop the member variable and use cast to get the subclass. --- libavfilter/dnn/dnn_backend_openvino.c | 17 - libavfilter/dnn/dnn_backend_tf.c | 19 +-- li

[FFmpeg-devel] [PATCH WIP v2 7/9] avfilter/dnn_backend_torch: Simplify memory allocation

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_torch.cpp | 31 +++ 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_torch.cpp b/libavfilter/dnn/dnn_backend_torch.cpp index abdef1f178..818ec5b713 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH WIP v2 3/9] avfilter/dnn_backend_openvino: simplify memory allocation

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 47 +++--- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 769ba0a54b..1acc54b791 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH WIP v2 4/9] avfilter/dnn_backend_tf: Remove one level of indentation

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 63 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index d24591b90b..60f9e57fb7 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH WIP v2 9/9] avfilter/dnn: Use dnn_backend_info_list to search for dnn module

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 1 + libavfilter/dnn/dnn_backend_tf.c | 1 + libavfilter/dnn/dnn_backend_torch.cpp | 1 + libavfilter/dnn/dnn_interface.c| 26 -- libavfilter/dnn_interface.h| 1 + 5 files

[FFmpeg-devel] [PATCH WIP v2 2/9] avfilter/dnn_backend_openvino: Fix free context at random place

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili It will be freed again by ff_dnn_uninit. --- libavfilter/dnn/dnn_backend_openvino.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index c4b0682f11..769ba0a54b 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH WIP v2 1/9] avfilter/dnn: Refactor DNN parameter configuration system

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili This patch trying to resolve mulitiple issues related to parameter configuration: Firstly, each DNN filters duplicate DNN_COMMON_OPTIONS, which should be the common options of backend. Secondly, backend options are hidden behind the scene. It's a AV_OPT_TYPE_S

[FFmpeg-devel] [PATCH WIP v2 5/9] avfilter/dnn_backend_tf: Fix free context at random place

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili It will be freed again by ff_dnn_uninit. --- libavfilter/dnn/dnn_backend_tf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 60f9e57fb7..3b4de6d13f 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH WIP v2 6/9] avfilter/dnn_backend_tf: Simplify memory allocation

2024-04-27 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 33 +--- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 3b4de6d13f..c7716e696d 100644 --- a/libavfilter/dnn

Re: [FFmpeg-devel] [PATCH WIP 0/9] Refactor DNN

2024-04-28 Thread Zhao Zhili
> On Apr 28, 2024, at 18:34, Guo, Yejun > wrote: > >> -Original Message- >> From: ffmpeg-devel > <mailto:ffmpeg-devel-boun...@ffmpeg.org>> On Behalf Of Zhao >> Zhili >> Sent: Sunday, April 28, 2024 12:42 AM >> To: ffmpeg-devel@ffmp

Re: [FFmpeg-devel] [PATCH WIP 0/9] Refactor DNN

2024-04-28 Thread Zhao Zhili
> On Apr 28, 2024, at 18:58, Paul B Mahol wrote: > > Extremely low quality filters, both in source code quality and > performance/security and output quality should be queued for removal. I don’t think there is any replacement for the function provided by dnn_detect, which is very important for

Re: [FFmpeg-devel] [PATCH WIP 0/9] Refactor DNN

2024-04-29 Thread Zhao Zhili
> On Apr 29, 2024, at 18:29, Guo, Yejun > wrote: > > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Zhao >> Zhili >> Sent: Sunday, April 28, 2024 6:55 PM >> To: FFmpeg development discussions and patches > de...@ffmpeg.or

[FFmpeg-devel] [PATCH v3 00/10] Refactor DNN

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili v3: 1. Init class with ff_dnn_filter_init_child_class and called by AVFilter preinit. 2. Fix crash in vf_dnn_detect (patch 10/10). Zhao Zhili (10): avfilter/dnn: Refactor DNN parameter configuration system avfilter/dnn_backend_openvino: Fix free context at random place

[FFmpeg-devel] [PATCH v3 03/10] avfilter/dnn_backend_openvino: simplify memory allocation

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 47 +++--- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 769ba0a54b..1acc54b791 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH v3 04/10] avfilter/dnn_backend_tf: Remove one level of indentation

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 63 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index d24591b90b..60f9e57fb7 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH v3 02/10] avfilter/dnn_backend_openvino: Fix free context at random place

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili It will be freed again by ff_dnn_uninit. --- libavfilter/dnn/dnn_backend_openvino.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index c4b0682f11..769ba0a54b 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH v3 06/10] avfilter/dnn_backend_tf: Simplify memory allocation

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 33 +--- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 3b4de6d13f..c7716e696d 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH v3 01/10] avfilter/dnn: Refactor DNN parameter configuration system

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili This patch trying to resolve mulitiple issues related to parameter configuration: Firstly, each DNN filters duplicate DNN_COMMON_OPTIONS, which should be the common options of backend. Secondly, backend options are hidden behind the scene. It's a AV_OPT_TYPE_S

[FFmpeg-devel] [PATCH v3 08/10] avfilter/dnn: Remove a level of dereference

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili For code such as 'model->model = ov_model' is confusing. We can just drop the member variable and use cast to get the subclass. --- libavfilter/dnn/dnn_backend_openvino.c | 17 - libavfilter/dnn/dnn_backend_tf.c | 19 +-- li

[FFmpeg-devel] [PATCH v3 05/10] avfilter/dnn_backend_tf: Fix free context at random place

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili It will be freed again by ff_dnn_uninit. --- libavfilter/dnn/dnn_backend_tf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 60f9e57fb7..3b4de6d13f 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH v3 07/10] avfilter/dnn_backend_torch: Simplify memory allocation

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_torch.cpp | 31 +++ 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_torch.cpp b/libavfilter/dnn/dnn_backend_torch.cpp index abdef1f178..818ec5b713 100644 --- a/libavfilter/dnn

[FFmpeg-devel] [PATCH v3 09/10] avfilter/dnn: Use dnn_backend_info_list to search for dnn module

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 1 + libavfilter/dnn/dnn_backend_tf.c | 1 + libavfilter/dnn/dnn_backend_torch.cpp | 1 + libavfilter/dnn/dnn_interface.c| 26 -- libavfilter/dnn_interface.h| 1 + 5 files

[FFmpeg-devel] [PATCH v3 10/10] avfilter/vf_dnn_detect: Fix null pointer dereference

2024-04-30 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/vf_dnn_detect.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_dnn_detect.c b/libavfilter/vf_dnn_detect.c index 926966368a..1830bae181 100644 --- a/libavfilter/vf_dnn_detect.c +++ b/libavfilter/vf_dnn_detect.c

Re: [FFmpeg-devel] [PATCH WIP v2 1/9] avfilter/dnn: Refactor DNN parameter configuration system

2024-04-30 Thread Zhao Zhili
> On Apr 30, 2024, at 13:54, Chen, Wenbin > wrote: > >> -Original Message- >> From: ffmpeg-devel On Behalf Of Zhao >> Zhili >> Sent: Sunday, April 28, 2024 2:47 PM >> To: ffmpeg-devel@ffmpeg.org >> Cc: Zhao Zhili >> Subject: [FFmp

Re: [FFmpeg-devel] [PATCH v4 3/4] all: Link to "context" from all contexts with documentation

2024-05-02 Thread Zhao Zhili
> On May 2, 2024, at 19:01, Lynne wrote: > > Apr 29, 2024, 11:24 by ffmpeg-de...@pileofstuff.org: > >> Some headings needed to be rewritten to accomodate the text, >> (hopefully) without changing the meaning. >> --- >> libavcodec/aac/aacdec.h| 2 +- >> libavcodec/aacenc.h

Re: [FFmpeg-devel] [PATCH v4 3/4] all: Link to "context" from all contexts with documentation

2024-05-02 Thread Zhao Zhili
> On May 2, 2024, at 21:27, Andrew Sayers wrote: > > On Thu, May 02, 2024 at 09:00:42PM +0800, Zhao Zhili wrote: >> >> >>> On May 2, 2024, at 19:01, Lynne wrote: >>> >>> Apr 29, 2024, 11:24 by ffmpeg-de...@pileofstuff.org: >>> &g

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-05-02 Thread Zhao Zhili
> -Original Message- > From: ffmpeg-devel On Behalf Of Ondřej Fiala > Sent: 2024年5月2日 22:25 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation > > On Wed May 1, 2024 at 7:27 AM CEST, Rémi Denis-Courmont wrote: > > Le 30 avril 202

Re: [FFmpeg-devel] [RFC] 5 year plan & Inovation

2024-05-04 Thread Zhao Zhili
> 在 2024年5月5日,上午5:51,epira...@gmail.com 写道: > >  > >> On 4 May 2024, at 23:25, Andrew Sayers wrote: >> >>> On Sat, May 04, 2024 at 09:28:03PM +0200, Michael Niedermayer wrote: >>> Hi >>> On Fri, May 03, 2024 at 03:45:20PM +, Cosmin Stejerean via ffmpeg-devel wrote: >>> [...] >>

Re: [FFmpeg-devel] [PATCH v3 01/10] avfilter/dnn: Refactor DNN parameter configuration system

2024-05-06 Thread Zhao Zhili
> On May 6, 2024, at 19:48, Guo, Yejun > wrote: > >> -Original Message- >> From: ffmpeg-devel > <mailto:ffmpeg-devel-boun...@ffmpeg.org>> On Behalf Of Zhao >> Zhili >> Sent: Tuesday, April 30, 2024 3:12 PM >> To: ffmpeg-devel@ffmp

[FFmpeg-devel] [PATCH v4 02/11] avfilter/dnn: Use dnn_backend_info_list to search for dnn module

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 1 + libavfilter/dnn/dnn_backend_tf.c | 1 + libavfilter/dnn/dnn_backend_torch.cpp | 1 + libavfilter/dnn/dnn_interface.c| 26 -- libavfilter/dnn_interface.h

[FFmpeg-devel] [PATCH v4 00/11] Refactor DNN

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili v4: 1. Move [patch v3 9/10] to [patch v4 2/11], since patch 3 depends on it. 2. Don't show backends which are not supported by a filter (patch 3). v3: 1. Init class with ff_dnn_filter_init_child_class and called by AVFilter preinit. 2. Fix crash in vf_dnn_detect (patch

[FFmpeg-devel] [PATCH v4 03/11] avfilter/dnn: Don't show backends which are not supported by a filter

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili --- libavfilter/dnn/dnn_interface.c | 11 --- libavfilter/dnn_filter_common.h | 11 +-- libavfilter/dnn_interface.h | 8 ++-- libavfilter/vf_derain.c | 2 +- libavfilter/vf_dnn_classify.c | 2 +- libavfilter/vf_dnn_detect.c | 2

[FFmpeg-devel] [PATCH v4 04/11] avfilter/dnn_backend_openvino: Fix free context at random place

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili It will be freed again by ff_dnn_uninit. Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index 5ea8fb8d1f..ba79eba73f

[FFmpeg-devel] [PATCH v4 01/11] avfilter/dnn: Refactor DNN parameter configuration system

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili This patch trying to resolve mulitiple issues related to parameter configuration: Firstly, each DNN filters duplicate DNN_COMMON_OPTIONS, which should be the common options of backend. Secondly, backend options are hidden behind the scene. It's a AV_OPT_TYPE_S

[FFmpeg-devel] [PATCH v4 07/11] avfilter/dnn_backend_tf: Fix free context at random place

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili It will be freed again by ff_dnn_uninit. Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index eb4a2a5289..8b53a3b87a 100644

[FFmpeg-devel] [PATCH v4 08/11] avfilter/dnn_backend_tf: Simplify memory allocation

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 33 +--- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 8b53a3b87a..583ebd7c13 100644 --- a

[FFmpeg-devel] [PATCH v4 09/11] avfilter/dnn_backend_torch: Simplify memory allocation

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_torch.cpp | 31 +++ 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_torch.cpp b/libavfilter/dnn/dnn_backend_torch.cpp index b70e4db600..0aa0b95269

[FFmpeg-devel] [PATCH v4 06/11] avfilter/dnn_backend_tf: Remove one level of indentation

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_tf.c | 63 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index 0ab3bd13ed..eb4a2a5289 100644 --- a

[FFmpeg-devel] [PATCH v4 05/11] avfilter/dnn_backend_openvino: simplify memory allocation

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 47 +++--- 1 file changed, 20 insertions(+), 27 deletions(-) diff --git a/libavfilter/dnn/dnn_backend_openvino.c b/libavfilter/dnn/dnn_backend_openvino.c index ba79eba73f..1a5ed6383a

[FFmpeg-devel] [PATCH v4 11/11] avfilter/vf_dnn_detect: Fix null pointer dereference

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavfilter/vf_dnn_detect.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_dnn_detect.c b/libavfilter/vf_dnn_detect.c index b4eee06fe7..2a277d4169 100644 --- a/libavfilter/vf_dnn_detect.c +++ b

[FFmpeg-devel] [PATCH v4 10/11] avfilter/dnn: Remove a level of dereference

2024-05-07 Thread Zhao Zhili
From: Zhao Zhili For code such as 'model->model = ov_model' is confusing. We can just drop the member variable and use cast to get the subclass. Signed-off-by: Zhao Zhili --- libavfilter/dnn/dnn_backend_openvino.c | 17 - libavfilter/dnn/dnn_backend_tf

Re: [FFmpeg-devel] [PATCH v3 01/10] avfilter/dnn: Refactor DNN parameter configuration system

2024-05-07 Thread Zhao Zhili
On 2024/5/6 21:42, Zhao Zhili wrote: On May 6, 2024, at 19:48, Guo, Yejun wrote: -Original Message- From: ffmpeg-devel On Behalf Of Zhao Zhili Sent: Tuesday, April 30, 2024 3:12 PM To: ffmpeg-devel@ffmpeg.org Cc: Zhao Zhili Subject: [FFmpeg-devel] [PATCH v3 01/10] avfilter/dnn

[FFmpeg-devel] [PATCH] avfilter/src_movie: Remove align dimension to fix crash

2024-05-10 Thread Zhao Zhili
From: Zhao Zhili The alignment is handled by ff_default_get_video_buffer2. We shouldn't use the aligned width/height as FFFramePool width/height. It cause recreate FFFramePool inside ff_default_get_video_buffer2. The recreate of FFFramePool together with multi-threads decoding leading to

[FFmpeg-devel] [RFC PATCH] avfilter/video: Protect frame_pool from multi-threads access

2024-05-10 Thread Zhao Zhili
From: Zhao Zhili Fix crash with ./ffplay -f lavfi -i movie=foo.mp4,drawtext=text=bar --- libavfilter/avfilter.c | 2 ++ libavfilter/avfilter_internal.h | 2 ++ libavfilter/video.c | 14 -- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a

Re: [FFmpeg-devel] [RFC PATCH] avfilter/video: Protect frame_pool from multi-threads access

2024-05-10 Thread Zhao Zhili
> On May 10, 2024, at 16:57, Zhao Zhili wrote: > > From: Zhao Zhili > > Fix crash with > ./ffplay -f lavfi -i movie=foo.mp4,drawtext=text=bar This is an RFC because I’m not sure whether it’s a valid use case or not to call ff_default_get_video_buffer2 from multiple th

[FFmpeg-devel] [PATCH] avformat/libsrt: Remove manually free AV_OPT_TYPE_STRING

2024-02-14 Thread Zhao Zhili
From: Zhao Zhili Signed-off-by: Zhao Zhili --- libavformat/libsrt.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index 56acb6e741..a1d732f841 100644 --- a/libavformat/libsrt.c +++ b/libavformat/libsrt.c @@ -674,9 +674,6 @@ static int

Re: [FFmpeg-devel] Add protocol for Android content providers

2024-02-14 Thread Zhao Zhili
> On Feb 14, 2024, at 06:50, Matthieu Bouron wrote: > > Hi, > > On Android, content providers are used for accessing files through shared > mechanisms. One typical case would be an app willing to open a video from > Google Photos, gallery apps, TikTok, Instagram or some other providers. > A co

Re: [FFmpeg-devel] Add protocol for Android content providers

2024-02-15 Thread Zhao Zhili
> 在 2024年2月15日,下午3:57,Matthieu Bouron 写道: > > On Thu, Feb 15, 2024 at 12:13:59PM +0800, Zhao Zhili wrote: >> >> >>>> On Feb 14, 2024, at 06:50, Matthieu Bouron >>>> wrote: >>> >>> Hi, >>> >>> On Android,

Re: [FFmpeg-devel] [PATCH] fate: use an even more exotic channel layout mov-mp4-pcm-float test

2024-02-18 Thread Zhao Zhili
> 在 2024年2月18日,下午6:45,Marton Balint 写道: > > The old layout happened to be a native layout and therefore missed some > recently fixed layout parsing bugs. > > Signed-off-by: Marton Balint > --- > tests/fate/mov.mak | 2 +- > tests/ref/fate/mov-mp4-pcm-float | 4 ++-- > 2 files chan

[FFmpeg-devel] [PATCH] fftools/ffplay: Fix output color_spaces of filter

2024-02-19 Thread Zhao Zhili
From: Zhao Zhili The sdl_supported_color_spaces only meant for SDL builtin renderer. --- fftools/ffplay.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 53e6fc0514..5b54fab492 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c

[FFmpeg-devel] [PATCH 1/5] avutil/hwcontext: Don't assume device_uninit is reentrant

2024-02-20 Thread Zhao Zhili
device_uninit will be called by hwdevice_ctx_free. vulkan_device_uninit is non-reentrant. --- libavutil/hwcontext.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/libavutil/hwcontext.c b/libavutil/hwcontext.c index e23bad230f..e8c6256a73 100644 --- a/libavutil/hwco

[FFmpeg-devel] [PATCH 2/5] avutil/hwcontext: Don't assume frames_uninit is reentrant

2024-02-20 Thread Zhao Zhili
From: Zhao Zhili Fix heap use after free when vulkan_frames_init failed. --- libavutil/hwcontext.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libavutil/hwcontext.c b/libavutil/hwcontext.c index e8c6256a73..dec8b84783 100644 --- a/libavutil/hwcontext.c +++ b

[FFmpeg-devel] [PATCH 5/5] avutil/vulkan: avoid overreads in ff_vk_count_images

2024-02-20 Thread Zhao Zhili
From: Zhao Zhili --- libavutil/vulkan.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/vulkan.h b/libavutil/vulkan.h index b666841836..a5e78760d7 100644 --- a/libavutil/vulkan.h +++ b/libavutil/vulkan.h @@ -271,7 +271,7 @@ typedef struct FFVulkanContext { static

[FFmpeg-devel] [PATCH 4/5] avutil/hwcontext_vulkan: Fix leaks in map_from_drm

2024-02-20 Thread Zhao Zhili
From: Zhao Zhili Also simplify error handing. --- This patch is untested since I don't have a proper device. libavutil/hwcontext_vulkan.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c

[FFmpeg-devel] [PATCH 3/5] avutil/hwcontext_vulkan: Fix leaks when semaphore creation fails

2024-02-20 Thread Zhao Zhili
From: Zhao Zhili --- libavutil/hwcontext_vulkan.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index a84713e621..c64094f31c 100644 --- a/libavutil/hwcontext_vulkan.c +++ b

Re: [FFmpeg-devel] [PATCH 3/5] avutil/hwcontext_vulkan: Fix leaks when semaphore creation fails

2024-02-20 Thread Zhao Zhili
I found serious memory leaks (dozens of frames depends on video filter) when test vulkan, which may or may not directly related to vulkan. See trac 10873. > 在 2024年2月20日,下午8:08,Zhao Zhili 写道: > > From: Zhao Zhili > > --- > libavutil/hwcon

[FFmpeg-devel] [PATCH] avutil/hwcontext_vulkan: Fix memleaks when transfer to vulkan

2024-02-20 Thread Zhao Zhili
From: Zhao Zhili Without ff_vk_exec_discard_deps which is called by ff_vk_exec_wait, the reference count of hwframe context cannot reach zero due to circular reference created by ff_vk_exec_add_dep_frame. Fix #10873 --- libavutil/hwcontext_vulkan.c | 4 +--- 1 file changed, 1 insertion(+), 3

Re: [FFmpeg-devel] [PATCH 3/5] avutil/hwcontext_vulkan: Fix leaks when semaphore creation fails

2024-02-20 Thread Zhao Zhili
On 2024/2/21 01:10, Lynne wrote: Feb 20, 2024, 13:10 by quinkbl...@foxmail.com: From: Zhao Zhili --- libavutil/hwcontext_vulkan.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil

Re: [FFmpeg-devel] [RFC] fate rsync switch to git

2024-02-20 Thread Zhao Zhili
> On Feb 21, 2024, at 09:39, Jean-Baptiste Kempf wrote: > > Yo, > > On Tue, 20 Feb 2024, at 15:31, Michael Niedermayer wrote: >> I did hear (at fosdem?) >> about the idea to switch from rsync to git for managing the fate samples >> i thought the idea sounds interresting but isnt rsync more eff

[FFmpeg-devel] [PATCH] avcodec/evc: Remove redefine of HEVC_MAX_ENTRY_POINT_OFFSETS

2024-02-21 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/evc.h | 9 - 1 file changed, 9 deletions(-) diff --git a/libavcodec/evc.h b/libavcodec/evc.h index 9711c760fe..e493455a42 100644 --- a/libavcodec/evc.h +++ b/libavcodec/evc.h @@ -141,15 +141,6 @@ enum { // A.4.1: table A.1 allows at most 600 slice

[FFmpeg-devel] [PATCH 1/2] avformat/mov: Update bits_per_coded_sample after read pcmC

2024-02-22 Thread Zhao Zhili
From: Zhao Zhili Fix #10878 --- libavformat/mov.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 1a1b104615..8c03c35c13 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -1890,6 +1890,7 @@ static int mov_read_pcmc(MOVContext *c

[FFmpeg-devel] [PATCH 2/2] avcodec/encode: Fix default setting of bits_per_raw_sample

2024-02-22 Thread Zhao Zhili
From: Zhao Zhili bits_per_raw_sample doesn't always match size of AV_SAMPLE_FMT_, e.g., S24. --- libavcodec/encode.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index a436be2657..8ca07814ee 100644 --- a/libavcodec/encode.c +++ b/libav

[FFmpeg-devel] [PATCH v2 3/5] avutil/hwcontext_vulkan: Fix leaks when semaphore creation fails

2024-02-22 Thread Zhao Zhili
From: Zhao Zhili --- libavutil/hwcontext_vulkan.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/libavutil/hwcontext_vulkan.c b/libavutil/hwcontext_vulkan.c index d660f63afe..ee13788ead 100644 --- a/libavutil/hwcontext_vulkan.c +++ b/libavutil

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread Zhao Zhili
> 在 2024年2月23日,上午4:19,Gnattu OC via ffmpeg-devel 写道: > > Actually, if you examine the `hwcontext_videotoolbox.c` file, you will find > that the current function for `vt_device_create` is essentially a no-op: it > only returns an error if a user attempts to select a device, otherwise it > jus

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread Zhao Zhili
> 在 2024年2月23日,上午9:20,Zhao Zhili 写道: > >  >> 在 2024年2月23日,上午4:19,Gnattu OC via ffmpeg-devel 写道: >> >> Actually, if you examine the `hwcontext_videotoolbox.c` file, you will find >> that the current function for `vt_device_create` is essentially a no-op:

[FFmpeg-devel] [PATCH] avfilter/vf_scale_vulkan: Fix typo

2024-02-22 Thread Zhao Zhili
From: Zhao Zhili Fix #10875 --- libavfilter/vf_scale_vulkan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_scale_vulkan.c b/libavfilter/vf_scale_vulkan.c index a1cf8b1aeb..7210509de3 100644 --- a/libavfilter/vf_scale_vulkan.c +++ b/libavfilter

[FFmpeg-devel] [PATCH 1/2] avutil/hwcontext_opencl: Fix missing linesize when map from opencl

2024-02-23 Thread Zhao Zhili
From: Zhao Zhili --- libavutil/hwcontext_opencl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/hwcontext_opencl.c b/libavutil/hwcontext_opencl.c index c1764ed098..de093fffb1 100644 --- a/libavutil/hwcontext_opencl.c +++ b/libavutil/hwcontext_opencl.c @@ -2014,6 +2014,7

[FFmpeg-devel] [PATCH 2/2] avutil/hwcontext_opencl: Add map from Videotoolbox to OpenCL

2024-02-23 Thread Zhao Zhili
From: Zhao Zhili For example: ./ffmpeg -hwaccel videotoolbox \ -hwaccel_output_format videotoolbox_vld \ -i foo.mp4 \ -vf hwmap=derive_device=opencl,transpose_opencl=dir=clock,hwmap,format=nv12 \ -c:v hevc_videotoolbox \ -c:a copy \ -b:v 2M -tag:v

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-23 Thread Zhao Zhili
___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-23 Thread Zhao Zhili
> 在 2024年2月23日,下午7:26,Gyan Doshi 写道: > >  > >> On 2024-02-23 01:26 pm, Nicolas George wrote: >> Anton Khirnov (12024-02-22): >>> In my updated proposal, based on comments by Niklas and Rémi, I'm >>> leaving it up to the TC member in question, based on the assumption that >>> TC members are hon

Re: [FFmpeg-devel] [PATCH v2 1/2] avdevice: deprecate opengl outdev

2024-02-26 Thread Zhao Zhili
> 在 2024年2月27日,上午12:47,Jan Ekström 写道: > > On Wed, Feb 21, 2024 at 1:34 PM J. Dekker wrote: >> >> Signed-off-by: J. Dekker >> --- >> doc/outdevs.texi| 2 +- >> libavdevice/opengl_enc.c| 11 +++ >> libavdevice/version_major.h | 2 ++ >> 3 files changed, 14 insertions(+)

Re: [FFmpeg-devel] Add protocol for Android content providers

2024-02-27 Thread Zhao Zhili
> On Feb 27, 2024, at 15:17, Matthieu Bouron wrote: > > On Sat, Feb 24, 2024 at 12:29:24PM +0100, Matthieu Bouron wrote: >> On Thu, Feb 15, 2024 at 10:13:03AM +0100, Matthieu Bouron wrote: >>> Le jeu. 15 févr. 2024, 9:46 AM, Zhao Zhili a >>> écrit : >

[FFmpeg-devel] [ infra] Does main server hang?

2024-02-29 Thread Zhao Zhili
Hi, I can't pull from main developer git server. Patchwork is slow to loading. I have tried two ISP. Anything happened? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link abo

[FFmpeg-devel] [PATCH] avcodec/mediacodecenc: Add a hint message to use nv12 pix_fmt

2024-03-03 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/mediacodecenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/mediacodecenc.c b/libavcodec/mediacodecenc.c index 086b545590..984014f1b1 100644 --- a/libavcodec/mediacodecenc.c +++ b/libavcodec/mediacodecenc.c @@ -319,6 +319,9 @@ static av_cold

[FFmpeg-devel] [RFC]x264 avcc and related issue

2024-03-05 Thread Zhao Zhili
There are multiple encoders which can output bitstream in avcc/hvcc format, e.g, x264, x265 and videotoolbox. This can improve performance depends on container format (no more ff_avc_parse_nal_units_buf). The problem is these encoders output parameter sets directly, not contained in a complete AV

Re: [FFmpeg-devel] [RFC]x264 avcc and related issue

2024-03-05 Thread Zhao Zhili
> 在 2024年3月6日,上午1:58,Andreas Rheinhardt 写道: > > Zhao Zhili: >> There are multiple encoders which can output bitstream in avcc/hvcc format, >> e.g, x264, x265 and videotoolbox. This can improve performance depends on >> container format (no more ff_avc_parse_nal_uni

[FFmpeg-devel] [PATCH] avcodec/libx264: fix extradata when config annexb=0

2024-03-06 Thread Zhao Zhili
From: Zhao Zhili --- configure| 2 +- libavcodec/libx264.c | 148 --- 2 files changed, 125 insertions(+), 25 deletions(-) diff --git a/configure b/configure index bbf1a70731..ef58c3fe97 100755 --- a/configure +++ b/configure @@ -3491,7

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: fix extradata when config annexb=0

2024-03-06 Thread Zhao Zhili
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: 2024年3月6日 22:19 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: fix extradata when > config annexb=0 > > Zhao

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: fix extradata when config annexb=0

2024-03-06 Thread Zhao Zhili
> -Original Message- > From: ffmpeg-devel On Behalf Of Andreas > Rheinhardt > Sent: 2024年3月7日 0:24 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libx264: fix extradata when > config annexb=0 > > Zhao Zhili: > &g

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-06 Thread Zhao Zhili
> On Mar 7, 2024, at 07:25, Michael Niedermayer via ffmpeg-devel > wrote: > > On Tue, Mar 05, 2024 at 11:27:22AM +0100, Anton Khirnov wrote: >> Quoting Michael Niedermayer (2024-03-05 03:50:01) >>> The STF opertunity had a deadline. >>> Also we can already start discussing what shall be done w

[FFmpeg-devel] [PATCH v2] avcodec/libx264: fix extradata when config annexb=0

2024-03-07 Thread Zhao Zhili
From: Zhao Zhili --- configure| 2 +- libavcodec/libx264.c | 134 +++ 2 files changed, 111 insertions(+), 25 deletions(-) diff --git a/configure b/configure index db7dc89755..24cb897d28 100755 --- a/configure +++ b/configure @@ -3491,7

[FFmpeg-devel] [PATCH v3] avcodec/libx264: fix extradata when config annexb=0

2024-03-11 Thread Zhao Zhili
From: Zhao Zhili --- v3: Remove unnecessary inclusion configure| 2 +- libavcodec/libx264.c | 132 +++ 2 files changed, 109 insertions(+), 25 deletions(-) diff --git a/configure b/configure index db7dc89755..24cb897d28 100755 --- a

<    1   2   3   4   5   6   7   8   9   10   >