Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: fix HT block decoder

2024-05-19 Thread Pierre-Anthony Lemieux
On Sun, May 19, 2024 at 9:02 AM Andreas Rheinhardt wrote: > > p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > Addresses https://trac.ffmpeg.org/ticket/10905 > > > > Co-authored-by: Osamu Watanabe > > Signed-off-by: Pierre-Ant

Re: [FFmpeg-devel] [RFC PATCH 2/2] tests/fate/source-check: Relax BSD licence check

2024-05-25 Thread Pierre-Anthony Lemieux
On Wed, May 22, 2024 at 4:38 AM Andreas Rheinhardt wrote: > > Several files already had standard license header (namely > 2-clause BSD files), yet due to the 80 char line length limit, > they were not treated as such by source-check.sh (which > fate-source uses). Therefore relax the BSD check. LG

Re: [FFmpeg-devel] [RFC PATCH] all: Adapt BSD license headers to avoid fate-source exceptions

2024-05-25 Thread Pierre-Anthony Lemieux
On Sat, May 25, 2024 at 7:57 AM Andreas Rheinhardt wrote: > > Andreas Rheinhardt: > > This is against the 80 char line length limit, but it is not > > a hard rule anyway. > > > > Signed-off-by: Andreas Rheinhardt > > --- > > This is an alternative to modifying check-source.sh (for which I also >

Re: [FFmpeg-devel] [PATCH v3] avcodec/jpeg2000dec: fix HT block decoder

2024-05-27 Thread Pierre-Anthony Lemieux
Will apply on 5/30 unless I hear otherwise. On Mon, May 27, 2024 at 9:25 AM wrote: > > From: Pierre-Anthony Lemieux > > Addresses https://trac.ffmpeg.org/ticket/10905 > > Co-authored-by: Osamu Watanabe > Signed-off-by: Pierre-Anthony Lemieux > --- >

Re: [FFmpeg-devel] [PATCH] configure: correct libopenjpeg description

2024-05-31 Thread Pierre-Anthony Lemieux
On Fri, May 31, 2024 at 8:32 AM Gyan Doshi wrote: > > Decoding is no longer possible as the decoder wrapper was removed > in 60ccb3fe78 > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 96b181fd21..6c5b8aab9a 100755 > --- a/co

Re: [FFmpeg-devel] [PATCH 3/9] avformat/imfdec: Simplify get_next_track_with_minimum_timestamp()

2024-06-02 Thread Pierre-Anthony Lemieux
LGTM On Sun, Jun 2, 2024 at 7:16 PM Michael Niedermayer wrote: > > This also makes the code more robust > > Fixes: CID1512414 Uninitialized pointer read > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavformat/imfdec.c | 5 + > 1 file changed, 1 inserti

Re: [FFmpeg-devel] [PATCH] configure: remove false positives with valgrind-memcheck

2024-06-08 Thread Pierre-Anthony Lemieux
On Sat, Jun 8, 2024 at 6:13 PM James Almer wrote: > > On 6/8/2024 9:59 PM, p...@sandflow.com wrote: > > From: Pierre-Anthony Lemieux > > > > If `--toolchain=valgrind-memcheck` is selected, fate-lavf-asf fails on a > > false positive. > > I can't

Re: [FFmpeg-devel] [PATCH] configure: remove false positives with valgrind-memcheck

2024-06-09 Thread Pierre-Anthony Lemieux
On Sun, Jun 9, 2024 at 6:41 AM James Almer wrote: > > On 6/9/2024 2:56 AM, Pierre-Anthony Lemieux wrote: > > On Sat, Jun 8, 2024 at 6:13 PM James Almer wrote: > >> > >> On 6/8/2024 9:59 PM, p...@sandflow.com wrote: > >>> From: Pierre-Anthony Lemi

Re: [FFmpeg-devel] [PATCH] configure: remove false positives with valgrind-memcheck

2024-06-13 Thread Pierre-Anthony Lemieux
On Sun, Jun 9, 2024 at 9:00 AM Pierre-Anthony Lemieux wrote: > > On Sun, Jun 9, 2024 at 6:41 AM James Almer wrote: > > > > On 6/9/2024 2:56 AM, Pierre-Anthony Lemieux wrote: > > > On Sat, Jun 8, 2024 at 6:13 PM James Almer wrote: > > >> > > &g

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: fix tilepart processing

2024-06-13 Thread Pierre-Anthony Lemieux
LGTM. Will merge over the weekend unless I hear otherwise. On Thu, Jun 6, 2024 at 5:25 PM Osamu Watanabe wrote: > > From: Osamu Watanabe <65328111+osamu...@users.noreply.github.com> > > Fix http://trac.ffmpeg.org/ticket/10121 > > Signed-off-by: Osamu Watanabe > --- > libavcodec/jpeg2000dec.c |

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/jpeg2000dec: Add support for placeholder passes, CAP, and CPF markers

2024-06-14 Thread Pierre-Anthony Lemieux
Hi Osamu, Can you provide the list of J2K reference codestreams that this code allows FFMPEG to support -- not including those already supported [1]? [1] https://github.com/FFmpeg/FFmpeg/blob/master/tests/fate/jpeg2000.mak Best, -- Pierre On Fri, Jun 14, 2024 at 8:15 PM Osamu Watanabe wrote:

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add support for p0_10.j2k

2024-06-18 Thread Pierre-Anthony Lemieux
On Tue, Jun 18, 2024 at 7:25 AM Tomas Härdin wrote: > > lör 2024-06-15 klockan 21:47 -0700 skrev p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > p0_10.j2k is one of the reference codestreams included in Rec. ITU-T > > T.803 | ISO/IEC 15444-4. > &

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add support for p0_10.j2k

2024-06-20 Thread Pierre-Anthony Lemieux
On Wed, Jun 19, 2024 at 1:42 AM Tomas Härdin wrote: > > tis 2024-06-18 klockan 07:59 -0700 skrev Pierre-Anthony Lemieux: > > On Tue, Jun 18, 2024 at 7:25 AM Tomas Härdin wrote: > > > > > > lör 2024-06-15 klockan 21:47 -0700 skrev p...@sandflow.com: > &

Re: [FFmpeg-devel] [PATCH 1/5] avformat/imf: Headers

2021-10-01 Thread Pierre-Anthony Lemieux
, 2021 at 11:46 PM Jean-Baptiste Kempf wrote: > > Sorry, but why does this need a public header? > > On Wed, 29 Sep 2021, at 22:47, p...@sandflow.com wrote: > > From: Pierre-Anthony Lemieux > > > > Signed-off-by: Pierre-Anthony Lemieux > > --- > > >

Re: [FFmpeg-devel] [PATCH 2/5] avformat/imf: CPL processor

2021-10-05 Thread Pierre-Anthony Lemieux
Hi Lynne, Can you be more specific? The file header we used look consistent with the header of other BSD-licensed files, like aacdec.c. Thanks, -- Pierre On Thu, Sep 30, 2021 at 6:40 AM Lynne wrote: > > 29 Sept 2021, 22:47 by p...@sandflow.com: > > > From: Pierre-

Re: [FFmpeg-devel] [PATCH 2/5] avformat/imf: CPL processor

2021-10-05 Thread Pierre-Anthony Lemieux
> > > > Thanks, > > > > -- Pierre > > > > On Thu, Sep 30, 2021 at 6:40 AM Lynne wrote: > > > >> > >> 29 Sept 2021, 22:47 by p...@sandflow.com: > >> > >> > From: Pierre-Anthony Lemieux > >> &g

Re: [FFmpeg-devel] [PATCH 2/5] avformat/imf: CPL processor

2021-10-07 Thread Pierre-Anthony Lemieux
; >> > Can you be more specific? > >> > > >> > The file header we used look consistent with the header of other > >> > BSD-licensed files, like aacdec.c. > >> > > >> > Thanks, > >> > > >> > -- Pierre >

Re: [FFmpeg-devel] [PATCH 2/5] avformat/imf: CPL processor

2021-10-08 Thread Pierre-Anthony Lemieux
On Thu, Oct 7, 2021 at 1:24 PM Pierre-Anthony Lemieux wrote: > > On Thu, Oct 7, 2021 at 1:03 PM Lynne wrote: > > > > 6 Oct 2021, 02:45 by p...@sandflow.com: > > > > > On Tue, Oct 5, 2021 at 5:03 PM Lynne wrote: > > > > > >> > > >>

Re: [FFmpeg-devel] [PATCH] avformat/mxf: support MCA audio information

2021-10-12 Thread Pierre-Anthony Lemieux
On Tue, Oct 12, 2021 at 12:29 PM Marton Balint wrote: > > > > On Tue, 12 Oct 2021, Tomas Härdin wrote: > > > mån 2021-10-11 klockan 18:32 +0200 skrev Marc-Antoine Arnaud: > >> --- > >> libavformat/mxf.h| 1 + > >> libavformat/mxfdec.c | 276 > >> ++- >

Re: [FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-10-27 Thread Pierre-Anthony Lemieux
On Wed, Oct 27, 2021 at 12:54 AM Paul B Mahol wrote: > > > > On Fri, Oct 8, 2021 at 1:42 AM wrote: >> >> From: Pierre-Anthony Lemieux >> >> Signed-off-by: Pierre-Anthony Lemieux >> --- >> >> Notes: >> I

Re: [FFmpeg-devel] [PATCH 2/5] avformat/imf: CPL processor

2021-10-27 Thread Pierre-Anthony Lemieux
On Wed, Oct 27, 2021 at 12:57 AM Paul B Mahol wrote: > > > > On Wed, Oct 20, 2021 at 4:55 PM wrote: >> >> From: Pierre-Anthony Lemieux >> >> Signed-off-by: Pierre-Anthony Lemieux >> --- >> >> Notes: >> Implements IMF Compositio

Re: [FFmpeg-devel] [PATCH 2/5] avformat/imf: CPL processor

2021-10-31 Thread Pierre-Anthony Lemieux
On Thu, Oct 28, 2021 at 12:56 AM Paul B Mahol wrote: > > > > On Thu, Oct 28, 2021 at 6:34 AM Pierre-Anthony Lemieux > wrote: >> >> On Wed, Oct 27, 2021 at 12:57 AM Paul B Mahol wrote: >> > >> > >> > >> > On Wed, Oct 20, 2

Re: [FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-10-31 Thread Pierre-Anthony Lemieux
On Thu, Oct 28, 2021 at 12:58 AM Paul B Mahol wrote: > > > > On Thu, Oct 28, 2021 at 6:32 AM Pierre-Anthony Lemieux > wrote: >> >> On Wed, Oct 27, 2021 at 12:54 AM Paul B Mahol wrote: >> > >> > >> > >> > On Fri, Oct 8, 2

Re: [FFmpeg-devel] [PATCH 2/5] avformat/imf: CPL processor

2021-10-31 Thread Pierre-Anthony Lemieux
On Sun, Oct 31, 2021 at 11:35 AM Paul B Mahol wrote: > > > > On Sun, Oct 31, 2021 at 5:48 PM Pierre-Anthony Lemieux > wrote: >> >> On Thu, Oct 28, 2021 at 12:56 AM Paul B Mahol wrote: >> > >> > >> > >> > On Thu, Oct 28, 2021 at

Re: [FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-10-31 Thread Pierre-Anthony Lemieux
On Sun, Oct 31, 2021 at 11:45 AM James Almer wrote: > > On 10/31/2021 3:34 PM, Pierre-Anthony Lemieux wrote: > >>> The functions are not static and are defined in imf_internal.h. They > >>> are used in both libavformat/imfdec.c and the tests at > >>> liba

Re: [FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-11-07 Thread Pierre-Anthony Lemieux
The comments have been addressed in v3 of the patch. On Sun, Oct 31, 2021 at 1:22 PM Pierre-Anthony Lemieux wrote: > > On Sun, Oct 31, 2021 at 11:45 AM James Almer wrote: > > > > On 10/31/2021 3:34 PM, Pierre-Anthony Lemieux wrote: > > >>> The functions

[FFmpeg-devel] Ping re: avformat/imf demuxer

2021-11-18 Thread Pierre-Anthony Lemieux
Hi, Just a quick ping on the v3 of the avformat/imf demuxer patch set. Any major issues/blockers? Best, -- Pierre ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above,

Re: [FFmpeg-devel] [PATCH v3 3/4] avformat/imf: Demuxer implementation

2021-11-22 Thread Pierre-Anthony Lemieux
Hi Paul, Thanks for the review. Are you saying that, in the event that any memory allocation fails within the demuxer, the demuxer is responsible for cleaning-up already previously allocated memory so that other parts of the pipeline can continue operating? In other words, ffmpeg is not expected

Re: [FFmpeg-devel] [PATCH v3 3/4] avformat/imf: Demuxer implementation

2021-11-22 Thread Pierre-Anthony Lemieux
On Mon, Nov 22, 2021 at 12:37 PM Paul B Mahol wrote: > > > > On Mon, Nov 22, 2021 at 5:35 PM Pierre-Anthony Lemieux > wrote: >> >> Hi Paul, >> >> Thanks for the review. >> >> Are you saying that, in the event that any memory allocation fails &g

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxf: support MCA audio information

2021-11-28 Thread Pierre-Anthony Lemieux
On Sun, Nov 28, 2021 at 4:56 PM Marton Balint wrote: > > > > On Thu, 25 Nov 2021, Marc-Antoine Arnaud wrote: > > > --- > > doc/demuxers.texi | 10 ++ > > libavformat/mxf.h | 1 + > > libavformat/mxfdec.c | 293 +- > > libavformat/version.h | 2 +-

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mxfdec: rework MCA channel layout parsing

2021-11-30 Thread Pierre-Anthony Lemieux
On Tue, Nov 30, 2021 at 10:36 AM Marton Balint wrote: > > > > On Mon, 29 Nov 2021, Pierre-Anthony Lemieux wrote: > > > On Mon, Nov 29, 2021 at 11:20 AM Marton Balint wrote: > >> > >> > >> > >> On Sun, 28 Nov 2021, Pierre-Anthony Lemieux

[FFmpeg-devel] IMF demuxer ping

2021-12-04 Thread Pierre-Anthony Lemieux
Hi all, Quick ping re: libavformat/imf demuxer patch set. All outstanding feedback (thanks!) has been addressed as far as I know. What are the next steps? It would be good to make progress while it is fresh in peoples' minds. Latest patchset at [1] and tracking PR at [2] (including memory lea

Re: [FFmpeg-devel] [PATCH] mxfdec.c: fixed frame wrapping detection for MXFGCP1FrameWrappedPicture essence container

2021-07-17 Thread Pierre-Anthony Lemieux
1-07-11 klockan 09:47 -0700 skrev p...@sandflow.com: > >> From: Pierre-Anthony Lemieux > >> > >> Signed-off-by: Pierre-Anthony Lemieux > >> --- > >> > >> Notes: > >> For JPEG 2000 essence, the MXF input format module currently uses

Re: [FFmpeg-devel] [PATCH] mxfdec.c: fixed frame wrapping detection for MXFGCP1FrameWrappedPicture essence container

2021-07-18 Thread Pierre-Anthony Lemieux
Ok. Thanks. Submitted V2 of the patch at: http://ffmpeg.org/pipermail/ffmpeg-devel/2021-July/282414.html On Sun, Jul 18, 2021 at 12:07 AM Marton Balint wrote: > > > > On Sat, 17 Jul 2021, Pierre-Anthony Lemieux wrote: > > > You mean something like this? > &

Re: [FFmpeg-devel] [PATCH V2] avformat/mxf: fixed frame wrapping detection for J2K essence container

2021-07-24 Thread Pierre-Anthony Lemieux
gt; > From: Pierre-Anthony Lemieux > > > > Signed-off-by: Pierre-Anthony Lemieux > > --- > > > > Notes: > >For JPEG 2000 essence, the MXF input format module currently uses the > > value of byte 14 of the essence container UL to determine > >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/jpeg2000htdec: Avoid freeing uninitialized pointers in ff_jpeg2000_decode_htj2k()

2023-08-03 Thread Pierre-Anthony Lemieux
On Thu, Aug 3, 2023 at 1:50 PM Tomas Härdin wrote: > > tor 2023-08-03 klockan 17:36 +0200 skrev Michael Niedermayer: > > On Thu, Aug 03, 2023 at 10:20:29AM +0200, Tomas Härdin wrote: > > > ons 2023-08-02 klockan 02:01 +0200 skrev Michael Niedermayer: > > > > Fixes: freeing of uninitialized pointer

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/jpeg2000htdec: Check m

2023-08-04 Thread Pierre-Anthony Lemieux
On Tue, Aug 1, 2023 at 5:02 PM Michael Niedermayer wrote: > > This also fixes assertion failures > > Fixes: shift exponent 95 is too large for 64-bit type 'unsigned long long' > Fixes: > 58299/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-5828618092937216 > > Found-by: continu

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/jpeg2000htdec: Consolidate jpeg2000 spec bits in jpeg2000_bitbuf_refill_backwards()

2023-08-04 Thread Pierre-Anthony Lemieux
On Tue, Aug 1, 2023 at 5:02 PM Michael Niedermayer wrote: > > Code should make more sense now > > Fixes: out of array access > Fixes: > 58299/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_JPEG2000_fuzzer-6627570448465920 > > Found-by: continuous fuzzing process > https://github.com/google/os

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/jpeg2000htdec: Check m

2023-08-06 Thread Pierre-Anthony Lemieux
On Sat, Aug 5, 2023 at 9:30 AM Michael Niedermayer wrote: > > On Fri, Aug 04, 2023 at 06:19:46PM -0700, Pierre-Anthony Lemieux wrote: > > On Tue, Aug 1, 2023 at 5:02 PM Michael Niedermayer > > wrote: > > > > > > This also fixes assertion failures > > >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/jpeg2000htdec: Check m

2023-08-10 Thread Pierre-Anthony Lemieux
On Sun, Aug 6, 2023 at 9:28 AM Pierre-Anthony Lemieux wrote: > > On Sat, Aug 5, 2023 at 9:30 AM Michael Niedermayer > wrote: > > > > On Fri, Aug 04, 2023 at 06:19:46PM -0700, Pierre-Anthony Lemieux wrote: > > > On Tue, Aug 1, 2023 at 5:02 PM Michael Niedermayer >

Re: [FFmpeg-devel] [PATCH v1] avcodec/jpeg2000htdec: check if block decoding will exceed internal precision

2023-08-12 Thread Pierre-Anthony Lemieux
On Sat, Aug 12, 2023 at 11:39 AM Michael Niedermayer wrote: > > On Thu, Aug 10, 2023 at 04:48:56PM -0700, p...@sandflow.com wrote: > > From: Pierre-Anthony Lemieux > > > > Intended to replace > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230802000135.

Re: [FFmpeg-devel] [PATCH v1] avcodec/jpeg2000htdec: check if block decoding will exceed internal precision

2023-08-12 Thread Pierre-Anthony Lemieux
On Sat, Aug 12, 2023 at 1:31 PM Pierre-Anthony Lemieux wrote: > > On Sat, Aug 12, 2023 at 11:39 AM Michael Niedermayer > wrote: > > > > On Thu, Aug 10, 2023 at 04:48:56PM -0700, p...@sandflow.com wrote: > > > From: Pierre-Anthony Lemieux > > >

Re: [FFmpeg-devel] [PATCH v2] avcodec/jpeg2000htdec: check if block decoding will exceed internal precision

2023-08-14 Thread Pierre-Anthony Lemieux
On Mon, Aug 14, 2023 at 1:14 AM Tomas Härdin wrote: > > lör 2023-08-12 klockan 13:31 -0700 skrev p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > Intended to replace > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20230802000135.26482-3-mich...@n

[FFmpeg-devel] J2K in HEIF was: [RFC]avformat: introduce AVStreamGroup

2023-09-13 Thread Pierre-Anthony Lemieux
On Wed, Sep 13, 2023 at 2:35 AM Tomas Härdin wrote: > > ons 2023-09-06 klockan 16:16 -0300 skrev James Almer: > > On 9/6/2023 2:53 PM, Tomas Härdin wrote: > > > ons 2023-09-06 klockan 11:38 -0300 skrev James Almer: > > > > Signed-off-by: James Almer > > > > --- > > > > This is an initial proof of

Re: [FFmpeg-devel] [PATCH] avformat/imf_cpl: Check the right variable

2022-08-25 Thread Pierre-Anthony Lemieux
LGTM On Thu, Aug 25, 2022 at 2:01 PM Andreas Rheinhardt wrote: > > Fixes Coverity issue #1512407. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/imf_cpl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c > index 4a

Re: [FFmpeg-devel] [PATCH 1/2] avformat/imfdec: check track valid before use it

2022-08-25 Thread Pierre-Anthony Lemieux
Since we are protecting against the algorithm within get_next_track_with_minimum_timestamp() return NULL, should this patch also include immediately returning from imf_read_packet() if get_next_track_with_minimum_timestamp() returns NULL? On Thu, Aug 25, 2022 at 7:53 PM Steven Liu wrote: > > fix

Re: [FFmpeg-devel] [PATCH] avformat/tests/imf: Test ff_imf_parse_cpl_from_xml_dom cleanup on error

2022-08-25 Thread Pierre-Anthony Lemieux
On Thu, Aug 25, 2022 at 1:58 PM Andreas Rheinhardt wrote: > > Improves the test; also should fix Coverity issue #1512408. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/tests/imf.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/libavformat/tests/im

Re: [FFmpeg-devel] [PATCH v2] avformat/imfdec: check track valid before use it

2022-08-26 Thread Pierre-Anthony Lemieux
On Fri, Aug 26, 2022 at 1:37 AM Andreas Rheinhardt wrote: > > Steven Liu: > > fix CID: 1512414 > > And return AVERROR_INVALIDDATA when get_next_track_with_minimum_timestamp > > incorrect in imf_read_packet; > > > > Signed-off-by: Steven Liu > > --- > > libavformat/imfdec.c | 7 +-- > > 1 fil

Re: [FFmpeg-devel] [PATCH] avformat/tests/imf: Test ff_imf_parse_cpl_from_xml_dom cleanup on error

2022-08-26 Thread Pierre-Anthony Lemieux
On Fri, Aug 26, 2022 at 1:22 AM Andreas Rheinhardt wrote: > > Pierre-Anthony Lemieux: > > On Thu, Aug 25, 2022 at 1:58 PM Andreas Rheinhardt > > wrote: > >> > >> Improves the test; also should fix Coverity issue #1512408. > >> > >> Signed-

Re: [FFmpeg-devel] [PATCH v2] avformat/imfdec: check track valid before use it

2022-08-26 Thread Pierre-Anthony Lemieux
On Fri, Aug 26, 2022 at 9:01 AM Andreas Rheinhardt wrote: > > Pierre-Anthony Lemieux: > > On Fri, Aug 26, 2022 at 1:37 AM Andreas Rheinhardt > > wrote: > >> > >> Steven Liu: > >>> fix CID: 1512414 > >>> And return AVERROR_INVALIDDATA w

Re: [FFmpeg-devel] [PATCH v2] avformat/imfdec: check track valid before use it

2022-08-27 Thread Pierre-Anthony Lemieux
On Sat, Aug 27, 2022 at 5:25 AM Steven Liu wrote: > > Pierre-Anthony Lemieux 于2022年8月27日周六 00:06写道: > > > > On Fri, Aug 26, 2022 at 9:01 AM Andreas Rheinhardt > > wrote: > > > > > > Pierre-Anthony Lemieux: > > > > On Fri, Aug

Re: [FFmpeg-devel] [PATCH v1] avformat/mxf: set stream frame rates for ST 422 essence containers

2022-09-05 Thread Pierre-Anthony Lemieux
On Sat, Sep 3, 2022 at 11:26 AM Tomas Härdin wrote: > > sön 2022-08-28 klockan 08:31 -0700 skrev p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > The MXF demuxer does not currently set AVStream::avg_frame_rate and > > ::r_frame_rate > > when J2K e

Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/imfdec: use CPL start timecode if available

2022-09-05 Thread Pierre-Anthony Lemieux
Just a quick ping. Looking forward to feedback. This patchset is intended to address https://trac.ffmpeg.org/ticket/9842. On Mon, Aug 22, 2022 at 10:11 PM wrote: > > From: Pierre-Anthony Lemieux > > The IMF CPL contains an optional timecode start address. This patch reads the

Re: [FFmpeg-devel] [PATCH v1] avformat/imfdec: check if Asset/Id exists before trying to read it

2022-09-05 Thread Pierre-Anthony Lemieux
Ping. This fixes Coverity issue #1512406. On Thu, Aug 25, 2022 at 8:22 PM wrote: > > From: Pierre-Anthony Lemieux > > Fixes Coverity issue #1512406 > > --- > libavformat/imfdec.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/liba

Re: [FFmpeg-devel] [PATCH v2 2/2] fate/mxf: add JPEG 2000 test

2022-09-06 Thread Pierre-Anthony Lemieux
On Tue, Sep 6, 2022 at 2:24 PM Andreas Rheinhardt wrote: > > p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > --- > > tests/fate/mxf.mak | 4 ++ > > tests/ref/fate/mxf-probe-j2k | 78 > > 2 f

Re: [FFmpeg-devel] [PATCH v2 2/2] fate/mxf: add JPEG 2000 test

2022-09-06 Thread Pierre-Anthony Lemieux
On Tue, Sep 6, 2022 at 2:33 PM Andreas Rheinhardt wrote: > > Pierre-Anthony Lemieux: > > On Tue, Sep 6, 2022 at 2:24 PM Andreas Rheinhardt > > wrote: > >> > >> p...@sandflow.com: > >>> From: Pierre-Anthony Lemieux > >>> > >>&g

Re: [FFmpeg-devel] [PATCH v2] avformat/imfdec: check track valid before use it

2022-09-08 Thread Pierre-Anthony Lemieux
See [1] for a patchset that is intended to address the coverity issue and simplify error handling. [1] https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220907200233.21255-1-...@sandflow.com/ On Sat, Aug 27, 2022 at 10:25 AM Pierre-Anthony Lemieux wrote: > > On Sat, Aug 27, 2022 at 5

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/mxf: set stream frame rates for ST 422 essence containers

2022-09-14 Thread Pierre-Anthony Lemieux
Ping. All outstanding feedback has been addressed AFAIK. This patchset addresses https://trac.ffmpeg.org/ticket/9856 On Tue, Sep 6, 2022 at 2:51 PM wrote: > > From: Pierre-Anthony Lemieux > > The MXF demuxer does not currently set AVStream::avg_frame_rate and > ::r_frame_

Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

2022-09-14 Thread Pierre-Anthony Lemieux
Ping. This patchset addresses a coverity issue #1512414. On Wed, Sep 7, 2022 at 1:02 PM wrote: > > From: Pierre-Anthony Lemieux > > Addresses coverity 1512414 > > --- > libavformat/imfdec.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) >

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add maintainer for the imf demuxer

2022-09-15 Thread Pierre-Anthony Lemieux
On Thu, Sep 15, 2022 at 4:07 PM Lynne wrote: > > Sep 16, 2022, 00:46 by p...@sandflow.com: > > > From: Pierre-Anthony Lemieux > > > > --- > > MAINTAINERS | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINER

Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

2022-09-16 Thread Pierre-Anthony Lemieux
On Fri, Sep 16, 2022 at 10:27 AM Michael Niedermayer wrote: > > On Wed, Sep 07, 2022 at 01:02:33PM -0700, p...@sandflow.com wrote: > > From: Pierre-Anthony Lemieux > > > > Addresses coverity 1512414 > > > > --- > > libavformat/imfdec.c | 15

Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

2022-09-16 Thread Pierre-Anthony Lemieux
On Fri, Sep 16, 2022 at 10:39 AM Pierre-Anthony Lemieux wrote: > > On Fri, Sep 16, 2022 at 10:27 AM Michael Niedermayer > wrote: > > > > On Wed, Sep 07, 2022 at 01:02:33PM -0700, p...@sandflow.com wrote: > > > From: Pierre-Anthony Lemieux > >

Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

2022-09-16 Thread Pierre-Anthony Lemieux
On Fri, Sep 16, 2022 at 1:15 PM Michael Niedermayer wrote: > > On Fri, Sep 16, 2022 at 10:39:22AM -0700, Pierre-Anthony Lemieux wrote: > > On Fri, Sep 16, 2022 at 10:27 AM Michael Niedermayer > > wrote: > > > > > > On Wed, Sep 07, 2022 at 01:02:33PM -0700, p

Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

2022-09-17 Thread Pierre-Anthony Lemieux
On Sat, Sep 17, 2022 at 7:43 AM Michael Niedermayer wrote: > > On Fri, Sep 16, 2022 at 01:19:09PM -0700, Pierre-Anthony Lemieux wrote: > > On Fri, Sep 16, 2022 at 1:15 PM Michael Niedermayer > > wrote: > > > > > > On Fri, Sep 16, 2022 at 10:39:22AM -0700, Pier

Re: [FFmpeg-devel] [PATCH] format/imfdec: improve error handling when selecting tracks for playback

2022-09-19 Thread Pierre-Anthony Lemieux
On Mon, Sep 19, 2022 at 7:42 AM Michael Niedermayer wrote: > > On Sat, Sep 17, 2022 at 08:57:37AM -0700, Pierre-Anthony Lemieux wrote: > > On Sat, Sep 17, 2022 at 7:43 AM Michael Niedermayer > > wrote: > > > > > > On Fri, Sep 16, 2022 at 01:19:09PM -0700, Pier

[FFmpeg-devel] Ping Re: [PATCH v1 1/2] avformat/imfdec: use CPL start timecode if available

2022-09-25 Thread Pierre-Anthony Lemieux
/48fa27e77a6d71be89f216cee13ae7e99d2b5003 Now that [1] has been merged, On Mon, Sep 5, 2022 at 11:06 AM Pierre-Anthony Lemieux wrote: > > Just a quick ping. > > Looking forward to feedback. > > This patchset is intended to address https://trac.ffmpeg.org/ticket/9842. > > > On Mon, Aug

Re: [FFmpeg-devel] [PATCH] Encrypted SMPTE DC MXF - additional UL needed to unpack EKLV packet

2022-09-30 Thread Pierre-Anthony Lemieux
On Fri, Sep 30, 2022 at 7:08 AM Richard Ayres wrote: > > We had an issue where ffmpeg was unable to unpack the EKLV of an encrypted 3D > SMPTE DC MXF. > > The patch adds the SMPTE UL for EKLV packets > (060e2b34.02040101.0d010301.027e0100), to mxfdec.c in order to unpack an EKLV > packet found

Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/imfdec: use CPL start timecode if available

2022-10-02 Thread Pierre-Anthony Lemieux
On Tue, Sep 27, 2022 at 5:40 AM Zane van Iperen wrote: > > Looks mostly ok from a cursory glance, just one minor nit. > > On 23/8/22 15:10, p...@sandflow.com wrote: > > > > +static int ff_imf_xml_read_boolean(xmlNodePtr element, int *value) > > +{ > > +xmlChar *element_text = NULL; > > +in

Re: [FFmpeg-devel] [PATCH 1/1] Enable building with WSL and MSVC

2022-10-02 Thread Pierre-Anthony Lemieux
On Sun, Oct 2, 2022 at 5:14 PM Timo Rothenpieler wrote: > > On 03.10.2022 01:47, Julio C. Rocha wrote: > > --- > > configure | 7 ++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/configure b/configure > > index 6712d045d9..f5f5eb29dd 100755 > > --- a/configure > >

Re: [FFmpeg-devel] [PATCH 1/1] Enable building with WSL and MSVC

2022-10-03 Thread Pierre-Anthony Lemieux
On Mon, Oct 3, 2022 at 1:11 AM Julio C. Rocha wrote: > > On Sun, Oct 2, 2022 at 5:19 PM Pierre-Anthony Lemieux > wrote: > > > On Sun, Oct 2, 2022 at 5:14 PM Timo Rothenpieler > > wrote: > > > > > > On 03.10.2022 01:47, Julio C. Rocha

Re: [FFmpeg-devel] [PATCH] Encrypted SMPTE DC MXF - additional UL needed to unpack EKLV packet

2022-10-04 Thread Pierre-Anthony Lemieux
On Tue, Oct 4, 2022 at 7:29 AM Tomas Härdin wrote: > > mån 2022-10-03 klockan 11:47 + skrev Richard Ayres: > > Thanks, Pierre-Anthony. I've updated the patch to remove the > > unnecessary UL and it's now using mxf_match_uid() to detect the EKLV > > packet. > > > > Signed-off-by: Richard Ayres

Re: [FFmpeg-devel] [PATCH] Encrypted SMPTE DC MXF - additional UL needed to unpack EKLV packet

2022-10-04 Thread Pierre-Anthony Lemieux
On Tue, Oct 4, 2022 at 7:59 AM Tomas Härdin wrote: > > tis 2022-10-04 klockan 07:50 -0700 skrev Pierre-Anthony Lemieux: > > On Tue, Oct 4, 2022 at 7:29 AM Tomas Härdin wrote: > > > > > > mån 2022-10-03 klockan 11:47 + skrev Richard Ayres: > > > >

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-07-11 Thread Pierre-Anthony Lemieux
I checked that the patch results in FFMPEG decoding without error the additional conformance codestreams at [1]. [1] https://ffmpeg.org/pipermail/ffmpeg-devel/2024-June/329727.html @Osamu, did you check if the decoded images fall within the tolerances specified in 15444-4? There is an errant spa

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-07-12 Thread Pierre-Anthony Lemieux
On Thu, Jul 11, 2024 at 10:28 PM Tomas Härdin wrote: > > > +if (s->in_tile_headers == 1 && s->isHT && (!s- > > >Ccap15_b11)) > > +av_log(s->avctx, AV_LOG_WARNING, "COD marker is > > found in HOMOGENEOUS HT set\n"); > > How bad is this and the other markers being present

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-07-18 Thread Pierre-Anthony Lemieux
On Mon, Jul 15, 2024 at 10:33 PM Tomas Härdin wrote: > > fre 2024-07-12 klockan 12:51 -0700 skrev Pierre-Anthony Lemieux: > > On Thu, Jul 11, 2024 at 10:28 PM Tomas Härdin wrote: > > > > > > > +if (s->in_tile_headers == 1 &am

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-07-20 Thread Pierre-Anthony Lemieux
On Sat, Jul 20, 2024 at 5:12 PM Tomas Härdin wrote: > > tor 2024-07-18 klockan 23:10 +0900 skrev Pierre-Anthony Lemieux: > > On Mon, Jul 15, 2024 at 10:33 PM Tomas Härdin wrote: > > > > > > fre 2024-07-12 klockan 12:51 -0700 skrev Pierre-Anthony Lemieux: > >

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-07-25 Thread Pierre-Anthony Lemieux
On Thu, Jul 25, 2024 at 2:17 AM Tomas Härdin wrote: > > sön 2024-07-21 klockan 14:07 +0900 skrev Pierre-Anthony Lemieux: > > On Sat, Jul 20, 2024 at 5:12 PM Tomas Härdin wrote: > > > > > > tor 2024-07-18 klockan 23:10 +0900 skrev Pierre-Anthony Lemieux: > >

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-07-26 Thread Pierre-Anthony Lemieux
On Fri, Jul 26, 2024 at 1:04 AM Tomas Härdin wrote: > > tor 2024-07-25 klockan 17:06 -0700 skrev Pierre-Anthony Lemieux: > > On Thu, Jul 25, 2024 at 2:17 AM Tomas Härdin wrote: > > > > > > sön 2024-07-21 klockan 14:07 +0900 skrev Pierre-Anthony Lemieux: > >

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-07-26 Thread Pierre-Anthony Lemieux
On Fri, Jul 26, 2024 at 2:29 PM Michael Niedermayer wrote: > > On Thu, Jul 25, 2024 at 05:06:04PM -0700, Pierre-Anthony Lemieux wrote: > > On Thu, Jul 25, 2024 at 2:17 AM Tomas Härdin wrote: > > > > > > sön 2024-07-21 klockan 14:07 +0900 skrev Pierre-Anthony Lemieux

Re: [FFmpeg-devel] [PATCH v7 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-08-05 Thread Pierre-Anthony Lemieux
Hi Osamu, Below are suggested improvements to error messages. There are also a couple of errant trailing white spaces in jpeg2000htdec.c. Can you fix them? Best, -- Pierre On Sat, Aug 3, 2024 at 10:27 PM Osamu Watanabe wrote: > > This commit adds support for CAP and CPF markers. Decoding wi

Re: [FFmpeg-devel] [PATCH v8 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-08-06 Thread Pierre-Anthony Lemieux
I plan to apply on Friday, after fixing the few errant trailing spaces. On Tue, Aug 6, 2024 at 8:48 PM Osamu Watanabe wrote: > > This commit adds support for CAP and CPF markers. Decoding will exit when > encountering Ilegal input codestreams. > > Signed-off-by: Osamu Watanabe > --- > libavcod

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add support for p0_10.j2k

2024-08-21 Thread Pierre-Anthony Lemieux
On Wed, Jun 19, 2024 at 1:42 AM Tomas Härdin wrote: > > tis 2024-06-18 klockan 07:59 -0700 skrev Pierre-Anthony Lemieux: > > On Tue, Jun 18, 2024 at 7:25 AM Tomas Härdin wrote: > > > > > > lör 2024-06-15 klockan 21:47 -0700 skrev p...@sandflow.com: > &

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add selected conformance codestreams from ISO/IEC 15444-4

2024-08-21 Thread Pierre-Anthony Lemieux
On Wed, Aug 21, 2024 at 8:54 AM Tomas Härdin wrote: > > mån 2024-08-19 klockan 23:03 -0700 skrev p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > --- > > tests/fate/jpeg2000.mak | 129 > > I presume you've tested that the fram

Re: [FFmpeg-devel] [PATCH] fate/jpeg2000dec: add selected conformance codestreams from ISO/IEC 15444-4

2024-08-22 Thread Pierre-Anthony Lemieux
> I have confirmed that FFMPEG passes all the test cases without the flag. > > The problem has been locally solved with the updated code, however, the patch > set is not yet ready. > (It won't take long) > > Best, > Osamu > > > > 2024/08/22 1:01、Pierre-Ant

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: Update FATE refs for conformance testing defined in ISO/IEC 15444-4

2024-08-29 Thread Pierre-Anthony Lemieux
On Thu, Aug 29, 2024 at 1:29 AM Osamu Watanabe wrote: > > The FATE refs are updated to reflect changes in the [PATCH 1/2]. It looks like the fate-j2k-dwt and fate-jpeg2000-dcinema fate files need to be regenerated as well. > > Signed-off-by: Osamu Watanabe > --- > tests/ref/fate/jpeg2000dec-p0

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/jpeg2000dec: Update to JPEG 2000 related FATE refs with the fix of FF_DWT97_INT (integer implementation of inverse DWT 97)

2024-08-29 Thread Pierre-Anthony Lemieux
Looks like more files need to be regenerated: tests/ref/vsynth/vsynth1-jpeg2000-97 tests/ref/vsynth/vsynth2-jpeg2000-97 tests/ref/vsynth/vsynth3-jpeg2000-97 tests/ref/vsynth/vsynth_lena-jpeg2000-97 On Thu, Aug 29, 2024 at 7:07 PM Osamu Watanabe wrote: > > Signed-off-by: Osamu Watanabe > --- >

Re: [FFmpeg-devel] [PATCH v5] avcodec/jpeg2000: Fix FF_DWT97_INT to pass the conformance testing defined in ISO/IEC 15444-4

2024-09-12 Thread Pierre-Anthony Lemieux
Looks like a nice improvement. It looks like the size of the codestreams obtained when running `-q: 20` are larger after the patch -- maybe related to the change in the step size calculation, which is now the same for both bitexact and non-bit-exact. Is that expected? I realize `-q` is arbitrary bu

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: use CPL start timecode if available

2022-10-28 Thread Pierre-Anthony Lemieux
Hi Zane et al., Quick ping on the revised patchset below. It addresses https://trac.ffmpeg.org/ticket/9842. Best, -- Pierre On Sun, Oct 2, 2022 at 9:28 AM wrote: > > From: Pierre-Anthony Lemieux > > The IMF CPL contains an optional timecode start address. This patch reads the

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: Add support for HTJ2K decoding.

2022-12-12 Thread Pierre-Anthony Lemieux
On Fri, Dec 2, 2022 at 10:46 AM Tomas Härdin wrote: > > fre 2022-12-02 klockan 21:11 +0300 skrev etemesica...@gmail.com: > > > > +/** > > + * Given a precomputed c, checks whether n % d == 0 > > + */ > > +static av_always_inline uint32_t is_divisible(uint32_t n, uint64_t > > c) > > +{ > > +re

Re: [FFmpeg-devel] GSoC 2023

2022-12-15 Thread Pierre-Anthony Lemieux
I have updated the page with the HTJ2K project. This is a good opportunity to ask for help completing the review of the patchset: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=8078 All known issues have been resolved and it would be good to merge soon, i.e. beat the iron while it is h

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: remove the experimental flag

2023-01-06 Thread Pierre-Anthony Lemieux
On Fri, Jan 6, 2023 at 7:45 AM Tomas Härdin wrote: > > tor 2023-01-05 klockan 15:29 -0800 skrev p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > --- > > libavformat/imfdec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > &g

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/imfdec: remove the experimental flag

2023-01-06 Thread Pierre-Anthony Lemieux
On Fri, Jan 6, 2023 at 8:09 AM Tomas Härdin wrote: > > fre 2023-01-06 klockan 07:50 -0800 skrev Pierre-Anthony Lemieux: > > On Fri, Jan 6, 2023 at 7:45 AM Tomas Härdin wrote: > > > > > > tor 2023-01-05 klockan 15:29 -0800 skrev p...@sandflow.com: > &

Re: [FFmpeg-devel] [PATCH v1] fate/imfdec: add audio test

2023-01-09 Thread Pierre-Anthony Lemieux
Quick ping. This adds an audio test for the IMF demuxer FATE suite, which currently only has image tests. On Thu, Dec 29, 2022 at 11:12 PM wrote: > > From: Pierre-Anthony Lemieux > > Adds an audio test for the IMF demuxer. > > FATE content at https://www.sandflow.com/public/c

Re: [FFmpeg-devel] [PATCH] lavf/matroska: add support for ARIB captions

2023-01-13 Thread Pierre-Anthony Lemieux
On Fri, Jan 13, 2023 at 9:27 AM rcombs wrote: > > Not yet ready for merge, pending finalization of the standard proposal for > this mapping: > https://github.com/ietf-wg-cellar/matroska-specification/pull/724 Is sample ARIB caption available? > --- > libavformat/matroska.c| 1 + > libavfo

Re: [FFmpeg-devel] IMF demuxer ping

2021-12-05 Thread Pierre-Anthony Lemieux
On Sun, Dec 5, 2021 at 2:13 AM Lynne wrote: > > 5 Dec 2021, 02:33 by p...@sandflow.com: > > > Hi all, > > > > Quick ping re: libavformat/imf demuxer patch set. > > > > All outstanding feedback (thanks!) has been addressed as far as I know. > > > > What are the next steps? > > > > It would be good

Re: [FFmpeg-devel] IMF demuxer ping

2021-12-06 Thread Pierre-Anthony Lemieux
On Mon, Dec 6, 2021 at 2:16 AM Anton Khirnov wrote: > > Quoting Lynne (2021-12-05 11:13:17) > > 5 Dec 2021, 02:33 by p...@sandflow.com: > > > > > Hi all, > > > > > > Quick ping re: libavformat/imf demuxer patch set. > > > > > > All outstanding feedback (thanks!) has been addressed as far as I know

Re: [FFmpeg-devel] IMF demuxer ping

2021-12-06 Thread Pierre-Anthony Lemieux
On Mon, Dec 6, 2021 at 8:02 AM Lynne wrote: > > 6 Dec 2021, 16:58 by p...@sandflow.com: > > > On Mon, Dec 6, 2021 at 2:16 AM Anton Khirnov wrote: > > > >> > >> Quoting Lynne (2021-12-05 11:13:17) > >> > 5 Dec 2021, 02:33 by p...@sandflow.com: > >> > > >> > > Hi all, > >> > > > >> > > Quick ping r

Re: [FFmpeg-devel] [PATCH v7 1/2] avformat/imf: Demuxer

2021-12-07 Thread Pierre-Anthony Lemieux
On Mon, Dec 6, 2021 at 9:45 AM Lynne wrote: > > 6 Dec 2021, 04:18 by p...@sandflow.com: > > > From: Pierre-Anthony Lemieux > > + > > +/** > > Please don't NIH-parse UUIDs. They're more complicated > than this. Use libuuid, it's stable, bug-fr

Re: [FFmpeg-devel] [PATCH v7 1/2] avformat/imf: Demuxer

2021-12-07 Thread Pierre-Anthony Lemieux
On Mon, Dec 6, 2021 at 12:55 PM Andreas Rheinhardt wrote: > > p...@sandflow.com: > > From: Pierre-Anthony Lemieux > > > > Signed-off-by: Pierre-Anthony Lemieux > > --- > > > > Notes: > > The IMF demuxer accepts as input an IMF C

[FFmpeg-devel] IMF demuxer status

2021-12-08 Thread Pierre-Anthony Lemieux
Hi all, I have posted v9 of the IMF demuxer patch. The small changes are the result of my running the demuxer through valgrind and failing individual heap allocation calls. Outstanding issues (I know of): - it was suggested that libuuid be used to parse UUIDs in the IMF CPL. As detailed at [1],

  1   2   3   >