[FFmpeg-devel] [PATCH 1/2] configure: detect djgpp libc

2018-11-12 Thread Peter Ross
ndition sys/version.h "defined __DJGPP__"; then +eval ${pfx}libc_type=djgpp +add_cppflags -U__STRICT_ANSI__ fi test_${pfx}cc < -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature _

[FFmpeg-devel] [PATCH 2/2] fmin/fmax/fminf/fmaxf implementation for djgpp libc

2018-11-12 Thread Peter Ross
PP__"; then eval ${pfx}libc_type=djgpp add_cppflags -U__STRICT_ANSI__ +add_cflags "-include $source_path/compat/djgpp/math.h" fi test_${pfx}cc < -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.a

[FFmpeg-devel] [PATCH] avfilter/graphmonitor: use %z when printing size_t

2018-11-19 Thread Peter Ross
t;%"PRId64, frames); +snprintf(buffer, sizeof(buffer)-1, "%zd", frames); drawtext(out, xpos, ypos, buffer, frames > 0 ? frames >= 10 ? frames >= 50 ? s->red : s->yellow : s->green : s->white); xpos += strlen(buffer) * 8; } -- 2.17.1

[FFmpeg-devel] [PATCHv2] avfilter/graphmonitor: use SIZE_SPECIFIER for size_t type

2018-11-19 Thread Peter Ross
snprintf(buffer, sizeof(buffer)-1, "%"SIZE_SPECIFIER, frames); drawtext(out, xpos, ypos, buffer, frames > 0 ? frames >= 10 ? frames >= 50 ? s->red : s->yellow : s->green : s->white); xpos += strlen(buffer) * 8; } -- 2.17.1 -- Peter (A907 E02F A6

[FFmpeg-devel] [PATCH] api-h264-slice-test: use av_be2ne16 instead of ntohs

2018-11-19 Thread Peter Ross
eader = 0; @@ -191,7 +191,7 @@ int main(int argc, char **argv) if (ret != sizeof(uint16_t)) break; -size = ntohs(size); +size = av_be2ne16(size); ret = fread(p, 1, size, file); if (ret != size) { perror("Couldn't read

[FFmpeg-devel] [PATCH 0/5] djgpp patch set v2

2018-11-20 Thread Peter Ross
revised ffmpeg dos patch set. passes fate. Peter Ross (5): configure: detect djgpp libc additional math.h functions for djgpp configure: memalign is broken on djgpp 2.05 avpriv_tempfile: add djgpp fallback fate-api-h264-slice: use the heap for nal buffer compat/djgpp/math.c

[FFmpeg-devel] [PATCH 1/5] configure: detect djgpp libc

2018-11-20 Thread Peter Ross
{pfx}cppflags -D__EXTENSIONS__ -D_XOPEN_SOURCE=600 +elif test_${pfx}cpp_condition sys/version.h "defined __DJGPP__"; then +eval ${pfx}libc_type=djgpp +add_cppflags -U__STRICT_ANSI__ fi test_${pfx}cc < -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34C

[FFmpeg-devel] [PATCH 2/5] additional math.h functions for djgpp

2018-11-20 Thread Peter Ross
8,7 @@ compat/avisynth/avxsynth_c.h compat/avisynth/windowsPorts/basicDataTypeConversions.h compat/avisynth/windowsPorts/windows2linux.h compat/cuda/dynlink_loader.h +compat/djgpp/math.h compat/float/float.h compat/float/limits.h Use of av_clip() where av_clip_uintp2() could be used: -- 2.17.1

[FFmpeg-devel] [PATCH 3/5] configure: memalign is broken on djgpp 2.05

2018-11-20 Thread Peter Ross
ble posix_memalign -fi +;; +*-dos|freedos|opendos) +if test_cpp_condition sys/version.h "defined(__DJGPP__) && __DJGPP__ == 2 && __DJGPP_MINOR == 5"; then +disable memalign +fi +;; +esac flatten_extralibs(){ nested_entries= -- 2.17.1 -- Peter (A907

[FFmpeg-devel] [PATCH 4/5] avpriv_tempfile: add djgpp fallback

2018-11-20 Thread Peter Ross
filename, len, "./%sXX", prefix); fd = mkstemp(*filename); -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org ht

[FFmpeg-devel] [PATCH 5/5] fate-api-h264-slice: use the heap for nal buffer

2018-11-20 Thread Peter Ross
e) fclose(file); av_frame_free(&frame); -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] patch for failing on WavPack DSD files

2018-11-20 Thread Peter Ross
idea to detect and error out early. > > Thanks! cool. is this dst-based, or your own algorithm? -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@f

Re: [FFmpeg-devel] [PATCH 3/5] configure: memalign is broken on djgpp 2.05

2018-11-21 Thread Peter Ross
On Tue, Nov 20, 2018 at 11:26:31PM +0100, Michael Niedermayer wrote: > On Tue, Nov 20, 2018 at 11:24:10PM +0100, Michael Niedermayer wrote: > > On Wed, Nov 21, 2018 at 01:29:48AM +1100, Peter Ross wrote: > > > djgpp 2.05 finally provides posix-compatible memalign, but it is br

[FFmpeg-devel] [PATCH 1/2] os_support: djgpp: define socket shutdown SHUT_xxx macros

2018-11-24 Thread Peter Ross
/os_support.h +++ b/libavformat/os_support.h @@ -76,7 +76,7 @@ static inline int is_dos_path(const char *path) return 0; } -#if defined(__OS2__) +#if defined(__OS2__) || defined(__DJGPP__) #define SHUT_RD 0 #define SHUT_WR 1 #define SHUT_RDWR 2 -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD

[FFmpeg-devel] [PATCH 2/2] configure: use watt socket library instead of libsocket library for djgpp builds

2018-11-24 Thread Peter Ross
) -network_extralibs="-lsocket" +network_extralibs="-lwatt" objformat="coff" enable dos_paths ;; -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH] os_support: define socket shutdown SHUT_xxx macros if they are not defined

2018-11-28 Thread Peter Ross
efine SHUT_WR 1 +#define SHUT_RDWR 2 +#endif +#endif + #if !HAVE_SOCKLEN_T typedef int socklen_t; #endif -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-

[FFmpeg-devel] [PATCH] ff_connect_parallel: do not fail when getsockopt(SO_ERROR) returns EISCONN

2018-11-29 Thread Peter Ross
| last_err == AVERROR(EISCONN)) { // Everything is ok, we seem to have a successful // connection. Close other sockets and return this one. for (j = 0; j < nb_attempts; j++) -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 7

Re: [FFmpeg-devel] Fix for KLV in mpegts

2018-12-07 Thread Peter Ross
t; > Fix should be changing side_data type from "char *" to "uint8_t *". looks good. i will apply if no one else rejects. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] os_support: define socket shutdown SHUT_xxx macros if they are not defined

2018-12-08 Thread Peter Ross
On Wed, Nov 28, 2018 at 10:03:15PM +1100, Peter Ross wrote: > sys/socket.h (with WIN32 guard) is needed to check if the SHUT_xxx macro > exists. > and because of this, SHUT_xxx defs have been moved into the CONFIG_NETWORK > block, > since they only affect network ca

[FFmpeg-devel] [PATCH 1/2] configure: use custom allocator extralibs when testing memalign and posix_memalign

2018-12-08 Thread Peter Ross
;& enable memalign -check_func ${malloc_prefix}posix_memalign && enable posix_memalign +check_func ${malloc_prefix}memalign ${malloc_extralibs} && enable memalign +check_func ${malloc_prefix}posix_memalign ${malloc_extralibs} && enable posix_memalign check_func

[FFmpeg-devel] [PATCH 2/2] configure: djgpp: do not disable memalign when using custom_allocator

2018-12-08 Thread Peter Ross
/version.h "defined(__DJGPP__) && __DJGPP__ == 2 && __DJGPP_MINOR__ == 5"; then +if test -z "$custom_allocator" && test_cpp_condition sys/version.h "defined(__DJGPP__) && __DJGPP__ == 2 && __DJGPP_MINOR__ == 5"; then disa

[FFmpeg-devel] [PATCH] configure: support dlmalloc custom allocator

2018-12-08 Thread Peter Ross
prefix require libjemalloc jemalloc/jemalloc.h malloc -ljemalloc -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 09/18] vp3: eliminate copy_fields

2020-03-14 Thread Peter Ross
, superblock_count); > -#undef copy_fields > +if (qps_changed) { > +memcpy(s->qps, s1->qps, sizeof(s->qps)); > + memcpy(s->last_qps, s1->last_qps, sizeof(s->last_qps)); > +s-

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-03-20 Thread Peter Ross
0, 0, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, > +}; > + > +static const uint8_t bink2_next_skips[] = { > +0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 7, 0, 0, > bink2f_next_skips and bink2_next_skips are identical. can you double check? > +static const uint8_t ones_count[16] = { > +

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-03-21 Thread Peter Ross
= x / 32; > +c->current_idc[c->mb_pos].block_type = type; > +flags = 0; > +if (y == start) > +flags |= 0x80; > +if (!x) > + flags |= 0x20; > +if (x == 32) > +flags |= 0

[FFmpeg-devel] [PATCH] avcodec/vp3: propagate error codes

2020-04-04 Thread Peter Ross
goto error; } @@ -2892,7 +2892,7 @@ error: if (!HAVE_THREADS || !(s->avctx->active_thread_type & FF_THREAD_FRAME)) av_frame_unref(s->current_frame.f); -return -1; +return ret; } static int read_huffman_tree(AVCodecContext *avctx, GetBitContext *g

[FFmpeg-devel] [PATCH 1/2] avcodec/vp9: prevent null pointer use on init_frames() failure

2020-04-04 Thread Peter Ross
(s->next_refs[i].f) { if (s->next_refs[i].f->buf[0]) ff_thread_release_buffer(avctx, &s->next_refs[i]); av_frame_free(&s->next_refs[i].f); +} } free_buffers(s); -- 2.20.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description:

[FFmpeg-devel] [PATCH 2/2] avcodec/vp9: indent

2020-04-04 Thread Peter Ross
ctx, &s->next_refs[i]); -av_frame_free(&s->next_refs[i].f); +if (s->next_refs[i].f->buf[0]) +ff_thread_release_buffer(avctx, &s->next_refs[i]); +av_frame_free(&s->next_refs[i].f); } } -- 2.20.1 -- Pete

[FFmpeg-devel] [PATCH] avcodec/vp3: fix indentation

2020-04-07 Thread Peter Ross
3 + (i && s->chroma_y_shift))) - 1; -apply_loop_filter(s, i, row, row + 1); -} +for (i = 0; i < 3; i++) { +int row = (s->height >> (3 + (i && s->chroma_y_shift))) - 1; +apply_loop_filter(s, i, row, row + 1); +} vp

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: prevent null pointer use on init_frames() failure

2020-04-07 Thread Peter Ross
Signed-off-by: Peter Ross Reviewed-by: James Almer --- libavcodec/vp9.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 7ee375d4d0..2e6cd912a5 100644 --- a/libavcodec/vp9.c +++ b/libavcodec/vp9.c @@ -1216,17 +1216,14

[FFmpeg-devel] [PATCH] configure: add MV30 blockdsp dependency

2020-04-10 Thread Peter Ross
coder" msmpeg4v3_encoder_select="h263_encoder" mss2_decoder_select="mpegvideo qpeldsp vc1_decoder" mts2_decoder_select="mss34dsp" +mv30_decoder_select="blockdsp" mvha_decoder_deps="zlib" mvha_decoder_select="llviddsp" mwsc_decoder_deps=&qu

[FFmpeg-devel] [PATCH 1/2] avcodec/mv30: remove unused table elements

2020-04-11 Thread Peter Ross
, }; static const uint8_t zigzag[] = { -- 2.20.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

[FFmpeg-devel] [PATCH 2/2] avcodec/mv30: use aandcttables for quantizer scaling

2020-04-11 Thread Peter Ross
18, 22, 27, 44, 47, 46, @@ -116,7 +98,7 @@ static void get_qtable(int16_t *table, int quant, const uint8_t *quant_tab) for (int i = 0; i < 64; i++) { table[i] = av_clip((quant_tab[i] * factor + 0x32) / 100, 1, 0x7fff); -table[i] = ((int)scale_tab[i] * (int)table[i] + 0x800) &

[FFmpeg-devel] [PATCH] ffplay: do not segfault on stream_open internal error

2020-04-17 Thread Peter Ross
>= ic->nb_streams) return; codecpar = ic->streams[stream_index]->codecpar; -- 2.20.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel

[FFmpeg-devel] [PATCH] avcodec/pngdec: set return value on av_stereo3d_create_side_data() failure

2020-04-17 Thread Peter Ross
ereo3d) { +ret = AVERROR(ENOMEM); goto fail; +} if (mode == 0 || mode == 1) { stereo3d->type = AV_STEREO3D_SIDEBYSIDE; -- 2.20.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC4

Re: [FFmpeg-devel] [PATCH] ffplay: set stream_index to -1 earlier to prevent segfault

2020-04-17 Thread Peter Ross
Signed-off-by: Peter Ross Reviewed-by: Marton Balint --- Great suggestion. I will apply in a few days if no objections. fftools/ffplay.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 1beec54293..d673b8049a 100644 --- a

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/iff: Fix invalid pointer intermediates in decode_deep_rle32()

2020-04-22 Thread Peter Ross
lt;= src_end) { > +while (src_end - src >= 5) { > int opcode; > opcode = *(int8_t *)src++; > if (opcode >= 0) { > -- > 2.17.1 looks good. please apply. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signat

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/iff: Check length before memcpy() in decode_deep_rle32()

2020-04-22 Thread Peter Ross
if (src_end - src < length) > +return; > memcpy(dst + y*linesize + x * 4, src, length * 4); > src += length * 4; > x += length; hi michael. i think the guard should be: if (src_end - src < length * 4) return; c

Re: [FFmpeg-devel] [PATCH 3/8] avcodec/vp9_raw_reorder_bsf: Remove unnecessary header

2020-04-22 Thread Peter Ross
; > #include "libavutil/log.h" > #include "libavutil/mem.h" > -#include "libavutil/opt.h" > > #include "bsf.h" > #include "get_bits.h" > -- > 2.20.1 looks good. please apply. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 676

Re: [FFmpeg-devel] [PATCH 1/2] avformat/wtvdec: Check len in parse_chunks() to avoid overflow

2021-02-08 Thread Peter Ross
(pb); > -if (len < 32) { > +if (len < 32 || len > INT_MAX - 7) { > int ret; > if (avio_feof(pb)) > return AVERROR_EOF; the + 7 comes from WTV_PAD calculation looks good -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) __

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp8: Move end check into MB loop in vp78_decode_mv_mb_modes()

2021-02-15 Thread Peter Ross
+} > if (mb_y == 0) > AV_WN32A((mb - s->mb_width - 1)->intra4x4_pred_mode_top, > DC_PRED * 0x01010101); ok -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] avformat/wtvdec: Fix reading OLE dates on BE

2021-02-27 Thread Peter Ross
buf_size, int64_t value) > { > -time_t t = (av_int2double(value) - 25569.0) * 86400; > +time_t t = (av_int2double(av_le2ne64(value)) - 25569.0) * 86400; > struct tm tmbuf; > struct tm *tm= gmtime_r(&t, &tmbuf); > if (!tm) > -- > 2.27.0 ok, ple

[FFmpeg-devel] [PATCH] Bugfix for #9135

2021-03-02 Thread Peter White
Hello dear ffmpeg developers, I have just created ticket #9135 on the bug tracker. According to the instructions, I am sending the patch to this list, see attachment. Peter diff --git a/configure b/configure index d11942fced..bcc845668b 100755 --- a/configure +++ b/configure @@ -6490,7

Re: [FFmpeg-devel] [PATCH] Bugfix for #9135

2021-03-02 Thread Peter White
Sorry, apparently patches need to be sent inline, I just noticed. Please excuse my ignorance. Peter diff --git a/configure b/configure index d11942fced..bcc845668b 100755 --- a/configure +++ b/configure @@ -6490,7 +6490,7 @@ enabled mmal && { check_lib mmal interface/mma

Re: [FFmpeg-devel] [PATCH] configure: Fix bashism in openal check. (was: [PATCH] Bugfix for #9135)

2021-03-02 Thread Peter White
On 02.03.21 17:56, James Almer wrote: On 3/2/2021 1:25 PM, Peter White wrote: Sorry, apparently patches need to be sent inline, I just noticed. Please excuse my ignorance. They don't need to be inline, although it is preferred. What they need to be is made with git format-patch,

Re: [FFmpeg-devel] [PATCH] configure: Fix bashism in openal check. (was: [PATCH] Bugfix for #9135)

2021-03-02 Thread Peter White
On 02.03.21 23:15, Marton Balint wrote: On Tue, 2 Mar 2021, Peter White wrote: On 02.03.21 17:56, James Almer wrote: On 3/2/2021 1:25 PM, Peter White wrote: Sorry, apparently patches need to be sent inline, I just noticed. Please excuse my ignorance. They don't need to be i

Re: [FFmpeg-devel] [PATCH] configure: Fix bashism in openal check. (was: [PATCH] Bugfix for #9135)

2021-03-05 Thread Peter White
This is a test to check if my postfix setup does what I intend. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH] configure: Fix bashism in openal check. (was: [PATCH] Bugfix for #9135)

2021-03-05 Thread Peter White
properly anyways but procrastinated it until now. Now I have finally done it. Shall I send the patch again, opening a new thread, or will the previous attachment suffice? So far it seems to be getting ignored, or do I simply need to be more patient? Peter _

Re: [FFmpeg-devel] DRM decryption with FFmpeg

2021-03-09 Thread Peter White
On Tue, Mar 09, 2021 at 12:48:45PM +0100, zsugabubus wrote: > Hi, > > On Tue, Mar 09, 2021 at 10:54:22AM +0100, Paul B Mahol wrote: > > We do not accept DRM code. > > Hmm. And what about only accepting files that are considered legal? DRM is AIDS wrapped in Cancer seasoned with a smidge of Syphi

[FFmpeg-devel] Feature request: "overlap" option for segment muxer?

2021-03-22 Thread Peter B.
e time before/after each cut, so that the output segments overlap? Thank you very much in advance, Peter B. (*) For example: $ ffmpeg -i day1.ts -c copy -map 0 -copy_unknown -f segment -segment_time 3600 out/day1-%03d.ts # Links: [1] https://ffmpeg.org/ffmpeg-all.html#segment_002c-stream_

[FFmpeg-devel] Feature request: Segment using info from textfile?

2021-03-22 Thread Peter B.
n the following information:   * start-position   * end-position   * title Creating a separate file for each start/end/title line. We would need such a functionality for archival preservation of multi-content recordings. This can be a paid request. Thank you very much in advance, Peter B. #

Re: [FFmpeg-devel] [PATCH] avcodec/msp2dec: Check available space in RLE decoder

2021-04-06 Thread Peter Ross
0] + x, gb.buffer, > FFMIN(size, width - x)); > bytestream2_skip(&gb, size); > } else { please apply -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/anm: Check extradata length before allocating frame

2020-05-30 Thread Peter Ross
OR_INVALIDDATA; > -} > - > bytestream2_skipu(&s->gb, 16 * 8); > for (i = 0; i < 256; i++) > s->palette[i] = (0xFFU << 24) | bytestream2_get_le32u(&s->gb); > -- > 2.20.1 ok. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC4

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/anm: Don't unnecessarily use context variables

2020-05-30 Thread Peter Ross
type >>= 14; > if (!count) { > @@ -167,11 +166,11 @@ static int decode_frame(AVCodecContext *avctx, > } > continue; > } > -pixel = type == 3 ? b

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/vp3: Check for end of input in 2 places of vp4_unpack_macroblocks()

2019-09-02 Thread Peter Ross
> } > > if (has_partial) { > +if (get_bits_left(gb) <= 0) > +return AVERROR_INVALIDDATA; > bit = get_bits1(gb); > current_run = vp4_get_mb_count(s, gb); > for (i = 0; i < s->yuv_macroblock_count; i++)

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/hashenc: add streamhash muxer

2019-09-12 Thread Peter B.
on't make it optional, what should the format be? >> Thus?: >> >> 0,v,SHA256=... >> 1,a,SHA256=... >> 2,s,SHA256=... > Looks fine. +1 from me, too :) I guess with multiple A/V tracks it will then be like this? 0,v,SHA256=... 1,v,SHA256

Re: [FFmpeg-devel] [PATCH 2/3] tools/target_dec_fuzzer: Adjust threshold for binkvideo

2019-09-16 Thread Peter Ross
+case AV_CODEC_ID_BINKVIDEO: maxpixels /= 32; break; > case AV_CODEC_ID_DIRAC: maxpixels /= 8192; break; > case AV_CODEC_ID_MSRLE: maxpixels /= 16; break; > case AV_CODEC_ID_QTRLE: maxpixels /= 16; break; > -- > 2.23.0 approve -- Peter (A907 E02F

Re: [FFmpeg-devel] [PATCH v2 3/3] avformat/hashenc: add streamhash muxer

2019-09-19 Thread Peter B.
btw: If you need anything to be tested, just let me know :) Cheers! Peter ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 3/5] tools/target_dec_fuzzer: Adjust VP7 threshold

2019-09-28 Thread Peter Ross
AV_CODEC_ID_TRUEMOTION2: maxpixels /= 1024; break; > +case AV_CODEC_ID_VP7: maxpixels /= 256; break; > } ok. however i am curious why this is needed for vp7 and not vp8. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 1/5] avformat/electronicarts: If no packet has been read at the end do not treat it as if theres a packet

2019-10-01 Thread Peter Ross
b)) > ret = AVERROR_EOF; > -packet_read = 1; > +hit_end = 1; > break; > > case MVIh_TAG: > @@ -737,6 +738,9 @@ get_video_packet: > > if (ret < 0 && partial_packet) > av_packet_unref(pkt); > +

Re: [FFmpeg-devel] [PATCH v1 04/11] avformat/jvdec: fix memleak when read_header failed

2019-10-09 Thread Peter Ross
gt; + av_freep(&ast->index_entries); > return AVERROR_INVALIDDATA; > } looks good. please apply. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

2019-10-11 Thread Peter Ross
(!s->version_b) > -- > 2.23.0 i think this checl belongs inside the fuzzer test harness, or as a general purpose codec check. the bink and smaker demuxers will only ever use BINKAUDIO_RDFT with 1 or 2 channels. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.as

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

2019-10-12 Thread Peter Ross
On Sat, Oct 12, 2019 at 06:53:05PM -0300, James Almer wrote: > On 10/12/2019 5:47 PM, Michael Niedermayer wrote: > > On Fri, Oct 11, 2019 at 08:51:54PM +1100, Peter Ross wrote: > >> On Fri, Oct 11, 2019 at 12:40:07AM +0200, Michael Niedermayer wrote: > >>>

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

2019-10-15 Thread Peter Ross
On Mon, Oct 14, 2019 at 10:06:55PM +0200, Michael Niedermayer wrote: > On Sun, Oct 13, 2019 at 10:51:49AM +1100, Peter Ross wrote: > > On Sat, Oct 12, 2019 at 06:53:05PM -0300, James Almer wrote: > > > On 10/12/2019 5:47 PM, Michael Niedermayer wrote: > > > > On F

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/vp5: Check render_x/y

2019-10-24 Thread Peter Ross
acroblock > rows */ > +render_x = vp56_rac_gets(c, 8); /* number of displayed macroblock > cols */ > +if (render_x == 0 || render_x > cols || > +render_y == 0 || render_y > rows) > +return AVERROR_INVALIDDATA; > vp56_rac_gets(c

Re: [FFmpeg-devel] [PATCH v2] avcodec/vp8: fix multiple ff_thread_finish_setup() calls

2019-11-18 Thread Peter Ross
l > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > > > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.or

Re: [FFmpeg-devel] [PATCH v2] avcodec/vp8: fix multiple ff_thread_finish_setup() calls

2019-11-26 Thread Peter Ross
On Mon, Nov 25, 2019 at 10:14:41PM +0800, zhilizhao wrote: > Please help to merge the patch if it’s acceptable, thanks! no code changes, it is acceptable as-is. > > > On Nov 18, 2019, at 7:00 PM, Peter Ross wrote: > > > > On Mon, Nov 18, 2019 at 10:34:32AM +0800, zhiliz

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1enc: Use version 3 by default (CRCs by default)

2019-12-09 Thread Peter B.
work on newer decoders)" [/quote] This should be known. However, since I hardly see any reason to prefer v1 over v3 anymore, and considering that it's now the most widely one used, I'm happy to see it become default. Any objec

Re: [FFmpeg-devel] [PATCH 10/11] avformat/wtvdec: Fix memleak when reading header fails

2020-01-07 Thread Peter Ross
> +wtvfile_close(wtv->pb); > return ret; > +} > avio_seek(wtv->pb, -32, SEEK_CUR); > > timeline_pos = avio_tell(s->pb); // save before opening another file > -- > 2.20.1 looks good. please apply. -- Peter (A90

Re: [FFmpeg-devel] [PATCH 11/11] avformat/wtvdec: Cosmetics

2020-01-07 Thread Peter Ross
; -return 0; > -} > +if (mode == SEEK_TO_PTS && wtv->pts >= seekts) { > +avio_skip(pb, WTV_PAD8(len) - consumed); > +return 0; > +} > } > } &

Re: [FFmpeg-devel] [PATCH] avformat/tty: add probe function

2020-01-28 Thread Peter Ross
ty_demuxer = { > .name = "tty", > .long_name = NULL_IF_CONFIG_SMALL("Tele-typewriter"), > .priv_data_size = sizeof(TtyDemuxContext), > +.read_probe = read_probe, > .read_header= read_header, > .read_packet= read_pac

Re: [FFmpeg-devel] [PATCH 2/2] tools/target_dec_fuzzer: Add threshold for IFF_ILBM

2020-01-28 Thread Peter Ross
V_CODEC_ID_FFWAVESYNTH: maxsamples /= 16384; break; > +case AV_CODEC_ID_IFF_ILBM: maxpixels /= 128; break; > case AV_CODEC_ID_MSRLE: maxpixels /= 16; break; > case AV_CODEC_ID_QTRLE: maxpixels /= 16; break; > case AV_CODEC_ID_RASC: maxpixels /= 16; br

[FFmpeg-devel] [PATCH] ansi: process ESC[3m italics attribute

2020-02-17 Thread Peter Ross
(m == 1 || m == 2 || m == 4 || m == 5 || m == 7 || m == 8) { +} else if (m == 1 || m == 2 || m == 3 || m == 4 || m == 5 || m == 7 || m == 8) { s->attributes |= 1 << (m - 1); } else if (m >= 30 && m <= 37) { s->

Re: [FFmpeg-devel] [PATCH 1/2] avformat/wtvdec: Forward errors when reading packet

2020-02-19 Thread Peter Ross
buf_size = FFMIN(buf_size, wf->length - wf->position); > > while(nread < buf_size) { > > -int n; > > int remaining_in_sector = (1 << wf->sector_bits) - (wf->position & > > ((1 << wf->sector_bits) - 1)); > > int re

Re: [FFmpeg-devel] [PATCH 4/9] avformat/wtvdec: Improve size overflow checks in parse_chunks()

2021-04-21 Thread Peter Ross
size = avio_rl32(pb); > -if (size < 0 || size > INT_MAX - 76) > +if (size < 0 || size > INT_MAX - 76 - consumed) > return AVERROR_INVALIDDATA; > parse_media_type(s, s->streams[stream_inde

Re: [FFmpeg-devel] [PATCH] avcodec/Makefile: Remove obsolete dependency of eatqi dec on rl.o

2021-04-27 Thread Peter Ross
FIG_EATQI_DECODER) += eatqi.o eaidct.o mpeg12.o \ > + mpeg12data.o mpegvideodata.o > OBJS-$(CONFIG_EIGHTBPS_DECODER)+= 8bps.o > OBJS-$(CONFIG_EIGHTSVX_EXP_DECODER)+= 8svx.o > OBJS-$(CONFIG_EIGHTSVX_FIB_DECODER)+= 8svx.o > -- > 2.27.0 please apply -

[FFmpeg-devel] [PATCH] libswscale: Make sws_init_context thread safe.

2021-04-28 Thread Peter Lundblad
Call ff_sws_rgb2rgb_init via ff_thread_once instead of checking one of the variables it updates. --- libswscale/utils.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index 6bac7b658d..d673209d95 100644 --- a/libswscale/utils.c +++

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mvdec: Check sample rate in parse_audio_var()

2021-04-28 Thread Peter Ross
rcmp(name, "SAMPLE_WIDTH")) { > uint64_t bpc = var_read_int(pb, size) * (uint64_t)8; > -- > 2.17.1 please apply -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/vp3: Don't try to decode VP4 when VP4 decoder is disabled

2021-05-08 Thread Peter Ross
n = 3; > -else if (avctx->codec_tag == MKTAG('V', 'P', '3', '0')) > +#if !CONFIG_VP4_DECODER > +av_log(avctx, AV_LOG_ERROR, "This build does not support decoding > VP4.\n"); > +return AVERROR_DECODER_NOT_FOUN

[FFmpeg-devel] [PATCH] fix broken links to msdn documentation

2021-05-09 Thread Peter Ross
. Revision 01.20.03. - * [2]http://msdn.microsoft.com/en-us/library/bb643323.aspx + * [2]http://web.archive.org/web/20131203084402/http://msdn.microsoft.com/en-us/library/bb643323.aspx */ #include "avformat.h" -- 2.30.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5

Re: [FFmpeg-devel] [PATCH] libswscale: Make sws_init_context thread safe.

2021-06-28 Thread Peter Lundblad
Hi, Would anyone consider applying this fairly simple patch to fix a multi-threading issue in the sws initialization code? Regards, //Peter On Wed, Apr 28, 2021 at 11:51 AM Peter Lundblad wrote: > Call ff_sws_rgb2rgb_init via ff_thread_once instead of checking one of the > variab

Re: [FFmpeg-devel] [PATCH 4/4] avformat/wtvdec: Check for EOF before seeking back in parse_media_type()

2021-08-01 Thread Peter Ross
)) > +return NULL; > avio_seek(pb, -size, SEEK_CUR); > > st = parse_media_type(s, st, sid, mediatype, actual_subtype, > actual_formattype, size - 32); ok -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature

[FFmpeg-devel] [PATCH] avutil/tests/random_seed: seeds[] is uint32_t, therefore use PRIX32 macro

2018-12-14 Thread Peter Ross
n 1; } } -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avutil/tests/random_seed: seeds[] is uint32_t, therefore use PRIX32 macro

2018-12-14 Thread Peter Ross
On Sat, Dec 15, 2018 at 03:10:52AM +0100, Carl Eugen Hoyos wrote: > 2018-12-15 3:07 GMT+01:00, Peter Ross : > > squelch format type warning > > --- > > libavutil/tests/random_seed.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp7: Check for end of input in vp78_decode_mv_mb_modes()

2018-12-14 Thread Peter Ross
> s->mv_bounds.mv_min.x = -MARGIN; > s->mv_bounds.mv_max.x = ((s->mb_width - 1) << 6) + MARGIN; > + > +if (vpX_rac_is_end(&s->c)) { > + return AVERROR_INVALIDDATA; > +} > for (mb_x = 0; mb_x <

Re: [FFmpeg-devel] [PATCH 1/2] configure: use custom allocator extralibs when testing memalign and posix_memalign

2018-12-16 Thread Peter Ross
On Sun, Dec 09, 2018 at 09:27:54AM +1100, Peter Ross wrote: > the memalign and posix_memalign tests currently fail when using a custom > allocator, > because configure does not include the custom allocator library. is any one using custom allocators? should i just apply these? -- Pe

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2018-12-19 Thread Peter Ross
vpkt->size before buf[10]; > +av_log(avctx, AV_LOG_WARNING, "this is a thumbnails file, " > + "reading first thumbnail only\n"); > +} else if (avpkt->size < 786432) { > +return AVERROR_INVALIDDATA; > +} > + > +

[FFmpeg-devel] [PATCH 1/3] configure: --help typo

2018-12-19 Thread Peter Ross
path to libfuzzer --ignore-tests=TESTS comma-separated list (without "fate-" prefix in the name) of tests whose result is ignored -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP

[FFmpeg-devel] [PATCH 2/3] configure: --help should display --host-extralibs

2018-12-19 Thread Peter Ross
compiler host OS [$target_os] --extra-cflags=ECFLAGS add ECFLAGS to CFLAGS [$CFLAGS] --extra-cxxflags=ECFLAGS add ECFLAGS to CXXFLAGS [$CXXFLAGS] -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature

[FFmpeg-devel] [PATCH 3/3] configure: make --windres option work

2018-12-19 Thread Peter Ross
refix toolchain valgrind +windres x86asmexe " -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.o

[FFmpeg-devel] [PATCH 1/2] fate: add dst decoder test

2018-12-20 Thread Peter Ross
4704,18816, 0x6a7f3268 -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 2/2] dstdec: use appropriate alignment

2018-12-20 Thread Peter Ross
]; DECLARE_ALIGNED(16, int16_t, filter)[DST_MAX_ELEMENTS][16][256]; DSDContext dsdctx[DST_MAX_CHANNELS]; } DSTContext; -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg

Re: [FFmpeg-devel] [PATCH 1/2] fate: add dst decoder test

2018-12-21 Thread Peter Ross
On Sat, Dec 22, 2018 at 12:26:05AM +0100, Carl Eugen Hoyos wrote: > 2018-12-21 3:32 GMT+01:00, Peter Ross : > > --- > > the dst sample file is 40 kilobytes. > > You could attach it... here is the file. cheers, -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

[FFmpeg-devel] [PATCH 1/4] vp3: ref_frame/ref_frames are only required when HAVE_THREADS=1

2019-01-05 Thread Peter Ross
ext(AVCodecContext *dst, const AVCodecContext *src) { Vp3DecodeContext *s = dst->priv_data, *s1 = src->priv_data; -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-deve

[FFmpeg-devel] [PATCH 0/4] On2 VP4 video decoder

2019-01-05 Thread Peter Ross
identical to the reference decoder. I have tested it on x86 and arm, but not done fuzzing to find hangs. Suggetions how to improve it are most welcome. Peter Ross (4): vp3: ref_frame/ref_frames are only required when HAVE_THREADS=1 vp3dsp: add 12 pixel loop filter functions VP4 data tables

[FFmpeg-devel] [PATCH 2/4] vp3dsp: add 12 pixel loop filter functions

2019-01-05 Thread Peter Ross
8_t *first_pixel, ptrdiff_t stride, int *bounding_values); + void ff_vp3dsp_init(VP3DSPContext *c, int flags); void ff_vp3dsp_init_arm(VP3DSPContext *c, int flags); void ff_vp3dsp_init_ppc(VP3DSPContext *c, int flags); -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) s

[FFmpeg-devel] [PATCH 3/4] VP4 data tables

2019-01-05 Thread Peter Ross
/vp4data.h @@ -0,0 +1,3784 @@ +/* + * Copyright (C) 2019 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either

[FFmpeg-devel] [PATCH 4/4] VP4 video decoder

2019-01-05 Thread Peter Ross
rops = AV_CODEC_PROP_LOSSY, }, { diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index a5d8c2ed0b..127189a22b 100644 --- a/libavcodec/vp3.c +++ b/libavcodec/vp3.c @@ -1,5 +1,6 @@ /* * Copyright (C) 2003-2004 The FFmpeg project + * Copyright (C) 2019 Peter Ross * * This file is part

[FFmpeg-devel] [PATCH] dstdec: big-endian compatiblity

2019-01-06 Thread Peter Ross
WL64A(status + 8, (RL64A(status + 8) << 1) | ((RL64A(status) >> 63) & 1)); +WL64A(status, (RL64A(status) << 1) | v); } } -- 2.17.1 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 4/4] VP4 video decoder

2019-01-06 Thread Peter Ross
On Sun, Jan 06, 2019 at 10:11:14AM +0100, Paul B Mahol wrote: > On 1/6/19, Peter Ross wrote: > > --- > > Changelog | 1 + > > doc/general.texi| 2 + > > libavcodec/codec_desc.c | 2 +- > &g

<    1   2   3   4   5   6   7   >