Re: [FFmpeg-devel] [PATCH 10/11] avformat/wtvdec: Fix memleak when reading header fails

[Peter Ross]

On Tue, Jan 07, 2020 at 02:55:48PM +0100, Andreas Rheinhardt wrote:
> Fixes #8314.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinha...@gmail.com>
> ---
>  libavformat/wtvdec.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/libavformat/wtvdec.c b/libavformat/wtvdec.c
> index 706e8ca38d..92629bb31b 100644
> --- a/libavformat/wtvdec.c
> +++ b/libavformat/wtvdec.c
> @@ -993,8 +993,10 @@ static int read_header(AVFormatContext *s)
>      }
>  
>      ret = parse_chunks(s, SEEK_TO_DATA, 0, 0);
> -    if (ret < 0)
> +    if (ret < 0) {
> +        wtvfile_close(wtv->pb);
>          return ret;
> +    }
>      avio_seek(wtv->pb, -32, SEEK_CUR);
>  
>      timeline_pos = avio_tell(s->pb); // save before opening another file
> -- 
> 2.20.1

looks good. please apply.

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

signature.asc
Description: PGP signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".