On Sun, Jan 06, 2019 at 10:11:14AM +0100, Paul B Mahol wrote: > On 1/6/19, Peter Ross <pr...@xvid.org> wrote: > > --- > > Changelog | 1 + > > doc/general.texi | 2 + > > libavcodec/codec_desc.c | 2 +- > > libavcodec/vp3.c | 701 ++++++++++++++++++++++++++++++++++++++-- > > libavformat/riff.c | 1 + > > 5 files changed, 671 insertions(+), 36 deletions(-) > > Why is it not using own codec id? It is better that way IMHO.
seperate ids would enable users to independently disable the decoder. but other than that, i don't know what value this brings. the codecs are very similar. even the reference implementation only uses the version field to distinguish them. if i change a true VP3 file to use the 'VP40' fourcc, it decodes correctly. if i change a true VP4 file to use the 'VP31' fourcc, it also decodes correctly. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
