Re: [FFmpeg-devel] [PATCH 2/5] avfilter/af_atempo: Simplify resetting

2024-05-22 Thread Pavel Koshevoy
On Wed, May 22, 2024, 02:59 Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > The earlier code distinguished between a partial reset > (yae_clear()) and a complete reset (yae_release_buffers() > which also releases the buffers); this separation existed > to avoid allocations, as buffer

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: offset all output timestamps by same amount of first input timestamp

2019-05-06 Thread Pavel Koshevoy
On Mon, May 6, 2019, 06:42 Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > Makes ffplay display correct timestamps when seeking. > --- > libavfilter/af_atempo.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/af_atempo.c b/libavfilter/af_ate

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: offset all output timestamps by same amount of first input timestamp

2019-05-06 Thread Pavel Koshevoy
On Mon, May 6, 2019, 07:28 Pavel Koshevoy wrote: > > > On Mon, May 6, 2019, 06:42 Paul B Mahol wrote: > >> Signed-off-by: Paul B Mahol >> --- >> Makes ffplay display correct timestamps when seeking. >> --- >> libavfilter/af_atempo.c | 8 +++- >&

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: offset all output timestamps by same amount of first input timestamp

2019-05-07 Thread Pavel Koshevoy
On 5/7/19 8:41 PM, Pavel Koshevoy wrote: On 5/6/19 6:41 AM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- Makes ffplay display correct timestamps when seeking. ---   libavfilter/af_atempo.c | 8 +++-   1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavfilter

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: offset all output timestamps by same amount of first input timestamp

2019-05-07 Thread Pavel Koshevoy
On 5/6/19 6:41 AM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- Makes ffplay display correct timestamps when seeking. --- libavfilter/af_atempo.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c index bfdad7d76

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: offset all output timestamps by same amount of first input timestamp

2019-05-07 Thread Pavel Koshevoy
On 5/7/19 9:02 PM, Pavel Koshevoy wrote: On 5/7/19 8:41 PM, Pavel Koshevoy wrote: On 5/6/19 6:41 AM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- Makes ffplay display correct timestamps when seeking. ---   libavfilter/af_atempo.c | 8 +++-   1 file changed, 7 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: offset all output timestamps by same amount of first input timestamp

2019-05-07 Thread Pavel Koshevoy
btw, I don't know if there is already a way to do this with an existing utility function... there probably is and I just don't know about it. I wrote this debugging helper to help me verify input/output PTS in atempo, I can send a patch if it's useful.  Alternatively, I'd like to know what the

[FFmpeg-devel] [PATCH] avfilter/af_atempo: Make ffplay display correct timestamps when seeking

2019-05-07 Thread Pavel Koshevoy
NOTE: this is a refinement of the patch from Paul B Mahol offset all output timestamps by same amount of first input timestamp --- libavfilter/af_atempo.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c index bfdad7d

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: Make ffplay display correct timestamps when seeking

2019-05-08 Thread Pavel Koshevoy
On 5/8/19 1:13 AM, Paul B Mahol wrote: On 5/8/19, Pavel Koshevoy wrote: NOTE: this is a refinement of the patch from Paul B Mahol offset all output timestamps by same amount of first input timestamp --- libavfilter/af_atempo.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_zscale: add slice threading

2019-05-31 Thread Pavel Koshevoy
On Fri, May 31, 2019 at 4:46 AM Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_zscale.c | 335 +--- > 1 file changed, 214 insertions(+), 121 deletions(-) > > diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c > index f03

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_zscale: add slice threading

2019-05-31 Thread Pavel Koshevoy
On Fri, May 31, 2019 at 1:44 PM Pavel Koshevoy wrote: > > > > > On Fri, May 31, 2019 at 4:46 AM Paul B Mahol wrote: > > > > Signed-off-by: Paul B Mahol > > --- > > libavfilter/vf_zscale.c | 335 +--- > > 1 f

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_zscale: add slice threading

2019-05-31 Thread Pavel Koshevoy
On Fri, May 31, 2019 at 2:03 PM Paul B Mahol wrote: > > On 5/31/19, Pavel Koshevoy wrote: > > On Fri, May 31, 2019 at 1:44 PM Pavel Koshevoy wrote: > >> > >> > >> > >> > >> On Fri, May 31, 2019 at 4:46 AM Paul

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_zscale: add slice threading

2019-05-31 Thread Pavel Koshevoy
On Fri, May 31, 2019 at 2:17 PM Paul B Mahol wrote: > > On 5/31/19, Pavel Koshevoy wrote: > > On Fri, May 31, 2019 at 2:03 PM Paul B Mahol wrote: > >> > >> On 5/31/19, Pavel Koshevoy wrote: > >> > On Fri, May 31, 2019 at 1:44 PM Pavel Koshevoy > &

[FFmpeg-devel] [PATCH] avcodec/videotoolbox_hevc: avoid leaking cached_hw_frames_ctx

2019-08-06 Thread Pavel Koshevoy
vtctx->cached_hw_frames_ctx is unref'd in videotoolbox_uninit, but videotoolbox_hevc used ff_videotoolbox_uninit which doesn't unref cache_hw_frames_ctx. --- libavcodec/videotoolbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/videotoolbox.c b/libavcodec/videoto

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox_hevc: avoid leaking cached_hw_frames_ctx

2019-08-14 Thread Pavel Koshevoy
On Tue, Aug 6, 2019 at 8:50 PM Pavel Koshevoy wrote: > > vtctx->cached_hw_frames_ctx is unref'd in videotoolbox_uninit, > but videotoolbox_hevc used ff_videotoolbox_uninit which > doesn't unref cache_hw_frames_ctx. > --- > libavcodec/videotoolbox.c | 2 +- >

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox_hevc: avoid leaking cached_hw_frames_ctx

2019-08-23 Thread Pavel Koshevoy
On Tue, Aug 6, 2019 at 8:50 PM Pavel Koshevoy wrote: > > vtctx->cached_hw_frames_ctx is unref'd in videotoolbox_uninit, > but videotoolbox_hevc used ff_videotoolbox_uninit which > doesn't unref cache_hw_frames_ctx. > --- > libavcodec/videotoolbox.c | 2 +- >

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox_hevc: avoid leaking cached_hw_frames_ctx

2019-08-23 Thread Pavel Koshevoy
On Fri, Aug 23, 2019 at 8:12 AM Pavel Koshevoy wrote: > > On Tue, Aug 6, 2019 at 8:50 PM Pavel Koshevoy wrote: > > > > vtctx->cached_hw_frames_ctx is unref'd in videotoolbox_uninit, > > but videotoolbox_hevc used ff_videotoolbox_uninit which >

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox_hevc: avoid leaking cached_hw_frames_ctx

2019-08-23 Thread Pavel Koshevoy
On 8/23/19 3:46 PM, Aman Gupta wrote: On Wed, Aug 14, 2019 at 3:53 AM Pavel Koshevoy wrote: On Tue, Aug 6, 2019 at 8:50 PM Pavel Koshevoy wrote: vtctx->cached_hw_frames_ctx is unref'd in videotoolbox_uninit, but videotoolbox_hevc used ff_videotoolbox_uninit which doesn

[FFmpeg-devel] [PATCH] lavfi/atempo: fix tempo range limit inconsistency

2018-10-03 Thread Pavel Koshevoy
yae_set_tempo was overlooked when max tempo limit was raised to 100. tested with: ./ffmpeg_g -i Delerium/SemanticSpaces/Gateway.mp3 \ -af asendcmd=f=asendcmd.cfg,atempo=1.0 -y /tmp/asendcmd-atempo.wav where asendcmd.cfg was: 15.0-45.0 [enter] atempo tempo 2.0, [leave] atempo tempo 0.5;

Re: [FFmpeg-devel] [PATCH] lavfi/atempo: fix tempo range limit inconsistency

2018-10-04 Thread Pavel Koshevoy
On Thu, Oct 4, 2018 at 2:11 AM Nicolas George wrote: > > Pavel Koshevoy (2018-10-03): > > yae_set_tempo was overlooked when max tempo limit was raised to 100. > > > > tested with: > > ./ffmpeg_g -i Delerium/SemanticSpaces/Gateway.mp3 \ > > -af asendcmd=f=asen

Re: [FFmpeg-devel] [PATCH] avfilter/setparams: add FF_FILTER_FLAG_HWFRAME_AWARE

2021-03-14 Thread Pavel Koshevoy
On Thu, Oct 1, 2020 at 4:24 PM Mark Thompson wrote: > On 29/09/2020 19:49, Pavel Koshevoy wrote: > > On Tue, Sep 29, 2020 at 12:14 PM Mark Thompson wrote: > > > >> On 29/09/2020 18:14, Pavel Koshevoy wrote: > >>> On Tue, Sep 29, 2

Re: [FFmpeg-devel] [PATCH] avfilter/setparams: add FF_FILTER_FLAG_HWFRAME_AWARE

2021-03-14 Thread Pavel Koshevoy
On Sun, Mar 14, 2021 at 1:59 PM Pavel Koshevoy wrote: > > I guess I no longer know how to use avfilter api: > > I've been doing this: > ``` > graph_ = avfilter_graph_alloc(); > > if (nb_threads_ > 0) > { > graph_->nb_threa

[FFmpeg-devel] [PATCH] avformat/utils: Preserve AV_PKT_FLAG_CORRUPT

2021-03-17 Thread Pavel Koshevoy
Preserve AV_PKT_FLAG_CORRUPT so the caller can decide whether to drop the packet. --- libavformat/utils.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index a73f944e6e..0dc978e3d2 100644 --- a/libavformat/utils.c +++ b/libavformat/

Re: [FFmpeg-devel] [PATCH] avformat/utils: Preserve AV_PKT_FLAG_CORRUPT

2021-03-18 Thread Pavel Koshevoy
On Thu, Mar 18, 2021 at 2:51 PM Marton Balint wrote: > > > On Wed, 17 Mar 2021, Pavel Koshevoy wrote: > > > Preserve AV_PKT_FLAG_CORRUPT so the caller can decide whether to drop > > the packet. > > LGTM, but Michael was against it last time: > > > http

Re: [FFmpeg-devel] [PATCH] avformat/utils: Preserve AV_PKT_FLAG_CORRUPT

2021-03-18 Thread Pavel Koshevoy
On Thu, Mar 18, 2021 at 2:57 PM Pavel Koshevoy wrote: > > > On Thu, Mar 18, 2021 at 2:51 PM Marton Balint wrote: > >> >> >> On Wed, 17 Mar 2021, Pavel Koshevoy wrote: >> >> > Preserve AV_PKT_FLAG_CORRUPT so the caller can decide whether to drop

Re: [FFmpeg-devel] [PATCH] avformat/utils: Preserve AV_PKT_FLAG_CORRUPT

2021-03-19 Thread Pavel Koshevoy
On Fri, Mar 19, 2021 at 7:58 AM Michael Niedermayer wrote: > On Wed, Mar 17, 2021 at 06:19:26PM -0600, Pavel Koshevoy wrote: > > Preserve AV_PKT_FLAG_CORRUPT so the caller can decide whether to drop > > the packet. > > --- > > libavformat/utils.c | 3 ++- > > 1

[FFmpeg-devel] [PATCH] lavc/tiff: Fix build failure due to always_inline

2021-03-29 Thread Pavel Koshevoy
Fixes: src/libavcodec/tiff.c: In function ‘tiff_unpack_strip’: src/libavcodec/tiff.c:280: error: ‘always_inline’ function could not be inlined in call to ‘dng_blit’: the function body must appear before caller src/libavcodec/tiff.c:720: error: called from here --- libavcodec/tiff.c | 6 +++--- 1

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/tiff: Avoid forward declarations

2021-03-30 Thread Pavel Koshevoy
On Tue, Mar 30, 2021 at 2:11 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > In this case it also fixes a potential for compilation failures: > Not all compilers can handle the case in which a function with > a forward declaration declared with an attribute to always inline it > i

Re: [FFmpeg-devel] [PATCH] lavc/tiff: Fix build failure due to always_inline

2021-03-30 Thread Pavel Koshevoy
On Tue, Mar 30, 2021 at 2:26 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Pavel Koshevoy: > > Fixes: > > src/libavcodec/tiff.c: In function ‘tiff_unpack_strip’: > > src/libavcodec/tiff.c:280: error: ‘always_inline’ function could not be > inli

[FFmpeg-devel] suspicious unconditional `goto fail` in decode.c:1892

2020-05-27 Thread Pavel Koshevoy
Hi, I've run into a regression that I've tracked down to this snippet of code in libavcodec/decode.c ``` if (hwaccel) { if (hwaccel->alloc_frame) { ret = hwaccel->alloc_frame(avctx, frame); goto fail; } } else avctx->sw_pix_fmt = avctx->pix_f

[FFmpeg-devel] [PATCH] lavc/nvenc: disable FMO unconditionally...

2020-06-01 Thread Pavel Koshevoy
because ff_h264_decode_picture_parameter_set doesn't support FMO --- libavcodec/nvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index cb33f9..c21c6dc567 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -997,12 +997,

[FFmpeg-devel] [PATCH] lavc/v4l2_m2m: don't close the file descriptor we don't own

2019-09-02 Thread Pavel Koshevoy
ff_v4l2_m2m_create_context initialized V4L2m2mContext.fd to 0 which is a valid file descriptor value. Next ff_v4l2_m2m_codec_init failed and v4l2_m2m_destroy_context closed file descriptor 0 even though it didn't belong to V4L2m2mContext. --- libavcodec/v4l2_m2m.c | 1 + 1 file changed, 1 insertio

Re: [FFmpeg-devel] [PATCH] lavc/v4l2_m2m: don't close the file descriptor we don't own

2019-09-02 Thread Pavel Koshevoy
On Mon, Sep 2, 2019 at 10:40 AM Aman Gupta wrote: > > > > On Mon, Sep 2, 2019 at 12:27 AM Pavel Koshevoy wrote: >> >> ff_v4l2_m2m_create_context initialized V4L2m2mContext.fd to 0 >> which is a valid file descriptor value. Next ff_v4l2_m2m_codec_init >> failed

Re: [FFmpeg-devel] [PATCH 14/14] avfilter/af_atempo: use ff_filter_process_command()

2019-10-09 Thread Pavel Koshevoy
On Wed, Oct 9, 2019 at 4:19 AM Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > --- > libavfilter/af_atempo.c | 25 - > 1 file changed, 8 insertions(+), 17 deletions(-) > > diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c > index 688dac5464..39b500ba95

Re: [FFmpeg-devel] [PATCH 14/14] avfilter/af_atempo: use ff_filter_process_command()

2019-10-10 Thread Pavel Koshevoy
On Thu, Oct 10, 2019 at 5:41 AM Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > --- > libavfilter/af_atempo.c | 25 - > 1 file changed, 8 insertions(+), 17 deletions(-) > > diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c > index 688dac5464..e4fc691abe

[FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable

2021-05-25 Thread Pavel Koshevoy
Un-hardcode the 200ms minimum latency between emitting subtitle events so that those that wish to receive a subtitle event for every screen change could do so. --- libavcodec/ccaption_dec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcode

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable

2021-05-26 Thread Pavel Koshevoy
On Wed, May 26, 2021, 00:18 Moritz Barsnick wrote: > On Tue, May 25, 2021 at 20:16:29 -0600, Pavel Koshevoy wrote: > > -sub->pts > ctx->last_real_time + av_rescale_q(200, ms_tb, > AV_TIME_BASE_Q)) { > > +sub->pts >= ctx->last_real_time + > a

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable

2021-05-29 Thread Pavel Koshevoy
On Tue, May 25, 2021 at 8:16 PM Pavel Koshevoy wrote: > Un-hardcode the 200ms minimum latency between emitting subtitle events > so that those that wish to receive a subtitle event for every screen > change could do so. > --- > libavcodec/ccaption_dec.c | 4 +++- > 1 file cha

[FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable v2

2021-05-29 Thread Pavel Koshevoy
Un-hardcode the 200ms minimum latency between emitting subtitle events so that those that wish to receive a subtitle event for every screen change could do so. The problem with delaying realtime output by any amount is that it is unknown when the next byte pair that would trigger output will happe

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable v2

2021-06-03 Thread Pavel Koshevoy
On Sat, May 29, 2021, 08:51 Pavel Koshevoy wrote: > Un-hardcode the 200ms minimum latency between emitting subtitle events > so that those that wish to receive a subtitle event for every screen > change could do so. > > The problem with delaying realtime output by any amoun

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable v2

2021-06-04 Thread Pavel Koshevoy
On Fri, Jun 4, 2021 at 4:56 PM Valerii Zapodovnikov wrote: > v2 is done by "git send-email -v2 -1" not what you did here. > Thanks, I didn't know that. I am unclear -- do you want me to resubmit the patch? I can just apply and push it myself if there are no objections, although I am not the m

[FFmpeg-devel] [PATCH v2] avcodec/ccaption_dec: Make real-time latency configurable

2021-06-05 Thread Pavel Koshevoy
Un-hardcode the 200ms minimum latency between emitting subtitle events so that those that wish to receive a subtitle event for every screen change could do so. The problem with delaying realtime output by any amount is that it is unknown when the next byte pair that would trigger output will happe

[FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Make real-time latency configurable

2021-06-05 Thread Pavel Koshevoy
Un-hardcode the 200ms minimum latency between emitting subtitle events so that those that wish to receive a subtitle event for every screen change could do so. The problem with delaying realtime output by any amount is that it is unknown when the next byte pair that would trigger output will happe

Re: [FFmpeg-devel] [PATCH v2] avcodec/ccaption_dec: Make real-time latency configurable

2021-06-13 Thread Pavel Koshevoy
On Sat, Jun 5, 2021 at 11:40 AM Pavel Koshevoy wrote: > Un-hardcode the 200ms minimum latency between emitting subtitle events > so that those that wish to receive a subtitle event for every screen > change could do so. > > The problem with delaying realtime output by any amoun

Re: [FFmpeg-devel] [PATCH v2] avcodec/ccaption_dec: Make real-time latency configurable

2021-06-14 Thread Pavel Koshevoy
On Mon, Jun 14, 2021 at 10:04 AM Paul B Mahol wrote: > On Sun, Jun 13, 2021 at 11:50 PM Pavel Koshevoy > wrote: > > > On Sat, Jun 5, 2021 at 11:40 AM Pavel Koshevoy > > wrote: > > > > > Un-hardcode the 200ms minimum latency between emitting subtitle eve

Re: [FFmpeg-devel] [PATCH v2] avcodec/ccaption_dec: Make real-time latency configurable

2021-06-17 Thread Pavel Koshevoy
On Sun, Jun 13, 2021 at 3:49 PM Pavel Koshevoy wrote: > > > On Sat, Jun 5, 2021 at 11:40 AM Pavel Koshevoy > wrote: > >> Un-hardcode the 200ms minimum latency between emitting subtitle events >> so that those that wish to receive a subtitle event for every s

Re: [FFmpeg-devel] [PATCH v2] avcodec/ccaption_dec: Make real-time latency configurable

2021-06-18 Thread Pavel Koshevoy
On Thu, Jun 17, 2021 at 7:07 PM Pavel Koshevoy wrote: > > > On Sun, Jun 13, 2021 at 3:49 PM Pavel Koshevoy > wrote: > >> >> >> On Sat, Jun 5, 2021 at 11:40 AM Pavel Koshevoy >> wrote: >> >>> Un-hardcode the 200ms minimum latency between e

[FFmpeg-devel] [PATCH] Fix build failure on macos 10.12

2021-07-25 Thread Pavel Koshevoy
--- libavutil/hwcontext_videotoolbox.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavutil/hwcontext_videotoolbox.c b/libavutil/hwcontext_videotoolbox.c index 58095a1fc9..99e117aca3 100644 --- a/libavutil/hwcontext_videotoolbox.c +++ b/libavutil/hwcontext_vide

Re: [FFmpeg-devel] [PATCH] libavfilter/af_atempo: offset output frames' pts by first_frame_pts / tempo

2019-01-24 Thread Pavel Koshevoy
On Thu, Jan 24, 2019 at 5:49 AM Paweł Wegner wrote: > > Signed-off-by: Paweł Wegner > --- > libavfilter/af_atempo.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c > index bfdad7d76b..1245eae8c1 100644 > --- a/libavfilter/af_ate

Re: [FFmpeg-devel] [PATCH] libavfilter/af_atempo: offset output frames' pts by first_frame_pts / tempo

2019-01-24 Thread Pavel Koshevoy
On Thu, Jan 24, 2019 at 8:01 AM Gyan wrote: > > > > On 24-01-2019 08:18 PM, Paweł Wegner wrote: > > > > This fixes seeking when I have video playback sped up in ffplay like this: > > ffplay -vf "setpts=0.5 * PTS" -af "atempo=2" input > > The better way to run this is > > ffplay -vf "setpts=0.

Re: [FFmpeg-devel] AMD external header

2017-11-27 Thread Pavel Koshevoy
On Mon, Nov 27, 2017 at 8:25 AM, Nicolas George wrote: > Mironov, Mikhail (2017-11-27): >> #1 >>policy: do not include external headers >>goal: minimize maintenance efforts and increase stability of the project >>action: remove NVidia headers > > Add to the goal: avoid being complicit

Re: [FFmpeg-devel] AMD external header

2017-11-29 Thread Pavel Koshevoy
On Tue, Nov 28, 2017 at 12:47 AM, Tobias Rapp wrote: > On 27.11.2017 17:14, Pavel Koshevoy wrote: >> Personally, I would prefer if the bundled external headers were >> installed together with ffmpeg public headers (so nvenc/cuda/etc... >> weren't simply private head

Re: [FFmpeg-devel] [PATCH] lavfi/atempo: Avoid false triggering an assertion failure

2017-09-02 Thread Pavel Koshevoy
On 08/30/2017 03:01 PM, Pavel Koshevoy wrote: On Wed, Aug 30, 2017 at 2:00 PM, Marton Balint wrote: On Mon, 19 Dec 2016, Marton Balint wrote: On Sat, 17 Dec 2016, pkoshe...@gmail.com wrote: From: Pavel Koshevoy Steps to reproduce: ./ffmpeg_g -f s16be -i /dev/null -af atempo=0.5 -y /tmp

Re: [FFmpeg-devel] [PATCH] lavfi/atempo: Avoid false triggering an assertion failure

2017-09-03 Thread Pavel Koshevoy
On Sun, Sep 3, 2017 at 9:26 AM, Marton Balint wrote: > > On Sun, 3 Sep 2017, Pavel Koshevoy wrote: > >> On 08/30/2017 03:01 PM, Pavel Koshevoy wrote: >> You can probably revert 4240e5b047379b29c33dd3f4438bc4e610527b83 -- I >> tried it locally and I no longer see the

Re: [FFmpeg-devel] order T-shirts

2017-10-24 Thread Pavel Koshevoy
On 10/24/2017 11:04 AM, Kyle Swanson wrote: Hi, On Sun, Sep 4, 2016 at 2:34 PM, Thomas Volkert wrote: Hi, Some guys at the VDD asked for FFmpeg T-shirts. I'd like to do a new T-shirt order. The shirts could be given to multimedia devs who stop at one of our next booths. My idea is to order

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: fix assertion failure on empty input

2016-12-14 Thread Pavel Koshevoy
On Wed, Dec 14, 2016 at 7:27 PM, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavfilter/af_atempo.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c > index 59b08ec..93a9c05 100644 > --- a/libav

Re: [FFmpeg-devel] [PATCH] lavc: Fix ticket 6024, truncated mode decoding

2016-12-15 Thread Pavel Koshevoy
passes fate, but I don't do that often so someone might want to double-check Pavel. On Thu, Dec 15, 2016 at 10:19 AM, wrote: > From: Pavel Koshevoy > > The assumption that avcodec_send_packet makes regarding decoders > consuming the entire packet is not true if t

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: fix assertion failure on empty input

2016-12-17 Thread Pavel Koshevoy
On Thu, Dec 15, 2016 at 3:31 AM, Marton Balint wrote: > > > On Wed, 14 Dec 2016, Pavel Koshevoy wrote: > >> On Wed, Dec 14, 2016 at 7:27 PM, Marton Balint wrote: >>> >>> Signed-off-by: Marton Balint >>> --- >>> libavfilter/af_atempo.c |

Re: [FFmpeg-devel] [PATCH] Add fate test for ticket 6024, truncated decoding mode

2016-12-17 Thread Pavel Koshevoy
On Sat, Dec 17, 2016 at 6:13 PM, Michael Niedermayer wrote: > On Sat, Dec 17, 2016 at 04:02:12PM -0700, pkoshe...@gmail.com wrote: >> From: Pavel Koshevoy >> >> --- >> tests/fate/video.mak| 3 +++ >> tests/ref/fate/mpeg2-ticket6024 | 27 ++

Re: [FFmpeg-devel] [PATCH] Add fate test for ticket 6024, truncated decoding mode (v2)

2016-12-22 Thread Pavel Koshevoy
On Dec 17, 2016 10:49 PM, wrote: From: Pavel Koshevoy --- tests/fate/video.mak| 3 +++ tests/ref/fate/mpeg2-ticket6024 | 27 +++ 2 files changed, 30 insertions(+) create mode 100644 tests/ref/fate/mpeg2-ticket6024 diff --git a/tests/fate/video.mak b

Re: [FFmpeg-devel] [PATCH] Restore compatibility with powerpc-apple-darwin9-gcc-4.2.1

2016-07-14 Thread Pavel Koshevoy
avel. On Thu, Jul 14, 2016 at 10:06 PM, wrote: > From: Pavel Koshevoy > > ... and attempt to preserve compatibility with clang that was > introduced in 311a953c76081fca99b872629d248f9d69ebc0c3 (untested) > --- > libavcodec/ppc/asm.S | 8 +++- > li

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: Make independent of the channel layout

2016-09-05 Thread Pavel Koshevoy
On Sep 5, 2016 4:41 PM, "Michael Niedermayer" wrote: > > Signed-off-by: Michael Niedermayer > --- > libavfilter/af_atempo.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c > index 7b3d57c..d5d29b3 100644 > --- a/libavfi

[FFmpeg-devel] vf_coreimage.m build failure on ppc osx 10.5

2016-03-28 Thread Pavel Koshevoy
I tried to get a fresh build of ffmpeg today and ran into this issue: OBJCC libavfilter/vf_coreimage.o src/libavfilter/vf_coreimage.m: In function ‘config_output’: src/libavfilter/vf_coreimage.m:75: warning: ISO C90 forbids mixed declarations and code src/libavfilter/vf_coreimage.m: In function ‘l

[FFmpeg-devel] latest ffmpeg git master build is broken on osx powerpc

2016-07-09 Thread Pavel Koshevoy
Hi, PowerPC build on OSX 10.5 (Leopard) is broken: $ gcc --version powerpc-apple-darwin9-gcc-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5577) Copyright (C) 2007 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILIT

Re: [FFmpeg-devel] [PATCH] Fix broken osx powerpc build

2016-07-11 Thread Pavel Koshevoy
fft_pass\suffix\()_altivec >From 97965f39a23835b4ecba6b1ba8cd694452c69168 Mon Sep 17 00:00:00 2001 From: Pavel Koshevoy Date: Mon, 11 Jul 2016 22:38:55 -0600 Subject: [PATCH] Restore compatibility with powerpc-apple-darwin9-gcc-4.2.1 ... and attempt to preserve compatibility with clang that w

Re: [FFmpeg-devel] [PATCH] Fix broken osx powerpc build

2016-07-12 Thread Pavel Koshevoy
On Jul 12, 2016 05:14, "Ronald S. Bultje" wrote: > > Hi, > > On Mon, Jul 11, 2016 at 9:56 PM, Jing Yu > wrote: > > > .macro movrel rd, sym, gp > > +#ifdef __APPLE__ > > +ld \rd, \sym@got(r2) > > +#else > > ld \rd, \sym@got(2) > > +#endif > > .endm > > > Does something like th

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle given video resolution

2017-01-02 Thread Pavel Koshevoy
On Sun, Jan 1, 2017 at 6:00 PM, wrote: > From: Pavel Koshevoy > > NVDEC (CUVID) does not support unlimited video resolutions, so if the > resolution of the source is known it can be used during avcodec_open2 > call to fail early, rather than failing later during > avcode

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle given video resolution

2017-01-02 Thread Pavel Koshevoy
On Mon, Jan 2, 2017 at 9:37 AM, Philip Langdale wrote: > On Mon, 2 Jan 2017 00:56:18 -0700 > Pavel Koshevoy wrote: >> Perhaps a more comprehensive solution is needed. I've run into the >> same problem again (avcodec_open2 succeeds, decoding spits errors) >> when

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle given video resolution

2017-01-02 Thread Pavel Koshevoy
On Mon, Jan 2, 2017 at 2:00 PM, Hendrik Leppkes wrote: > On Jan 3, 2017 07:52, "Pavel Koshevoy" wrote: > > On Mon, Jan 2, 2017 at 9:37 AM, Philip Langdale wrote: >> It is documented as only supporting 420, even though it doesn't return >> an error, so it

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle given video resolution

2017-01-02 Thread Pavel Koshevoy
On Mon, Jan 2, 2017 at 3:08 PM, Pavel Koshevoy wrote: > On Mon, Jan 2, 2017 at 2:00 PM, Hendrik Leppkes wrote: >> On Jan 3, 2017 07:52, "Pavel Koshevoy" wrote: >> >> On Mon, Jan 2, 2017 at 9:37 AM, Philip Langdale wrote: > >>> It is documented as

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle given video parameters

2017-01-07 Thread Pavel Koshevoy
On Mon, Jan 2, 2017 at 2:26 PM, wrote: > From: Pavel Koshevoy > > Evidently CUVID doesn't support decoding 422 or 444 chroma formats, > and only a limited set of resolutions per codec are supported. > > Given that stream resolution and pixel format are typically known a

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle given video parameters

2017-01-09 Thread Pavel Koshevoy
On Sun, Jan 8, 2017 at 2:53 PM, Hendrik Leppkes wrote: > On Tue, Jan 3, 2017 at 8:26 AM, wrote: >> +ret = convert_to_cuda_video_chroma_format(avctx->pix_fmt, >> &probed_chroma_format); >> +if (ret < 0) { >> +// pixel format is not supported: >> +return ret; >> +} >

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle given video parameters

2017-01-09 Thread Pavel Koshevoy
On Mon, Jan 9, 2017 at 3:12 AM, wm4 wrote: > On Mon, 2 Jan 2017 14:26:45 -0700 > pkoshe...@gmail.com wrote: > >> From: Pavel Koshevoy >> +ret = convert_to_cuda_video_chroma_format(avctx->pix_fmt, >> &probed_chroma_format); >> +if (ret &

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle video parameters

2017-01-12 Thread Pavel Koshevoy
On 01/12/2017 10:32 AM, Timo Rothenpieler wrote: On 1/9/2017 7:22 PM, pkoshe...@gmail.com wrote: From: Pavel Koshevoy Evidently CUVID doesn't support decoding 422 or 444 chroma formats, and only a limited set of resolutions per codec are supported. Given that stream resolution and

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle video parameters

2017-01-21 Thread Pavel Koshevoy
On Sat, Jan 21, 2017 at 10:27 AM, wrote: > From: Pavel Koshevoy > > Evidently CUVID doesn't support decoding 422 or 444 chroma formats, > and only a limited set of resolutions per codec are supported. > > Unfortunately CUVID silently drops packets for video of unsupported

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle video parameters

2017-01-21 Thread Pavel Koshevoy
On Sat, Jan 21, 2017 at 10:35 AM, Pavel Koshevoy wrote: > Despite wm4 objections I am resubmitting this patch, because I can > find no other reasonable method for rejecting ffmpeg cuvid decoder > when it can't handle a given video stream. An unreasonable > alternative woul

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle video parameters

2017-01-21 Thread Pavel Koshevoy
On Thu, Jan 12, 2017 at 10:32 AM, Timo Rothenpieler wrote: > On 1/9/2017 7:22 PM, pkoshe...@gmail.com wrote: >> From: Pavel Koshevoy >> enum AVPixelFormat pix_fmts[3] = { AV_PIX_FMT_CUDA, >>

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle video parameters

2017-01-22 Thread Pavel Koshevoy
On 01/22/2017 07:05 AM, Timo Rothenpieler wrote: Despite wm4 objections I am resubmitting this patch, because I can find no other reasonable method for rejecting ffmpeg cuvid decoder when it can't handle a given video stream. An unreasonable alternative would be to duplicate the work that cuvid.

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle video parameters

2017-01-22 Thread Pavel Koshevoy
On 01/22/2017 04:58 AM, wm4 wrote: On Sat, 21 Jan 2017 10:35:50 -0700 Pavel Koshevoy wrote: On Sat, Jan 21, 2017 at 10:27 AM, wrote: From: Pavel Koshevoy -ret = cuvid_test_dummy_decoder(avctx, &ctx->cuparseinfo); +ret = cuvid_test_dummy_decoder(avctx, &ctx-&

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle video parameters

2017-01-22 Thread Pavel Koshevoy
On 01/22/2017 05:28 AM, Mark Thompson wrote: On 21/01/17 17:35, Pavel Koshevoy wrote: On Sat, Jan 21, 2017 at 10:27 AM, wrote: From: Pavel Koshevoy Evidently CUVID doesn't support decoding 422 or 444 chroma formats, and only a limited set of resolutions per codec are supp

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle video parameters

2017-01-22 Thread Pavel Koshevoy
On Sun, Jan 22, 2017 at 9:37 AM, Pavel Koshevoy wrote: > On 01/22/2017 07:05 AM, Timo Rothenpieler wrote: >>> >>> Despite wm4 objections I am resubmitting this patch, because I can >>> find no other reasonable method for rejecting ffmpeg cuvid decoder >>> wh

Re: [FFmpeg-devel] [PATCH] lavc/cuvid: fail early if GPU can't handle video parameters

2017-01-22 Thread Pavel Koshevoy
On 1/22/17 11:13 AM, Philip Langdale wrote: On Sat, 21 Jan 2017 10:27:30 -0700 pkoshe...@gmail.com wrote: From: Pavel Koshevoy Evidently CUVID doesn't support decoding 422 or 444 chroma formats, and only a limited set of resolutions per codec are supported. Unfortunately CUVID sil

Re: [FFmpeg-devel] [PATCH] lavc/vda_h264_dec.c Fix NULL pointer dereference

2017-02-15 Thread Pavel Koshevoy
On Thu, Feb 9, 2017 at 8:20 PM, wrote: > From: Pavel Koshevoy > > ps.sps_list entries may be NULL, so check before dereferencing > --- > libavcodec/vda_h264_dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/vda_h264_dec.c b/l

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: fix sound shake when change speed

2017-02-17 Thread Pavel Koshevoy
On Feb 17, 2017 01:56, "Steven Liu" wrote: commandline: ./ffmpeg -i ~/Downloads/test.wav -af atempo=1.5 -acodec aac -y output.aac play the output.aac, the sound is very shake, terrible. after this patch, play the sound is smooth Signed-off-by: Steven Liu --- libavfilter/af_atempo.c | 17 +

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: fix sound shake when change speed

2017-02-17 Thread Pavel Koshevoy
On Fri, Feb 17, 2017 at 1:55 AM, Steven Liu wrote: > commandline: > ./ffmpeg -i ~/Downloads/test.wav -af atempo=1.5 -acodec aac -y > output.aac > > play the output.aac, the sound is very shake, terrible. > after this patch, > play the sound is smooth > > Signed-off-by: Steven Liu > --- > libavfi

Re: [FFmpeg-devel] [PATCH] avfilter/af_atempo: fix drift calculation, ticket #6157

2017-02-18 Thread Pavel Koshevoy
On 02/18/2017 07:04 PM, Steven Liu wrote: 2017-02-19 6:46 GMT+08:00 mailto:pkoshe...@gmail.com>>: From: Pavel Koshevoy mailto:pkoshe...@gmail.com>> --- libavfilter/af_atempo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a

Re: [FFmpeg-devel] [PATCH] lavfi/atempo: Avoid false triggering an assertion failure

2017-08-30 Thread Pavel Koshevoy
On Wed, Aug 30, 2017 at 2:00 PM, Marton Balint wrote: > > On Mon, 19 Dec 2016, Marton Balint wrote: > >> >> On Sat, 17 Dec 2016, pkoshe...@gmail.com wrote: >> >>> From: Pavel Koshevoy >>> >>> Steps to reproduce: >>> ./f

[FFmpeg-devel] [PATCH] avfilter/atempo: Flush all buffered input samples

2014-08-18 Thread Pavel Koshevoy
Fixes ticket #3829 --- libavfilter/af_atempo.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c index 6a3fd61..fcd0cb0 100644 --- a/libavfilter/af_atempo.c +++ b/libavfilter/af_atempo.c @@ -949,7 +949,13 @@ static int yae_

Re: [FFmpeg-devel] [PATCH] af_tempo.c: fix checking of samples and zero frame counts

2024-03-12 Thread Pavel Koshevoy
On Tue, Mar 12, 2024, 02:52 Rajiv Harlalka wrote: > On 3/8/24 4:34 AM, Rajiv Harlalka wrote: > > Check for zeros equal to the total samples early, because in case the > > check is true we would already be leaving the first few frames out. > > > > Signed-off-by: Rajiv Harlalka > > #10692 > > ---

Re: [FFmpeg-devel] [PATCH] af_tempo.c: fix checking of samples and zero frame counts

2024-03-12 Thread Pavel Koshevoy
On Tue, Mar 12, 2024 at 2:52 AM Rajiv Harlalka wrote: > On 3/8/24 4:34 AM, Rajiv Harlalka wrote: > > Check for zeros equal to the total samples early, because in case the > > check is true we would already be leaving the first few frames out. > > > > Signed-off-by: Rajiv Harlalka > > #10692 > >

[FFmpeg-devel] [PATCH] lavfi/atempo: avoid asendcmd assertion failure

2024-03-12 Thread Pavel Koshevoy
From: Rajiv Harlalka Check for zeros equal to the total samples early, because in that case we would already be leaving the first few frames out. Fixes trac ticket #10692 --- libavfilter/af_atempo.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavfilt

Re: [FFmpeg-devel] [PATCH] af_tempo.c: fix checking of samples and zero frame counts

2024-03-12 Thread Pavel Koshevoy
On Tue, Mar 12, 2024 at 8:22 PM Pavel Koshevoy wrote: > > > On Tue, Mar 12, 2024 at 2:52 AM Rajiv Harlalka > wrote: > >> On 3/8/24 4:34 AM, Rajiv Harlalka wrote: >> > Check for zeros equal to the total samples early, because in case the >> > check is tru

Re: [FFmpeg-devel] [PATCH] lavfi/atempo: avoid asendcmd assertion failure

2024-03-12 Thread Pavel Koshevoy
On Tue, Mar 12, 2024 at 9:01 PM Pavel Koshevoy wrote: > From: Rajiv Harlalka > > Check for zeros equal to the total samples early, because in > that case we would already be leaving the first few frames out. > > Fixes trac ticket #10692 > --- > liba

Re: [FFmpeg-devel] [PATCH 08/12] avcodec/decode: check for global side data in AVCodecContext side data

2023-08-28 Thread Pavel Koshevoy
On Mon, Aug 28, 2023, 06:38 James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/decode.c | 56 + > libavcodec/decode.h | 2 +- > 2 files changed, 47 insertions(+), 11 deletions(-) > > diff --git a/libavcodec/decode.c b/libavcodec/decod

[FFmpeg-devel] AVFrame.color_trc wrong since f2ad6238e4c0e99e2fc131ee14c586e87b045680

2020-09-15 Thread Pavel Koshevoy
set_side_data used to do out->color_trc = s->sei.alternative_transfer.preferred_transfer_characteristics; In commit f2ad6238e4c0e99e2fc131ee14c586e87b045680 this was removed. Now ffprobe of an HLG stream reports wrong transfer characteristics for each frame: ``` $ ffprobe -show_frames 20190914-14

Re: [FFmpeg-devel] AVFrame.color_trc wrong since f2ad6238e4c0e99e2fc131ee14c586e87b045680

2020-09-15 Thread Pavel Koshevoy
On Tue, Sep 15, 2020, 21:25 James Almer wrote: > On 9/15/2020 10:57 PM, Pavel Koshevoy wrote: > > set_side_data used to do out->color_trc = > > s->sei.alternative_transfer.preferred_transfer_characteristics; > > > > In commit f2ad6238e4c0e99e2fc131ee14c586e87

[FFmpeg-devel] [PATCH] avcodec/hevcdec: fix per-frame signaling of color_trc

2020-09-16 Thread Pavel Koshevoy
This is a partial revert of f2ad6238e4c0e99e2fc131ee14c586e87b045680 It fixes per-frame color_trc signaling of arib-std-b67 frames. Reproducible with: ffprobe -show_frames lg_4k_hlg.ts | grep color_transfer= --- libavcodec/hevcdec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavc

Re: [FFmpeg-devel] AVFrame.color_trc wrong since f2ad6238e4c0e99e2fc131ee14c586e87b045680

2020-09-16 Thread Pavel Koshevoy
On 9/15/20 9:24 PM, James Almer wrote: On 9/15/2020 10:57 PM, Pavel Koshevoy wrote: that should be color_transfer=arib-std-b67 Would anyone object if I restored previous behavior? I'd prefer avoid reimplementing SEI parsing outside of libav just to get the correct per-frame colo

[FFmpeg-devel] [PATCH] avfilter/setparams: add FF_FILTER_FLAG_HWFRAME_AWARE

2020-09-21 Thread Pavel Koshevoy
Allow setparams to be used with hw backed frames and avoid an assertion failure in avfilter_config_links. --- libavfilter/vf_setparams.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/vf_setparams.c b/libavfilter/vf_setparams.c index 689097fac0..72a69e3fc2 100644 --- a/libavfil

Re: [FFmpeg-devel] [PATCH] avfilter/setparams: add FF_FILTER_FLAG_HWFRAME_AWARE

2020-09-27 Thread Pavel Koshevoy
On Wed, Sep 23, 2020 at 1:32 PM Paul B Mahol wrote: > On Mon, Sep 21, 2020 at 09:47:40PM -0600, Pavel Koshevoy wrote: > > Allow setparams to be used with hw backed frames and > > avoid an assertion failure in avfilter_config_links. > > --- > > libavfilter/vf_setp

  1   2   3   >